Debian Bug report logs - #701233
debhelper: Add -DCMAKE_BUILD_TYPE=RelWithDebInfo to standard set of cmake flags

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <Vincentc1208@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: debhelper: Add -DCMAKE_BUILD_TYPE=RelWithDebInfo to standard set of cmake flags

Date: Sat, 23 Feb 2013 02:21:34 -0800

Package: debhelper
Version: 9.20120909
Severity: wishlist
Tags: patch

Dear Maintainer,

Some packages default to -DCMAKE_BUILD_TYPE=Release, or their maintainers 
choose to set that flag in debian/rules, thus producing binaries compiled with
-O3 -DNDEBUG. As discussed on debian-devel [1], this isn't ideal. Instead,
we should be promoting the use of -DCMAKE_BUILD_TYPE=RelWithDebInfo (-g -O2),
and here's a patch that does that.

diff --git a/Debian/Debhelper/Buildsystem/cmake.pm b/Debian/Debhelper/Buildsystem/cmake.pm
index 1d009b4..d47821c 100644
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -43,6 +43,7 @@ sub configure {
 	# Standard set of cmake flags
 	push @flags, "-DCMAKE_INSTALL_PREFIX=/usr";
 	push @flags, "-DCMAKE_VERBOSE_MAKEFILE=ON";
+	push @flags, "-DCMAKE_BUILD_TYPE=RelWithDebInfo";
 
 	# CMake doesn't respect CPPFLAGS, see #653916.
 	if ($ENV{CPPFLAGS} && ! compat(8)) {

Regards,
Vincent

[1] https://lists.debian.org/debian-devel/2013/02/msg00124.html

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6.8-1-vclaptop-amd64 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debhelper depends on:
ii  binutils    2.22-7.1
ii  dpkg        1.16.9
ii  dpkg-dev    1.16.9
ii  file        5.11-2
ii  html2text   1.3.2a-15
ii  man-db      2.6.2-1
ii  perl        5.14.2-18
ii  po-debconf  1.0.16+nmu2

debhelper recommends no packages.

Versions of packages debhelper suggests:
ii  dh-make  0.61

-- no debconf information

Message #12 received at 701233-close@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: 701233-close@bugs.debian.org

Subject: Bug#701233: fixed in debhelper 9.20130504

Date: Sun, 05 May 2013 04:02:35 +0000

Source: debhelper
Source-Version: 9.20130504

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 701233@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 04 May 2013 23:32:27 -0400
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 9.20130504
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <joeyh@debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 debhelper  - helper programs for debian/rules
Closes: 525821 680339 683551 683557 683941 684689 684895 686696 690378 690399 691398 691557 692208 693100 700200 701233 703262 703515 706314
Changes: 
 debhelper (9.20130504) unstable; urgency=low
 .
   * dh_shlibdeps: Warn if -V flag is passed, to avoid it accidentially being
     used here rather than in dh_makeshlibs. Closes: #680339
   * dh_lintian: Source overrides doc improvement. Closes: #683941
   * dh_installmime: No longer makes maintainer scripts run update-mime and
     update-mime-database, that is now handled by triggers. Closes: #684689
     Thanks, Charles Plessy
   * python distutils buildsystem: Propagate failure of pyversions.
     Closes: #683551 Thanks, Clint Byrum
   * python distutils buildsystem: When checking if a version of python is
     installed, don't trust the presense of the executable, as
     a python2.X-minimal package may provide it while not having
     distutils installed. Closes: #683557, #690378
   * dh_icons: Improve documentation. Closes: #684895
   * Improve -X documentation. Closes: #686696
   * Support installing multiple doc-base files which use the same doc-id.
     Closes: #525821
   * dh_installdocs: Support having the same document id in different binary
     packages built from the same source.
     Closes: #525821 Thanks, Don Armstrong
   * dh_installdeb: Avoid unnecessary is_udeb tests. Closes: #691398
   * Updated German man page translation. Closes: #691557, #706314
   * dh_installinit: Support systemd.
     Closes: #690399 Thanks, Michael Stapelberg
   * Updated French man page translation. Closes: #692208
   * dh_icons: Reword description. Closes: #693100
   * Avoid find -perm +mode breakage caused by findutils 4.5.11,
     by instead using -perm /mode. Closes: #700200
   * cmake: Configure with -DCMAKE_BUILD_TYPE=RelWithDebInfo
     Closes: #701233
   * dh_auto_test: Avoid doing anything when cross-compiling. Closes: #703262
   * dh_testdir: Fix error message. Closes: #703515
Checksums-Sha1: 
 d85b2648ca8d1fc90ad43584d3bd5875dee44db6 1577 debhelper_9.20130504.dsc
 da3e094d2b0a61f6aeadfe1f0ed5c6bdcea67877 470050 debhelper_9.20130504.tar.gz
 3c1da0c1f75877cafa598b677b5c1e9366560b51 706414 debhelper_9.20130504_all.deb
Checksums-Sha256: 
 9dd245024b2be9230bcd6569c617d2dae39e19c206cb639c72e4e252c3c86d3b 1577 debhelper_9.20130504.dsc
 7d6ee2657430afcb477396c32c4bc170aa7fae97332045aa8f4ebec889051f01 470050 debhelper_9.20130504.tar.gz
 08450bd3fbae0bcef04e60d299c8557634e35f027a446a454ab574f8948d2419 706414 debhelper_9.20130504_all.deb
Files: 
 6823c687eb955536e3d5d32b69a7dd41 1577 devel optional debhelper_9.20130504.dsc
 b5ea99c845e78cecbc89d25484a46b42 470050 devel optional debhelper_9.20130504.tar.gz
 fe4f489a57e830c66c6b2fbac672cdf4 706414 devel optional debhelper_9.20130504_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBUYXVcckQ2SIlEuPHAQj8sw//R3bheMCm70k4D33QJ9Xc8wVHlcYgmY2f
Bi7ChTYcCtgyazS7yZmQ759Sh+m9vn11v/qqzVNKsxhIUnjjHFLWWfpcdCdn//Zp
6aAmRN0OT6ovLYFBAbuB80EBeSOE41QjKLUV1M7IU7DoFi+kCWWFHpv2Pni1XP/B
c7GqNAOI9CDKXEivyrgcv+UIA1PGCGz3Pk8J3ZF8Jy5GT2zelmvczj00uDVj/jUf
qWjQRirHrpOpmH8gcImhmlTS02WD6vAfNYuCa98HCh2o6QxWLx9tvgGRkudvHUr4
U4rT6ITAakVELQyVLbG/C9AhnHSMW96OT5ew834w3jcbPcXu9qMeTyUQyo/I9Od8
Wtipn28JoG9D04omMQMktXV8rdu1jfY8splBkow+kE7gIkjCpk6WkwBBd5XqvWAq
Xihf7eijRM1E2GbbEACg4pnVa1YynoZqhQhHf1V3bhoxYHtRbWHfV+KwXNznob/p
kOuOuftGpYANvP66E8kI9IDu612x95+Wn2G1KhLhvuX9CPXr/JDe3+fsYpvpGmJz
dZlVD787+LjEc3p5+sx+IGngNEjUa8CecIsJhir1Z6rZ9mGIPkVZZeEWBAXTi+kz
c8h4elA2ebSeB9qTHX5iXNbgtxmdkBZiddhb5dyF89DA25FQHcgm0GQu9Pmocido
lkNNVbB1DvU=
=YmiJ
-----END PGP SIGNATURE-----

Message #27 received at 701233@bugs.debian.org (full text, mbox, reply):

From: Mathieu Malaterre <malat@debian.org>

To: 701233@bugs.debian.org

Date: Thu, 5 Dec 2013 13:06:27 +0100

Control: severity -1 important

I would like request a different patch than what was initially
suggested. Instead debhelper should set:

diff --git a/Debian/Debhelper/Buildsystem/cmake.pm
b/Debian/Debhelper/Buildsystem/cmake.pm
index 1d009b4..d47821c 100644
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -43,6 +43,7 @@ sub configure {
  # Standard set of cmake flags
  push @flags, "-DCMAKE_INSTALL_PREFIX=/usr";
  push @flags, "-DCMAKE_VERBOSE_MAKEFILE=ON";
+ push @flags, "-DCMAKE_BUILD_TYPE=None";

  # CMake doesn't respect CPPFLAGS, see #653916.
  if ($ENV{CPPFLAGS} && ! compat(8)) {


As can be seen in :

http://bugs.debian.org/730636#15
or
http://bugs.debian.org/711515#30

Strictly speaking build system (eg. cmake) should not try to set any
compilation flags themselves. It is required by policy that CFLAGS and
CXXFLAGS (solely) are used when building.

Thanks.

Message #36 received at 701233-close@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: 701233-close@bugs.debian.org

Subject: Bug#701233: fixed in debhelper 9.20131213

Date: Fri, 13 Dec 2013 19:03:33 +0000

Source: debhelper
Source-Version: 9.20131213

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 701233@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 13 Dec 2013 14:46:26 -0400
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 9.20131213
Distribution: unstable
Urgency: low
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 debhelper  - helper programs for debian/rules
Closes: 701233 731723
Changes: 
 debhelper (9.20131213) unstable; urgency=low
 .
   [ Joey Hess ]
   * cmake: Configure with -DCMAKE_BUILD_TYPE=None
     Closes: #701233
 .
   [ Andreas Beckmann ]
   * dh_installdeb: Add support for dpkg-maintscript-helper commands
     symlink_to_dir and dir_to_symlink that were added in dpkg 1.17.2.
     Closes: #731723
Checksums-Sha1: 
 e57694e1861d7f2bac3d7551bb78c531c93f17e7 1699 debhelper_9.20131213.dsc
 7e262896c42f1ba14f31d992363394cc393607d9 472845 debhelper_9.20131213.tar.gz
 4817e9a5ab7ec7acdf86c4f4c89c0761855d2522 686748 debhelper_9.20131213_all.deb
Checksums-Sha256: 
 b435d171894d76e0336dec482b6bcd578f8c48f366418fa039f28106159053a1 1699 debhelper_9.20131213.dsc
 5a6db89e1487f05d43f149b8617f068956649cd66fbbdaf26e845b3a311c3685 472845 debhelper_9.20131213.tar.gz
 b666175ef2d4493652b63fe7dfb280ceaf8a54f649b0a6ee9a403228e62085f2 686748 debhelper_9.20131213_all.deb
Files: 
 322947c045c49c53d3c9f8f63bbe4a7d 1699 devel optional debhelper_9.20131213.dsc
 44af065f723dc6a62ae38655066726be 472845 devel optional debhelper_9.20131213.tar.gz
 6bb5008aad092e81b331724e09ce8774 686748 devel optional debhelper_9.20131213_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIVAwUBUqtW7MkQ2SIlEuPHAQiXtBAAgVFKjmFEbC36rOyOuGbNRXN9mAMzhbhh
ikeGRqK9EHETX92GHyDoxu2gCdS1mMlGL7iEedBcDqbeSnb03hQPMAdoE8KNEZuo
mybufpJrbEPTCYi+TXLqpQ5+yBv0PwMm/xGvXCaDytAJiYW8fjW4SuQXQXWDr3EU
7W4qw7haq00wcYSS/GHntJpv/q+bbyJhHAodkmtix4ETcBdhM2Ib0d8F0XclWeri
lmPMy2vpfZEPnzb5KMPge90dTLJrYNKafJMAPad2TMySHrQ7iiBYyVQoptrp0TDk
NdtVXQk2K4C8gWQb5mJBpjQP3YdHvHkaFiqFe97QlerDURodz4zJJljNa9xWxdJf
WEIto+Ypy8z2sK6Cd//nPlfNrIaT8NQicgkf13FXHLNt/JRFnH816/GRxZK7LkCS
FiKrXqAM0k5C7vyv8GtbuZ+Ck8H3Lpj6FIEZPpkofSRFcrRn1ljXSbIK4kdvbTpi
eq2T/wteSIMXjPt4+BBtClQrdGxZwap/nUdEzrlRrmrdvA2KqPky0XMCisnW2u13
6a65Qsz9WJYWUDo/i9P9A71HRl6pqKchRDDIYa94Di43p07u7e/AZeovc2vYrOSu
BN0/lInu5mU+Hy9lXPHWo9vIcuz65BXx3GVpa+CdqIDkQGnRpWhLat1qqOSF7+Kx
GSppVzdh/B0=
=z5so
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.