Debian Bug report logs - #701134
php-soap: directory vs. symlink conflict: /usr/share/php/doc

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: php-soap: directory vs. symlink conflict: /usr/share/php/doc

Date: Fri, 22 Feb 2013 00:16:42 +0100

[Message part 1 (text/plain, inline)]

Package: php-soap
Version: 0.12.0-2
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package installs files over
an existing symlink shipped or created by another package.

Installing something over existing symlinks is considered bad practice.
See e.g. http://lists.debian.org/87ehlevcrf.fsf@windlord.stanford.edu

It may break in subtle ways and dpkg cannot detect this as a problem.
* Your package might silently overwrite files installed at the symlink
  destination by other packages.
* If the package shipping the symlink decides to make the link point
  somewhere else (or turn it into a real directory), the files owned
  by your package "will be lost" somewhere in the filesystem.
* Depending on installation order the problematic path will be created
  either as a symlink or a directory: the package installed first will
  "win" and all others have "lost".
  Note that dpkg intentionally does not replace directories with
  symlinks and vice versa, see in particular the end of point 4 in
  http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase
  (Note: Adding Pre-Depends is *not* a solution.)

Please move the files shipped in your package to the "real" location.

Your package ships:

  /usr/share/php/doc/SOAP/example/*

but php-pear ships:

  /usr/share/php/doc -> ../doc/php-pear/PEAR

>From the attached log (usually somewhere in the middle...):

0m15.7s INFO: dirname part contains a symlink:
  /usr/share/php/doc/SOAP (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP (?)
  /usr/share/php/doc/SOAP/example (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example (?)
  /usr/share/php/doc/SOAP/example/attachment.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/attachment.php (?)
  /usr/share/php/doc/SOAP/example/client.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/client.php (?)
  /usr/share/php/doc/SOAP/example/com_client.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/com_client.php (?)
  /usr/share/php/doc/SOAP/example/disco_server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/disco_server.php (?)
  /usr/share/php/doc/SOAP/example/email_client.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/email_client.php (?)
  /usr/share/php/doc/SOAP/example/email_gateway.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/email_gateway.php (?)
  /usr/share/php/doc/SOAP/example/email_pop_gateway.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/email_pop_gateway.php (?)
  /usr/share/php/doc/SOAP/example/email_pop_server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/email_pop_server.php (?)
  /usr/share/php/doc/SOAP/example/email_server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/email_server.php (?)
  /usr/share/php/doc/SOAP/example/example_server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/example_server.php (?)
  /usr/share/php/doc/SOAP/example/example_types.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/example_types.php (?)
  /usr/share/php/doc/SOAP/example/server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/server.php (?)
  /usr/share/php/doc/SOAP/example/server2.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/server2.php (?)
  /usr/share/php/doc/SOAP/example/smtp.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/smtp.php (?)
  /usr/share/php/doc/SOAP/example/stockquote.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/stockquote.php (?)
  /usr/share/php/doc/SOAP/example/tcp_client.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/tcp_client.php (?)
  /usr/share/php/doc/SOAP/example/tcp_daemon.pl (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/tcp_daemon.pl (?)
  /usr/share/php/doc/SOAP/example/tcp_server.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/tcp_server.php (?)
  /usr/share/php/doc/SOAP/example/wsdl_client.php (php-soap) != /usr/share/doc/php5-common/PEAR/SOAP/example/wsdl_client.php (?)


cheers,

Andreas

[php-soap_0.12.0-2.log.gz (application/x-gzip, attachment)]

Message #10 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Prach Pongpanich <prachpub@gmail.com>

To: 701134@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: php-soap: directory vs. symlink

Date: Fri, 1 Mar 2013 16:03:59 +0700

[Message part 1 (text/plain, inline)]

tags 701134 + patch
thanks

Hello maintainer,

I have prepared a patch which solves the this bug.

php-pear:

usr/share/php/doc -> ../doc/php-pear/PEAR
usr/share/php/../doc/php-pear -> php5-common


Regards,

-- 
 ปรัชญ์ พงษ์พานิช
 Prach Pongpanich

 http://prach-public.blogspot.com

[fix_701134.patch (application/octet-stream, attachment)]

Message #17 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Prach Pongpanich <prachpub@gmail.com>

To: 701134@bugs.debian.org

Subject: Re: php-soap: directory vs. symlink

Date: Tue, 12 Mar 2013 13:10:58 +0700

[Message part 1 (text/plain, inline)]

Hi,

I have prepared a  patch for NMU

Regrads,

-- 
Prach Pongpanich

[php-soap_0.12.0-2.1-nmu.diff (application/octet-stream, attachment)]

Message #22 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Prach Pongpanich <prachpub@gmail.com>, 702849@bugs.debian.org

Cc: Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, 701134@bugs.debian.org, Thierry Randrianiriana <thierry@debian.org>, Debian Release <debian-release@lists.debian.org>

Subject: Re: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Tue, 12 Mar 2013 23:28:04 +0800

To the release team (and Prach):
====================
Dear release team,

Prach Pongpanich in the mentors list is trying to fix #701134.
He is removing the Pre-Depends which was added for the
release of Squeeze, because of #605867, which I filled, but
can't remember what it was about. The bug report says:

As dicussed with the release team, we need to add a
Pre-Depends because of /usr/share/php/doc.

Does anyone remember off-hand what it was about?

Thoughts on this?

To Prach:
=========
Please also read above.

Appart from that, I insist, Debian's policy
is to install documentation of packages under:

/usr/share/doc/<package-name>

So I would do that, and not move the doc into:

/usr/share/doc/php5-common/PEAR

which is not where our Debian users would
naturally search.

Arguably, php-pear goes together with the
php5-common package, so it puts files there.
I would however think it's a bug, rather
than a feature, and that the docs from the
php-pear package really should be under:

/usr/share/doc/php-pear

To Thierry:
===========
Is it ok if someone NMU the fix?

Also, for Jessie, it would be nice to switch
php-soap so that it uses pkg-php-tools (so
that you can use dh, instead of the old
debhelper style). You can have a look at any
package which build-depends on pkg-php-tools
to find examples. Any plans for that?

It's also disappointing to see that version
0.13.0 of php-soap, which was release upstream
on the 2012-01-26, isn't in wheezy. This
version was a QA release!!!

Now, seeing this, I wonder: would you be ok
to have this package team maintained in the
future, and have it under the pkg-php-pear
team, so that others are also allowed to upload
it if needed? The team also needs some help to
maintain all these PEAR modules, so you would
be welcome to join.

Cheers,

Thomas

Message #27 received at 701134@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: Thomas Goirand <zigo@debian.org>

Cc: Prach Pongpanich <prachpub@gmail.com>, 702849@bugs.debian.org, Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, 701134@bugs.debian.org, Thierry Randrianiriana <thierry@debian.org>, Debian Release <debian-release@lists.debian.org>

Subject: Re: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Tue, 12 Mar 2013 20:12:54 +0000

On Tue, 2013-03-12 at 23:28 +0800, Thomas Goirand wrote:
> Prach Pongpanich in the mentors list is trying to fix #701134.
> He is removing the Pre-Depends which was added for the
> release of Squeeze, because of #605867, which I filled, but
> can't remember what it was about. The bug report says:
> 
> As dicussed with the release team, we need to add a
> Pre-Depends because of /usr/share/php/doc.
> 
> Does anyone remember off-hand what it was about?

The original issue was #602865, in php-net-smtp, fixed in 1.4.2-{2,3}.

Given that we don't officially support upgrades that skip a stable
release, the packages in wheezy technically don't need to include the
Pre-Depends.

Regards,

Adam

Message #32 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: 702849@bugs.debian.org

Cc: Prach Pongpanich <prachpub@gmail.com>, Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, 701134@bugs.debian.org, Thierry Randrianiriana <thierry@debian.org>, Debian Release <debian-release@lists.debian.org>

Subject: Re: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Wed, 13 Mar 2013 14:33:35 +0800

On 03/13/2013 04:12 AM, Adam D. Barratt wrote:
> On Tue, 2013-03-12 at 23:28 +0800, Thomas Goirand wrote:
>> Prach Pongpanich in the mentors list is trying to fix #701134.
>> He is removing the Pre-Depends which was added for the
>> release of Squeeze, because of #605867, which I filled, but
>> can't remember what it was about. The bug report says:
>>
>> As dicussed with the release team, we need to add a
>> Pre-Depends because of /usr/share/php/doc.
>>
>> Does anyone remember off-hand what it was about?
> The original issue was #602865, in php-net-smtp, fixed in 1.4.2-{2,3}.
>
> Given that we don't officially support upgrades that skip a stable
> release, the packages in wheezy technically don't need to include the
> Pre-Depends.
>
> Regards,
>
> Adam
Hi,

That's what I thought as well, but I wanted to check. Thanks Adam for
taking the time to confirm it.

Prach, please change the new path to /usr/share/doc/php-soap, and
I will sponsor the upload.

Cheers,

Thomas

Message #37 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Prach Pongpanich <prachpub@gmail.com>

To: Thomas Goirand <zigo@debian.org>

Cc: 702849@bugs.debian.org, Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, 701134@bugs.debian.org, Thierry Randrianiriana <thierry@debian.org>, Debian Release <debian-release@lists.debian.org>

Subject: Re: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Wed, 13 Mar 2013 15:46:31 +0700

Hi ,

I'm sorry for noise, and thank you very much for reviews and discussions

> Prach, please change the new path to /usr/share/doc/php-soap, and
> I will sponsor the upload.

I already done it and upload to mentors.d.n [1]

[1] http://mentors.debian.net/debian/pool/main/p/php-soap/php-soap_0.12.0-2.1.dsc

Regrads,

Prach

Message #42 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <thomas@goirand.fr>

To: Prach Pongpanich <prachpub@gmail.com>, 702849@bugs.debian.org

Cc: Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, 701134@bugs.debian.org, Thierry Randrianiriana <thierry@debian.org>

Subject: Re: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Wed, 13 Mar 2013 23:59:39 +0800

On 03/13/2013 04:46 PM, Prach Pongpanich wrote:
> Hi ,
>
> I'm sorry for noise, and thank you very much for reviews and discussions
>
>> Prach, please change the new path to /usr/share/doc/php-soap, and
>> I will sponsor the upload.
> I already done it and upload to mentors.d.n [1]
>
> [1] http://mentors.debian.net/debian/pool/main/p/php-soap/php-soap_0.12.0-2.1.dsc
>
> Regrads,
>
> Prach
>
>
Uploaded.

Do you know how to open an unblock request, so that the
release team allows your fix to reach Wheezy?

If you don't know, I can:
- explain you how
- do it for you

Thanks for your contribution.

Thomas

Message #47 received at 701134-close@bugs.debian.org (full text, mbox, reply):

From: Prach Pongpanich <prachpub@gmail.com>

To: 701134-close@bugs.debian.org

Subject: Bug#701134: fixed in php-soap 0.12.0-2.1

Date: Wed, 13 Mar 2013 16:02:28 +0000

Source: php-soap
Source-Version: 0.12.0-2.1

We believe that the bug you reported is fixed in the latest version of
php-soap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 701134@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Prach Pongpanich <prachpub@gmail.com> (supplier of updated php-soap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 12 Mar 2013 02:39:01 +0700
Source: php-soap
Binary: php-soap
Architecture: source all
Version: 0.12.0-2.1
Distribution: unstable
Urgency: low
Maintainer: Thierry Randrianiriana <thierry@debian.org>
Changed-By: Prach Pongpanich <prachpub@gmail.com>
Description: 
 php-soap   - a SOAP Client/Server class for PHP
Closes: 701134
Changes: 
 php-soap (0.12.0-2.1) unstable; urgency=low
 .
   * Non-maintainer upload to fix RC bug.
   * Fix silently overwrite files installed at the symlink
     destination by other packages (Closes: #701134):
     - Move the files shipped in package to the "real" location
     - Drop Pre-Depends: php-pear as it's not needed
Checksums-Sha1: 
 f30da865136ad88672f3a1622f63fa70ed587691 1093 php-soap_0.12.0-2.1.dsc
 a6366294a7d274e0a1f2fe08799454cd1f6a571c 3663 php-soap_0.12.0-2.1.debian.tar.gz
 2c340cd9ec189db5c6c558e7f8c4bfcfacc691c5 82144 php-soap_0.12.0-2.1_all.deb
Checksums-Sha256: 
 335164b1b29f1857d3032be459aa8d1fd66c1b7eb474f548f43ad12ea5e5eda0 1093 php-soap_0.12.0-2.1.dsc
 e6ccdd90348fffce6217a2ca4c49291260248897e8256b9b2648bb489e90bb4d 3663 php-soap_0.12.0-2.1.debian.tar.gz
 dd61ac5d2464ec3b88e841e6f8b4e3f4b2a0aaca4b34b3c0e922a5c6384f5975 82144 php-soap_0.12.0-2.1_all.deb
Files: 
 6da5ab60f35019313b9dbed498954b8d 1093 php optional php-soap_0.12.0-2.1.dsc
 7f0ca8b1b2d92a3fa38849c91ce616c1 3663 php optional php-soap_0.12.0-2.1.debian.tar.gz
 bd9b44c3f4b3461f9fa5ecf414589049 82144 php optional php-soap_0.12.0-2.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlFAjrQACgkQl4M9yZjvmknxUQCghgxIfg6yaf+oothpkOk2LoYw
rggAn2DD0w9fiJYZypEULUs8Biijpy3D
=jlFJ
-----END PGP SIGNATURE-----

Message #52 received at 701134@bugs.debian.org (full text, mbox, reply):

From: Prach Pongpanich <prachpub@gmail.com>

To: Thomas Goirand <thomas@goirand.fr>, 701134@bugs.debian.org

Cc: 702849@bugs.debian.org, Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>, Thierry Randrianiriana <thierry@debian.org>

Subject: Re: Bug#701134: Bug#702849: RFS: php-soap/0.12.0-2.1 [NMU] [RC]

Date: Thu, 14 Mar 2013 00:42:40 +0700

Hi Thomas,

> Do you know how to open an unblock request, so that the
> release team allows your fix to reach Wheezy?
 Yes, I do. [1]  #702981

> If you don't know, I can:
> - explain you how
> - do it for you
>
> Thanks for your contribution.

 Thanks for your help and sponsor.

[1] http://release.debian.org/wheezy/freeze_policy.html

Prach

Send a report that this bug log contains spam.