Debian Bug report logs - #696841
libsbuild-perl: fails to parse configuration: uses undef as HASH ref (MAILTO_HASH)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libsbuild-perl: fails to parse configuration: uses undef as HASH ref (MAILTO_HASH)

Date: Fri, 28 Dec 2012 01:48:38 +0000

Package: libsbuild-perl
Version: 0.63.2-1.1
Severity: grave
Tags: patch
Justification: renders package unusable

Hi,

without the patch below, sbuild/buildd fail to run
after writing a configuration file, with the error:

Starting Debian package autobuilder: buildd Error reading configuration: Can't use an undefined value as a HASH reference at /usr/share/perl5/Sbuild/ConfBase.pm line 83.

It exits with errorlevel 2 then, and buildd-mail also
spews lots of errors.

The patch below fixes this. Feel free to downgrade the
severity if this doesn't affect the majority of users,
but seeing as the official Debian buildds do not dogfood
the buildd suite in unstable, I am not so sure about that…

--- ConfBase.pm~
+++ ConfBase.pm
@@ -84,6 +84,7 @@ sub init_allowed_keys {
 		   $conf->get('MAILTO_HASH')->{$value})
 	    if ($value &&
 		$conf->get('DISTRIBUTION') &&
+		$conf->get('MAILTO_HASH') &&
 		$conf->get('MAILTO_HASH')->{$value});
     };
 


-- System Information:
Debian Release: 7.0
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: m68k

Kernel: Linux 3.2.0-4-atari
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/mksh-static

Versions of packages libsbuild-perl depends on:
ii  adduser                         3.113+nmu3
ii  apt                             0.9.7.7
ii  apt-utils                       0.9.7.7
ii  dctrl-tools                     2.22.2
ii  devscripts                      2.12.6
ii  dpkg-dev                        1.16.9
ii  libdpkg-perl                    1.16.9
ii  libexception-class-perl         1.32-1
ii  libfilesys-df-perl              0.92-4+b1
ii  libmime-lite-perl               3.028-1
ii  perl                            5.14.2-16
ii  perl-modules [libio-zlib-perl]  5.14.2-16
ii  postfix [mail-transport-agent]  2.9.5-1
ii  schroot                         1.6.4-4

libsbuild-perl recommends no packages.

libsbuild-perl suggests no packages.

-- no debconf information

Message #10 received at 696841@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>

To: 696841@bugs.debian.org

Cc: debian-68k@lists.debian.org

Subject: same for upload_queues

Date: Fri, 28 Dec 2012 14:49:58 +0000 (UTC)

Hi,

	$upload_queues = […];
must also be changed into
	@upload_queues = (…);
otherwise one gets an error instead of an uploader:

Can't call method "get" on unblessed reference at /usr/share/perl5/Buildd/Uploader.pm line 69.

bye,
//mirabilos
-- 
I want one of these. They cost 720 € though… good they don’t have the HD hole,
which indicates 3½″ floppies with double capacity… still. A tad too much, atm.
‣ http://www.floppytable.com/floppytable-images-1.html

Message #15 received at 696841@bugs.debian.org (full text, mbox, reply):

From: Wouter Verhelst <wouter@debian.org>

To: Thorsten Glaser <tg@mirbsd.de>

Cc: 696841@bugs.debian.org, debian-68k@lists.debian.org

Subject: Re: same for upload_queues

Date: Sun, 30 Dec 2012 16:14:21 +0100

On Fri, Dec 28, 2012 at 02:49:58PM +0000, Thorsten Glaser wrote:
> Hi,
> 
> 	$upload_queues = […];
> must also be changed into

What do you mean by "changed"? The example in my previous mail, as well
as on wiki.debian.org, shows that you need to use (), not [], to
construct the options...

if you misread and/or miscopy things, obviously they won't work ;-)

> 	@upload_queues = (…);
> otherwise one gets an error instead of an uploader:
> 
> Can't call method "get" on unblessed reference at /usr/share/perl5/Buildd/Uploader.pm line 69.

That's because you're passing an anonymous array reference rather than a
list as an array initializer, which doesn't work.

-- 
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.

Message #24 received at 696841@bugs.debian.org (full text, mbox, reply):

From: Matthias Klumpp <mak@debian.org>

To: 696841@bugs.debian.org

Subject: Re: libsbuild-perl: fails to parse configuration: uses undef as HASH ref (MAILTO_HASH)

Date: Fri, 5 Apr 2013 18:26:11 +0200

Hi!
What is the progress on this bug? The issue is highly annoying, and it
would be great if it could be fixed soon. The patch from the wiki page
would have to be applied, and the default buildd sample config would
need some adjustments for this to work.
Regards,
    Matthias

Message #29 received at 696841@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>

To: Matthias Klumpp <mak@debian.org>

Cc: 696841@bugs.debian.org

Subject: Re: libsbuild-perl: fails to parse configuration: uses undef as HASH ref (MAILTO_HASH)

Date: Mon, 8 Apr 2013 11:27:26 +0000 (UTC)

Matthias Klumpp dixit:

>What is the progress on this bug? The issue is highly annoying, and it
>would be great if it could be fixed soon. The patch from the wiki page

It’s applied and fixed in git, and my Atari buildd VM is churning
happily (we got needs-build down to ca. 1000 source packages).

Here’s my last status mail (the last one I found in sent-mail on
the go, anyway):

From: Thorsten Glaser <tg@mirbsd.de>
Message-ID: <Pine.BSM.4.64L.1301061439210.11558@herc.mirbsd.org>
To: Roger Leigh <rleigh@codelibre.net>
Cc: 696840@bugs.debian.org, debian-68k@lists.debian.org
Date: Sun, 6 Jan 2013 14:41:50 +0000 (UTC)
Subject: Re: [buildd-tools-devel] Bug#696840: same for upload_queues

Roger Leigh dixit:

>In both sbuild and buildd, we changed the internal configuration
>(Buildd::Conf and Sbuild::Conf classes) to *only* use scalars,

Okay, with the latest patches, this actually works.

I’m using
• http://anonscm.debian.org/gitweb/?p=buildd-tools/sbuild.git;a=commitdiff;h=fbd76de128aefe983eb8d981e061fc4051432c7f
• http://anonscm.debian.org/gitweb/?p=buildd-tools/sbuild.git;a=commitdiff;h=134223e35d4bea3c58a4764d5ee4944598f67e25
• http://anonscm.debian.org/gitweb/?p=buildd-tools/sbuild.git;a=commitdiff;h=b0b469da801b54c4441fd16a9c85faa6a6b2362d
on top of the sid version (0.63.2-1.1).

bye,
//mirabilos
-- 
☎ <Natureshadow> Ich glaub ich hab mir grad mit dem [Ham]Burger die Nase abge‐
putzt… <mirabilos> Ich glaub ich hab ne neue eMail-Signatur
<Natureshadow> Scheiße, warum passiert mir sowas immer, wenn ich mit dir spre‐
che? *hust* Das war Schnodderburger… *hust*

Message #34 received at 696841-close@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@debian.org>

To: 696841-close@bugs.debian.org

Subject: Bug#696841: fixed in sbuild 0.64.0-1

Date: Fri, 17 May 2013 22:48:16 +0000

Source: sbuild
Source-Version: 0.64.0-1

We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 696841@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roger Leigh <rleigh@debian.org> (supplier of updated sbuild package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 17 May 2013 23:06:13 +0100
Source: sbuild
Binary: libsbuild-perl sbuild buildd
Architecture: source all
Version: 0.64.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian buildd-tools Developers <buildd-tools-devel@lists.alioth.debian.org>
Changed-By: Roger Leigh <rleigh@debian.org>
Description: 
 buildd     - Daemon for automatically building Debian binary packages from Deb
 libsbuild-perl - Tool for building Debian binary packages from Debian sources
 sbuild     - Tool for building Debian binary packages from Debian sources
Closes: 626361 636477 672711 681292 686509 693788 693790 695203 695273 695513 696840 696841 697298 699903
Changes: 
 sbuild (0.64.0-1) unstable; urgency=low
 .
   [ Thorsten Glaser ]
   * Apply patch from Arnaud Patard to fix the uploader (Closes: #636477).
   * Make sample configuration entries actually work (Closes: #696840).
   * Avoid using undef as HASH reference (Closes: #696841).
 .
   [ Philipp Kern ]
   * Forward port patches from the buildd-0.61.0 branch:
     - Buildd::Client: Don't change the cwd.
     - Buildd: Fix SSH control master restart.
 .
   [ Roger Leigh ]
   * New release.
   * Upgrade to Standards-Version 3.9.4 (no changes).
   * buildd:
     - Remove duplicate stop action from init script (Closes: #695513).
     - Failure count before sleeping is configurable with
       MAX_SBUILD_FAILS (Closes: #693790).
     - buildd.init specifies correct Required-Stop dependencies.
     - Remove empty preinst script.
   * sbuild:
     - Cross build-dependency installation failure throws an
       exception (Closes: #693788).
     - In Sbuild::ResolverBase, pass the correct options to deps_parse
       for cross-building and foo:native build dependencies
       (Closes: #697298).  Thanks to Colin Watson for this patch.
     - In Sbuild::Build::copy_to_chroot, remove stray exit() which could
       cause sbuild to hang with a "Failed to copy" error
       (Closes: #699903).  Thanks to Stephan Sürken for this patch.
     - Compute changes path correctly, to allow “--debbuildopt=-A” to
       work correctly with _all.changes (Closes: #686509).  Thanks to
       Daniel Dehennin for the original version of this patch.
     - Run lintian from inside the chroot (Closes: #626361).  Thanks to
       Reinhard Tartler for this patch.
 .
   [ Colin Watson ]
   * sbuild:
     - Resolve cross-build-dependencies from package being built rather than
       from current apt sources (Closes: #695203).
   * buildd:
     - Reset sbuild failure count after sleeping.
 .
   [ Adam Conrad ]
   * sbuild:
     - Improve cross chroot detection to look for $dist-$build-$host as a
       valid chroot for cross-build to avoid namespace clashes with native
       chroots, and document this better in the manpage (Closes: #695273)
 .
   [ Geoffrey Thomas ]
   * sbuild:
     - When creating a changelog entry for binNMUs or
       --append-to-version, tag it with "binary-only=yes" so that
       dpkg-gencontrol uses the previous changelog entry for the source
       version (Closes: #672711, #681292).
Checksums-Sha1: 
 8b2cdc820ba39034ca929e5003a787e254f5aa1a 2149 sbuild_0.64.0-1.dsc
 eb9212def8709afdd3858eb8da1b1da7fd839c68 600345 sbuild_0.64.0.orig.tar.gz
 15338c3d98bcec2075981aa3c6825e9ea31ba319 80780 sbuild_0.64.0-1.debian.tar.gz
 f1fce32aba936b58b20a900a234fe5aac4043ef5 295280 libsbuild-perl_0.64.0-1_all.deb
 03ca4073aeabf5062d34d1c9ae11b6b677cf362d 310678 sbuild_0.64.0-1_all.deb
 c9233b1dfa3877265e65df9c4f9ba7a52cbbf8ed 295148 buildd_0.64.0-1_all.deb
Checksums-Sha256: 
 c980171759a2d8597ca50df244427fa31fc9ae915eae722d1fea4e897ba3faf3 2149 sbuild_0.64.0-1.dsc
 73a42be8383c7f6caf4bc165c7a8e06c33963af7dca3146767a150fa39518306 600345 sbuild_0.64.0.orig.tar.gz
 638b7cb0d9981b10765b4ea81127c1768ab3fb0eb3bd4d2d414a6a7567e64034 80780 sbuild_0.64.0-1.debian.tar.gz
 5875f41ef455223af6e1e6bb8226c4324570b828e97cca8fbfc7c43cdcbfd8be 295280 libsbuild-perl_0.64.0-1_all.deb
 cbe2ce7742a64e78276161445cc33ada47189486cab049e2c69f682af9cc3ab4 310678 sbuild_0.64.0-1_all.deb
 89bb85155da52746694a9e5b193ebd9b485233320a818fba444c3254f14aa82a 295148 buildd_0.64.0-1_all.deb
Files: 
 d623dff31fdb7cd072a66a23b174a141 2149 devel extra sbuild_0.64.0-1.dsc
 9a635ef786541f13e73446b3699d123b 600345 devel extra sbuild_0.64.0.orig.tar.gz
 e06d6f42db64fed83ce295d9f754862b 80780 devel extra sbuild_0.64.0-1.debian.tar.gz
 cc36322957089f1f0920485de9a8e1a0 295280 perl extra libsbuild-perl_0.64.0-1_all.deb
 1af87b5e8ca828956ac8f1171df2a3f1 310678 devel extra sbuild_0.64.0-1_all.deb
 ea29cbc566eee26bdf386e49a26c9576 295148 devel extra buildd_0.64.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJRlrD5AAoJEOJSSsUKn1xZAAsQALD9IHwg04jqKym6z8thSZ2c
eDLPuPyM+ZfKpdw9WEjYMblYgjp8ExmNempLFsKdcIBRHuj4SO2lyup5p1plYufj
EJCtqcCB5IxQgDxjmMr05PsO+Ro19G4AxpYY1H0repdZJCq/pOfhtyUu4VCuHx3O
E+QgqeVvGDmqklT9NwUMTXRIQzjzCkFI4bZonX74G/uSx6uvJx2SM8U28DCq2a+V
T3MRll1Xl/FS6VLq/y63V3dsc2J5h/ixA30H0XZl2SxTqz3Cu5En/kSV3MjdROu3
CZfEl1kVc5FRkuInLApOgWPfVV9THecXVHvLM93pJcE/o3IRXLILPxu7LEFr46O6
1JdVLz3PDQAC+s0OnV3VZnvKTdPskJX3SothvCZtoRA2xvBsy8yyHnpTGisJSkA3
/6xo4lWNPy+c8ZaDGHuE99rjABCOy6r15kTx/TahRB690JGdMfjDJ2wu+VPrWGrh
51t+QesX1BV/8P6iX/KstOPuS5XJ/6JkHT9R1nOHNkWZ9yQDVmtwkVZQ2aTmoRlH
R7xoORy/U4s0djKD6Hihag9cg60pvpGKPLOi10+3gjb+4wqKC5vL7M4wc/9oyQFD
tyjZRYR1kBMu+TfbZhEyrfBx2+pcqymYtQJH3GXggm4edLVGZs+sjKRbk2G1YPY2
RwyJFra/EP1aJXQzdT9/
=lGga
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.