Debian Bug report logs - #695307
tcpick thinko and patch

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Dr. David Alan Gilbert" <dave@treblig.org>

To: submit@bugs.debian.org

Subject: tcpick thinko and patch

Date: Thu, 6 Dec 2012 20:48:26 +0000

Package: tcpick
Version: 0.2.1-6

This started off as an ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/tcpick/+bug/1086534

There's a thinko/cut-n-paste in time.c:time_ascii where there is
an incorrect length memset; this causes fortify to kill it
in the Ubuntu built versions.

I don't see any upstream activity for years, so I'm not sure
there is really anywhere to report it there.

Dave

Here is my patch:

--- ../../../tcpick-0.2.1/src/time.c    2005-01-09 00:21:44.000000000 +0000
+++ src/time.c  2012-12-06 20:11:10.041288135 +0000
@@ -42,7 +42,7 @@
   tzp = (struct timezone * ) S_malloc( sizeof(struct timezone) );  

   memset(tp,  0, sizeof(struct timeval));  
-  memset(tzp, 0, sizeof(struct timeval));  
+  memset(tzp, 0, sizeof(struct timezone)); 

   if(gettimeofday(tp, tzp)) {


-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Message #10 received at 695307-done@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: "Dr. David Alan Gilbert" <dave@treblig.org>, 695307-done@bugs.debian.org

Subject: Re: Bug#695307: tcpick thinko and patch

Date: Mon, 13 Jul 2015 14:03:51 +0200

Version: 0.2.1-6.1

On Thu, 06 Dec 2012, Dr. David Alan Gilbert wrote:
> This started off as an ubuntu bug:
> https://bugs.launchpad.net/ubuntu/+source/tcpick/+bug/1086534
> 
> There's a thinko/cut-n-paste in time.c:time_ascii where there is
> an incorrect length memset; this causes fortify to kill it
> in the Ubuntu built versions.
> 
> I don't see any upstream activity for years, so I'm not sure
> there is really anywhere to report it there.

I (re)discovered this error by myself today while fixing the
GCC 5 build failure and I fixed it in the 0.2.1-6.1 upload I just
made.

Thanks for the report!

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

Send a report that this bug log contains spam.