Debian Bug report logs - #695261
choose-mirror: fails with with a preseeded mirror and a non-debianish codename

version graph

Package: choose-mirror; Maintainer for choose-mirror is Debian Install System Team <debian-boot@lists.debian.org>; Source for choose-mirror is src:choose-mirror.

Reported by: Raphaël Hertzog <hertzog@debian.org>

Date: Thu, 6 Dec 2012 10:15:07 UTC

Severity: normal

Tags: patch

Found in version choose-mirror/2.44

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#695261; Package choose-mirror. (Thu, 06 Dec 2012 10:15:10 GMT) Full text and rfc822 format available.

Acknowledgement sent to Raphaël Hertzog <hertzog@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Thu, 06 Dec 2012 10:15:10 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Raphaël Hertzog <hertzog@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: choose-mirror: fails with with a preseeded mirror and a non-debianish codename
Date: Thu, 06 Dec 2012 11:13:21 +0100
[Message part 1 (text/plain, inline)]
Package: choose-mirror
Version: 2.44
Severity: normal
Tags: patch

I have a derivative distribution which has its own codename. So I have
preseeded the installer like this:

d-i mirror/country string enter information manually
d-i mirror/suite string foobar
d-i mirror/codename string foobar
d-i mirror/http/hostname string ftp.foobar.com
d-i mirror/http/directory string /foobar

And this points to a perfectly fine APT repository. However while testing
choose-mirror always ends up complaining that the mirror is broken
after having tried to download
http://ftp.foobar.com/foobar/dists/wheezy/Release and having noted that
this file in fact contains another codename. This is precisely because
"wheezy" is a symlink to "foobar" (because unfortunately too many Debian
tools hardcode the codename in some ways).

My CD contains a base system so many checks are skipped and in particular
in get_default_suite() the preseeding of mirror/suite is ignored so that
/etc/default-release is always the source of information.

This comes back to this commit:

commit 80b173602201a274681dbb9dffc0c43b39157bce
Author: Frans Pop <fjp@debian.org>
Date:   Thu Nov 19 21:46:28 2009 +0000

    Ignore preseeded suite when installing from CD with base system
    
    If we're installing from a CD that contains base system packages we
    want to always use the release corresponding to that.
    
    r61380

But I don't really buy this argument. If I preseed something, it's because
I want this value to be used! Furthermore /etc/default-release is hardcoded
in the initrd and it's much less convenient to update.

Suggested patch is attached.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
[0001-Respect-mirror-suite-even-if-the-installation-media-.patch (text/x-diff, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#695261; Package choose-mirror. (Mon, 17 Dec 2012 09:51:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Cyril Brulebois <kibi@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Mon, 17 Dec 2012 09:51:03 GMT) Full text and rfc822 format available.

Message #10 received at 695261@bugs.debian.org (full text, mbox):

From: Cyril Brulebois <kibi@debian.org>
To: Raphaël Hertzog <hertzog@debian.org>, 695261@bugs.debian.org
Subject: Re: Bug#695261: choose-mirror: fails with with a preseeded mirror and a non-debianish codename
Date: Mon, 17 Dec 2012 10:47:18 +0100
[Message part 1 (text/plain, inline)]
Hi,

Raphaël Hertzog <hertzog@debian.org> (06/12/2012):
> I have a derivative distribution which has its own codename. […]

Thanks for the patch, but it looks to me like (1) that's just too late
for wheezy, (2) it doesn't affect it directly. That shouldn't even be
a blocker anyway since you're rolling up your derivative, so you can
apply your patch there.

Feel free to push your patch into a jessie branch for later inclusion.

Mraw,
KiBi.
[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Apr 19 09:53:26 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.