Debian Bug report logs - #694986
flash-kernel: postinst modifies /etc/default/rcS

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Zobel-Helas <zobel@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change

Date: Sun, 2 Dec 2012 12:23:07 +0100

[Message part 1 (text/plain, inline)]

Package: initscripts
Version: 2.88dsf-34
Severity: serious

After a fresh installation of Debian Squeeze and immediate upgrade to
Wheezy, I am asked to confirm changes for /etc/default/rcS which i never
touched. 

Setting up initscripts (2.88dsf-34) ...
Installing new version of config file /etc/init.d/bootlogs ...
Installing new version of config file /etc/init.d/bootmisc.sh ...
Installing new version of config file /etc/init.d/checkfs.sh ...
Installing new version of config file /etc/init.d/checkroot.sh ...
Installing new version of config file /etc/init.d/mountall.sh ...
Installing new version of config file /etc/init.d/mountall-bootclean.sh
...
Installing new version of config file /etc/init.d/mountnfs.sh ...
Installing new version of config file /etc/init.d/mountnfs-bootclean.sh
...
Installing new version of config file /etc/init.d/mountdevsubfs.sh ...
Installing new version of config file /etc/init.d/mountkernfs.sh ...
Installing new version of config file /etc/init.d/mtab.sh ...
Installing new version of config file /etc/init.d/rc.local ...
Installing new version of config file /etc/init.d/sendsigs ...
Installing new version of config file /etc/init.d/umountfs ...
Installing new version of config file /etc/init.d/umountnfs.sh ...
Installing new version of config file /etc/init.d/umountroot ...
Installing new version of config file /etc/init.d/urandom ...

Configuration file `/etc/default/rcS'
 ==> File on system created by you or by a script.
 ==> File also in package provided by package maintainer.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** rcS (Y/I/N/O/D/Z) [default=N] ? D

--- /etc/default/rcS    2012-11-10 18:33:22.812057000 +0000
+++ /etc/default/rcS.dpkg-new   2012-08-31 20:14:04.000000000 +0000
@@ -7,11 +7,18 @@
 #
 # This file belongs to the "initscripts" package.
 
-TMPTIME=0
-SULOGIN=no
-DELAYLOGIN=no
-UTC=yes
-VERBOSE=no
-FSCKFIX=yes
-RAMRUN=no
-RAMLOCK=no
+# delete files in /tmp during boot older than x days.
+# '0' means always, -1 or 'infinite' disables the feature
+#TMPTIME=0
+
+# spawn sulogin during boot, continue normal boot if not used in 30
seconds
+#SULOGIN=no
+
+# do not allow users to log in until the boot has completed
+#DELAYLOGIN=no
+
+# be more verbose during the boot process
+#VERBOSE=no
+
+# automatically repair filesystems with inconsistencies during boot
+#FSCKFIX=no




-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages initscripts depends on:
ii  coreutils       8.20-3
ii  debianutils     4.3.4
ii  libc6           2.13-37
ii  lsb-base        4.1+Debian9
ii  mount           2.20.1-5.2
ii  sysv-rc         2.88dsf-34
ii  sysvinit-utils  2.88dsf-34

Versions of packages initscripts recommends:
ii  e2fsprogs  1.42.5-1
ii  psmisc     22.20-1

initscripts suggests no packages.

-- no debconf information

-- 
 Martin Zobel-Helas <zobel@debian.org>  | Debian System Administrator
 Debian & GNU/Linux Developer           |           Debian Listmaster
 GPG key http://go.debian.net/B11B627B  |            Debian Webmaster
 GPG Fingerprint:  6B18 5642 8E41 EC89 3D5D  BDBB 53B1 AC6D B11B 627B 

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Martin Zobel-Helas <zobel@debian.org>

To: 694928@bugs.debian.org

Subject: Re: Bug#694928: Acknowledgement (asks for confirmation on config-file change on /etc/default/rcS, while file didn't change)

Date: Sun, 2 Dec 2012 12:36:25 +0100

[Message part 1 (text/plain, inline)]

12/02/12 [12:32:37] < rleigh_> zobel: Could you possibly attach the entire original file as well?

argento% ls -al /etc/default/rcS.dpkg-old 
-rw-r--r-- 1 root root 283 Nov 10 18:33 /etc/default/rcS.dpkg-old

argento% md5sum /etc/default/rcS.dpkg-old
2d41de8630a2da1b95616aaaacf5c7ef  /etc/default/rcS.dpkg-old

find the file attached.

Cheers
Martin
-- 
 Martin Zobel-Helas <zobel@debian.org>  | Debian System Administrator
 Debian & GNU/Linux Developer           |           Debian Listmaster
 GPG key http://go.debian.net/B11B627B  |            Debian Webmaster
 GPG Fingerprint:  6B18 5642 8E41 EC89 3D5D  BDBB 53B1 AC6D B11B 627B 

[rcS (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Martin Zobel-Helas <zobel@debian.org>

To: 694928@bugs.debian.org

Subject: Re: Bug#694928: Acknowledgement (asks for confirmation on config-file change on /etc/default/rcS, while file didn't change)

Date: Sun, 2 Dec 2012 13:38:14 +0100

[Message part 1 (text/plain, inline)]

Hi,

short conclusion on #debian-devel was, it comes from:

flash-kernel (2.6) unstable; urgency=low
  * Set FSCKFIX=yes in /etc/default/rcS to stop fsck from prompting the
    user for input since most users don't have a serial console.
 -- Martin Michlmayr <tbm@cyrius.com>  Sun, 17 Aug 2008 16:31:53 +0300

Cheers,
Martin
-- 
 Martin Zobel-Helas <zobel@debian.org>  | Debian System Administrator
 Debian & GNU/Linux Developer           |           Debian Listmaster
 GPG key http://go.debian.net/B11B627B  |            Debian Webmaster
 GPG Fingerprint:  6B18 5642 8E41 EC89 3D5D  BDBB 53B1 AC6D B11B 627B 

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivo.dedecker@ugent.be>

To: 694928@bugs.debian.org

Subject: Re: Bug#694928: config-file change on /etc/default/rcS

Date: Sun, 2 Dec 2012 20:04:59 +0100

Control: reassign -1 flash-kernel

Hi,

On Sun, Dec 02, 2012 at 01:38:14PM +0100, Martin Zobel-Helas wrote:
> short conclusion on #debian-devel was, it comes from:
> 
> flash-kernel (2.6) unstable; urgency=low
>   * Set FSCKFIX=yes in /etc/default/rcS to stop fsck from prompting the
>     user for input since most users don't have a serial console.
>  -- Martin Michlmayr <tbm@cyrius.com>  Sun, 17 Aug 2008 16:31:53 +0300

The postinst from flash-kernel contains this:

# Stop fsck from prompting the user for input since most users don't
# have a serial console.
sed -i "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true

So this bug should be reassigned.

Cheers,

Ivo

Message #33 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 694928@bugs.debian.org

Cc: pkg-sysvinit-devel@lists.alioth.debian.org

Subject: Re: [Pkg-sysvinit-devel] Bug#694928: config-file change on /etc/default/rcS

Date: Sun, 2 Dec 2012 20:22:53 +0100

[Ivo De Decker]
> The postinst from flash-kernel contains this:
> 
> # Stop fsck from prompting the user for input since most users don't
> # have a serial console.
> sed -i "s/^FSCKFIX=no$/FSCKFIX=yes/" /target/etc/default/rcS || true
> 
> So this bug should be reassigned.

Of course, this bug was introduced when sysvinit changed
/etc/default/rcS from a non-conffile to a conffile.  Before this
change, /etc/default/rcS was copied into place on first time
installation, and never updated using dpkg.  This was done like this
to avoid any conffile questions during upgrades.

At the moment with /etc/default/rcS as a conffile, there is no way for
flash-kernel to do what it want in a policy compliant way. :( The only
way to make that happen is for sysvinit to provide a mechanism to edit
the file, or to convert the file back to being a non-conffile.

-- 
Happy hacking
Petter Reinholdtsen

Message #38 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@codelibre.net>

To: Martin Zobel-Helas <zobel@debian.org>, 694928@bugs.debian.org

Subject: Re: Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change

Date: Sun, 2 Dec 2012 23:47:37 +0000

clone 694928 -1
reassign -1 initscripts
thanks

On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote:

Please find attached an example patch for flash-kernel to
support old and new (rcS and fsck) locations for FSCKFIX
as discussed on #debian-devel earlier.

Please don't apply it just yet--we'll presumably need to get
approval from the release team to change this in initscripts
at the same time.  I'll have a patch for initscripts shortly;
might be a bit later in the week to allow for comprehensive
testing.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800

Message #43 received at 694928@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@codelibre.net>

To: Martin Zobel-Helas <zobel@debian.org>, 694928@bugs.debian.org

Subject: Re: Bug#694928: asks for confirmation on config-file change on /etc/default/rcS, while file didn't change

Date: Sun, 2 Dec 2012 23:49:44 +0000

[Message part 1 (text/plain, inline)]

On Sun, Dec 02, 2012 at 11:47:37PM +0000, Roger Leigh wrote:
> clone 694928 -1
> reassign -1 initscripts
> thanks
> 
> On Sun, Dec 02, 2012 at 12:23:07PM +0100, Martin Zobel-Helas wrote:
> 
> Please find attached an example patch for flash-kernel to
> support old and new (rcS and fsck) locations for FSCKFIX
> as discussed on #debian-devel earlier.

Hmm, actually attached now.

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800

[0001-debian-Update-etc-default-fsck-in-flash-kernel-insta.patch (text/x-diff, attachment)]

Message #58 received at 694986@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 694986@bugs.debian.org, Martin Zobel-Helas <zobel@debian.org>, Ivo De Decker <ivo.dedecker@ugent.be>, Roger Leigh <rleigh@codelibre.net>

Subject: Re: flash-kernel: postinst modifies /etc/default/rcS

Date: Tue, 04 Feb 2014 11:43:05 +0100

I read this bug report, but fail to understand what exactly it is
expected for the sysvinit maintainers to do here.  Anyone care to
explain what more can be done in this case?  Roger, you cloned it
instead of reassigning it.  What did you have in mind?

-- 
Happy hacking
Petter Reinholdtsen

Message #63 received at 694986@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@codelibre.net>

To: Petter Reinholdtsen <pere@hungry.com>

Cc: 694986@bugs.debian.org, Martin Zobel-Helas <zobel@debian.org>, Ivo De Decker <ivo.dedecker@ugent.be>

Subject: Re: flash-kernel: postinst modifies /etc/default/rcS

Date: Tue, 4 Feb 2014 11:42:24 +0000

On Tue, Feb 04, 2014 at 11:43:05AM +0100, Petter Reinholdtsen wrote:
> 
> I read this bug report, but fail to understand what exactly it is
> expected for the sysvinit maintainers to do here.  Anyone care to
> explain what more can be done in this case?  Roger, you cloned it
> instead of reassigning it.  What did you have in mind?

Sorry, I can't remember.  Possibly it related to changing the
FSCKFIX default and/or defaulting FSCKFIX if unconfigured
depending upon if we could detect an interactive console.  I
understand the latter isn't always possible on arm systems--
there may be a console but it's not necessarily interactive.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800

Message #70 received at 694986@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 694986@bugs.debian.org, Martin Zobel-Helas <zobel@debian.org>, Ivo De Decker <ivo.dedecker@ugent.be>

Subject: Re: flash-kernel: postinst modifies /etc/default/rcS

Date: Tue, 11 Nov 2014 20:32:27 +0100

Control: severity -1 important

I'm not sure this is fixable, but I am sure it isn't release critical.
Reduce the severity to important to reflect this fact.

-- 
Happy hacking
Petter Reinholdtsen

Message #77 received at 694986@bugs.debian.org (full text, mbox, reply):

From: Dmitry Bogatov <KAction@debian.org>

To: Petter Reinholdtsen <pere@hungry.com>

Cc: 694986@bugs.debian.org, Martin Zobel-Helas <zobel@debian.org>, Ivo De Decker <ivo.dedecker@ugent.be>

Subject: Re: flash-kernel: postinst modifies /etc/default/rcS

Date: Wed, 19 Dec 2018 23:40:39 +0000

control: tag -1 +moreinfo

[2014-11-11 20:32] Petter Reinholdtsen <pere@hungry.com>
> Control: severity -1 important
> 
> I'm not sure this is fixable, but I am sure it isn't release critical.
> Reduce the severity to important to reflect this fact.

Dear co-maintainers and maintainers of flash-kernel, what is current
state of issue?

 * Does FSCKFIX=yes still wanted by `flash-kernel' package?
 * What will break if FSCKFIX=yes will be set on by default?

One part of code, affected by value of FSCKFIX is checkroot.sh:213:

	if [ "$FSCKFIX" = yes ]
	then
		fix="-y"
	else
		fix="-a"
	fi

This `fix' variable is used as argument at checkroot.sh:234:

	logsave -s $FSCK_LOGFILE fsck $spinner $force $fix -t $roottype $rootdev


By the way neither -a nor -y mentioned in fsck(8) (but mentioned
in fsck.ext4(8)). Is it okay?

Message #84 received at 694986@bugs.debian.org (full text, mbox, reply):

From: Pierre Ynard <linkfanel@yahoo.fr>

To: "694986@bugs.debian.org" <694986@bugs.debian.org>

Cc: Dmitry Bogatov <KAction@debian.org>, Martin Zobel-Helas <zobel@debian.org>

Subject: Re: flash-kernel: postinst modifies /etc/default/rcS

Date: Wed, 13 Mar 2019 08:13:34 +0000 (UTC)

> * What will break if FSCKFIX=yes will be set on by default?

There's an open bug for changing the default to yes, #637087.
Reportedly, what might break is MD/LVM setups if fsck gets mistakenly
run with -y on the wrong device; the discussion about this is rather
unconclusive.

> By the way neither -a nor -y mentioned in fsck(8) (but mentioned in
> fsck.ext4(8)). Is it okay?

It was removed from fsck(8):

https://salsa.debian.org/debian/util-linux/commit/7208ef864bf903ae4eb16491e7cfd24cf792baad

> fsck: remove fs-specific options from man page

Even then it stated:

> Options to different filesystem-specific fsck's are not standardized.
> If in doubt, please consult the man pages of the filesystem-specific
> checker. Although not guaranteed, the following options are supported
> by most filesystem checkers:

So I think there's some kind of issue with passing -a or -y in the
general case; hopefully they are at least silently ignored by most
implementations, aren't they?

-- 
Pierre Ynard

Send a report that this bug log contains spam.