Debian Bug report logs - #694892
tvtime: package installation creates /root/.tvtime

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: tvtime: package installation creates /root/.tvtime

Date: Sat, 01 Dec 2012 21:36:19 +0100

[Message part 1 (text/plain, inline)]

Package: tvtime
Version: 1.0.2-9
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed that your package creates files in
/root. From the attached log (scroll to the bottom):

0m34.1s ERROR: FAIL: Package purging left files on system:
  /root/.tvtime/	 not owned

Creating stuff in /root is a FHS and policy violation. (And of course
these files should not be deleted by maintainer scripts.)
But it is also an indication that the package operation may depend on
root's .tvtime configuration (and package installation might even fail if
that configuration is broken). That would be a case for "configuration
files not in /etc".

This might also be the cause for #445192 where a users ~/.tvtime/ is
owned by root:root - probably depending on how the user switched to root.

See #689806 for a similar issue with /root/.gnupg/ and how this was
solved there.


Cheers,

Andreas

[tvtime_1.0.2-9.log.gz (application/x-gzip, attachment)]

Message #10 received at 694892@bugs.debian.org (full text, mbox, reply):

From: Michael Stapelberg <stapelberg@debian.org>

To: Andreas Beckmann <debian@abeckmann.de>

Cc: 694892@bugs.debian.org, control@bugs.debian.org

Subject: Re: tvtime: package installation creates /root/.tvtime

Date: Sun, 2 Dec 2012 23:57:38 +0100

[Message part 1 (text/plain, inline)]

tags 694892 + patch
thanks

On Sat, 01 Dec 2012 21:36:19 +0100
Andreas Beckmann <debian@abeckmann.de> wrote:
> 0m34.1s ERROR: FAIL: Package purging left files on system:
>   /root/.tvtime/	 not owned
This is due to tvtime-configure being called in the postinst script.
tvtime-configure uses config_new() which in turn contains this code:

    /* Make the ~/.tvtime directory every time on startup, to be safe. */
    if( asprintf( &temp_dirname, "%s/.tvtime", getenv( "HOME" ) ) < 0 ) {
        /* FIXME: Clean up ?? */
        return 0;
    }
    mkdir_and_force_owner( temp_dirname, ct->uid, getgid() );
    free( temp_dirname );

Therefore, tvtime-configure creates $HOME/.tvtime everytime you
run it, even when the invocation is something like 
tvtime-configure -F /etc/tvtime/tvtime.xml

I have attached a patch which will fix the bug (that is, not create
$HOME/.tvtime on every run) but will still work correctly by creating
dirname(config_filename) before saving. I tested it by changing the
deinterlacing setting.

-- 
Best regards,
Michael

[mkdir.patch (text/x-patch, attachment)]

Message #19 received at 694892-close@bugs.debian.org (full text, mbox, reply):

From: Bart Martens <bartm@debian.org>

To: 694892-close@bugs.debian.org

Subject: Bug#694892: fixed in tvtime 1.0.2-10

Date: Fri, 07 Dec 2012 12:02:39 +0000

Source: tvtime
Source-Version: 1.0.2-10

We believe that the bug you reported is fixed in the latest version of
tvtime, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 694892@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bart Martens <bartm@debian.org> (supplier of updated tvtime package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 07 Dec 2012 08:44:21 +0000
Source: tvtime
Binary: tvtime
Architecture: source amd64
Version: 1.0.2-10
Distribution: unstable
Urgency: low
Maintainer: Bart Martens <bartm@debian.org>
Changed-By: Bart Martens <bartm@debian.org>
Description: 
 tvtime     - television display application
Closes: 445192 694892
Changes: 
 tvtime (1.0.2-10) unstable; urgency=low
 .
   * debian/patches/saveconfig.diff: Added.  Prevents needless creation of
     $HOME/.tvtime by tvtime-configure.  Closes: #694892, #445192.
Checksums-Sha1: 
 7ba6945c9f32fe082ba725fe55067a8767e67e9c 1828 tvtime_1.0.2-10.dsc
 9c2faba822d1c9f25068cb50cf5f3ef83ab2821a 92518 tvtime_1.0.2-10.diff.gz
 810b86b4d8bdba341de5bd07e6447915416fc3df 744270 tvtime_1.0.2-10_amd64.deb
Checksums-Sha256: 
 bba9e269ca11415aa8b2a6ffede3bcc74cb4f4d04b98a5fc341f1ab8c847ae94 1828 tvtime_1.0.2-10.dsc
 b6119abee5f4e5e642904e3747f95e4b5896f9dfd00a58aee80e66489890a42d 92518 tvtime_1.0.2-10.diff.gz
 70f246c4a1182c9e74d95e1a816ab4a66aadc19ed7ca0e57e8385da251f6363b 744270 tvtime_1.0.2-10_amd64.deb
Files: 
 632acaf2cd3f2d87e1664d173b82db07 1828 video optional tvtime_1.0.2-10.dsc
 21afb1fb2c5948ce6b2d6b8e47e7ed19 92518 video optional tvtime_1.0.2-10.diff.gz
 37a86865254b48ebce7932cb5dae6922 744270 video optional tvtime_1.0.2-10_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJQwdbtAAoJEDNV9NY7WCHMcfcP/Rid+JpDVPctQjY9rnZBWuDu
AcfzFtLQVx01XMM9aFRAaWM+tLhOd5jbYMUBeM7KA+dn4EAk5+XpLGaGtzJ6lLeo
UzWvcOAsQICcJBAZMNFB3nf/ll2bVBEwSpeh3PGV+RueOO4INvwnlabx28P1wUxe
sW22BUvRcFEy4Q/9r9ryhclGqyZGWma8mm9AK1zFXVVPo/XNXqKZKkgE1iOX26vN
uWPriTfL3aH1l8w5MI6NmkdzE1rVsqjA67dhzToBUN/FftZehAsxMDrnrUhx/b8k
u1ZZ6wF9He34fxEH4QhFIfFaORvpGfPlwxG9vttTVQd36au9N9jnIprLgGu4Dyc9
KHjRj5+bXxhizTIByROfozIh2fI3DX3JKfIErcTqOhv81XeHaGgtjAeeePWIuXBB
y86GBmCPEwgu3snXcEE8+PN0pkjl+1mp5xGOa2CyI/+FX4TpKXaazXltqnMm0XeD
xRcLMPr/vwy5z8r6FXn6/7k4OHrgFHcTlo5y3QNP6CZBE/XLSBmQbV8KrdlF/xhm
EBOayjHpV6Tg7Pv/BOan4IFw1bKxkOWmr8xmbuUNgyMmXnBoWZnaHo7EDpoqkxfs
l1s51nsAPuLknW0CNaD95XPE4dL792oDAxqxvTJjo2+vJ7GBxwZ6yJ8nMyyKoxPn
LY1jNBikVHWXdObO3qC9
=3JWP
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.