Debian Bug report logs - #693320
libnet-server-perl: Uninitialized value in pattern match spam

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Patrick Matthäi <pmatthaei@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libnet-server-perl: Uninitialized value in pattern match spam

Date: Thu, 15 Nov 2012 15:07:14 +0100

Package: libnet-server-perl
Version: 2.006-1
Severity: important
Tags: patch

Using munin-node on Wheezy the /var/log/munin-node.log is spammed down with
this entries:

	Use of uninitialized value in pattern match (m//) at /usr/share/perl5/Net/Server.pm line 600.

This is because of some missing variable checking and wrong order of checking for them.
Please also add this for Wheezy.


--- Server.pm.orig      2012-11-15 14:51:16.825804448 +0100
+++ Server.pm   2012-11-15 15:05:56.025792549 +0100
@@ -597,10 +597,10 @@

     # if the addr or host isn't blocked yet, allow it if it is allowed
     foreach (@{ $prop->{'allow'} }) {
-        return 1 if $prop->{'peerhost'} =~ /^$_$/ && defined $prop->{'reverse_lookups'};
-        return 1 if $peeraddr =~ /^$_$/;
+        return 1 if defined $prop->{'reverse_lookups'} && defined $prop->{'peerhost'} && $prop->{'peerhost'} =~ /^$_$/;
+       return 1 if defined $peeraddr && $peeraddr =~ /^$_$/;
     }
-    if (@{ $prop->{'cidr_allow'} }) {
+    if (defined $peeraddr && defined @{ $prop->{'cidr_allow'} }) {
         require Net::CIDR;
         return 1 if Net::CIDR::cidrlookup($peeraddr, @{ $prop->{'cidr_allow'} });
     }



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libnet-server-perl depends on:
ii  libio-multiplex-perl     1.13-1
ii  libio-socket-inet6-perl  2.69-2
ii  libnet-cidr-perl         0.15-1
ii  libsocket6-perl          0.23-1+b2
ii  perl                     5.14.2-15

libnet-server-perl recommends no packages.

Versions of packages libnet-server-perl suggests:
ii  libio-socket-ssl-perl  1.76-2
pn  liblog-log4perl-perl   <none>
ii  libnet-ssleay-perl     1.48-1+b1

-- no debconf information

Message #14 received at 693320@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Patrick Matthäi <pmatthaei@debian.org>, 693320@bugs.debian.org

Subject: Re: Bug#693320: libnet-server-perl: Uninitialized value in pattern match spam

Date: Sat, 17 Nov 2012 13:37:30 +0100

[Message part 1 (text/plain, inline)]

On Thu, 15 Nov 2012 15:07:14 +0100, Patrick Matthäi wrote:

> Using munin-node on Wheezy the /var/log/munin-node.log is spammed down with
> this entries:
> 
> 	Use of uninitialized value in pattern match (m//) at /usr/share/perl5/Net/Server.pm line 600.

Right, I see the same here ...
 
> This is because of some missing variable checking and wrong order of checking for them.
> Please also add this for Wheezy.

Ack.

There's also an upstream bug report:
https://rt.cpan.org/Ticket/Display.html?id=78828
with a slightly different patch (which also addresses the 'deny'
case) but doesn't check on $peeraddr ...

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: It Ain't Me, Babe

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 693320-close@bugs.debian.org (full text, mbox, reply):

From: Xavier Guimard <x.guimard@free.fr>

To: 693320-close@bugs.debian.org

Subject: Bug#693320: fixed in libnet-server-perl 2.007-1

Date: Sun, 05 May 2013 10:48:44 +0000

Source: libnet-server-perl
Source-Version: 2.007-1

We believe that the bug you reported is fixed in the latest version of
libnet-server-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 693320@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Xavier Guimard <x.guimard@free.fr> (supplier of updated libnet-server-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 05 May 2013 06:17:50 +0200
Source: libnet-server-perl
Binary: libnet-server-perl
Architecture: source all
Version: 2.007-1
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: Xavier Guimard <x.guimard@free.fr>
Description: 
 libnet-server-perl - extensible, general perl server engine
Closes: 693320
Changes: 
 libnet-server-perl (2.007-1) unstable; urgency=low
 .
   [ Salvatore Bonaccorso ]
   * Change Vcs-Git to canonical URI (git://anonscm.debian.org)
   * Change search.cpan.org based URIs to metacpan.org based URIs
 .
   [ Xavier Guimard ]
   * Imported Upstream version 2.007 (Closes: #693320)
   * Bump Standards-Version to 3.9.4 (no changes)
   * Remove pod patch now included in upstream
   * Add spelling error patch
   * Update debian/copyright years
Checksums-Sha1: 
 2ff79b197cfe328b4f976cb2e1ad7b65083f3124 2263 libnet-server-perl_2.007-1.dsc
 e2cd92dc275371c50e3baca43f90e8bef1cdda7e 133765 libnet-server-perl_2.007.orig.tar.gz
 ee82e0435ec96cb0af65ce28d95b60fba7ce41b5 5043 libnet-server-perl_2.007-1.debian.tar.gz
 10b94cade795e97835c1dece155a7c9bb30cbdb2 209564 libnet-server-perl_2.007-1_all.deb
Checksums-Sha256: 
 4bdc21fa58c788b7121f955a7eda27e1178c00e0c26133f59eca0fabc1f6669f 2263 libnet-server-perl_2.007-1.dsc
 1c6fd3145b1bb796e28ebf74c181e4a7bbf5c412b37b51f72ad2707686a80328 133765 libnet-server-perl_2.007.orig.tar.gz
 94320c8bf598c78975dd3d8086705292cf049b211347dbffb53e8f02c05cb20e 5043 libnet-server-perl_2.007-1.debian.tar.gz
 c4750c105ca3d44bc19f195c89eb5a907770f6f35e5e5e5a3c24279249555e90 209564 libnet-server-perl_2.007-1_all.deb
Files: 
 a695f0cf4d2a5ac6fa59f6ebb5afde87 2263 perl optional libnet-server-perl_2.007-1.dsc
 b256c35a18caecc8fce9e6e1f2825658 133765 perl optional libnet-server-perl_2.007.orig.tar.gz
 5ac83ac1e1f4e250af8990e8c705edd1 5043 perl optional libnet-server-perl_2.007-1.debian.tar.gz
 f3b0ec7f7c459e931f1827a5ab64ff3e 209564 perl optional libnet-server-perl_2.007-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRhjSxAAoJELs6aAGGSaoGVNgQAKlLZDXe124Rxl9dwbOCMdRD
Dr16hzeBql8J+A6eJOFUS7PxV/N6RN/rc0Kva6TN0lwCi8WIwgFx2w+7gLDWITHl
T+LEfly7gvtYb5kd5SJ0/IVE0mr4zMP1eUoBKYUh9t489/flUiVYZaAO01lVBSji
yo2gkQ+6YtF0DtDT0JNFl6gApQi+5I6cBxpd1zFLnExlqDmvI0yfJyKj9wIcz+s6
dMbd7JMxGvLkJwrKPGxuGDTh8g7yTmCwUyU/kDM3LScjMEbc+/Hm/no918D5zfH0
4KERWcTdmlqHbxq+f9ZZXkvq635k+CmsOrHvU9jM+stBVXUITPW/zgr2OHIWk3Xg
SfVwEX0Wn3e7dCOQFEsK28Jip08j0DG87Q4hXJuF31eL33Pm5j5UMrUjl4VmYLSw
kQ1APPQc0VXai2gg2fyEfHxczmscwSOKP6aCw10k36qw4aN3/aKsf0nsHmmqlE9W
+QFbjY85nyq5WuFbeRK3IUkf1PKFLIancnbsdzoBj7TUc7GIKCPwjkNxADG4q46s
69J7rj7AbuOpLvW6qGUSzLkPCWPbHk68kmlcb6ziShXDkeElfSTylGhlENAl1VJp
xfnkea5lcvd8QhdRSgKYYJ53ntgxinqLcOu/QlpSJ0yDDHuvYyRMoQXdr8cXVQHA
KITJxxaPMgjU/fHZo8YT
=/TVb
-----END PGP SIGNATURE-----

Message #30 received at 693320@bugs.debian.org (full text, mbox, reply):

From: pkg-perl-maintainers@lists.alioth.debian.org

To: 693320@bugs.debian.org, 693320-submitter@bugs.debian.org

Subject: Pending fixes for bugs in the libnet-server-perl package

Date: Thu, 28 Nov 2013 13:00:09 +0000

tag 693320 + pending
thanks

Some bugs in the libnet-server-perl package are closed in revision
f69136bea8d6f9eb946780f7731fff4646553d28 in branch '  wheezy' by
Salvatore Bonaccorso

The full diff can be seen at
http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libnet-server-perl.git;a=commitdiff;h=f69136b

Commit message:

    Add fix-use-of-uninitialized-value-in-pattern-match.patch
    
    Fixes use of uninitialized value in pattern match.
    
    This in particular affects munin-nodes under wheezy. Logs are spammed
    with entries: "Use of uninitialized value in pattern match (m//) at
    /usr/share/perl5/Net/Server.pm line 600.".
    
    Closes: #693320

Message #40 received at 693320-close@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: 693320-close@bugs.debian.org

Subject: Bug#693320: fixed in libnet-server-perl 2.006-1+deb7u1

Date: Sun, 01 Dec 2013 00:32:05 +0000

Source: libnet-server-perl
Source-Version: 2.006-1+deb7u1

We believe that the bug you reported is fixed in the latest version of
libnet-server-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 693320@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated libnet-server-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 28 Nov 2013 12:31:37 +0100
Source: libnet-server-perl
Binary: libnet-server-perl
Architecture: source all
Version: 2.006-1+deb7u1
Distribution: wheezy
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Description: 
 libnet-server-perl - extensible, general perl server engine
Closes: 693320
Changes: 
 libnet-server-perl (2.006-1+deb7u1) wheezy; urgency=low
 .
   * Team upload.
   * Add fix-use-of-uninitialized-value-in-pattern-match.patch.
     Fixes use of uninitialized value in pattern match.
     This in particular affects munin-nodes under wheezy. Logs are spammed
     with entries: "Use of uninitialized value in pattern match (m//) at
     /usr/share/perl5/Net/Server.pm line 600.". (Closes: #693320)
Checksums-Sha1: 
 e8959e6b7d7416d73cde67d0f5beb4de6d75f5c5 2250 libnet-server-perl_2.006-1+deb7u1.dsc
 37badd90bcf3ac2b8f7bd1dc2b08aac0781c9a46 6937 libnet-server-perl_2.006-1+deb7u1.debian.tar.gz
 f9e35df99224a0a3271e7a7222600dfc5ff07ebc 209068 libnet-server-perl_2.006-1+deb7u1_all.deb
Checksums-Sha256: 
 9ad8cfa6a09109bd8eadca5bf47a80596e49a1d33b7a7bd82130473aae56cd3a 2250 libnet-server-perl_2.006-1+deb7u1.dsc
 407999fa82ea5aa8245aac92a2a233f68070107f8da077a1a72b049b01da5729 6937 libnet-server-perl_2.006-1+deb7u1.debian.tar.gz
 05bbf832345a190755ce76f984a7502fa168168d66092639cd88ba176fee0e15 209068 libnet-server-perl_2.006-1+deb7u1_all.deb
Files: 
 1765fce64cc26ebc094d5c04d34897cb 2250 perl optional libnet-server-perl_2.006-1+deb7u1.dsc
 5788ac6f13e2a9c08863a63258e365c1 6937 perl optional libnet-server-perl_2.006-1+deb7u1.debian.tar.gz
 2df07d46f7a0519b0f2102220fb00439 209068 perl optional libnet-server-perl_2.006-1+deb7u1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBCgAGBQJSlyn3AAoJEAVMuPMTQ89Ep1cP/jrKzRYxjlVeUtZhg/lNViWt
XgGxvFdAxfSSM+FC9gPrDn7EbwQFoX8tKEYxlb+waVKqkI46Na1u1WSXQ8fYTo3X
qaojQw/Yhnc9xnIKPDZEvoff8DFA9aMlAVZEMPZaOMNUwJb/rHmCtROWE6mSRzZl
lXRc8+kR69UXsLBaOrohQ8hM0vDVRhz2yA+0i6cCAn9s2c1h7D54mR9290Vs8cyO
o4RN3J3NTMhlp2GlHAcwGWbe+4pPo5v1I5KdPJtqi2Gph0nuou2sFQGYDCnglhGD
1lpv99irQUaH51ej3SHKwkgnHqAlWtRcULV+12Rrk8DRAnx384ny43rD2K5FqEbH
NTDnIMWJFEQl9AS9Lcb712XFaZHGW9Hs8e95HE4LP4+lD1t1x20b93c4wR69T2zG
AHBsiqcz+Q355aks+XLecCgOA6Ic7mc55NScyrC/QmbVsbAo6KdiOLwVR7+Rgal/
Cu3+qSRjuk34WqUnAvZsAlrzFf07tjkTemvF9G7b8DkNXRgOOUQaqJq9LsDyFK2m
zmVhAPDo/kDzWF2U4d7fEdDyxiRI4bm4Gp0W9JmGCqxQqyuzA+Ja+hX1X7jz9k59
tpbaGva6eYuZwS+31/62ChQrDF9JxhkVkZxPrgTQA+b6VDPuN6MVr3NAhEsF4dS6
kwvuqLvIEwZ1nBM9KOXJ
=sve8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.