Debian Bug report logs - #691719
sphinx: Cannot build text with footnotes when using l10n

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Mon, 29 Oct 2012 10:05:05 +0400

[Message part 1 (text/plain, inline)]

Source: sphinx
Version: 1.1.3+dfsg-4
Severity: normal
Tags: patch
Control: affects -1 ubuntu-packaging-guide

Dear maintainer,

The attached patch is a cherry-pick of upstream changeset that fixes
build of localized projects that contain footnotes in the text.

It affects the ubuntu-packaging-guide package (yes, a package in Debian)
which is going to ship translation packages.

It is not urgent, but it would be very good if this patch is applied in
(at least experimental version of) sphinx.

Please let me know if I should go ahead and commit it myself.

--
Dmitry Shachnev

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (700, 'unstable'), (500, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/4 CPU cores)
Locale: LANG=ru_RU.utf8, LC_CTYPE=ru_RU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[fix_l10n_footnotes.diff (text/x-patch, attachment)]

Message #10 received at 691719@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Dmitry Shachnev <mitya57@gmail.com>, 691719@bugs.debian.org

Subject: Re: Bug#691719: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Mon, 29 Oct 2012 09:29:17 +0100

* Dmitry Shachnev <mitya57@gmail.com>, 2012-10-29, 10:05:
>The attached patch is a cherry-pick of upstream changeset that fixes 
>build of localized projects that contain footnotes in the text.
>
>It affects the ubuntu-packaging-guide package (yes, a package in 
>Debian) which is going to ship translation packages.

Does u-p-g uses autonumbered footnotes, or it's some other kind of 
markup that triggers the issue?

>-            for child in patch.children: # update leaves
>-                child.parent = node
>-            node.children = patch.children
>+
>+            # copy text children
>+            for i, child in enumerate(patch.children):
>+                if isinstance(child, nodes.Text):
>+                    child.parent = node
>+                    node.children[i] = child

It appears to me that this patch trades one bug for another. What if 
types of "node.children[i]" and "child" don't match? Or if "patch" has a 
different number of children than "node"?

-- 
Jakub Wilk

Message #15 received at 691719@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@gmail.com>

To: 691719@bugs.debian.org

Subject: Re: Bug#691719: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Mon, 29 Oct 2012 13:00:20 +0400

On Mon, Oct 29, 2012 at 12:29 PM, Jakub Wilk <jwilk@debian.org> wrote:
> Does u-p-g uses autonumbered footnotes, or it's some other kind of markup
> that triggers the issue?

Yes, something like this:
http://bazaar.launchpad.net/~ubuntu-packaging-guide-team/ubuntu-packaging-guide/trunk/view/head:/ubuntu-packaging-guide/udd-merging.rst#L8

> It appears to me that this patch trades one bug for another. What if types
> of "node.children[i]" and "child" don't match? Or if "patch" has a different
> number of children than "node"?

You are right, it is a bug, I'll now leave a comment on the upstream
bug. However, as far as I understand, such cases weren't working
without the patch either, so I think it still can be safely applied
(especially given that it's now in the upstream branch).

--
Dmitry Shachnev

Message #26 received at 691719@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@gmail.com>

To: 691719@bugs.debian.org

Subject: Re: Bug#691719: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Fri, 23 Nov 2012 18:26:20 +0400

[Message part 1 (text/plain, inline)]

Control: retitle -1 Cannot build text with footnotes when using l10

Attached updated patch that is based on first one and
http://dev.sphinx-doc.org/sphinx/pull-request/86/fixed-955-footnote-i18n-translation-cause/commits .

Does it look better?

--
Dmitry Shachnev

[fix_l10n_footnotes_v2.diff (text/x-patch, attachment)]

Message #33 received at 691719@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Dmitry Shachnev <mitya57@gmail.com>, 691719@bugs.debian.org

Subject: Re: Bug#691719: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Sat, 24 Nov 2012 20:24:22 +0100

* Dmitry Shachnev <mitya57@gmail.com>, 2012-11-23, 18:26:
>Attached updated patch that is based on first one and
>http://dev.sphinx-doc.org/sphinx/pull-request/86/fixed-955-footnote-i18n-translation-cause/commits .
>
>Does it look better?

Looks good to me. If you tested it and it works, feel free to commit it 
to the repository.

-- 
Jakub Wilk

Message #40 received at 691719@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@gmail.com>

To: 691719@bugs.debian.org

Cc: Andrew Starr-Bochicchio <asb@debian.org>

Subject: Re: Bug#691719: sphinx: Please cherry-pick changeset b7b808e46851 that fixes issues with localized projects

Date: Fri, 7 Dec 2012 17:13:00 +0400

Hi Jakub,

The pull request has been accepted upstream after some refactoring,
and I've updated the patch in SVN with the latest changes. If it
(still) looks good, can you please make a new upload?

We really want to make a new upload of ubuntu-packaging-guide with
Spanish translation included :)

Cheers,

--
Dmitry Shachnev

On Sat, Nov 24, 2012 at 11:24 PM, Jakub Wilk <jwilk@debian.org> wrote:
> * Dmitry Shachnev <mitya57@gmail.com>, 2012-11-23, 18:26:
>
>> Attached updated patch that is based on first one and
>>
>> http://dev.sphinx-doc.org/sphinx/pull-request/86/fixed-955-footnote-i18n-translation-cause/commits
>> .
>>
>> Does it look better?
>
>
> Looks good to me. If you tested it and it works, feel free to commit it to
> the repository.
>
> --
> Jakub Wilk

Message #45 received at 691719-close@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 691719-close@bugs.debian.org

Subject: Bug#691719: fixed in sphinx 1.1.3+dfsg-6

Date: Sat, 08 Dec 2012 15:05:26 +0000

Source: sphinx
Source-Version: 1.1.3+dfsg-6

We believe that the bug you reported is fixed in the latest version of
sphinx, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 691719@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jakub Wilk <jwilk@debian.org> (supplier of updated sphinx package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 08 Dec 2012 14:38:19 +0100
Source: sphinx
Binary: python-sphinx python3-sphinx sphinx-common sphinx-doc libjs-sphinxdoc
Architecture: source all
Version: 1.1.3+dfsg-6
Distribution: experimental
Urgency: low
Maintainer: Jakub Wilk <jwilk@debian.org>
Changed-By: Jakub Wilk <jwilk@debian.org>
Description: 
 libjs-sphinxdoc - JavaScript support for Sphinx documentation
 python-sphinx - documentation generator for Python projects (implemented in Pytho
 python3-sphinx - documentation generator for Python projects (implemented in Pytho
 sphinx-common - documentation generator for Python projects - common data
 sphinx-doc - documentation generator for Python projects - documentation
Closes: 691719
Changes: 
 sphinx (1.1.3+dfsg-6) experimental; urgency=low
 .
   [ Jakub Wilk ]
   * DEP-8 tests: remove “Features: no-build-needed”; it's the default now.
   * Bump standards version to 3.9.4; no changes needed.
   * Pass -a to xvfb-run, so that it tries to get a free server number.
   * Rebuild MO files from source.
     + Update debian/rules.
     + Add the rebuilt files to extend-diff-ignore.
   * Make synopses in the patch header start with a lowercase latter and not
     end with a full stop.
 .
   [ Dmitry Shachnev ]
   * debian/patches/l10n_fixes.diff: fix crashes and not working external
     links in l10n mode (closes: #691719).
   * debian/patches/sort_stopwords.diff: mark as applied upstream.
Checksums-Sha1: 
 da99b5f1f2519a4b813e8b9549e38f40f20f1bb7 2783 sphinx_1.1.3+dfsg-6.dsc
 485bb7806f4b263012baffed333df21676840661 28848 sphinx_1.1.3+dfsg-6.debian.tar.gz
 3932ca54b637212ed28d0e0222ecf4c138dde412 311764 python-sphinx_1.1.3+dfsg-6_all.deb
 c71a5015a3408d84bce139598631a84686d731ac 310754 python3-sphinx_1.1.3+dfsg-6_all.deb
 c713941262acbb1350dd5bcfdfe7cea524202225 419346 sphinx-common_1.1.3+dfsg-6_all.deb
 07792f8e94e2172af3d07b13a4ca33511044dd9e 855820 sphinx-doc_1.1.3+dfsg-6_all.deb
 236ef2ce8e29319bbb7000b0e033c89a341687eb 44452 libjs-sphinxdoc_1.1.3+dfsg-6_all.deb
Checksums-Sha256: 
 f15e20cd6299563b2b7ce176a89c378677630f0b46edf61b140993fc143b460c 2783 sphinx_1.1.3+dfsg-6.dsc
 cc6a7beee657ab9f40c045d6634565d79c69cc0611dd733980aebbca1f530a09 28848 sphinx_1.1.3+dfsg-6.debian.tar.gz
 28a6de926563501ef7f8292c57f4c9fed59793de5cdc08d96edfea9723744f3f 311764 python-sphinx_1.1.3+dfsg-6_all.deb
 960b015bf42d8d8376f993fde8d9f007e553c8d7585af5f6cd4df58874727173 310754 python3-sphinx_1.1.3+dfsg-6_all.deb
 ac78544393b8fb3b126510cbeb3437dd602a4ddb4eec93871c5d8b5c9dcd46a1 419346 sphinx-common_1.1.3+dfsg-6_all.deb
 fce68070a483bd5795438ee833a64fceffa55ffa6db639494a5f7130ee1f3093 855820 sphinx-doc_1.1.3+dfsg-6_all.deb
 580301267fee9347ad5c51e9c218916cd56ee65ae56884ece764af309661e1b7 44452 libjs-sphinxdoc_1.1.3+dfsg-6_all.deb
Files: 
 c1f964f96f2f4de6b57297ad293ff5e2 2783 python optional sphinx_1.1.3+dfsg-6.dsc
 4688cdf44641d2d1ca66cc1d22a6a628 28848 python optional sphinx_1.1.3+dfsg-6.debian.tar.gz
 891c7f99561d572a0632a02249b1cdb4 311764 python optional python-sphinx_1.1.3+dfsg-6_all.deb
 c222f35f88eb84aef36b9445b66d0a0a 310754 python optional python3-sphinx_1.1.3+dfsg-6_all.deb
 e82402e0d73b788d5778e0db0a82a262 419346 python optional sphinx-common_1.1.3+dfsg-6_all.deb
 78a926b6f3ea35c47d4d2ff4073eaf5a 855820 doc optional sphinx-doc_1.1.3+dfsg-6_all.deb
 86af94458ccfd0745c120895af70f5b1 44452 web optional libjs-sphinxdoc_1.1.3+dfsg-6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQw0aSAAoJEC1Os6YBVHX1wtcQAM8MOTil1FujqbwFNauTPG11
gL8QzHLWNTEqRMoyu2I04X+lEEh07iz5F0zKksPPFdKxjbyl2dNlbbdyU5dcuuh/
smFo7MMn7dVurjeFA8VzDCw2Gn9e9YeyGHljwziMFChNhoPeStHG+tmkHsVmycN3
7oFbLp6/BgjDI9FpEIz/QEPX/vLQkTyc23IGQdZc04dI2DufqHpEkEy+TJ7g3bXO
wy8RmGrMYeA8Urigxxx7yXGHLiRr4qsjVyiBnnqlAg3AP57iFV00wUP4rVX1s5Qm
lQtChyksAto+0g4dK7KJ4w2Gu7jscarZyGc9mGj5GD1NpdTUs0wGq7XbzTveP5/o
uz70kMA6uEH41TvK8x56OKdVAeFh3hzr7teFwUuuZSiWHIyVg3PNxAhlJNGyCjL6
Fmfmce2r+IsrD8onvLQ/pd61MFRkxbdTGDOdXphHfDMTfPa6J3mWNpXNtZWB4NIe
8+l4lcZ+cRAsebdavPawr+F0iDeqi9Zku6qfqNdaRgSLc8FnpW6/cSAB7mKqbPxg
lNRyOj2BuLnfB0G4tiS46Zgg7avsQwt09fwBoHMM/TSfteAJJ1JaNcj/3pj54qv0
B8VpEDPxS+0gqZQPIuYLAd25Ve0M4L/gz5J+Ya6IuHAMrUnCdkL/TFZm5yX4PD91
xNsSMQ5ss0W0U36QmWph
=ZDxg
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.