Debian Bug report logs - #690492
love: uses embedded copy of GLee

[Message part 1 (text/plain, inline)]
Package: love
Version: 0.8.0-1
Severity: serious
Justification: package gets rejected by ftp-master.

LÖVE includes a copy of GLee, which is also packaged in Debian. It
should use that package instead.

[signature.asc (application/pgp-signature, inline)]
[Message part 1 (text/plain, inline)]
notfound 690492 0.8.0-1
thanks

On Sun, Oct 14, 2012 at 06:57:43PM +0200, Bas Wijnen wrote:
> On Sun, Oct 14, 2012 at 04:02:50PM +0000, Debian FTP Masters wrote:
> > love: lintian output: 'embedded-library usr/bin/love-0.8: glee', automatically rejected package.
> > love: If you have a good reason, you may override this lintian tag.
> 
> I didn't touch that. I could override this error, but I shouldn't,
> because it is a valid error. I didn't fix it, but I still would like the
> other bugfixes to be included in stable (so I need to get the package
> included in unstable first).

Update: this bug was already worked around in the Debian package: the
files included by upstream are not used, and the debian library package
is used instead. The embeded copy is in the upstream source, and that is
an upstream bug (which should trigger the lintian warning).

The question remains: how should I get this package into unstable?

Thanks,
Bas

[signature.asc (application/pgp-signature, inline)]
Bas Wijnen <wijnen@debian.org> writes:
> On Sun, Oct 14, 2012 at 06:57:43PM +0200, Bas Wijnen wrote:
>> On Sun, Oct 14, 2012 at 04:02:50PM +0000, Debian FTP Masters wrote:
>> > love: lintian output: 'embedded-library usr/bin/love-0.8: glee', automatically rejected package.
>> > love: If you have a good reason, you may override this lintian tag.
>> 
>> I didn't touch that. I could override this error, but I shouldn't,
>> because it is a valid error. I didn't fix it, but I still would like the
>> other bugfixes to be included in stable (so I need to get the package
>> included in unstable first).
>
> Update: this bug was already worked around in the Debian package: the
> files included by upstream are not used, and the debian library package
> is used instead. The embeded copy is in the upstream source, and that is
> an upstream bug (which should trigger the lintian warning).

Are you sure the Debian package does not use the embedded copy? The
lintian error seems to be triggered by the binary package (as it
includes the path).

Ansgar

[Message part 1 (text/plain, inline)]
On Sun, Oct 14, 2012 at 11:05:28PM +0200, Ansgar Burchardt wrote:
> > Update: this bug was already worked around in the Debian package: the
> > files included by upstream are not used, and the debian library package
> > is used instead. The embeded copy is in the upstream source, and that is
> > an upstream bug (which should trigger the lintian warning).
> 
> Are you sure the Debian package does not use the embedded copy? The
> lintian error seems to be triggered by the binary package (as it
> includes the path).

I was pretty sure, but you seem to be right. Ah, now I see: here's the
entry from the changelog:
* Tried to removed internal glee, but it doesn't seem to like the
system's one

So it wasn't used, indeed.

Thanks for the clarification,
Bas

[signature.asc (application/pgp-signature, inline)]
Source: love
Source-Version: 0.8.0-2

We believe that the bug you reported is fixed in the latest version of
love, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 690492@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bas Wijnen <wijnen@debian.org> (supplier of updated love package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Oct 2012 15:01:02 +0200
Source: love
Binary: love love-dbg love-doc
Architecture: source all i386
Version: 0.8.0-2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Bas Wijnen <wijnen@debian.org>
Description: 
 love       - 2D game development framework based on Lua and OpenGL
 love-dbg   - 2D game development framework - debugging symbols
 love-doc   - 2D game development framework - documentation
Closes: 690394 690492 690494
Changes: 
 love (0.8.0-2) unstable; urgency=low
 .
   * Team upload.
   * Convert copyright file to machine readable format.
   * Add copyright information for utf8-cpp. Closes: #690394
   * Add hardening flags to build rules. Closes: #690494
   * Replace included GLee with system version. Closes: #690492
Checksums-Sha1: 
 bd6af0bbe9d39437bdea786b3c6962ca9a95325d 2194 love_0.8.0-2.dsc
 9d192eb240d6aa6d35bf6f8813cf92b863a77f33 105808 love_0.8.0-2.debian.tar.bz2
 768b3d2d483b14fe5bfa94d3f203f2fadbe7b9db 894842 love-doc_0.8.0-2_all.deb
 e18ca8d7de44dfb7ae51cb9d17d821d499dcf07b 930976 love_0.8.0-2_i386.deb
 f30da44ddbca48fe22f272c461b882fa1ff351d0 3624562 love-dbg_0.8.0-2_i386.deb
Checksums-Sha256: 
 4579602229b0faa24cf1021ad234c7715abec5a26ae0a7f041b54ec5346b6c17 2194 love_0.8.0-2.dsc
 998d1f2aecc3133979f632524aa6f5d16b03973325efd413fbf81bf7cc32e164 105808 love_0.8.0-2.debian.tar.bz2
 b0cebae3d3e0558ccf8042bd764592ce4df0225df63652b51592e0e730e1c092 894842 love-doc_0.8.0-2_all.deb
 b65b8f9cfa20a9b969c3f2582401953da4ccb8b51a95f330478d7de9acd9a5d9 930976 love_0.8.0-2_i386.deb
 aef2758d29a79e8ac895a8d42ea902552e35b49ed3f8148e1d1bc4036e602b80 3624562 love-dbg_0.8.0-2_i386.deb
Files: 
 633bc3900878939bc2b1b108a7d04301 2194 interpreters optional love_0.8.0-2.dsc
 b70b8d39b160d1ec60d2658113aa0ee0 105808 interpreters optional love_0.8.0-2.debian.tar.bz2
 d1e77a8acf2d213da533e43c2be5e683 894842 doc optional love-doc_0.8.0-2_all.deb
 65ff5f45aeb2c63dbe3f19888b865b1d 930976 interpreters optional love_0.8.0-2_i386.deb
 8f1318652a8652285188218bae93c3f4 3624562 debug extra love-dbg_0.8.0-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlB7vZMACgkQFShl+2J8z5XGdgCfZUYX9ThOoUB4/DAFw9UyrFbl
KA4An2kyJpyVX8lhpmHhjDcoV/cTUbSn
=DyUm
-----END PGP SIGNATURE-----

[Message part 1 (text/plain, inline)]
Hi again,

I solved this bug by using the already present code to replace GLee with
the system version. For this package, that means the problem is solved
(the package got accepted), but you may want to be less strict with
autorejections in cases like this one.

Thanks,
Bas

On Mon, Oct 15, 2012 at 08:41:48AM +0200, Bas Wijnen wrote:
> On Sun, Oct 14, 2012 at 11:05:28PM +0200, Ansgar Burchardt wrote:
> > > Update: this bug was already worked around in the Debian package: the
> > > files included by upstream are not used, and the debian library package
> > > is used instead. The embeded copy is in the upstream source, and that is
> > > an upstream bug (which should trigger the lintian warning).
> > 
> > Are you sure the Debian package does not use the embedded copy? The
> > lintian error seems to be triggered by the binary package (as it
> > includes the path).
> 
> I was pretty sure, but you seem to be right. Ah, now I see: here's the
> entry from the changelog:
> * Tried to removed internal glee, but it doesn't seem to like the
> system's one
> 
> So it wasn't used, indeed.
> 
> Thanks for the clarification,
> Bas

> _______________________________________________
> Pkg-games-devel mailing list
> Pkg-games-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-games-devel

[signature.asc (application/pgp-signature, inline)]
Bas,

On Tue, Oct 16, 2012 at 09:52:52AM +0200, Bas Wijnen wrote:
> I solved this bug by using the already present code to replace GLee with
> the system version. For this package, that means the problem is solved
> (the package got accepted), but you may want to be less strict with
> autorejections in cases like this one.

As you can see on http://ftp-master.debian.org/static/lintian.tags,
embedded-library is a non-fatal tag, so you can get the package uploaded if
you add a lintian override.

Cheers,

Ivo

[Message part 1 (text/plain, inline)]
retitle 690877 unblock: love/0.8.0-1+deb7u1 TPU pre-approval
tags 690877 - moreinfo
thanks

Hi,

On Sun, Nov 11, 2012 at 07:11:10PM +0100, Bas Wijnen wrote:
> On 11-11-12 18:40, Julien Cristau wrote:
> >> The new package fixes several RC and RG bugs. Compared to the previous unblock
> >> request, this one also fixes the build depends (which is another RC bug).
> >>
> > How do I know using the system glee doesn't regress anything here?  Is
> > it the exact same version, with no local changes in love's copy?
> > Doesn't look like a change to make during a freeze...
> 
> Hmm, good point, I hadn't thought of that. (I just fixed it to get the
> hardening flags patch in; the package was auto-rejected so I fixed the
> reason for that without thinking about freeze effects.) It is not the
> same version, and it probably shouldn't migrate. However, this leaves
> the hardening issue (#690494) unfixed, but I suppose that is acceptable
> in this stage of the freeze.

I prepared a TPU upload to fix the copyright file bug (#690394) in wheezy. The
debdiff is attached.

I also included a lintian override for the ftp-master autoreject (bug
#690492). I don't know if this is needed for TPU uploads. As Julien downgraded
bug #690492 from serious to important, I suspect the embedded copy of glee can
stay for wheezy.

Cheers,

Ivo

[love_0.8.0-1+deb7u1.debdiff (text/plain, attachment)]
[Message part 1 (text/plain, inline)]
On 23-12-12 00:37, Ivo De Decker wrote:
> I prepared a TPU upload to fix the copyright file bug (#690394) in wheezy. The
> debdiff is attached.

Looks good. However, version 0.8.0-3 is already in unstable, so please
make the version 0.8.0-2.1 instead.

Will you upload the package?

> I also included a lintian override for the ftp-master autoreject (bug
> #690492). I don't know if this is needed for TPU uploads. As Julien downgraded
> bug #690492 from serious to important, I suspect the embedded copy of glee can
> stay for wheezy.

In don't usually like lintian overrides, but I suppose this is a good
use for one. Still I'd prefer the error to be visible, and override the
autoreject instead of lintian itself...

Thanks,
Bas

[signature.asc (application/pgp-signature, attachment)]
Hi Bas,

On Sun, Dec 23, 2012 at 11:45:43PM +0100, Bas Wijnen wrote:
> On 23-12-12 00:37, Ivo De Decker wrote:
> > I prepared a TPU upload to fix the copyright file bug (#690394) in wheezy. The
> > debdiff is attached.
> 
> Looks good.

Thanks for the review.

> However, version 0.8.0-3 is already in unstable, so please
> make the version 0.8.0-2.1 instead.

That's fine with me, but I guess the release team prefers +deb7u1 for wheezy.

> Will you upload the package?

That's OK, but as it is a TPU upload, we first need pre-approval from the
release team.

> > I also included a lintian override for the ftp-master autoreject (bug
> > #690492). I don't know if this is needed for TPU uploads. As Julien downgraded
> > bug #690492 from serious to important, I suspect the embedded copy of glee can
> > stay for wheezy.
> 
> In don't usually like lintian overrides, but I suppose this is a good
> use for one. Still I'd prefer the error to be visible, and override the
> autoreject instead of lintian itself...

Well, I'm just using the procedure I know. I don't think there is a way to
override the autoreject without overriding the lintian error (other than
asking for a manual override after the upload).

Anyway, this problem will go away after wheezy, as you uploaded the fix to
unstable for jessie.

Cheers,

Ivo

[Message part 1 (text/plain, inline)]
On Mon, Dec 24, 2012 at 04:08:29PM +0100, Ivo De Decker wrote:
> > On 23-12-12 00:37, Ivo De Decker wrote:
> > > I prepared a TPU upload to fix the copyright file bug (#690394) in wheezy. The
> > > debdiff is attached.
> > 
> > Looks good.
> Thanks for the review.
> 
> > However, version 0.8.0-3 is already in unstable, so please
> > make the version 0.8.0-2.1 instead.
> 
> That's fine with me, but I guess the release team prefers +deb7u1 for wheezy.

Your changelog claims to be an NMU, so the correct version would be
0.8.0-2.1. I'm not all that fussed though.

> > Will you upload the package?
> 
> That's OK, but as it is a TPU upload, we first need pre-approval from the
> release team.

You can upload this fix to tpu.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

<directhex> i have six years of solaris sysadmin experience, from
            8->10. i am well qualified to say it is made from bonghits
			layered on top of bonghits

[signature.asc (application/pgp-signature, inline)]
Hi again, Jonathan,

On Sun, Jan 27, 2013 at 04:12:48PM +0000, Jonathan Wiltshire wrote:
> > > However, version 0.8.0-3 is already in unstable, so please
> > > make the version 0.8.0-2.1 instead.
> > 
> > That's fine with me, but I guess the release team prefers +deb7u1 for wheezy.
> 
> Your changelog claims to be an NMU, so the correct version would be
> 0.8.0-2.1. I'm not all that fussed though.

Well, I've had the reverse request for other TPU uploads, so I didn't change
this one. I don't really care what the version numbers should be, but it would
be nice if there was some unambiguous documentation somewhere. There is
#685646 and #542288, so hopefully this will happen soon.

> > > Will you upload the package?
> > 
> > That's OK, but as it is a TPU upload, we first need pre-approval from the
> > release team.
> 
> You can upload this fix to tpu.

The package was just uploaded to TPU (thanks to Anton Gladky for the sponsored
upload).

Cheers,

Ivo

[Message part 1 (text/plain, inline)]
On Sun, Jan 27, 2013 at 16:12:48 +0000, Jonathan Wiltshire wrote:

> You can upload this fix to tpu.
> 
Approved.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Debian Bug report logs - #690492 love: uses embedded copy of GLee

Debian Bug report logs - #690492
love: uses embedded copy of GLee