Debian Bug report logs - #690281
unblock: file-mmagic/1.29-1

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: NOKUBI Takatsugu <knok@daionet.gr.jp>

Date: Fri, 12 Oct 2012 01:09:01 UTC

Severity: wishlist

Tags: moreinfo

Done: "Adam D. Barratt" <adam@adam-barratt.org.uk>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Fri, 12 Oct 2012 01:09:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to NOKUBI Takatsugu <knok@knok.daionet.gr.jp>:
New Bug report received and forwarded. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Fri, 12 Oct 2012 01:09:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: NOKUBI Takatsugu <knok@knok.daionet.gr.jp>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: file-mmagic/1.29-1
Date: Fri, 12 Oct 2012 09:52:28 +0900
Package: release.debian.org
Severity: wishlist
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package file-mmagic

Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
The follwing is diff (really small changes):
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279

unblock file-mmagic/1.29-1

-- System Information:
Debian Release: 6.0.6
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-bpo.2-686-bigmem (SMP w/4 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Sat, 13 Oct 2012 15:09:08 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 13 Oct 2012 15:09:08 GMT) Full text and rfc822 format available.

Message #10 received at 690281@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: NOKUBI Takatsugu <knok@knok.daionet.gr.jp>, <690281@bugs.debian.org>
Subject: Re: Bug#690281: unblock: file-mmagic/1.29-1
Date: Sat, 13 Oct 2012 16:06:42 +0100
Control: tags -1 + moreinfo

On 12.10.2012 01:52, NOKUBI Takatsugu wrote:
> Please unblock package file-mmagic
>
> Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
> The follwing is diff (really small changes):
> http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279

The upstream diff for that particular fix might be really small and 
targeted. What you're asking us to unblock is quite a bit more than 
that.

Aside from the upstream changes including more changes, to do with 
"content hooks" and some others, the packaging also includes a change to 
short-form dh and source format 3.0 (quilt); neither of those are 
appropriate things to be doing during a freeze (at least for packages 
you expect to transition).

Regards,

Adam





Added tag(s) moreinfo. Request was from "Adam D. Barratt" <adam@adam-barratt.org.uk> to 690281-submit@bugs.debian.org. (Sat, 13 Oct 2012 15:09:08 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Sat, 13 Oct 2012 15:57:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 13 Oct 2012 15:57:05 GMT) Full text and rfc822 format available.

Message #17 received at 690281@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: <690281@bugs.debian.org>
Subject: Re: Bug#690281: unblock: file-mmagic/1.29-1
Date: Sat, 13 Oct 2012 16:53:19 +0100
On 13.10.2012 16:06, Adam D. Barratt wrote:
> Control: tags -1 + moreinfo

ftr, the submitter's email bounces:

 knok@knok.daionet.gr.jp
    SMTP error from remote mail server after RCPT 
TO:<knok@knok.daionet.gr.jp>:
    host daio.daionet.gr.jp [61.194.16.210]: 554 5.7.1 
<knok@knok.daionet.gr.jp>:
    Relay access denied

Regards,

Adam



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Sat, 10 Nov 2012 14:15:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to intrigeri <intrigeri@boum.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 10 Nov 2012 14:15:03 GMT) Full text and rfc822 format available.

Message #22 received at 690281@bugs.debian.org (full text, mbox):

From: intrigeri <intrigeri@boum.org>
To: 690281@bugs.debian.org, NOKUBI Takatsugu <knok@knok.daionet.gr.jp>
Cc: debian-perl@lists.debian.org
Subject: Re: Bug#690281: unblock: file-mmagic/1.29-1
Date: Sat, 10 Nov 2012 15:12:56 +0100
Hi,

Adam D. Barratt wrote (13 Oct 2012 15:06:42 GMT) :
>> Old file-mmagic uses deprecated perl syntax, so I want to unblock it.
>> The follwing is diff (really small changes):
>> http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=286&r2=279

(That's the diff from "somewhere in between 1.27 and 1.28" to 1.29...)

> The upstream diff for that particular fix might be really small
> and targeted.

It is. The revision that fixes this specific bug is 281:
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
It is really tiny and looks correct to me.
It might be a fine candidate for 1.27-2 and tpu
if someone cares enough.

The upstream ticket corresponding to this issue is
https://rt.cpan.org/Public/Bug/Display.html?id=74252

It seems to me the actual issue that patch fixes only may impact the
test suite of other modules that check for unexpected warnings. AFAIK,
Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
Debian, so I would say it's low priority. Fellow debian-perl members,
did you see any?

Another bugfix that might be useful to include in Wheezy is r279
(memory leak fix):
http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279

Cheers,
--
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Sat, 10 Nov 2012 15:03:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to gregor herrmann <gregoa@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 10 Nov 2012 15:03:06 GMT) Full text and rfc822 format available.

Message #27 received at 690281@bugs.debian.org (full text, mbox):

From: gregor herrmann <gregoa@debian.org>
To: intrigeri <intrigeri@boum.org>
Cc: 690281@bugs.debian.org, NOKUBI Takatsugu <knok@knok.daionet.gr.jp>, debian-perl@lists.debian.org
Subject: Re: Bug#690281: unblock: file-mmagic/1.29-1
Date: Sat, 10 Nov 2012 16:01:55 +0100
[Message part 1 (text/plain, inline)]
On Sat, 10 Nov 2012 15:12:56 +0100, intrigeri wrote:

> The upstream ticket corresponding to this issue is
> https://rt.cpan.org/Public/Bug/Display.html?id=74252
> 
> It seems to me the actual issue that patch fixes only may impact the
> test suite of other modules that check for unexpected warnings. AFAIK,
> Lucas' archive rebuilds did not detect any FTBFS caused by this bug in
> Debian, so I would say it's low priority. Fellow debian-perl members,
> did you see any?

I don't remember any problems either.

The CPAN ticket mentions as broken modules:
- CPAN::Digger: not in Debian
- Module::CPANTS::Analyse: here we repackage the dist and don't run
  all tests, and it still builds
 

Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Rebekka Bakken: As Tears Clear Our Eyes
[signature.asc (application/pgp-signature, inline)]

Changed Bug submitter to 'NOKUBI Takatsugu <knok@daionet.gr.jp>' from 'NOKUBI Takatsugu <knok@knok.daionet.gr.jp>' Request was from NOKUBI Takatsugu <knok@daionet.gr.jp> to control@bugs.debian.org. (Sat, 24 Nov 2012 03:21:03 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Sat, 24 Nov 2012 10:45:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 24 Nov 2012 10:45:05 GMT) Full text and rfc822 format available.

Message #34 received at 690281@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: NOKUBI Takatsugu <knok@daionet.gr.jp>
Cc: 690281@bugs.debian.org
Subject: Re: file-mmagic 1.27-2 for testing
Date: Sat, 24 Nov 2012 10:41:05 +0000
On Sat, 2012-11-24 at 12:42 +0900, NOKUBI Takatsugu wrote:
> I build file-mmagic package for testing.
> Can I upload it?

Once we've seen a debdiff, maybe. :-)

> >From changelog:
> file-mmagic (1.27-2) testing-proposed-updates; urgency=low

1.27-1+deb7u1 would be more conventional.

>   * Unblock #690281

That doesn't need to go in the changelog. However, given that the bug
exists, why didn't you just send the mail there? (CC added)

>   * Fix deprecated array existing check.
>      http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
>   * Fix memory leak.
>      http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279

Regards,

Adam




Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Wed, 28 Nov 2012 06:42:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to NOKUBI Takatsugu <knok@daionet.gr.jp>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Wed, 28 Nov 2012 06:42:03 GMT) Full text and rfc822 format available.

Message #39 received at 690281@bugs.debian.org (full text, mbox):

From: NOKUBI Takatsugu <knok@daionet.gr.jp>
To: "Adam D. Barratt" <adam@adam-barratt.org.uk>
Cc: NOKUBI Takatsugu <knok@daionet.gr.jp>, 690281@bugs.debian.org
Subject: Re: file-mmagic 1.27-2 for testing
Date: Wed, 28 Nov 2012 15:31:46 +0900
Thank you guys for your comments.

The following is debdiff:

diff -u file-mmagic-1.27/debian/changelog file-mmagic-1.27/debian/changelog
--- file-mmagic-1.27/debian/changelog
+++ file-mmagic-1.27/debian/changelog
@@ -1,8 +1,17 @@
+file-mmagic (1.27-1+deb7u1) testing-proposed-updates; urgency=low
+
+  * Fix deprecated array existing check.
+     http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=279&r2=281
+  * Fix memory leak.
+     http://cvs.namazu.org/Subversion/MMagic/trunk/MMagic.pm?r1=278&r2=279
+
+ -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Wed, 28 Nov 2012 14:37:05 +0900
+
 file-mmagic (1.27-1) unstable; urgency=low
 
   * New upstream release
 
- -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Wed,  1 Nov 2006 15:28:57 +0900
+ -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Mon, 26 Nov 2012 16:58:33 +0900
 
 file-mmagic (1.26-1) unstable; urgency=low
 
only in patch2:
unchanged:
--- file-mmagic-1.27.orig/MMagic.pm
+++ file-mmagic-1.27/MMagic.pm
@@ -302,6 +302,7 @@
 
 use FileHandle;
 use strict;
+use Scalar::Util;
 
 use vars qw(
 %TEMPLATES %ESC $VERSION
@@ -715,6 +716,7 @@
 
     $fname =~ s/^.*\///;
     for my $regex (keys %{$self->{FILEEXTS}}) {
+	Scalar::Util::weaken($self->{FILEEXTS});
 	if ($fname =~ /$regex/i) {
 	    if ((defined $type && $type !~ /;/) || (! defined $type)) {
 		$type = $self->{FILEEXTS}->{$regex}; # has no x-type param
@@ -1119,7 +1121,7 @@
 	    $$MF[1] = $line;
 	    return length($thisDepth);
 	}
-	elsif (defined(@$entry)) {
+	elsif ('ARRAY' eq ref $entry && @$entry) {
 	    # already have an entry.  this is not a continuation.
 	    # save this line for the next call and exit.
 	    $$MF[1] = $line;



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#690281; Package release.debian.org. (Wed, 28 Nov 2012 07:48:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Wed, 28 Nov 2012 07:48:03 GMT) Full text and rfc822 format available.

Message #44 received at 690281@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: NOKUBI Takatsugu <knok@daionet.gr.jp>, 690281@bugs.debian.org
Subject: Re: Bug#690281: file-mmagic 1.27-2 for testing
Date: Wed, 28 Nov 2012 07:43:41 +0000
On Wed, 2012-11-28 at 15:31 +0900, NOKUBI Takatsugu wrote:
> diff -u file-mmagic-1.27/debian/changelog file-mmagic-1.27/debian/changelog
> --- file-mmagic-1.27/debian/changelog
> +++ file-mmagic-1.27/debian/changelog
[...]
>  file-mmagic (1.27-1) unstable; urgency=low
>  
>    * New upstream release
>  
> - -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Wed,  1 Nov 2006 15:28:57 +0900
> + -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Mon, 26 Nov 2012 16:58:33 +0900

The date change there looks a little odd... Other than that it looks
fine; thanks.

Regards,

Adam




Reply sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
You have taken responsibility. (Thu, 29 Nov 2012 20:27:06 GMT) Full text and rfc822 format available.

Notification sent to NOKUBI Takatsugu <knok@daionet.gr.jp>:
Bug acknowledged by developer. (Thu, 29 Nov 2012 20:27:06 GMT) Full text and rfc822 format available.

Message #49 received at 690281-done@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: NOKUBI Takatsugu <knok@daionet.gr.jp>, 690281-done@bugs.debian.org
Subject: Re: Bug#690281: file-mmagic 1.27-2 for testing
Date: Thu, 29 Nov 2012 20:24:22 +0000
On Wed, 2012-11-28 at 07:43 +0000, Adam D. Barratt wrote:
> On Wed, 2012-11-28 at 15:31 +0900, NOKUBI Takatsugu wrote:
> > diff -u file-mmagic-1.27/debian/changelog file-mmagic-1.27/debian/changelog
> > --- file-mmagic-1.27/debian/changelog
> > +++ file-mmagic-1.27/debian/changelog
> [...]
> >  file-mmagic (1.27-1) unstable; urgency=low
> >  
> >    * New upstream release
> >  
> > - -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Wed,  1 Nov 2006 15:28:57 +0900
> > + -- NOKUBI Takatsugu <knok@daionet.gr.jp>  Mon, 26 Nov 2012 16:58:33 +0900
> 
> The date change there looks a little odd...

That was a hint to fix it. :-p

> Other than that it looks fine; thanks.

I can't be bothered to ask for another upload to fix the changelog, so
approve hint added; thanks.

Regards,

Adam




Message #50 received at 690281-done@bugs.debian.org (full text, mbox):

From: NOKUBI Takatsugu <knok@daionet.gr.jp>
To: "Adam D. Barratt" <adam@adam-barratt.org.uk>
Cc: NOKUBI Takatsugu <knok@daionet.gr.jp>, 690281-done@bugs.debian.org
Subject: Re: Bug#690281: file-mmagic 1.27-2 for testing
Date: Fri, 30 Nov 2012 08:14:39 +0900
At Thu, 29 Nov 2012 20:24:22 +0000,
Adam D. Barratt wrote:
> > The date change there looks a little odd...
> 
> That was a hint to fix it. :-p

I had compared with my local rebuild package, so such difference was
appeared. I believe the autual package is correct. But it was my
skimp.

Anything else thank you.




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 28 Dec 2012 07:27:48 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Apr 18 08:45:17 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.