Debian Bug report logs - #688319
devscripts: Please consider including the 'yodack' tool

version graph

Package: devscripts; Maintainer for devscripts is Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>; Source for devscripts is src:devscripts.

Reported by: Gergely Nagy <algernon@madhouse-project.org>

Date: Fri, 21 Sep 2012 14:39:01 UTC

Severity: wishlist

Found in version devscripts/2.12.3

Done: Gergely Nagy <algernon@balabit.hu>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Fri, 21 Sep 2012 14:39:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@madhouse-project.org>:
New Bug report received and forwarded. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Fri, 21 Sep 2012 14:39:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@madhouse-project.org>
To: submit@bugs.debian.org
Subject: devscripts: Please consider including the 'yodack' tool
Date: Fri, 21 Sep 2012 16:28:27 +0200
Package: devscripts
Version: 2.12.3
Severity: wishlist

As of a few days ago, it is possible to upload signed command files to
ftp-master, granting/revoking DM upload permissions, as originally
explained by Ansgar Burchardt on -project@ in June:
 https://lists.debian.org/debian-devel/2012/06/msg00321.html

In an attempt to make constructing and uploading such files easier, I
wrote a little tool called "Ye Olde Debian Archive Control Kit"
(yodack)[1]. It's a simple shell script with a conffile, a separate
package for it is overkill, therefore I'd like to ask for its inclusion
into devscripts.

If the tool is deemed worthy for devscripts, I'll happily prepare a
patch against devscripts git that does the necessary things to pull
yodack in.

As an example of what the tool can do, the following line does just what
it reads:

$ yodack on ftp-master.debian.org, \
         for debian maintainer algernon@madhouse-project.org, \
         please grant upload rights on dh-exec, ivykis, \
         but deny uploads of eglibc, bash.

Thanks for considering!

 [1]: http://anonscm.debian.org/gitweb/?p=users/algernon/yodack.git;a=summary

-- 
|8]



Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Fri, 28 Sep 2012 13:09:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@balabit.hu>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Fri, 28 Sep 2012 13:09:03 GMT) Full text and rfc822 format available.

Message #10 received at 688319@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: 688319@bugs.debian.org
Subject: Re: devscripts: Please consider including the 'yodack' tool
Date: Fri, 28 Sep 2012 15:07:47 +0200
FWIW, since the example given in the bug report is fairly verbose, and
that tends to put off some people, I'd like to mention that yodack does
not need the verboseness, that is merely an option.

The following command does exactly the same thing that the example I
originally posted:

$ yodack ftp-master dm algernon@madhouse-project.org \
         allow dh-exec ivykis deny eglibc bash

Let me know if there's anything I can do to help this script be
integrated into devscripts!

-- 
|8]




Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Thu, 04 Oct 2012 11:03:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Luca Capello <luca@pca.it>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Thu, 04 Oct 2012 11:03:05 GMT) Full text and rfc822 format available.

Message #15 received at 688319@bugs.debian.org (full text, mbox):

From: Luca Capello <luca@pca.it>
To: 688319@bugs.debian.org
Cc: Gergely Nagy <algernon@balabit.hu>, Alexander Golovko <alexandro@ankalagon.ru>
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Thu, 04 Oct 2012 12:56:30 +0200
[Message part 1 (text/plain, inline)]
usertags 688319 + debian-packaging
thanks

Hi there!

On Fri, 28 Sep 2012 15:07:47 +0200, Gergely Nagy wrote:
> FWIW, since the example given in the bug report is fairly verbose, and
> that tends to put off some people, I'd like to mention that yodack does
> not need the verboseness, that is merely an option.
>
> The following command does exactly the same thing that the example I
> originally posted:
>
> $ yodack ftp-master dm algernon@madhouse-project.org \
>          allow dh-exec ivykis deny eglibc bash

IMHO this relies too much on the debian-keyring package, which is not
always in sync with the real situation:
=====
$ who-uploads bacula
Uploads for bacula:
5.2.6+dfsg-5 to unstable: <unrecognised public key (31455D17)>
5.2.6+dfsg-4 to unstable: <unrecognised public key (31455D17)>
5.2.6+dfsg-3 to unstable: Luca Capello <gismo@debian.org>

$ gpg --no-default-keyring \
      --keyring /usr/share/keyrings/debian-maintainers.gpg \
      --list-key 31455D17
gpg: error reading key: public key not found

$ wget -O - http://ftp-master.debian.org/dm-uploaders.html | grep -A 3 31455D17
--2012-10-04 11:24:31--  http://ftp-master.debian.org/dm-uploaders.html
Resolving ftp-master.debian.org (ftp-master.debian.org)... 128.148.34.3
Connecting to ftp-master.debian.org (ftp-master.debian.org)|128.148.34.3|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 68299458 (65M) [text/html]
Saving to: ‘STDOUT’

 0% [                                                             ] 0           --.-K/s                  <td align="left">5E2A59462C7B2CD307FB8A5A949C322631455D17</td>
  </tr>
  <tr valign="top">
    <td align="left">alexandro@ankalagon.ru</td>
 7% [===>                                                         ] 5,179,371    814KB/s  eta 97s    ^C

$ git clone git://anonscm.debian.org/users/algernon/yodack.git
Cloning into 'yodack'...
remote: Counting objects: 92, done.
remote: Compressing objects: 100% (78/78), done.
remote: Total 92 (delta 39), reused 0 (delta 0)
Receiving objects: 100% (92/92), 42.93 KiB, done.
Resolving deltas: 100% (39/39), done.

$ cd yodack/
$ USER=gismo ./yodack ftp-master dm 31455D17 allow bacula
A known DM permissions to set, you must.

$ git diff
[attached below]
$ USER=gismo ./yodack ftp-master dm 31455D17 keyring ~/.gnupg/pubring.gpg allow bacula
[verification and GnuPG stuff]
Upload to 'ftp-master', how to I know not.
[no exit error code]

$ ln -s ~/src/Debian/yodack/yodack.conf ~/.yodack.conf
$ USER=gismo ./yodack ftp-master dm 31455D17 keyring ~/.gnupg/pubring.gpg allow bacula
[verification and GnuPG stuff]
Uploading gismo-1349344867.dak-commands to ftp-master.d.o...

$ 
=====

BTW, is there any reason not to use dput/dcut for upload, but instead a
custom curl command?

Thx, bye,
Gismo / Luca

[0001-yodack-add-keyring-option.patch (text/x-diff, attachment)]
[Message part 3 (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Thu, 04 Oct 2012 11:09:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@balabit.hu>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Thu, 04 Oct 2012 11:09:03 GMT) Full text and rfc822 format available.

Message #20 received at 688319@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: Luca Capello <luca@pca.it>
Cc: 688319@bugs.debian.org, Alexander Golovko <alexandro@ankalagon.ru>
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Thu, 04 Oct 2012 13:07:11 +0200
Luca Capello <luca@pca.it> writes:

> On Fri, 28 Sep 2012 15:07:47 +0200, Gergely Nagy wrote:
>> FWIW, since the example given in the bug report is fairly verbose, and
>> that tends to put off some people, I'd like to mention that yodack does
>> not need the verboseness, that is merely an option.
>>
>> The following command does exactly the same thing that the example I
>> originally posted:
>>
>> $ yodack ftp-master dm algernon@madhouse-project.org \
>>          allow dh-exec ivykis deny eglibc bash
>
> IMHO this relies too much on the debian-keyring package, which is not
> always in sync with the real situation:

Oh, right. I haven't thought of that. Thanks for the patch, I'll review
& apply in a bit!

[...]
> $ git diff
> [attached below]
> $ USER=gismo ./yodack ftp-master dm 31455D17 keyring ~/.gnupg/pubring.gpg allow bacula
> [verification and GnuPG stuff]
> Upload to 'ftp-master', how to I know not.
> [no exit error code]

Hrm, it should exit with a non-zero code there. I'll fix that too,
thanks for noticing it!

> BTW, is there any reason not to use dput/dcut for upload, but instead a
> custom curl command?

Because when the tool was originally written, neither dput nor dcut were
happy about .dak-command files for one, and because for uploading a
single file, they both seemed like overkill to begin with.

(In all honesty, a longer-term plan is to improve yodack to the point
where it can replace dcut alltogether.)

-- 
|8]




Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Thu, 04 Oct 2012 11:39:17 GMT) Full text and rfc822 format available.

Acknowledgement sent to Luca Capello <luca@pca.it>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Thu, 04 Oct 2012 11:39:17 GMT) Full text and rfc822 format available.

Message #25 received at 688319@bugs.debian.org (full text, mbox):

From: Luca Capello <luca@pca.it>
To: Gergely Nagy <algernon@balabit.hu>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Thu, 04 Oct 2012 13:23:40 +0200
[Message part 1 (text/plain, inline)]
Hi there!

On Thu, 04 Oct 2012 13:07:11 +0200, Gergely Nagy wrote:
> Luca Capello <luca@pca.it> writes:
>> BTW, is there any reason not to use dput/dcut for upload, but instead a
>> custom curl command?
>
> Because when the tool was originally written, neither dput nor dcut were
> happy about .dak-command files for one, and because for uploading a
> single file, they both seemed like overkill to begin with.
>
> (In all honesty, a longer-term plan is to improve yodack to the point
> where it can replace dcut alltogether.)

Well, dcut accepts .commands and works using the same configuration file
than dput, while yodack wants yet another configuration file.  Your
call, but this seems to me duplication for no real advantage.

Thx, bye,
Gismo / Luca
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Thu, 04 Oct 2012 11:42:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@balabit.hu>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Thu, 04 Oct 2012 11:42:03 GMT) Full text and rfc822 format available.

Message #30 received at 688319@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: Luca Capello <luca@pca.it>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Thu, 04 Oct 2012 13:39:42 +0200
Luca Capello <luca@pca.it> writes:

> Hi there!
>
> On Thu, 04 Oct 2012 13:07:11 +0200, Gergely Nagy wrote:
>> Luca Capello <luca@pca.it> writes:
>>> BTW, is there any reason not to use dput/dcut for upload, but instead a
>>> custom curl command?
>>
>> Because when the tool was originally written, neither dput nor dcut were
>> happy about .dak-command files for one, and because for uploading a
>> single file, they both seemed like overkill to begin with.
>>
>> (In all honesty, a longer-term plan is to improve yodack to the point
>> where it can replace dcut alltogether.)
>
> Well, dcut accepts .commands and works using the same configuration file
> than dput, while yodack wants yet another configuration file.  Your
> call, but this seems to me duplication for no real advantage.

It doesn't take much effort to support .commands files, and the same
config file. I just didn't get around to do it yet, and .dak-commands
was the priority. (Hence the longer-term plan being replacing dcut, not
an immediate one :)

-- 
|8]




Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Sat, 06 Oct 2012 16:12:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Benjamin Drung <bdrung@debian.org>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Sat, 06 Oct 2012 16:12:03 GMT) Full text and rfc822 format available.

Message #35 received at 688319@bugs.debian.org (full text, mbox):

From: Benjamin Drung <bdrung@debian.org>
To: Gergely Nagy <algernon@balabit.hu>, 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Sat, 06 Oct 2012 18:09:43 +0200
[Message part 1 (text/plain, inline)]
Am Freitag, den 28.09.2012, 15:07 +0200 schrieb Gergely Nagy:
> Let me know if there's anything I can do to help this script be
> integrated into devscripts!

This is just my opinion: I like to see shunit2 tests for yodack before
integrating it into devscripts. To make yodack testable, it should be
possible to output the command files instead of uploading them. Then you
can compare the command files with the expected content. You can also
test the return value of yodack and test the behavior for invalid input.

-- 
Benjamin Drung
Debian & Ubuntu Developer
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Sat, 06 Oct 2012 16:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@balabit.hu>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Sat, 06 Oct 2012 16:51:02 GMT) Full text and rfc822 format available.

Message #40 received at 688319@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: Benjamin Drung <bdrung@debian.org>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Sat, 06 Oct 2012 18:46:17 +0200
Benjamin Drung <bdrung@debian.org> writes:

> Am Freitag, den 28.09.2012, 15:07 +0200 schrieb Gergely Nagy:
>> Let me know if there's anything I can do to help this script be
>> integrated into devscripts!
>
> This is just my opinion: I like to see shunit2 tests for yodack before
> integrating it into devscripts. To make yodack testable, it should be
> possible to output the command files instead of uploading them. Then you
> can compare the command files with the expected content. You can also
> test the return value of yodack and test the behavior for invalid
> input.

Makes sense, I'll let you (via this bug) know when the tests are
done. Most of the stuff one would need for testing are already in
yodack, all I need is to write the tests themselves. I was already
pondering about it, but didn't know about shunit2 - so thanks for
pointing me to the right direction!

-- 
|8]




Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Sat, 06 Oct 2012 16:54:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Benjamin Drung <bdrung@debian.org>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Sat, 06 Oct 2012 16:54:06 GMT) Full text and rfc822 format available.

Message #45 received at 688319@bugs.debian.org (full text, mbox):

From: Benjamin Drung <bdrung@debian.org>
To: Gergely Nagy <algernon@balabit.hu>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Sat, 06 Oct 2012 18:51:15 +0200
[Message part 1 (text/plain, inline)]
Am Samstag, den 06.10.2012, 18:46 +0200 schrieb Gergely Nagy:
> Benjamin Drung <bdrung@debian.org> writes:
> 
> > Am Freitag, den 28.09.2012, 15:07 +0200 schrieb Gergely Nagy:
> >> Let me know if there's anything I can do to help this script be
> >> integrated into devscripts!
> >
> > This is just my opinion: I like to see shunit2 tests for yodack before
> > integrating it into devscripts. To make yodack testable, it should be
> > possible to output the command files instead of uploading them. Then you
> > can compare the command files with the expected content. You can also
> > test the return value of yodack and test the behavior for invalid
> > input.
> 
> Makes sense, I'll let you (via this bug) know when the tests are
> done. Most of the stuff one would need for testing are already in
> yodack, all I need is to write the tests themselves. I was already
> pondering about it, but didn't know about shunit2 - so thanks for
> pointing me to the right direction!

You're welcome. I didn't know about shunit2 until someone pointed me to
it after I wrote my own test suite for devscripts. :)

You might want to look at the test/test_* scripts use runCommand() from
test/shunit2-helper-functions.sh.

-- 
Benjamin Drung
Debian & Ubuntu Developer
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Sun, 07 Oct 2012 11:21:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gergely Nagy <algernon@balabit.hu>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Sun, 07 Oct 2012 11:21:05 GMT) Full text and rfc822 format available.

Message #50 received at 688319@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: Benjamin Drung <bdrung@debian.org>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Sun, 07 Oct 2012 13:19:48 +0200
Benjamin Drung <bdrung@debian.org> writes:

> Am Freitag, den 28.09.2012, 15:07 +0200 schrieb Gergely Nagy:
>> Let me know if there's anything I can do to help this script be
>> integrated into devscripts!
>
> This is just my opinion: I like to see shunit2 tests for yodack before
> integrating it into devscripts. To make yodack testable, it should be
> possible to output the command files instead of uploading them. Then you
> can compare the command files with the expected content. You can also
> test the return value of yodack and test the behavior for invalid input.

There's a reasonably complete test suite in yodack's git now. It does
not test the verification dialog yet, I have to think of a sane way to
do that, but pretty much everything else should be covered, I think.

-- 
|8]




Information forwarded to debian-bugs-dist@lists.debian.org, Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>:
Bug#688319; Package devscripts. (Thu, 11 Oct 2012 21:15:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Benjamin Drung <bdrung@debian.org>:
Extra info received and forwarded to list. Copy sent to Devscripts Devel Team <devscripts-devel@lists.alioth.debian.org>. (Thu, 11 Oct 2012 21:15:06 GMT) Full text and rfc822 format available.

Message #55 received at 688319@bugs.debian.org (full text, mbox):

From: Benjamin Drung <bdrung@debian.org>
To: Gergely Nagy <algernon@balabit.hu>
Cc: 688319@bugs.debian.org
Subject: Re: Bug#688319: devscripts: Please consider including the 'yodack' tool
Date: Thu, 11 Oct 2012 23:11:34 +0200
[Message part 1 (text/plain, inline)]
Am Sonntag, den 07.10.2012, 13:19 +0200 schrieb Gergely Nagy:
> Benjamin Drung <bdrung@debian.org> writes:
> 
> > Am Freitag, den 28.09.2012, 15:07 +0200 schrieb Gergely Nagy:
> >> Let me know if there's anything I can do to help this script be
> >> integrated into devscripts!
> >
> > This is just my opinion: I like to see shunit2 tests for yodack before
> > integrating it into devscripts. To make yodack testable, it should be
> > possible to output the command files instead of uploading them. Then you
> > can compare the command files with the expected content. You can also
> > test the return value of yodack and test the behavior for invalid input.
> 
> There's a reasonably complete test suite in yodack's git now. It does
> not test the verification dialog yet, I have to think of a sane way to
> do that, but pretty much everything else should be covered, I think.

Thanks. I think it's time to move the script to devscripts. Can you
create a git formatted patch against our jessie branch that adds the
script to our package? The source package layout of your yodack branch
is a little different than the current devscripts layout.

-- 
Benjamin Drung
Debian & Ubuntu Developer
[signature.asc (application/pgp-signature, inline)]

Reply sent to Gergely Nagy <algernon@balabit.hu>:
You have taken responsibility. (Sun, 14 Oct 2012 17:33:04 GMT) Full text and rfc822 format available.

Notification sent to Gergely Nagy <algernon@madhouse-project.org>:
Bug acknowledged by developer. (Sun, 14 Oct 2012 17:33:04 GMT) Full text and rfc822 format available.

Message #60 received at 688319-done@bugs.debian.org (full text, mbox):

From: Gergely Nagy <algernon@balabit.hu>
To: 688319-done@bugs.debian.org
Subject: Re: devscripts: Please consider including the 'yodack' tool
Date: Sun, 14 Oct 2012 19:31:32 +0200
Turns out that there's another tool in the works, with similar
intentions to yodack: replacing dcut & dput aswell as providing an
interface to generating .dak-commands.

Difference is, dputng is closer to that goal than yodack, and will be a
separate package.

I don't see the point in having two tools that do essentially the same
thing, and since yodack's the inferior one, lets not split effort: I'm
closing this wishlist.

-- 
|8]




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 12 Nov 2012 07:25:55 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 09:16:40 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.