Debian Bug report logs - #687616
unblock php-apc/3.1.13-1

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lior Kaplan <kaplan@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: unblock php-apc/3.1.13-1

Date: Fri, 14 Sep 2012 12:52:55 +0300

[Message part 1 (text/plain, inline)]

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package php-apc

The current verson of php-apc in testing (3.1.10-1) was a major release
(although that doesn't appear in the version itself) to support PHP 5.4.
This current version in unstable (3.1.13-1) is a minor release for bug
fixes, which I think we'll benefit from in the long run for Debian stable.

I've waited with this request until some reported bugs in Debian were fixed
upstream (e.g. #685893), and now I think the package status is OK for
migration to testing.

See changelog at http://pecl.php.net/package-changelog.php?package=APC

Thanks.

unblock php-apc/3.1.13-1

[Message part 2 (text/html, inline)]

Message #10 received at 687616@bugs.debian.org (full text, mbox, reply):

From: Mehdi Dogguy <mehdi@dogguy.org>

To: Lior Kaplan <kaplan@debian.org>, 687616@bugs.debian.org

Subject: Re: Bug#687616: unblock php-apc/3.1.13-1

Date: Sun, 07 Oct 2012 15:34:58 +0200

On 14/09/2012 11:52, Lior Kaplan wrote:
> Package: release.debian.org <http://release.debian.org/>
> Severity: normal
> User: release.debian.org@packages.debian.org
> <mailto:release.debian.org@packages.debian.org>
> Usertags: unblock
> 
> Please unblock package php-apc
> 
> The current verson of php-apc in testing (3.1.10-1) was a major release
> (although that doesn't appear in the version itself) to support PHP 5.4.
> This current version in unstable (3.1.13-1) is a minor release for bug
> fixes, which I think we'll benefit from in the long run for Debian stable.
> 

I couldn't judge by looking at the diff because the top-directory in the
sources is versioned :/ Could you please provide a sensible diff between
the two version (patches applied)?

Regards,

-- 
Mehdi Dogguy مهدي الدڤي

Message #15 received at 687616@bugs.debian.org (full text, mbox, reply):

From: Lior Kaplan <kaplan@debian.org>

To: Mehdi Dogguy <mehdi@dogguy.org>

Cc: 687616@bugs.debian.org

Subject: Re: Bug#687616: unblock php-apc/3.1.13-1

Date: Sun, 7 Oct 2012 16:25:36 +0200

[Message part 1 (text/plain, inline)]

On Sun, Oct 7, 2012 at 3:34 PM, Mehdi Dogguy <mehdi@dogguy.org> wrote:

> I couldn't judge by looking at the diff because the top-directory in the
> sources is versioned :/ Could you please provide a sensible diff between
> the two version (patches applied)?
>

I haven't applied any patches of my own, just took upstream maintenance
releases.

Regarding the Debian package, only the changelog was chnaged:

$ debdiff php-apc_3.1.10-1.dsc php-apc_3.1.13-1.dsc | grep +++ | grep debian
+++ php-apc-3.1.13/debian/changelog    2012-09-04 20:01:26.000000000 +0300

Regarding upstream, see the attached diff between 3.1.10 to 3.1.13.

Kaplan

[Message part 2 (text/html, inline)]

[apc_3.1.10_to_3.1.13.diff.gz (application/x-gzip, attachment)]

Message #20 received at 687616@bugs.debian.org (full text, mbox, reply):

From: Mehdi Dogguy <mehdi@dogguy.org>

To: Lior Kaplan <kaplan@debian.org>, 687616@bugs.debian.org

Subject: Re: Bug#687616: unblock php-apc/3.1.13-1

Date: Sun, 07 Oct 2012 17:44:23 +0200

On 07/10/2012 16:25, Lior Kaplan wrote:
> On Sun, Oct 7, 2012 at 3:34 PM, Mehdi Dogguy <mehdi@dogguy.org 
> <mailto:mehdi@dogguy.org>> wrote:
> 
> I couldn't judge by looking at the diff because the top-directory in 
> the sources is versioned :/ Could you please provide a sensible diff 
> between the two version (patches applied)?
> 
> 
> I haven't applied any patches of my own, just took upstream 
> maintenance releases.
> 
> Regarding the Debian package, only the changelog was chnaged:
> 
> $ debdiff php-apc_3.1.10-1.dsc php-apc_3.1.13-1.dsc | grep +++ |
> grep debian +++ php-apc-3.1.13/debian/changelog    2012-09-04 
> 20:01:26.000000000 +0300
> 
> Regarding upstream, see the attached diff between 3.1.10 to 3.1.13.
> 

Thanks.

Looking at the provided diff, I've found for example:

+#ifdef ZEND_ENGINE_2_4
+    case IS_CALLABLE:
+        /* XXX implement this */
+        assert(0);
+        break;
+#endif

I'd rather avoid it.

Moreover, most changes are put under an "#ifdef ZEND_ENGINE_2_4" while
php5-dev (afaics) defines ZEND_ENGINE_2. So, as far as I can tell, this
release won't add much for Debian. (Please tell me if I got something
wrong). Based on that, I'd prefer to keep current wheezy's version
unchanged.

Instead of accepting php-apc/3.1.13-1, did you want to include targeted
fixes in Wheezy? If not, I think I'd close this bugreport.

Regards and thanks for your work!

-- 
Mehdi Dogguy مهدي الدڤي

Message #25 received at 687616@bugs.debian.org (full text, mbox, reply):

From: Lior Kaplan <kaplan@debian.org>

To: Mehdi Dogguy <mehdi@dogguy.org>

Cc: 687616@bugs.debian.org

Subject: Re: Bug#687616: unblock php-apc/3.1.13-1

Date: Sun, 7 Oct 2012 21:02:58 +0200

[Message part 1 (text/plain, inline)]

On Sun, Oct 7, 2012 at 5:44 PM, Mehdi Dogguy <mehdi@dogguy.org> wrote:

> Looking at the provided diff, I've found for example:
>
> +#ifdef ZEND_ENGINE_2_4
> +    case IS_CALLABLE:
> +        /* XXX implement this */
> +        assert(0);
> +        break;
> +#endif
>
> I'd rather avoid it.
>

I'm not a C programmer so I can't comment on that otherwise than this is
also the default for the switch (looks a few line bellow that section in
apc_compile.c).

    default:
        assert(0);

So basically this only adds support for a new object type changed in PHP
5.4 (due to changes in Closures and addition of Traits, AFAIK).


> Moreover, most changes are put under an "#ifdef ZEND_ENGINE_2_4" while
> php5-dev (afaics) defines ZEND_ENGINE_2. So, as far as I can tell, this
> release won't add much for Debian. (Please tell me if I got something
> wrong). Based on that, I'd prefer to keep current wheezy's version
> unchanged.
>

Indeed PHP only defines ZEND_ENGINE_2, but apc defines ZEND_ENGINE_2_4 for
anything which is PHP 5.4 by checking for ZEND_MODULE_API_NO (at apc_php.h):

#if ZEND_MODULE_API_NO >= 20100409
#define ZEND_ENGINE_2_4
#endif
#if ZEND_MODULE_API_NO > 20060613
#define ZEND_ENGINE_2_3
#endif

PHP 5.3 has 20090626, PHP 5.4 has 20100525

PHP 5.3:
http://git.php.net/?p=php-src.git;a=commitdiff;h=4b4283bdc0c578971f863a2a53b8a95c59cfc2d0

Two changes for 5.4
http://git.php.net/?p=php-src.git;a=commitdiff;h=7f18561bdce9ca7228c2ca7104b30371ca1575f5
http://git.php.net/?p=php-src.git;a=commitdiff;h=f7ce69585c0809a40ff79ebc2d429720aadd4534

Instead of accepting php-apc/3.1.13-1, did you want to include targeted
> fixes in Wheezy? If not, I think I'd close this bugreport.
>

Nope, I want to include 3.1.13, as it offers better PHP 5.4 support. I
don't want people to encounter all the memory leaks and crashes fixed since
the initial PHP 5.4 support for APC ( = version 3.1.10). See
http://pecl.php.net/package-changelog.php?package=APC

Regards and thanks for your work!


Gladly, thanks for reviewing this seriously.

Kaplan

[Message part 2 (text/html, inline)]

Message #30 received at 687616-done@bugs.debian.org (full text, mbox, reply):

From: Mehdi Dogguy <mehdi@dogguy.org>

To: Lior Kaplan <kaplan@debian.org>, 687616-done@bugs.debian.org

Subject: Re: Bug#687616: unblock php-apc/3.1.13-1

Date: Sun, 07 Oct 2012 23:04:28 +0200

On 07/10/2012 21:02, Lior Kaplan wrote:
> Indeed PHP only defines ZEND_ENGINE_2, but apc defines ZEND_ENGINE_2_4
> for anything which is PHP 5.4 by checking for ZEND_MODULE_API_NO (at
> apc_php.h).

Right. I knew I got something wrong. Thanks for spotting it.

Ok, based on the different fixes present in the diff, I've unblocked the
package.

Kind Regards,

-- 
Mehdi Dogguy مهدي الدڤي

Send a report that this bug log contains spam.