Debian Bug report logs - #686731
edos-builddebcheck: Stopped working

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@deb-multimedia.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: edos-distcheck: Syopped to work

Date: Wed, 05 Sep 2012 07:56:12 +0200

Package: edos-distcheck
Version: 1.4.2-13+b1
Severity: serious

Dear Maintainer,

As today edos-builddebcheck doesn't work at all with the following error :



$ edos-builddebcheck /debian/data/unstable/Packages_i386 /debian/dists/unstable/main/source/Sources
Merging...
File "/usr/share/edos-distcheck/add-sources.py", line 144, in <module>
    pkg = pkg_of_src(src)
  File "/usr/share/edos-distcheck/add-sources.py", line 124, in pkg_of_src
    if src.has_key(field):
AttributeError: 'Sources' object has no attribute 'has_key'
Completing conflicts...                                            * 100.0%
Merging...                                                          0 Fatal error: exception Failure("Warning: package ignored because it has no name")



Christian

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.5.2 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages edos-distcheck depends on:
ii  libbz2-1.0     1.0.6-4
ii  libc6          2.13-35
ii  libgdbm3       1.8.3-11
ii  libpcre3       1:8.30-5
ii  libpopt0       1.16-7
ii  librpm3        4.10.0-5
ii  librpmio3      4.10.0-5
ii  perl           5.14.2-12
ii  python         2.7.3-2
ii  python-debian  0.1.21+nmu1
ii  zlib1g         1:1.2.7.dfsg-13

edos-distcheck recommends no packages.

edos-distcheck suggests no packages.

-- no debconf information

Message #12 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Mehdi Dogguy <mehdi@dogguy.org>

To: Christian Marillat <marillat@deb-multimedia.org>, 686731@bugs.debian.org

Subject: Re: Bug#686731: edos-distcheck: Syopped to work

Date: Wed, 05 Sep 2012 10:36:21 +0200

On 09/05/2012 07:56 AM, Christian Marillat wrote:
> 
> $ edos-builddebcheck /debian/data/unstable/Packages_i386 
> /debian/dists/unstable/main/source/Sources Merging... File 
> "/usr/share/edos-distcheck/add-sources.py", line 144, in <module>
> pkg = pkg_of_src(src) File
> "/usr/share/edos-distcheck/add-sources.py", line 124, in pkg_of_src
> if src.has_key(field): AttributeError: 'Sources' object has no
> attribute 'has_key' Completing conflicts... * 100.0% Merging... 0
> Fatal error: exception Failure("Warning: package ignored because it 
> has no name")
> 

Can you please check if one of those files has an empty line at the
beginning and try to run edos-builddebcheck after removing the extra
empty line (in any)?

It would also help us to provide those files so that we can try to
reproduce the bug (even if they look downloaded from a Debian mirror...
but we never know what users do with their files :)).

Regards,

-- 
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/

Message #17 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@debian.org>

To: Mehdi Dogguy <mehdi@dogguy.org>

Cc: 686731@bugs.debian.org

Subject: Re: Bug#686731: edos-distcheck: Syopped to work

Date: Wed, 05 Sep 2012 11:26:02 +0200

Mehdi Dogguy <mehdi@dogguy.org> writes:

> On 09/05/2012 07:56 AM, Christian Marillat wrote:
>> 
>> $ edos-builddebcheck /debian/data/unstable/Packages_i386 
>> /debian/dists/unstable/main/source/Sources Merging... File 
>> "/usr/share/edos-distcheck/add-sources.py", line 144, in <module>
>> pkg = pkg_of_src(src) File
>> "/usr/share/edos-distcheck/add-sources.py", line 124, in pkg_of_src
>> if src.has_key(field): AttributeError: 'Sources' object has no
>> attribute 'has_key' Completing conflicts... * 100.0% Merging... 0
>> Fatal error: exception Failure("Warning: package ignored because it 
>> has no name")
>> 
>
> Can you please check if one of those files has an empty line at the
> beginning and try to run edos-builddebcheck after removing the extra
> empty line (in any)?

No empty line. Note, this was working before.

> It would also help us to provide those files so that we can try to
> reproduce the bug (even if they look downloaded from a Debian mirror...
> but we never know what users do with their files :)).

Steps to reproduce this 'feature' :

,----
| lynx -dump http://ftp.fr.debian.org/debian/dists/unstable/main/binary-i386/Packages.bz2 | bunzip2 -cd > Packages_i386
| lynx -dump http://www.deb-multimedia.org/dists/unstable/main/binary-i386//Packages.bz2 | bunzip2 -cd >> Packages_i386
| lynx -dump http://www.deb-multimedia.org/dists/unstable/non-free/binary-i386/Packages.bz2 | bunzip2 -cd >> Packages_i386
| lynx -dump http://www.deb-multimedia.org/dists/unstable/main/source/Sources.bz2 | bunzip2 -cd > Sources
| edos-builddebcheck Packages_i386 Sources
`----

Christian

Message #22 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Ralf Treinen <treinen@pps.univ-paris-diderot.fr>

To: 686731@bugs.debian.org, Christian Marillat <marillat@deb-multimedia.org>

Subject: Re: Bug#686731: edos-distcheck: Syopped to work

Date: Wed, 5 Sep 2012 11:28:07 +0200

Hello,

>$ edos-builddebcheck /debian/data/unstable/Packages_i386
> +/debian/dists/unstable/main/source/Sources
> Merging...
> File "/usr/share/edos-distcheck/add-sources.py", line 144, in <module>
> pkg = pkg_of_src(src)
> File "/usr/share/edos-distcheck/add-sources.py", line 124, in pkg_of_src
> if src.has_key(field):

This seems to be due to a change in python-debian version 0.1.21+nmu1.
Downgrading python-debian to version 0.1.21 (the one in testing) solves
the problem. I'll try to understand what is going on ...

-Ralf.
-- 
Ralf Treinen
Laboratoire Preuves, Programmes et Systèmes
Université Paris Diderot, Paris, France.
http://www.pps.univ-paris-diderot.fr/~treinen/
=====> New email address: treinen@pps.univ-paris-diderot.fr <=====

Message #35 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Ralf Treinen <treinen@pps.univ-paris-diderot.fr>, 686731@bugs.debian.org, debian-ocaml-maint@lists.debian.org

Cc: Christian Marillat <marillat@deb-multimedia.org>

Subject: Re: Bug#686731: edos-distcheck: Stopped to work

Date: Wed, 5 Sep 2012 11:20:10 +0100

reassign 686731 python-debian
notfound 686731 debian-python/0.1.21+nmu1
found 686731 python-debian/0.1.21+nmu1
thanks

edos-distcheck should be changed to use "if field in src:" rather than
"if src.has_key(field):" - the latter syntax will not work in Python 3.

However, the regression in the Python 2 case is clearly a bug in my NMU,
which I'll fix.

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #46 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Ralf Treinen <treinen@pps.univ-paris-diderot.fr>, 686731@bugs.debian.org, debian-ocaml-maint@lists.debian.org

Cc: Christian Marillat <marillat@deb-multimedia.org>

Subject: Re: Bug#686731: edos-distcheck: Stopped to work

Date: Wed, 5 Sep 2012 11:35:34 +0100

Dear python-debian maintainers, here's my NMU diff for this bug, which
I've also pushed to my python3 git branch.  I've uploaded this without
delay since it's a regression.

diff -Nru python-debian-0.1.21+nmu1/debian/changelog python-debian-0.1.21+nmu2/debian/changelog
--- python-debian-0.1.21+nmu1/debian/changelog	2012-08-22 16:27:06.000000000 +0100
+++ python-debian-0.1.21+nmu2/debian/changelog	2012-09-05 11:29:00.000000000 +0100
@@ -1,3 +1,11 @@
+python-debian (0.1.21+nmu2) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * In Python 2, restore Deb822Dict.has_key method for compatibility.
+    (Closes: #686731)
+
+ -- Colin Watson <cjwatson@debian.org>  Wed, 05 Sep 2012 11:28:58 +0100
+
 python-debian (0.1.21+nmu1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru python-debian-0.1.21+nmu1/lib/debian/deb822.py python-debian-0.1.21+nmu2/lib/debian/deb822.py
--- python-debian-0.1.21+nmu1/lib/debian/deb822.py	2012-08-22 16:26:15.000000000 +0100
+++ python-debian-0.1.21+nmu2/lib/debian/deb822.py	2012-09-05 11:17:38.000000000 +0100
@@ -270,7 +270,10 @@
     def __contains__(self, key):
         key = _strI(key)
         return key in self.__keys
-    
+
+    if sys.version < '3':
+        has_key = __contains__
+
     ### END _mutable_mapping_mixin methods
 
     def __repr__(self):

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #51 received at 686731-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 686731-close@bugs.debian.org

Subject: Bug#686731: fixed in python-debian 0.1.21+nmu2

Date: Wed, 05 Sep 2012 10:47:39 +0000

Source: python-debian
Source-Version: 0.1.21+nmu2

We believe that the bug you reported is fixed in the latest version of
python-debian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 686731@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated python-debian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 05 Sep 2012 11:28:58 +0100
Source: python-debian
Binary: python-debian python3-debian
Architecture: source all
Version: 0.1.21+nmu2
Distribution: unstable
Urgency: low
Maintainer: Debian python-debian Maintainers <pkg-python-debian-maint@lists.alioth.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 python-debian - Python modules to work with Debian-related data formats
 python3-debian - Python 3 modules to work with Debian-related data formats
Closes: 686731
Changes: 
 python-debian (0.1.21+nmu2) unstable; urgency=low
 .
   * Non-maintainer upload.
   * In Python 2, restore Deb822Dict.has_key method for compatibility.
     (Closes: #686731)
Checksums-Sha1: 
 d87ac3053addb1e62b1953ea6e6f0e3a1460e6cf 2130 python-debian_0.1.21+nmu2.dsc
 b97b79bf2467c82657ce365bfc61d7bb251c0ebc 188683 python-debian_0.1.21+nmu2.tar.gz
 605ae1da93910fdd0214f0119c5b3e968edac426 64090 python-debian_0.1.21+nmu2_all.deb
 33b1fceb906757f55dfae3e8469036ae1e0a2891 46344 python3-debian_0.1.21+nmu2_all.deb
Checksums-Sha256: 
 50ddadaf4c60ec896e1c90de7b966e366d7e65b79a4aa4e9d147ebbc36d128db 2130 python-debian_0.1.21+nmu2.dsc
 ef524e55749f14f36af921bdbf90b79aa06764d53b6348c8cb3a615954da0dcd 188683 python-debian_0.1.21+nmu2.tar.gz
 ac40c7311611899ce317bab13aec33d5d1df5a79d212cc6e3df1901a87a59727 64090 python-debian_0.1.21+nmu2_all.deb
 b7110c2ce37a817ba0b7ea1ad5c28fd99e4b1f2365d70d4ec0aceebc514851e1 46344 python3-debian_0.1.21+nmu2_all.deb
Files: 
 d0f028c3f2691313eac18229951a5647 2130 python optional python-debian_0.1.21+nmu2.dsc
 72915c8b95f53dc36b989e721a292858 188683 python optional python-debian_0.1.21+nmu2.tar.gz
 9a938357f983272c1ffd348af57f54b7 64090 python optional python-debian_0.1.21+nmu2_all.deb
 0e3beef17a802efc5e6e82781a6df31e 46344 python optional python3-debian_0.1.21+nmu2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBUEcq3Tk1h9l9hlALAQimhBAArV1JHB+LIhqX3hKYl983BpTKdKCnvaVo
HTwLmJ+Rn/TWE0keGSapvm92KYRYObFJ50qIHtUz+ipWlLeXORVDgFCkunitkJiv
uio0GcLwEQuyrj5MjNilbqqoktcTSdFr+bbmdiS2tANi8Ao80SL6zJphQ5w18Djd
pKcVBwgDP4KtiAsFprYqAxSudEBpHkPw89HGe8rwnpOEhVNVPCPrN4/sKCcmZnIv
Z8MYDiCWWU5Qkwczwb5r1Xw2Jc4iNdOJDCJBOqW5dqyUBuFQPkX3LlCip8Dwhlm3
HuffzHCLGxk9meNxaQjuGgnFjyQNtSNaaOm2fk+Ks+n5BEDefnuX0ewaOs5q+55h
I1j+X7LU/HB55VM0yNyaWCvGiT7rsk532cGvzlsgpTPL1/6MNQyC8wBAWDzedMQ7
vt2+Zcm8UEHcflg/zX096RjezBeyjysWeLxQNhUvonkFb5KGO4qfC0KVRmQn1KnR
w265COPbj6Oj4PncrSfP0pYda90n7vb1t8O6fw37FpisHm5Evp/sil4UgJuHW7pg
M7rshBNWcAOL2Hqdq+S9/JcbiJCfP65WIUqsyEkKW+pm76Pmyzkdnetv88XWZJ4s
aoluCkb8mkkFUKCgekmBkC/CWGcVHLX8Egx81gvM4L3wsB/gScyHdUsxGvggDvyH
QDVQkTSYoPk=
=4CT+
-----END PGP SIGNATURE-----

Message #58 received at 686731@bugs.debian.org (full text, mbox, reply):

From: Stefano Zacchiroli <zack@debian.org>

To: Colin Watson <cjwatson@debian.org>

Cc: 686731@bugs.debian.org, debian-ocaml-maint@lists.debian.org

Subject: Re: Bug#686731: edos-distcheck: Stopped to work

Date: Wed, 5 Sep 2012 13:38:54 +0200

[Message part 1 (text/plain, inline)]

clone 686731 -1
reassign -1 edos-distcheck
retitle -1 add-sources.py should use forward compatible "in" syntax instead of "has_key"
severity -1 wishlist
tags -1 + pending
thanks

On Wed, Sep 05, 2012 at 11:20:10AM +0100, Colin Watson wrote:
> edos-distcheck should be changed to use "if field in src:" rather than
> "if src.has_key(field):" - the latter syntax will not work in Python 3.

Thanks for noticing, I've just pushed a fix for that to edos-distcheck
Git repo. (Debian OCamlers: I've tested it and it seems to work
properly, but more testing is welcome!)

> However, the regression in the Python 2 case is clearly a bug in my NMU,
> which I'll fix.

And while we're at it: thanks also for your python-debian NMU, without
which we would still be without a Python 3 port of it. Regression
happens when doing stuff: they're no big deal, especially when someone
is as quick as you've been in cleaning up after them :-)

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Debian Project Leader . . . . . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.