Debian Bug report logs - #686425
unblock: mlt/0.8.0-4

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: Patrick Matthäi <pmatthaei@debian.org>

Date: Sat, 1 Sep 2012 11:45:02 UTC

Severity: normal

Done: "Adam D. Barratt" <adam@adam-barratt.org.uk>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#686425; Package release.debian.org. (Sat, 01 Sep 2012 11:45:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Patrick Matthäi <pmatthaei@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 01 Sep 2012 11:45:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Patrick Matthäi <pmatthaei@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: mlt/0.8.0-4
Date: Sat, 01 Sep 2012 13:40:43 +0200
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package mlt

It adds two upstream patches - which are also available in 0.8.2 - to fix:

04-cache-memory-leak: Huge memory leak which could cause mlt to leak more than 8 GB
					  of memory
05-ladspa-crash: Potential crash with ladspa plugins enabled on dlclose()

--- mlt-0.8.0/debian/changelog  2012-07-28 13:44:26.000000000 +0200
+++ mlt-0.8.0/debian/changelog  2012-09-01 13:10:03.000000000 +0200
@@ -1,3 +1,12 @@
+mlt (0.8.0-4) unstable; urgency=low
+
+  * Add upstream patch 04-cache-memory-leak, which fixes a memory leak when
+    using mlt_cache for frames.
+  * Add upstream patch 05-ladspa-crash, which fixes a potential LADSPA crash
+    on dlclose().
+
+ -- Patrick Matthäi <pmatthaei@debian.org>  Sat, 01 Sep 2012 13:09:30 +0200
+
 mlt (0.8.0-3) unstable; urgency=low
 
   * Disable compression from the luma module on mips. The convert process never
diff -Nru mlt-0.8.0/debian/patches/04-cache-memory-leak.diff mlt-0.8.0/debian/patches/04-cache-memory-leak.diff
--- mlt-0.8.0/debian/patches/04-cache-memory-leak.diff  1970-01-01 01:00:00.000000000 +0100
+++ mlt-0.8.0/debian/patches/04-cache-memory-leak.diff  2012-09-01 13:10:03.000000000 +0200
@@ -0,0 +1,35 @@
+# Upstream patch to fix a memory leak when using mlt_cache for frames.
+
+diff -Naur mlt-0.8.0.orig/src/framework/mlt_cache.c mlt-0.8.0/src/framework/mlt_cache.c
+--- mlt-0.8.0.orig/src/framework/mlt_cache.c   2012-06-01 22:51:32.000000000 +0200
++++ mlt-0.8.0/src/framework/mlt_cache.c        2012-08-28 20:27:03.371711652 +0200
+@@ -83,6 +83,7 @@
+ {
+       int count;             /**< the number of items currently in the cache */
+       int size;              /**< the maximum number of items permitted in the cache <= \p MAX_CACHE_SIZE */
++      int is_frames;         /**< indicates if this cache is used to cache frames */
+       void* *current;        /**< pointer to the current array of pointers */
+       void* A[ MAX_CACHE_SIZE ];
+       void* B[ MAX_CACHE_SIZE ];
+@@ -122,6 +123,13 @@
+ {
+       char key[19];
+ 
++      if ( cache->is_frames )
++      {
++              // Frame caches are easy - just close the object as mlt_frame.
++              mlt_frame_close( object );
++              return;
++      }
++
+       // Fetch the cache item from the active list by its owner's address
+       sprintf( key, "%p", object );
+       mlt_cache_item item = mlt_properties_get_data( cache->active, key, NULL );
+@@ -554,6 +562,7 @@
+ 
+       // swap the current array
+       cache->current = (void**) alt;
++      cache->is_frames = 1;
+       pthread_mutex_unlock( &cache->mutex );
+ }
+ 
diff -Nru mlt-0.8.0/debian/patches/05-ladspa-crash.diff mlt-0.8.0/debian/patches/05-ladspa-crash.diff
--- mlt-0.8.0/debian/patches/05-ladspa-crash.diff       1970-01-01 01:00:00.000000000 +0100
+++ mlt-0.8.0/debian/patches/05-ladspa-crash.diff       2012-09-01 13:10:03.000000000 +0200
@@ -0,0 +1,14 @@
+# Upstream patch to fix some LADSPA crashing on dlclose on some systems.
+
+diff -Naur mlt-0.8.0.orig/src/modules/jackrack/plugin_mgr.c mlt-0.8.0/src/modules/jackrack/plugin_mgr.c
+--- mlt-0.8.0.orig/src/modules/jackrack/plugin_mgr.c   2012-06-01 22:51:32.000000000 +0200
++++ mlt-0.8.0/src/modules/jackrack/plugin_mgr.c        2012-08-28 20:32:35.782841105 +0200
+@@ -80,7 +80,7 @@
+   int err;
+   
+   /* open the object file */
+-  dl_handle = dlopen (filename, RTLD_LAZY);
++  dl_handle = dlopen (filename, RTLD_NOW);
+   if (!dl_handle)
+     {
+       mlt_log_info( NULL, "%s: error opening shared object file '%s': %s\n",
diff -Nru mlt-0.8.0/debian/patches/series mlt-0.8.0/debian/patches/series
--- mlt-0.8.0/debian/patches/series     2012-07-28 13:32:34.000000000 +0200
+++ mlt-0.8.0/debian/patches/series     2012-09-01 13:10:03.000000000 +0200
@@ -1,3 +1,5 @@
 01-changed-preset-path.diff
 02-allow-file-prefix.diff
 03-audio-limits-and-crash.diff
+04-cache-memory-leak.diff
+05-ladspa-crash.diff


unblock mlt/0.8.0-4

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



Reply sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
You have taken responsibility. (Sat, 01 Sep 2012 11:57:13 GMT) Full text and rfc822 format available.

Notification sent to Patrick Matthäi <pmatthaei@debian.org>:
Bug acknowledged by developer. (Sat, 01 Sep 2012 11:57:13 GMT) Full text and rfc822 format available.

Message #10 received at 686425-done@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: Patrick Matthäi <pmatthaei@debian.org>, 686425-done@bugs.debian.org
Subject: Re: Bug#686425: unblock: mlt/0.8.0-4
Date: Sat, 01 Sep 2012 12:53:40 +0100
On Sat, 2012-09-01 at 13:40 +0200, Patrick Matthäi wrote:
> Please unblock package mlt
> 
> It adds two upstream patches - which are also available in 0.8.2 - to fix:
> 
> 04-cache-memory-leak: Huge memory leak which could cause mlt to leak more than 8 GB
> 					  of memory
> 05-ladspa-crash: Potential crash with ladspa plugins enabled on dlclose()

Unblocked; thanks.

Regards,

Adam




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sun, 30 Sep 2012 07:27:36 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Apr 18 16:23:57 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.