Debian Bug report logs - #682097
unblock: dbskkd-cdb/1:2.00-6

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: Tatsuya Kinoshita <tats@debian.org>

Date: Thu, 19 Jul 2012 13:36:02 UTC

Severity: normal

Done: Julien Cristau <jcristau@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Thu, 19 Jul 2012 13:36:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tatsuya Kinoshita <tats@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Thu, 19 Jul 2012 13:36:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Tatsuya Kinoshita <tats@debian.org>
To: submit@bugs.debian.org
Subject: unblock: dbskkd-cdb/1:2.00-5
Date: Thu, 19 Jul 2012 22:31:41 +0900 (JST)
[Message part 1 (text/plain, inline)]
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock dbskkd-cdb/1:2.00-5 to enable hardening flags for wheezy.

Changes:

  * debian/rules: Use dpkg-buildflags to support hardening flags

See also the attached debdiff.

unblock dbskkd-cdb/1:2.00-5

Thanks,
--
Tatsuya Kinoshita
[dbskkd-cdb_2.00-5.debdiff (text/plain, inline)]
diffstat for dbskkd-cdb-2.00 dbskkd-cdb-2.00

 changelog |    6 ++++++
 rules     |   10 +++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff -Nru dbskkd-cdb-2.00/debian/changelog dbskkd-cdb-2.00/debian/changelog
--- dbskkd-cdb-2.00/debian/changelog	2012-04-18 22:55:37.000000000 +0900
+++ dbskkd-cdb-2.00/debian/changelog	2012-07-08 11:35:51.000000000 +0900
@@ -1,3 +1,9 @@
+dbskkd-cdb (1:2.00-5) unstable; urgency=low
+
+  * debian/rules: Use dpkg-buildflags to support hardening flags
+
+ -- Tatsuya Kinoshita <tats@debian.org>  Sun, 08 Jul 2012 11:34:47 +0900
+
 dbskkd-cdb (1:2.00-4) unstable; urgency=low
 
   * debian/copyright: Switch to copyright-format-1.0.
diff -Nru dbskkd-cdb-2.00/debian/rules dbskkd-cdb-2.00/debian/rules
--- dbskkd-cdb-2.00/debian/rules	2012-04-18 22:53:28.000000000 +0900
+++ dbskkd-cdb-2.00/debian/rules	2012-07-08 11:33:32.000000000 +0900
@@ -4,16 +4,20 @@
 # Uncomment this to turn on verbose mode. 
 #export DH_VERBOSE=1
 
-CFLAGS := -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
+CFLAGS=$(shell $(dpkg_buildflags) --get CFLAGS)
+CPPFLAGS=$(shell $(dpkg_buildflags) --get CPPFLAGS)
+LDFLAGS=$(shell $(dpkg_buildflags) --get LDFLAGS)
 
 build: build-arch build-indep
 
 build-arch: build-arch-stamp
 build-arch-stamp:
 	dh_testdir
-	$(MAKE) CC='gcc $(CFLAGS)' \
+	$(MAKE) CC='gcc $(CFLAGS) $(CPPFLAGS)' \
                 COMPAT='-DJISYO_FILE=\"/usr/share/skk/SKK-JISYO.cdb\"' \
-		CDBLIB=-lcdb
+		CDBLIB='$(LDFLAGS) -lcdb'
 	touch $@
 
 build-indep: build-indep-stamp
[Message part 3 (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Fri, 31 Aug 2012 20:21:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Adam D. Barratt" <adam@adam-barratt.org.uk>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Fri, 31 Aug 2012 20:21:06 GMT) Full text and rfc822 format available.

Message #10 received at 682097@bugs.debian.org (full text, mbox):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
To: Tatsuya Kinoshita <tats@debian.org>, 682097@bugs.debian.org
Subject: Re: Bug#682097: unblock: dbskkd-cdb/1:2.00-5
Date: Fri, 31 Aug 2012 21:17:37 +0100
Control: tags -1 + moreinfo

On Thu, 2012-07-19 at 22:31 +0900, Tatsuya Kinoshita wrote:
> Please unblock dbskkd-cdb/1:2.00-5 to enable hardening flags for wheezy.
> 
> Changes:
> 
>   * debian/rules: Use dpkg-buildflags to support hardening flags

> -CFLAGS := -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
> +export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
> +CFLAGS=$(shell $(dpkg_buildflags) --get CFLAGS)

That seems to lose -Wall?

Regards,

Adam




Added tag(s) moreinfo. Request was from "Adam D. Barratt" <adam@adam-barratt.org.uk> to 682097-submit@bugs.debian.org. (Fri, 31 Aug 2012 20:21:06 GMT) Full text and rfc822 format available.

Removed tag(s) moreinfo. Request was from Tatsuya Kinoshita <tats@debian.org> to control@bugs.debian.org. (Sat, 01 Sep 2012 12:42:04 GMT) Full text and rfc822 format available.

Changed Bug title to 'unblock: dbskkd-cdb/1:2.00-6' from 'unblock: dbskkd-cdb/1:2.00-5' Request was from Tatsuya Kinoshita <tats@debian.org> to control@bugs.debian.org. (Sat, 01 Sep 2012 12:42:05 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Sat, 01 Sep 2012 12:51:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tatsuya Kinoshita <tats@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 01 Sep 2012 12:51:03 GMT) Full text and rfc822 format available.

Message #21 received at 682097@bugs.debian.org (full text, mbox):

From: Tatsuya Kinoshita <tats@debian.org>
To: adam@adam-barratt.org.uk
Cc: 682097@bugs.debian.org
Subject: Bug#682097: unblock: dbskkd-cdb/1:2.00-6
Date: Sat, 01 Sep 2012 21:35:51 +0900 (JST)
[Message part 1 (text/plain, inline)]
tags 682097 - moreinfo
retitle 682097 unblock: dbskkd-cdb/1:2.00-6
thanks

Please unblock dbskkd-cdb/1:2.00-6 to enable hardening flags for wheezy.

On August 31, 2012 at 9:17PM +0100,
adam (at adam-barratt.org.uk) wrote:

>> -CFLAGS := -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
>> +export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
>> +CFLAGS=$(shell $(dpkg_buildflags) --get CFLAGS)
>
> That seems to lose -Wall?

Revived the -Wall option for CFLAGS in dbskkd-cdb/1:2.00-6, even
though enabling/disabling -Wall does not hurt the package.

See also the attached debdiff.

unblock dbskkd-cdb/1:2.00-6

Thanks,
--
Tatsuya Kinoshita
[dbskkd-cdb_2.00-6.debdiff (text/plain, inline)]
diffstat for dbskkd-cdb-2.00 dbskkd-cdb-2.00

 changelog |   12 ++++++++++++
 rules     |   10 +++++++---
 2 files changed, 19 insertions(+), 3 deletions(-)

diff -Nru dbskkd-cdb-2.00/debian/changelog dbskkd-cdb-2.00/debian/changelog
--- dbskkd-cdb-2.00/debian/changelog	2012-04-18 22:55:37.000000000 +0900
+++ dbskkd-cdb-2.00/debian/changelog	2012-09-01 20:16:05.000000000 +0900
@@ -1,3 +1,15 @@
+dbskkd-cdb (1:2.00-6) unstable; urgency=low
+
+  * debian/rules: Revive the -Wall option for CFLAGS
+
+ -- Tatsuya Kinoshita <tats@debian.org>  Sat, 01 Sep 2012 20:16:04 +0900
+
+dbskkd-cdb (1:2.00-5) unstable; urgency=low
+
+  * debian/rules: Use dpkg-buildflags to support hardening flags
+
+ -- Tatsuya Kinoshita <tats@debian.org>  Sun, 08 Jul 2012 11:34:47 +0900
+
 dbskkd-cdb (1:2.00-4) unstable; urgency=low
 
   * debian/copyright: Switch to copyright-format-1.0.
diff -Nru dbskkd-cdb-2.00/debian/rules dbskkd-cdb-2.00/debian/rules
--- dbskkd-cdb-2.00/debian/rules	2012-04-18 22:53:28.000000000 +0900
+++ dbskkd-cdb-2.00/debian/rules	2012-09-01 20:20:38.000000000 +0900
@@ -4,16 +4,20 @@
 # Uncomment this to turn on verbose mode. 
 #export DH_VERBOSE=1
 
-CFLAGS := -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
+CFLAGS=-Wall $(shell $(dpkg_buildflags) --get CFLAGS)
+CPPFLAGS=$(shell $(dpkg_buildflags) --get CPPFLAGS)
+LDFLAGS=$(shell $(dpkg_buildflags) --get LDFLAGS)
 
 build: build-arch build-indep
 
 build-arch: build-arch-stamp
 build-arch-stamp:
 	dh_testdir
-	$(MAKE) CC='gcc $(CFLAGS)' \
+	$(MAKE) CC='gcc $(CFLAGS) $(CPPFLAGS)' \
                 COMPAT='-DJISYO_FILE=\"/usr/share/skk/SKK-JISYO.cdb\"' \
-		CDBLIB=-lcdb
+		CDBLIB='$(LDFLAGS) -lcdb'
 	touch $@
 
 build-indep: build-indep-stamp
[Message part 3 (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Wed, 10 Oct 2012 07:42:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Cristau <jcristau@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Wed, 10 Oct 2012 07:42:03 GMT) Full text and rfc822 format available.

Message #26 received at 682097@bugs.debian.org (full text, mbox):

From: Julien Cristau <jcristau@debian.org>
To: Tatsuya Kinoshita <tats@debian.org>, 682097@bugs.debian.org
Cc: adam@adam-barratt.org.uk
Subject: Re: Bug#682097: unblock: dbskkd-cdb/1:2.00-6
Date: Wed, 10 Oct 2012 09:40:00 +0200
[Message part 1 (text/plain, inline)]
On Sat, Sep  1, 2012 at 21:35:51 +0900, Tatsuya Kinoshita wrote:

> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags

What's this DEB_BUILD_MAINT_OPTIONS thing about?

Cheers,
Julien
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Wed, 10 Oct 2012 12:27:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tatsuya Kinoshita <tats@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Wed, 10 Oct 2012 12:27:03 GMT) Full text and rfc822 format available.

Message #31 received at 682097@bugs.debian.org (full text, mbox):

From: Tatsuya Kinoshita <tats@debian.org>
To: jcristau@debian.org
Cc: 682097@bugs.debian.org, adam@adam-barratt.org.uk
Subject: Re: Bug#682097: unblock: dbskkd-cdb/1:2.00-6
Date: Wed, 10 Oct 2012 21:18:48 +0900 (JST)
[Message part 1 (text/plain, inline)]
On October 10, 2012 at 9:40AM +0200,
jcristau (at debian.org) wrote:

>> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
>
> What's this DEB_BUILD_MAINT_OPTIONS thing about?

This DEB_BUILD_MAINT_OPTIONS set the environment varialbe to the
value of the make variable for dpkg-buildflags.

Thanks,
--
Tatsuya Kinoshita
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#682097; Package release.debian.org. (Wed, 10 Oct 2012 16:15:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Cristau <jcristau@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Wed, 10 Oct 2012 16:15:03 GMT) Full text and rfc822 format available.

Message #36 received at 682097@bugs.debian.org (full text, mbox):

From: Julien Cristau <jcristau@debian.org>
To: Tatsuya Kinoshita <tats@debian.org>, 682097@bugs.debian.org
Cc: adam@adam-barratt.org.uk
Subject: Re: Bug#682097: unblock: dbskkd-cdb/1:2.00-6
Date: Wed, 10 Oct 2012 18:10:32 +0200
[Message part 1 (text/plain, inline)]
On Wed, Oct 10, 2012 at 21:18:48 +0900, Tatsuya Kinoshita wrote:

> On October 10, 2012 at 9:40AM +0200,
> jcristau (at debian.org) wrote:
> 
> >> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
> >
> > What's this DEB_BUILD_MAINT_OPTIONS thing about?
> 
> This DEB_BUILD_MAINT_OPTIONS set the environment varialbe to the
> value of the make variable for dpkg-buildflags.
> 
It's already set by the export line just above this one...

Cheers,
Julien
[signature.asc (application/pgp-signature, inline)]

Reply sent to Julien Cristau <jcristau@debian.org>:
You have taken responsibility. (Wed, 10 Oct 2012 18:21:03 GMT) Full text and rfc822 format available.

Notification sent to Tatsuya Kinoshita <tats@debian.org>:
Bug acknowledged by developer. (Wed, 10 Oct 2012 18:21:03 GMT) Full text and rfc822 format available.

Message #41 received at 682097-done@bugs.debian.org (full text, mbox):

From: Julien Cristau <jcristau@debian.org>
To: Tatsuya Kinoshita <tats@debian.org>
Cc: 682097-done@bugs.debian.org, adam@adam-barratt.org.uk
Subject: Re: Bug#682097: unblock: dbskkd-cdb/1:2.00-6
Date: Wed, 10 Oct 2012 20:17:08 +0200
[Message part 1 (text/plain, inline)]
On Wed, Oct 10, 2012 at 21:18:48 +0900, Tatsuya Kinoshita wrote:

> On October 10, 2012 at 9:40AM +0200,
> jcristau (at debian.org) wrote:
> 
> >> +dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
> >
> > What's this DEB_BUILD_MAINT_OPTIONS thing about?
> 
> This DEB_BUILD_MAINT_OPTIONS set the environment varialbe to the
> value of the make variable for dpkg-buildflags.
> 
Nevermind my other reply.  Jakub pointed out I was mistaken.  Unblocked.

Cheers,
Julien
[signature.asc (application/pgp-signature, inline)]

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 08 Nov 2012 07:28:42 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Apr 19 15:43:44 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.