Debian Bug report logs - #681332
unblock: dpkg/1.16.8

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: Raphaël Hertzog <hertzog@debian.org>

Date: Thu, 12 Jul 2012 11:48:02 UTC

Severity: normal

Done: Raphael Hertzog <hertzog@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, guillem@debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Thu, 12 Jul 2012 11:48:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Raphaël Hertzog <hertzog@debian.org>:
New Bug report received and forwarded. Copy sent to guillem@debian.org, Debian Release Team <debian-release@lists.debian.org>. (Thu, 12 Jul 2012 11:48:16 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Raphaël Hertzog <hertzog@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: dpkg/1.16.7
Date: Thu, 12 Jul 2012 13:44:36 +0200
[Message part 1 (text/plain, inline)]
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package dpkg

The version 1.16.5/1.16.6 introduced several important changes that we wanted
to have in Wheezy:
- the support of "dpkg-query --control-show" and "dpkg-query
  --control-list" to prepare for the move of changelog and copyright
  into the package metadata
- dpkg-buildflags --status
- several improvements in the 3.0 (quilt) format
- an SE linux fix
- many translations updates

But we had to re-upload after the freeze to fix #679959 so the automatic
unblock no longer matches. Please update it to match.

unblock dpkg/1.16.7

The debdiff is thus rather huge but most changes are translation updates
or short string updates. I attach a diff where I filter po files and man
page updates (filterdiff -x '*.po' -x '*.pot' -x '*/man/*').

$ git diff --stat 1.16.4.3..1.16.7
[...]
 212 files changed, 77626 insertions(+), 59263 deletions(-)

$ git diff 1.16.4.3..1.16.7 |filterdiff -x '*.po' -x '*.pot' -x '*/man/*'
 configure.ac                            |    2 
 debian/changelog                        |  116 ++++++++++++
 debian/source/options                   |    4 
 doc/README.feature-removal-schedule     |    8 
 doc/triggers.txt                        |   10 -
 dpkg-deb/build.c                        |   11 -
 dpkg-deb/extract.c                      |   42 ++--
 dpkg-deb/info.c                         |   16 +
 dpkg-deb/main.c                         |    6 
 dpkg-split/join.c                       |    9 
 dpkg-split/main.c                       |    6 
 dpkg-split/queue.c                      |    5 
 dpkg-split/split.c                      |   18 +
 dselect/bindings.cc                     |    2 
 dselect/main.cc                         |    6 
 dselect/pkglist.cc                      |    2 
 lib/compat/empty.c                      |    1 
 lib/dpkg/Makefile.am                    |    2 
 lib/dpkg/ar.c                           |   11 +
 lib/dpkg/buffer.c                       |   73 ++-----
 lib/dpkg/buffer.h                       |   33 +--
 lib/dpkg/command.c                      |   21 ++
 lib/dpkg/command.h                      |    1 
 lib/dpkg/compress.c                     |   10 -
 lib/dpkg/dpkg.h                         |    2 
 lib/dpkg/ehandle.c                      |   28 --
 lib/dpkg/ehandle.h                      |    4 
 lib/dpkg/fields.c                       |    2 
 lib/dpkg/file.c                         |   27 ++
 lib/dpkg/file.h                         |    1 
 lib/dpkg/libdpkg.map                    |    2 
 lib/dpkg/log.c                          |    4 
 lib/dpkg/pkg-format.c                   |   24 +-
 lib/dpkg/pkg-format.h                   |    4 
 lib/dpkg/report.c                       |   72 +++++++
 lib/dpkg/report.h                       |   47 ++++
 lib/dpkg/test/t-buffer.c                |    4 
 po/POTFILES.in                          |    1 
 scripts/Dpkg/Arch.pm                    |   22 +-
 scripts/Dpkg/BuildEnv.pm                |  105 +++++++++++
 scripts/Dpkg/BuildFlags.pm              |  107 ++++++++---
 scripts/Dpkg/BuildOptions.pm            |    5 
 scripts/Dpkg/Changelog/Debian.pm        |    2 
 scripts/Dpkg/Changelog/Entry/Debian.pm  |    6 
 scripts/Dpkg/Control/Fields.pm          |   13 -
 scripts/Dpkg/Deps.pm                    |   29 ++-
 scripts/Dpkg/Shlibs/SymbolFile.pm       |    6 
 scripts/Dpkg/Source/Functions.pm        |    1 
 scripts/Dpkg/Source/Package.pm          |   11 +
 scripts/Dpkg/Source/Package/V2.pm       |  178 +++++++++++++-----
 scripts/Dpkg/Source/Package/V3/bzr.pm   |    3 
 scripts/Dpkg/Source/Package/V3/git.pm   |    6 
 scripts/Dpkg/Source/Package/V3/quilt.pm |  270 ++++++++--------------------
 scripts/Dpkg/Source/Patch.pm            |    9 
 scripts/Dpkg/Source/Quilt.pm            |  305 ++++++++++++++++++++++++++++++++
 scripts/Dpkg/Substvars.pm               |   24 +-
 scripts/Dpkg/Vendor.pm                  |    5 
 scripts/Makefile.am                     |    2 
 scripts/changelog/debian.pl             |    5 
 scripts/dpkg-architecture.pl            |   10 -
 scripts/dpkg-buildflags.pl              |   52 ++++-
 scripts/dpkg-buildpackage.pl            |   22 +-
 scripts/dpkg-checkbuilddeps.pl          |   11 -
 scripts/dpkg-distaddfile.pl             |    5 
 scripts/dpkg-genchanges.pl              |   12 -
 scripts/dpkg-gencontrol.pl              |   37 ++-
 scripts/dpkg-gensymbols.pl              |    4 
 scripts/dpkg-maintscript-helper.sh      |    4 
 scripts/dpkg-mergechangelogs.pl         |    7 
 scripts/dpkg-name.pl                    |    6 
 scripts/dpkg-parsechangelog.pl          |    5 
 scripts/dpkg-scanpackages.pl            |    8 
 scripts/dpkg-scansources.pl             |    6 
 scripts/dpkg-shlibdeps.pl               |   36 +--
 scripts/dpkg-source.pl                  |   23 +-
 scripts/dpkg-vendor.pl                  |    3 
 scripts/po/POTFILES.in                  |    2 
 scripts/t/750_Dpkg_Substvars.t          |    6 
 src/archives.c                          |  127 +++++++------
 src/configure.c                         |   23 +-
 src/divertcmd.c                         |    6 
 src/enquiry.c                           |    4 
 src/errors.c                            |   14 -
 src/filesdb.c                           |    4 
 src/help.c                              |   10 -
 src/main.c                              |    6 
 src/main.h                              |    2 
 src/packages.c                          |    7 
 src/processarc.c                        |   17 -
 src/querycmd.c                          |  195 ++++++++++++++++----
 src/remove.c                            |   12 -
 src/script.c                            |    5 
 src/select.c                            |    2 
 src/statcmd.c                           |   14 -
 src/trigcmd.c                           |   12 -
 src/trigproc.c                          |    5 
 src/update.c                            |    2 
 utils/start-stop-daemon.c               |   23 +-
 utils/update-alternatives.c             |   74 ++++---
 99 files changed, 1776 insertions(+), 798 deletions(-)

-- System Information:
Debian Release: wheezy/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (150, 'experimental')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.4-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
[debdiff.gz (application/x-gzip, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Thu, 12 Jul 2012 18:31:44 GMT) Full text and rfc822 format available.

Acknowledgement sent to Guillem Jover <guillem@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Thu, 12 Jul 2012 18:31:48 GMT) Full text and rfc822 format available.

Message #10 received at 681332@bugs.debian.org (full text, mbox):

From: Guillem Jover <guillem@debian.org>
To: Raphaël Hertzog <hertzog@debian.org>, 681332@bugs.debian.org
Subject: Re: Bug#681332: unblock: dpkg/1.16.7
Date: Thu, 12 Jul 2012 20:29:10 +0200
On Thu, 2012-07-12 at 13:44:36 +0200, Raphaël Hertzog wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package dpkg
> 
> The version 1.16.5/1.16.6 introduced several important changes that we wanted
> to have in Wheezy:
> - the support of "dpkg-query --control-show" and "dpkg-query
>   --control-list" to prepare for the move of changelog and copyright
>   into the package metadata
> - dpkg-buildflags --status
> - several improvements in the 3.0 (quilt) format
> - an SE linux fix
> - many translations updates

Because I'm going to upload 1.16.8 pretty shortly with new translation
updates, less than 10 days have passed (but even if 10 had passed that
would be too short) and I was planning to request an unblock later on
once there's been enough time for any other regressions to show up,
I'd just disregard this request.

> But we had to re-upload after the freeze to fix #679959 so the automatic
> unblock no longer matches. Please update it to match.
>
> unblock dpkg/1.16.7
> 
> The debdiff is thus rather huge but most changes are translation updates
> or short string updates. I attach a diff where I filter po files and man
> page updates (filterdiff -x '*.po' -x '*.pot' -x '*/man/*').

> $ git diff --stat 1.16.4.3..1.16.7
> [...]
>  212 files changed, 77626 insertions(+), 59263 deletions(-)

In addition because the automatic freeze exception was for 1.16.5, which
would have gone in anyway, I don't see the point in asking the release
team to review the diff starting from the testing version. I think it
makes more sense to use a diff from 1.16.5.. onwards, but obviously
the release team might disagree with that.

guillem




Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Thu, 12 Jul 2012 19:24:19 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Cristau <jcristau@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Thu, 12 Jul 2012 19:24:22 GMT) Full text and rfc822 format available.

Message #15 received at 681332@bugs.debian.org (full text, mbox):

From: Julien Cristau <jcristau@debian.org>
To: Guillem Jover <guillem@debian.org>, 681332@bugs.debian.org
Cc: Raphaël Hertzog <hertzog@debian.org>
Subject: Re: Bug#681332: unblock: dpkg/1.16.7
Date: Thu, 12 Jul 2012 20:42:02 +0200
[Message part 1 (text/plain, inline)]
On Thu, Jul 12, 2012 at 20:29:10 +0200, Guillem Jover wrote:

> In addition because the automatic freeze exception was for 1.16.5, which
> would have gone in anyway, I don't see the point in asking the release
> team to review the diff starting from the testing version. I think it
> makes more sense to use a diff from 1.16.5.. onwards, but obviously
> the release team might disagree with that.
> 
They do.  1.16.5 wasn't going to go in because 1.16.5 was broken.
1.16.4.3 isn't, AFAIK, so you're going to have to explain why the new
version should be considered instead.

Cheers,
Julien
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Sat, 21 Jul 2012 01:15:09 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jonathan Nieder <jrnieder@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 21 Jul 2012 01:15:09 GMT) Full text and rfc822 format available.

Message #20 received at 681332@bugs.debian.org (full text, mbox):

From: Jonathan Nieder <jrnieder@gmail.com>
To: Cyril Brulebois <kibi@debian.org>
Cc: 681332@bugs.debian.org, debian-dpkg@lists.debian.org
Subject: Re: debian-cd BoF at DebConf
Date: Fri, 20 Jul 2012 20:12:32 -0500
Hi,

Cyril Brulebois wrote:

> dpkg's current diff between testing and unstable, once *.po and *.gmo
> stripped is:
>  323 files changed, 7307 insertions(+), 4626 deletions(-)
>
> There's #681332 about that, which was left unanswered.

Dpkg development has been happening pretty quickly lately, so there
are a lot of changes between the versions in wheezy and sid.

* Version number bumped
* Translation updates: sv de fr ja ca it sk es zh_TW ru pl da eo
* Documentation improvements: deb(5) deb-src-control(5)
* Bugfixes:

    #652970 3.0 (quilt): More graceful reporting of and recovery from
    patch application errors

    dpkg-source --commit: Clean up on failure.

    dpkg-parsechangelog: Correct capitalization of fields when
    reporting errors.

    #677631 dpkg-source: Avoid warning noise when HOME is unset.

    (non-Debian) Add a dummy symbol to libcompat so unpleasant
    toolchains can still cope with it.

    #678933 Error out instead of writing an invalid ar file when
    member name or size is too large

    #640676 dpkg-shlibdeps: Report bogus Build-Depends using a
    sane message instead of a "use of undefined value" warning.

    #679641 dpkg: Use SELinux raw context API to avoid relying
    on the mcstransd daemon during unpack.

* Features:

    3.0 (quilt): When regenerating the automatic patch, keep comments
    leading up to the patch from the old version, since they might
    contain useful information.

    dpkg-source --commit: Automatically add modified binary files to
    debian/source/include-binaries.

    #643043 dpkg-source learns --no-unapply-patches.

    #664058 dpkg-buildflags learns --status.

    #440094 Add support for "binary-only" changelog field and use it
    to detect source version (though the old heuristic of detecting
    +b<num> is still supported, too).

    #675333 dpkg-source -b: Take architecture wildcards into account
    when removing repeated arches in the resulting source control and
    changes files.

    #627333 start-stop-daemon learns --no-close.

    dpkg-query learns --control-list and --control-show.

    #679010 update-alternatives --query, --config have more useful
    output.

    #621763 Buffer I/O errors and errors in the dpkg-query --show
    format argument are reported more cleanly.

    #624000 Avoid full stop and double newline at the end of errors
    and warnings

    Change short name for --help to -? instead of -h.

    dpkg-mergechangelogs --help output is more consistent with
    other commands.

    #676232 Add support for Architecture-qualified dependencies like
    Depends: libc6:amd64 (>= 2.14)

    #558095 Add support for :native syntax for Build-Depends.

    #673190 dpkg-query -l adds an Architecture column.

    More consistently uses US English spelling in documentation and
    error messages.

* Cleanup:

    Dpkg::Source::Functions::is_binary(): Don't clobber $_.

    Dpkg::Source::Package::V2: Make binary file handling into a
    dedicated BinaryFiles class.

    New Dpkg::Source::Quilt module, split off from
    Dpkg::Source::Package::V3::quilt.

    Dpkg::Control::Fields: Remove obsolete changelog fields
    Timestamp, Header, Items, Trailer, Urgency_comment, Urgency_lc
    from field order.

    Use new notice() function (which takes care of the program
    name and trailing newline, making the list of translated strings
    saner) for notices to stderr instead of using fprintf directly.

* Packaging:

    Source package compression switched to xz.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Sat, 21 Jul 2012 08:51:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Cristau <jcristau@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 21 Jul 2012 08:51:03 GMT) Full text and rfc822 format available.

Message #25 received at 681332@bugs.debian.org (full text, mbox):

From: Julien Cristau <jcristau@debian.org>
To: Jonathan Nieder <jrnieder@gmail.com>, 681332@bugs.debian.org
Cc: Cyril Brulebois <kibi@debian.org>, debian-dpkg@lists.debian.org
Subject: Re: Bug#681332: debian-cd BoF at DebConf
Date: Sat, 21 Jul 2012 10:47:38 +0200
[Message part 1 (text/plain, inline)]
On Fri, Jul 20, 2012 at 20:12:32 -0500, Jonathan Nieder wrote:

> Dpkg development has been happening pretty quickly lately, so there
> are a lot of changes between the versions in wheezy and sid.
> 
At this point quick development should target experimental, not sid.

Cheers,
Julien
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#681332; Package release.debian.org. (Sat, 21 Jul 2012 16:06:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jonathan Nieder <jrnieder@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Sat, 21 Jul 2012 16:06:03 GMT) Full text and rfc822 format available.

Message #30 received at 681332@bugs.debian.org (full text, mbox):

From: Jonathan Nieder <jrnieder@gmail.com>
To: Julien Cristau <jcristau@debian.org>
Cc: 681332@bugs.debian.org, Cyril Brulebois <kibi@debian.org>, debian-dpkg@lists.debian.org
Subject: unblock: dpkg/1.16.8 (Re: debian-cd BoF at DebConf)
Date: Sat, 21 Jul 2012 11:03:01 -0500
[Message part 1 (text/plain, inline)]
retitle 681332 unblock: dpkg/1.16.8
quit

Julien Cristau wrote:
> On Fri, Jul 20, 2012 at 20:12:32 -0500, Jonathan Nieder wrote:

>> Dpkg development has been happening pretty quickly lately, so there
>> are a lot of changes between the versions in wheezy and sid.
>
> At this point quick development should target experimental, not sid.

Yes, sorry for the lack of clarity.  When I said lately, I meant the
month before the freeze started.  Though that's neither here nor
there.

Among the changes I listed, a few seem especially important:

    Translation updates: sv de fr ja ca it sk es zh_TW ru pl da eo

    #678933 Error out instead of writing an invalid ar file when
    member name or size is too large

    #679641 dpkg: Use SELinux raw context API to avoid relying
    on the mcstransd daemon during unpack [since not having that
    makes upgrading policycoreutils complicated]

    #643043 dpkg-source learns --no-unapply-patches.

    #627333 start-stop-daemon learns --no-close.

    #676232 Add support for Architecture-qualified dependencies like
    Depends: libc6:amd64 (>= 2.14)

    #558095 Add support for :native syntax for Build-Depends.

However, I can understand if you want to delay architecture-qualified
dependencies and build-dependencies, since as interfaces those are
subtle.  On the gripping hand, no packages in the archive use those
constructs, so in a way, adding support for them is safe.

For most changes it would be easy to prepare an upload for t-p-u once
it is clear which changes are wanted, but not so for the translation
updates.  It might be easier to selectively revert changes if there
are some changes you're worried about.

Compressed debdiff attached.  Generated with

	debdiff dpkg_1.16.4.3.dsc dpkg_1.16.8.dsc |

	# Exclude translations and autotools-generated files
	filterdiff -x '*.po' -x '*.pot' -x '*/man/*/*' -x '*.in' -x '*/aclocal.m4' |

	# Exclude compiled message catalogs (.gmo files)
	grep -v '^Binary files'

dirstat:

   3.3% debian/
   6.3% lib/dpkg/
   3.1% man/
   6.9% scripts/Dpkg/Source/Package/V3/
   3.0% scripts/Dpkg/Source/Package/
   5.8% scripts/Dpkg/Source/
   6.3% scripts/Dpkg/
   7.1% scripts/
  12.2% src/

 123 files changed, 3700 insertions(+), 848 deletions(-)

The percentages add up to 54% because 46% of the change is in
ChangeLog (1813 lines).

Hope that helps,
Jonathan
[dpkg_1.16.4.3_1.16.8.debdiff.xz (application/octet-stream, attachment)]

Changed Bug title to 'unblock: dpkg/1.16.8' from 'unblock: dpkg/1.16.7' Request was from Jonathan Nieder <jrnieder@gmail.com> to control@bugs.debian.org. (Sat, 21 Jul 2012 16:06:04 GMT) Full text and rfc822 format available.

Reply sent to Raphael Hertzog <hertzog@debian.org>:
You have taken responsibility. (Wed, 01 Aug 2012 07:36:24 GMT) Full text and rfc822 format available.

Notification sent to Raphaël Hertzog <hertzog@debian.org>:
Bug acknowledged by developer. (Wed, 01 Aug 2012 07:36:24 GMT) Full text and rfc822 format available.

Message #37 received at 681332-done@bugs.debian.org (full text, mbox):

From: Raphael Hertzog <hertzog@debian.org>
To: 681332-done@bugs.debian.org
Subject: Re: dpkg unblock added by Neil
Date: Wed, 1 Aug 2012 09:25:17 +0200
On Wed, 01 Aug 2012, Raphael Hertzog wrote:
> FWIW Neil added an unblock + age-days 30 a few days go. This bug can
> probably be closed.

Closing on request of jcristau.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/



Information stored :
Bug#681332; Package release.debian.org. (Wed, 01 Aug 2012 07:36:26 GMT) Full text and rfc822 format available.

Acknowledgement sent to Raphael Hertzog <hertzog@debian.org>:
Extra info received and filed, but not forwarded. (Wed, 01 Aug 2012 07:36:26 GMT) Full text and rfc822 format available.

Message #42 received at 681332-quiet@bugs.debian.org (full text, mbox):

From: Raphael Hertzog <hertzog@debian.org>
To: 681332-quiet@bugs.debian.org
Subject: dpkg unblock added by Neil
Date: Wed, 1 Aug 2012 09:16:06 +0200
FWIW Neil added an unblock + age-days 30 a few days go. This bug can
probably be closed.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 30 Aug 2012 07:26:38 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 13:18:39 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.