Debian Bug report logs - #680852
bash-completion: dh_bash-completion processes only one package if "proper snippet"

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Jean-Michel Vourgère" <jmv_deb@nirgal.com>

To: submit@bugs.debian.org

Subject: bash-completion: dh_bash-completion processes only one package if "proper snippet"

Date: Sun, 8 Jul 2012 18:25:58 +0000

[Message part 1 (text/plain, inline)]

Package: bash-completion
Version: 1:2.0-1
Severity: normal

My package mdbtools provides 2 bash-completion snippet. Only one get installed.

I suppose this might be caused by a intall+exit(0) on line 83 after detection
that there is not a list of file in the package.bash-completion file. But there
might be other packages and exit is a bit strong an action.

You can reproduce wih code at:
http://git.debian.org/?p=collab-maint/mdbtools.git



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages bash-completion depends on:
ii  bash  4.2-2
ii  dpkg  1.16.4.3

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 680852@bugs.debian.org (full text, mbox, reply):

From: "Jean-Michel Vourgère" <jmv_deb@nirgal.com>

To: 680852@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Patch

Date: Mon, 9 Jul 2012 21:41:23 +0000

[Message part 1 (text/plain, inline)]

tags 680852 +patch
thanks

Attached is a patch.
I'm not familiar with perl: This works for me, but please review carefully.

[680852.diff (text/x-patch, inline)]

Description: Don't stop processing packages after proper snippet
Author: Jean-Michel Vourgère <jmv_deb@nirgal.com>
Forwarded: not-needed
Last-Update: 2012-01-04

--- debian/extra/debhelper/dh_bash-completion	2012-06-17 21:08:08.000000000 +0200
+++ /usr/bin/dh_bash-completion	2012-07-09 23:20:33.000000000 +0200
@@ -38,7 +38,7 @@
 my $srcdir = '.';
 $srcdir = $dh{SOURCEDIR}."/" if defined $dh{SOURCEDIR};
 
-foreach my $package (@{$dh{DOPACKAGES}}) {
+PKG: foreach my $package (@{$dh{DOPACKAGES}}) {
 	next if is_udeb($package);
 
 	my $tmp = tmpdir($package);
@@ -80,7 +80,7 @@
 					warning "file-list parsing failed, installing as proper snippet";
 
 					doit("install", "-p", "-m644", $completions, "$bc_dir/$package");
-					exit 0
+					next PKG
 				}
 				push @filelist, @found;
 			}

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 680852-close@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: 680852-close@bugs.debian.org

Subject: Bug#680852: fixed in bash-completion 1:2.1-3

Date: Wed, 19 Mar 2014 11:03:30 +0000

Source: bash-completion
Source-Version: 1:2.1-3

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 680852@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <dapal@debian.org> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 19 Mar 2014 11:44:27 +0100
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:2.1-3
Distribution: unstable
Urgency: medium
Maintainer: Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>
Changed-By: David Paleino <dapal@debian.org>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 496162 574950 665651 673235 680852 697513 698977 702498 704832 708173 737672 737881 739835 741657
Changes: 
 bash-completion (1:2.1-3) unstable; urgency=medium
 .
   * Import patch from Ubuntu:
     - fix_quote_readline_by_ref.patch, thanks to JuanJo Ciarlante
       (Closes: #739835):
       + avoid escaping 1st '~' (LP: #1288314)
       + avoid quoting if empty, else expansion without args only shows
         dirs (LP: #1288031)
       + replace double escaping to single (eg for completing file/paths
         with spaces)
     - words_bad_array_subscript.patch, thanks to Barry Warsaw
     - dpkg_ddeb.patch: dpkg also supports *.ddeb, thanks to Sebastien
       Bacher (LP: #568404, Closes: #737881)
     - disable_avahi_browse.patch: slow, and doesn't scale to big
       networks, thanks to Chris Jones (Closes: #574950, LP: #510591)
     - xine_add_more_formats.patch: add oga and ogx to multimedia players
       (Closes: #496162, LP: #311525)
   * debian/maintscript, debian/postinst:
     - clean etc conffiles on upgrade since completion files are in /usr
       with 2.0, thanks to Sebastien Bacher
   * debian/control: marked Multi-Arch: foreign
   * debian/patches/:
     - fix_gcc_detection.patch, correctly parses Debian's GCC version
       number, thanks to Tomas Janousek (Closes: #665651)
     - xpdf_support_compressed_pdf.patch, in Debian xpdf also supports
       compressed files, thanks to Alfredo Finelli (Closes: #702498)
     - dpkg_support_raw-extract_vextract.patch: add support for more
       options in dpkg-deb, thanks to Uwe Storbeck (Closes: #698977)
     - dpkg_fix_-W_option.patch: -W|--show doesn't support udebs/ddebs,
       thanks to Luca Capello (Closes: #697513)
     - aptitude_safe-upgrade.patch: safe-upgrade supports package names,
       thanks to Nicolas Le Cam (Closes: #673235)
     - ifconfig_locale.patch: _mac_addresses() didn't consider locale
       awareness of ifconfig, thanks to Thilo Six (Closes: #704832)
     - dont_return_from_sourced_script.patch: avoid problems with shells
       not supporting returning from a sourced script (Closes: #741657)
     - look_for_pod.patch: perldoc: look for .pod in addition to .pm
       files, thanks to Carl Hayter (Closes: #708173)
   * debian/extra/debhelper/dh_bash-completion: fix installation process
     when more than one "proper snippet" is being installed, thanks to
     Jean-Michel Vourgère (Closes: #680852)
   * Dropped completions included in util-linux (Closes: #737672)
Checksums-Sha1: 
 e9849707f765792d9227836eec5a9db90a1bcb0b 1377 bash-completion_2.1-3.dsc
 abd628e5dfef3242aa467277e4647a0ec0b13a7d 19408 bash-completion_2.1-3.debian.tar.xz
 f2a0edfbace7dfc007d629968e6eec180267c124 182124 bash-completion_2.1-3_all.deb
Checksums-Sha256: 
 2b44aeb674a9690c6af75957fa5308889277c9abd1a05143c81ccb4733e0a15f 1377 bash-completion_2.1-3.dsc
 8f48a945a680d9ab0da54be570929c33ae7bc5ec0f25fb6512fb75db1013ee3a 19408 bash-completion_2.1-3.debian.tar.xz
 d226ff84e0633c0ee4abdb9b2631fe0532b6c516f9d434a035633500811d9049 182124 bash-completion_2.1-3_all.deb
Files: 
 1ad095c77d5c9f34aa34d8822c52af4b 1377 shells standard bash-completion_2.1-3.dsc
 0d3f94bc45de05f6c05bfdf7d8d9a82e 19408 shells standard bash-completion_2.1-3.debian.tar.xz
 b3f48281983f26282a473b2a082d9786 182124 shells standard bash-completion_2.1-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlMpdqQACgkQ5qqQFxOSsXRWtwCfRpjyuFpSIdtHdUnGSM3nzZSv
5OUAn29tGWEKYQydzlajsOUrA45W4D/f
=67po
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.