Debian Bug report logs - #680057
unblock: fracplanet/0.4.0-3

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: "Bernhard R. Link" <brlink@debian.org>

Date: Tue, 3 Jul 2012 09:03:02 UTC

Severity: normal

Done: Mehdi Dogguy <mehdi@dogguy.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#680057; Package release.debian.org. (Tue, 03 Jul 2012 09:03:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Bernhard R. Link" <brlink@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Tue, 03 Jul 2012 09:03:19 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: "Bernhard R. Link" <brlink@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: fracplanet/0.4.0-3
Date: Tue, 3 Jul 2012 11:01:26 +0200
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please consider unblocking package fracplanet/0.4.0-3

The version fixes FTBFS 653584 caused by the
configuration target being phony by mistake.

It also makes sure the proper flags are passed,
and calls dpkg-buildflags so the default hardening
flags are used.

unblock fracplanet/0.4.0-3

diff -r -u -N fracplanet_0.4.0-2/debian/changelog fracplanet_0.4.0-3/debian/changelog
--- fracplanet_0.4.0-2/debian/changelog	2012-05-09 04:44:47.000000000 +0200
+++ fracplanet_0.4.0-3/debian/changelog	2012-07-01 16:39:17.000000000 +0200
@@ -1,3 +1,13 @@
+fracplanet (0.4.0-3) unstable; urgency=low
+
+  * QA upload.
+  * fix configure calling
+  - use proper stamp file, avoiding recompilation (Closes: 653584)
+  - use dpkg-buildflags
+  - use correct variables to pass flags (thus respecting DEB_BUILD_OPTIONS)
+
+ -- Bernhard R. Link <brlink@debian.org>  Sun, 01 Jul 2012 16:36:55 +0200
+
 fracplanet (0.4.0-2) unstable; urgency=low
 
   * QA upload.
diff -r -u -N fracplanet_0.4.0-2/debian/rules fracplanet_0.4.0-3/debian/rules
--- fracplanet_0.4.0-2/debian/rules	2010-04-09 16:16:23.000000000 +0200
+++ fracplanet_0.4.0-3/debian/rules	2012-07-01 17:01:00.000000000 +0200
@@ -2,21 +2,34 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-CFLAGS = -Wall -g
+CFLAGS       := $(shell dpkg-buildflags --get CFLAGS)
+CXXFLAGS     := $(shell dpkg-buildflags --get CXXFLAGS)
+CPPFLAGS     := $(shell dpkg-buildflags --get CPPFLAGS)
+LDFLAGS      := $(shell dpkg-buildflags --get LDFLAGS)
+# options needed for qmake (called by ./configure)
+# (set _RELEASE and _DEBUG empty to avoid those overriding what we give,
+#  pass CPPFLAGS and CFLAGS and CXXFLAGS,
+#  pass CXXFLAGS and LDFLAGS in LFLAGS (it's LFLAGS, not LDFLAGS!)):
+QMAKEOPTIONS := QMAKE_CXXFLAGS_RELEASE='' QMAKE_CXXFLAGS_DEBUG='' \
+                QMAKE_CFLAGS_RELEASE='' QMAKE_CFLAGS_DEBUG='' \
+                QMAKE_CFLAGS='-Wall $(CFLAGS) $(CPPFLAGS)' \
+                QMAKE_CXXFLAGS='-Wall $(CFLAGS) $(CPPFLAGS)' \
+                QMAKE_LFLAGS='$(CXXFLAGS) $(LDFLAGS)'
 
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
+ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
+	MAKEFLAGS += -j$(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 endif
 
-config.status: configure
+
+configure-stamp: configure
 	dh_testdir
-	QTDIR=/usr/lib/qt4 ./configure CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"
+	QTDIR=/usr/lib/qt4 ./configure $(QMAKEOPTIONS)
+	touch $@
 
-build: build-stamp
+build build-arch: build-stamp
+build-indep:
 
-build-stamp:  config.status
+build-stamp:  configure-stamp
 	dh_testdir
 	$(MAKE)
 	touch $@
@@ -24,12 +37,12 @@
 clean:
 	dh_testdir
 	dh_testroot
-	rm -f build-stamp
+	rm -f build-stamp configure-stamp
 	[ ! -f Makefile ] || $(MAKE) distclean
 	rm -f Makefile usage_text.h
 	dh_clean
 
-install: build
+install: build-stamp
 	dh_testdir
 	dh_testroot
 	dh_prep
@@ -39,11 +52,11 @@
 	cp debian/fracplanet.desktop debian/fracplanet/usr/share/applications/
 
 # Build architecture-independent files here.
-binary-indep: build install
+binary-indep:
 # We have nothing to do by default.
 
 # Build architecture-dependent files here.
-binary-arch: build install
+binary-arch: install
 	dh_testdir
 	dh_testroot
 	dh_installchangelogs
@@ -60,4 +73,4 @@
 	dh_builddeb
 
 binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install
+.PHONY: build build-indep build-arch clean binary-indep binary-arch binary install




Reply sent to Mehdi Dogguy <mehdi@dogguy.org>:
You have taken responsibility. (Thu, 05 Jul 2012 14:57:04 GMT) Full text and rfc822 format available.

Notification sent to "Bernhard R. Link" <brlink@debian.org>:
Bug acknowledged by developer. (Thu, 05 Jul 2012 14:57:05 GMT) Full text and rfc822 format available.

Message #10 received at 680057-done@bugs.debian.org (full text, mbox):

From: Mehdi Dogguy <mehdi@dogguy.org>
To: "Bernhard R. Link" <brlink@debian.org>, 680057-done@bugs.debian.org
Subject: Re: Bug#680057: unblock: fracplanet/0.4.0-3
Date: Thu, 05 Jul 2012 16:53:34 +0200
On 03/07/12 11:01, Bernhard R. Link wrote:
> unblock fracplanet/0.4.0-3

Unblocked.

Regards,

-- 
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 03 Aug 2012 07:33:19 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 11:51:20 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.