Debian Bug report logs - #679952
unblock: fldigi/3.21.48-1

Package: release.debian.org; Maintainer for release.debian.org is Debian Release Team <debian-release@lists.debian.org>;

Reported by: Kamal Mostafa <kamal@whence.com>

Date: Mon, 2 Jul 2012 16:45:02 UTC

Severity: normal

Done: Mehdi Dogguy <mehdi@dogguy.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#679952; Package release.debian.org. (Mon, 02 Jul 2012 16:45:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kamal Mostafa <kamal@whence.com>:
New Bug report received and forwarded. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Mon, 02 Jul 2012 16:45:05 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Kamal Mostafa <kamal@whence.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: fldigi/3.21.48-1
Date: Mon, 02 Jul 2012 09:42:51 -0700
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: freeze-exception

Please unblock package fldigi

I request a freeze exception for fldigi/3.21.48-1 which I have uploaded to
unstable.  The delta for this version includes only the two bug fixes noted in
the changelog entry here:

    fldigi (3.21.48-1) unstable; urgency=low

       * New upstream release, includes these changes only:
         - Tango Icon Library updated public domain version (Closes: #679792)
         - Retry session ID after session time out (Closes: #679797)

The Tango Icons issue is a DFSG-non-compliance problem (more details in the bug
report #679792).  The fix involves no functional change, just a replacement of
the icon pixmaps.  But as this results in a 10000-line diff of just C-language
xpm pixmap data, I shall omit the diff from this report.

The Retry session ID (#679797) fix is a small functional change which corrects
a moderately serious malfunction of the application; that diff is attached for
reference.

Thanks!


unblock fldigi/3.21.48-1




Information forwarded to debian-bugs-dist@lists.debian.org, Debian Release Team <debian-release@lists.debian.org>:
Bug#679952; Package release.debian.org. (Mon, 02 Jul 2012 16:51:09 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kamal Mostafa <kamal@whence.com>:
Extra info received and forwarded to list. Copy sent to Debian Release Team <debian-release@lists.debian.org>. (Mon, 02 Jul 2012 16:51:10 GMT) Full text and rfc822 format available.

Message #10 received at 679952@bugs.debian.org (full text, mbox):

From: Kamal Mostafa <kamal@whence.com>
To: <679952@bugs.debian.org>
Subject: for reference: diff for #679797
Date: Mon, 02 Jul 2012 09:46:46 -0700
From e94e2f2c17e81fa4bc114c31110916dfe02540f7 Mon Sep 17 00:00:00 2001
From: David Freese <w1hkj@w1hkj.com>
Date: Sat, 30 Jun 2012 12:57:59 -0500
Subject: [PATCH 1/3] HAMQTH Session ID

  * Retry session ID after session time out
  * Correct error string extraction
---
 src/logbook/lookupcall.cxx |   23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/logbook/lookupcall.cxx b/src/logbook/lookupcall.cxx
index 6a3aa2c..2f35dc0 100644
--- a/src/logbook/lookupcall.cxx
+++ b/src/logbook/lookupcall.cxx
@@ -751,20 +751,22 @@ bool HAMQTH_get_session_id()
 	if (!fetch_http(url, retstr, 5.0)) {
 		return false;
 	}
-	if ((p1 = retstr.find("<error>")) != string::npos) {
+	p1 = retstr.find("<error>");
+	if (p1 != string::npos) {
 		p2 = retstr.find("</error>");
-		lookup_notes = retstr.substr(p1 + 7, p2 - p1 - 7);
+		if (p2 != string::npos) {
+			p1 += 7;
+			lookup_notes = retstr.substr(p1, p2 - p1);
+		}
 		return false;
 	}
-	if ((p1 = retstr.find("<session_id>")) == string::npos) {
+	p1 = retstr.find("<session_id>");
+	if (p1 == string::npos) {
 		lookup_notes = "HamQTH not available";
 		return false;
 	}
 	p2 = retstr.find("</session_id>");
 	HAMQTH_session_id = retstr.substr(p1 + 12, p2 - p1 - 12);
-//#ifdef HAMQTH_DEBUG
-//	printf("session id = %s\n", HAMQTH_session_id.c_str());
-//#endif
 	return true;
 }
 
@@ -885,12 +887,13 @@ bool HAMQTHget(string& htmlpage)
 	url.append("&prg=FLDIGI");
 
 	ret = fetch_http(url, htmlpage, 5.0);
-	if (htmlpage.find("<error>") != string::npos ) {
-		size_t p = htmlpage.find("<error>") + 7;
-		size_t p1 = htmlpage.find("</error>");
+	size_t p = htmlpage.find("<error>");
+	if (p != string::npos ) {
+		size_t p1 = htmlpage.find("</error>", p);
 		if (p1 != string::npos) {
 			string tempstr;
-			tempstr.assign(htmlpage.substr(p1, p1 - p));
+			p += 7;
+			tempstr.assign(htmlpage.substr(p, p1 - p));
 			LOG_WARN("HAMQTH error: %s", tempstr.c_str());
 		}
 		htmlpage.clear();
-- 
1.7.9.5





Reply sent to Mehdi Dogguy <mehdi@dogguy.org>:
You have taken responsibility. (Thu, 05 Jul 2012 15:09:07 GMT) Full text and rfc822 format available.

Notification sent to Kamal Mostafa <kamal@whence.com>:
Bug acknowledged by developer. (Thu, 05 Jul 2012 15:09:07 GMT) Full text and rfc822 format available.

Message #15 received at 679952-done@bugs.debian.org (full text, mbox):

From: Mehdi Dogguy <mehdi@dogguy.org>
To: Kamal Mostafa <kamal@whence.com>, 679952-done@bugs.debian.org
Subject: Re: Bug#679952: unblock: fldigi/3.21.48-1
Date: Thu, 05 Jul 2012 17:06:02 +0200
On 02/07/12 18:42, Kamal Mostafa wrote:
> unblock fldigi/3.21.48-1

Unblocked.

Regards,

-- 
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 03 Aug 2012 07:32:36 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 06:16:54 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.