Debian Bug report logs - #679642
quake-server: does not install properly without shadow passwords

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Stephan Springl <debian-sysvrc@springl.homeip.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: quake-server: does not install properly without shadow passwords

Date: Sat, 30 Jun 2012 14:24:08 +0200

Package: quake-server
Version: 2
Severity: important
Tags: patch

Dear Maintainer,

quake-server does neither install nor purge properly on systems
without shadow password because usermod gives an error for its
e option in this case.  Postinst nad postrm scripts could be
modified to cope with this.

Regards,
Stephan

diff --git a/debian/quake-server.postinst b/debian/quake-server.postinst
index e0319b3..c241c8b 100644
--- a/debian/quake-server.postinst
+++ b/debian/quake-server.postinst
@@ -11,7 +11,11 @@ case "$1" in
 	--ingroup games --force-badname quake-server
     fi
     # Unlock account, if it was locked by our postrm
-    usermod -U -e '' quake-server
+    if [ -f /etc/shadow ]; then
+      usermod -U -e '' quake-server
+    else
+      usermod -U quake-server
+    fi
     install -d /var/games
     install -d -o quake-server -g games /var/games/quake-server
   ;;
diff --git a/debian/quake-server.postrm b/debian/quake-server.postrm
index 3f84523..220bc81 100644
--- a/debian/quake-server.postrm
+++ b/debian/quake-server.postrm
@@ -6,7 +6,11 @@ set -e
 
 if [ "$1" = "purge" ] ; then
     # Lock account on purge
-    usermod -L -e 1 quake-server
+    if [ -f /etc/shadow ]; then
+        usermod -L -e 1 quake-server
+    else
+        usermod -L quake-server
+    fi
     rm -r /var/games/quake-server
     rmdir --ignore-fail-on-non-empty /var/games
 fi
-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')

Shell: /bin/sh linked to /bin/dash

Message #10 received at 679642@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: debian-devel@lists.debian.org

Cc: Stephan Springl <debian-sysvrc@springl.homeip.net>, 679642@bugs.debian.org, 621833@bugs.debian.org, Roger Leigh <rleigh@codelibre.net>

Subject: locking system users on package removal

Date: Sat, 30 Jun 2012 14:12:45 +0100

On 30/06/12 13:24, Stephan Springl wrote (on Bug #679642):
> quake-server does neither install nor purge properly on systems
> without shadow password because usermod gives an error for its
> e option in this case.

I took this use of usermod from the discussion on debian-devel regarding
Policy bug #621833 (where it was originally suggested by Roger Leigh),
so this potentially affects quite a few packages.

Stephan's proposed patch (below) makes me think we really need a script
(or dpkg-maintscript-helper subcommand) that locks and unlocks system
users, in which we can make changes like this once and have them affect
every relevant package, rather than individually patching every
maintainer script.

Roger: does the change below look appropriate?

Regards,
    S

[in the preinst]
> -    usermod -U -e '' quake-server
> +    if [ -f /etc/shadow ]; then
> +      usermod -U -e '' quake-server
> +    else
> +      usermod -U quake-server
> +    fi
[in the postrm]
>      # Lock account on purge
> -    usermod -L -e 1 quake-server
> +    if [ -f /etc/shadow ]; then
> +        usermod -L -e 1 quake-server
> +    else
> +        usermod -L quake-server
> +    fi

Message #15 received at 679642@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@codelibre.net>

To: Simon McVittie <smcv@debian.org>

Cc: debian-devel@lists.debian.org, Stephan Springl <debian-sysvrc@springl.homeip.net>, 679642@bugs.debian.org, 621833@bugs.debian.org

Subject: Re: locking system users on package removal

Date: Sat, 30 Jun 2012 14:36:47 +0100

On Sat, Jun 30, 2012 at 02:12:45PM +0100, Simon McVittie wrote:
> On 30/06/12 13:24, Stephan Springl wrote (on Bug #679642):
> > quake-server does neither install nor purge properly on systems
> > without shadow password because usermod gives an error for its
> > e option in this case.
> 
> I took this use of usermod from the discussion on debian-devel regarding
> Policy bug #621833 (where it was originally suggested by Roger Leigh),
> so this potentially affects quite a few packages.
> 
> Stephan's proposed patch (below) makes me think we really need a script
> (or dpkg-maintscript-helper subcommand) that locks and unlocks system
> users, in which we can make changes like this once and have them affect
> every relevant package, rather than individually patching every
> maintainer script.
> 
> Roger: does the change below look appropriate?
> 
> [in the preinst]
> > -    usermod -U -e '' quake-server
> > +    if [ -f /etc/shadow ]; then
> > +      usermod -U -e '' quake-server
> > +    else
> > +      usermod -U quake-server
> > +    fi
> [in the postrm]
> >      # Lock account on purge
> > -    usermod -L -e 1 quake-server
> > +    if [ -f /etc/shadow ]; then
> > +        usermod -L -e 1 quake-server
> > +    else
> > +        usermod -L quake-server
> > +    fi

It looks sane to me.  Having a dh_ command or some other dpkg
maintscript helper shell function to do this automatically would
IMO be a very nice improvement.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800

Message #20 received at 679642@bugs.debian.org (full text, mbox, reply):

From: Marc Haber <mh+debian-devel@zugschlus.de>

To: Roger Leigh <rleigh@codelibre.net>

Cc: debian-devel@lists.debian.org, 679642@bugs.debian.org, 621833@bugs.debian.org

Subject: Re: locking system users on package removal

Date: Sat, 30 Jun 2012 17:29:11 +0200

On Sat, 30 Jun 2012 14:36:47 +0100, Roger Leigh <rleigh@codelibre.net>
wrote:
>On Sat, Jun 30, 2012 at 02:12:45PM +0100, Simon McVittie wrote:
>> [in the preinst]
>> > -    usermod -U -e '' quake-server
>> > +    if [ -f /etc/shadow ]; then
>> > +      usermod -U -e '' quake-server
>> > +    else
>> > +      usermod -U quake-server
>> > +    fi
>> [in the postrm]
>> >      # Lock account on purge
>> > -    usermod -L -e 1 quake-server
>> > +    if [ -f /etc/shadow ]; then
>> > +        usermod -L -e 1 quake-server
>> > +    else
>> > +        usermod -L quake-server
>> > +    fi
>
>It looks sane to me.  Having a dh_ command or some other dpkg
>maintscript helper shell function to do this automatically would
>IMO be a very nice improvement.

Given the amount of code lines that were spent in adduser to allow its
transparent usage in maintainer scripts, I would prefer having that
code in adduser. with adduser --lock locking an account and adduser
--system unlocking a locked user that is present but locked.

Having debhelper code for that is wrong since it means rebuilding
packages to fix bugs in that code.

Greetings
Marc
-- 
-------------------------------------- !! No courtesy copies, please !! -----
Marc Haber         |   " Questions are the         | Mailadresse im Header
Mannheim, Germany  |     Beginning of Wisdom "     | http://www.zugschlus.de/
Nordisch by Nature | Lt. Worf, TNG "Rightful Heir" | Fon: *49 621 72739834

Message #25 received at 679642-close@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: 679642-close@bugs.debian.org

Subject: Bug#679642: fixed in quake 3

Date: Thu, 26 Sep 2013 22:19:29 +0000

Source: quake
Source-Version: 3

We believe that the bug you reported is fixed in the latest version of
quake, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 679642@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <smcv@debian.org> (supplier of updated quake package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 26 Sep 2013 21:53:10 +0100
Source: quake
Binary: quake quake-server
Architecture: source all
Version: 3
Distribution: unstable
Urgency: low
Maintainer: David Banks <amoebae@gmail.com>
Changed-By: Simon McVittie <smcv@debian.org>
Description: 
 quake      - classic first person shooter
 quake-server - classic first person shooter - server and init script
Closes: 679642
Changes: 
 quake (3) unstable; urgency=low
 .
   [ David Banks ]
   * Add LSB description field to init script.
   * Add status action to init script (ported from quake3 package).
   * Bump debhelper compat version to 9 to avoid python warning.
   * Bump standards version to the latest version, 3.9.3.
 .
   [ Simon McVittie ]
   * Apply patch from Stephan Springl to install successfully with
     non-shadow passwords (Closes: #679642)
   * Standards-Version: 3.9.4, no changes needed
Checksums-Sha1: 
 14773a9d8d9d11d852b4322312d7100fab3c8257 1535 quake_3.dsc
 e04a7641b0a93987898771fd567c78082e54fd1b 24613 quake_3.tar.gz
 debb7d1e42081ea3fb159c78d1d5e5f3bcb0b5f7 39978 quake_3_all.deb
 b18870954ca56a0809db812441709b56047e5701 7614 quake-server_3_all.deb
Checksums-Sha256: 
 7c367293cde00ecb7688045df226509bed7af6648a494b7cf6d88867c7babb97 1535 quake_3.dsc
 4b433fae055c9d3a3da06a8e0106a31b4a5a754407e810f262d74cc8091885c3 24613 quake_3.tar.gz
 7ef7112c8195ef4f2974464467f5d5e721c871572bd06ee4a5e61db6aee88907 39978 quake_3_all.deb
 879a6d55003d5e0ead509be9322ab77c9ea7b4b1d2f2a2c213d497b8e358b1f5 7614 quake-server_3_all.deb
Files: 
 e2577fa4a97e323a277f08f121f6444b 1535 contrib/games optional quake_3.dsc
 6abd4caf255f335672e72dc98d790596 24613 contrib/games optional quake_3.tar.gz
 ce40f26a44463efb5d76232c392e2a0f 39978 contrib/games optional quake_3_all.deb
 8a18e30076812e73d26e720cb7a1000d 7614 contrib/games optional quake-server_3_all.deb

-----BEGIN PGP SIGNATURE-----

iQIVAwUBUkSvAU3o/ypjx8yQAQh7TA//VXQ5SMpUWCMttKqFk67c3xYYLtNRhnPj
mlJWMKO7uAZa6uIJMphOWMWrHpcrGmVAeV1+Agwj9fBeEhySpufxBAOm1q8TAyH/
WGbH7xPqi6kn2DrPJovSa2TWCqe82yzFITFWi9f/20OlNtGhDHCOzUvXTVAZDZm/
hAtcNeEpLdL8R/uY+PSHhLTbV6HK3IKQjdKQY3lydUtCD8n7WfvocPG/8+9aZfM5
f1W5CTXPMkmQc3CjP6sjNKeUopmodRrGD6AdpO1HdkyijLpBn/RDozI7Qf1Lf+eO
XkoxBZQr99RwskYxQP44gzyiTdOWtM6hGYknP7bFZ16juAEXkfQvBCK1HMsr+jsO
sF1LzIWwnhFC1O6j6B41bqlf9wO+v88If0iEeQZFVqZFLtVDD0scV9LvKV4e2ReG
I7ErADhkGCKTpVpI+WDWUG+PwsBQWAZDQhQ22f/q6+clR9aANzHYaZzJn/P/FP0w
AMvBM5M+pj2YYcz6D0u67cssA6Xnzvlu+K1KYvAl9wW2Q8CmBjn+uxIAY0CaSH12
6WkqeyWIL5SQzm0TaczJt7qc1Bz79hyzD032k1NWTzBUePtn66CI6VcviZ0YtQ7n
Hmfhp5CEqYmvYHfj6SeoXIhUjHSwspI2oD73m7tja8ArYZU5I6YDI7CUT1NQCtzi
ZUmMzGK8DQ8=
=fFsq
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.