Debian Bug report logs - #679123
tcc: Incorrect shift result type with 64-bit ABI

version graph

Package: tcc; Maintainer for tcc is Thomas Preud'homme <robotux@debian.org>; Source for tcc is src:tcc (PTS, buildd, popcon).

Reported by: Vincent Lefevre <vincent@vinc17.net>

Date: Tue, 26 Jun 2012 13:39:17 UTC

Severity: important

Tags: patch, upstream

Found in versions tcc/0.9.26~git20120612.ad5f375-4, tcc/0.9.26~git20120612.ad5f375-3

Fixed in version tcc/0.9.26~git20120612.ad5f375-5

Done: Thomas Preud'homme <robotux@celest.fr>

Bug is archived. No further changes may be made.

Forwarded to http://lists.nongnu.org/archive/html/tinycc-devel/2012-06/msg00037.html

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to debian-bugs-dist@lists.debian.org, Aurélien GÉRÔME <ag@debian.org>:
Bug#679123; Package tcc. (Tue, 26 Jun 2012 13:39:21 GMT) (full text, mbox, link).

Acknowledgement sent to Vincent Lefevre <vincent@vinc17.net>:
New Bug report received and forwarded. Copy sent to Aurélien GÉRÔME <ag@debian.org>. (Tue, 26 Jun 2012 13:39:21 GMT) (full text, mbox, link).

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vincent Lefevre <vincent@vinc17.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: tcc: Incorrect shift result type with 64-bit ABI
Date: Tue, 26 Jun 2012 15:38:40 +0200
Package: tcc
Version: 0.9.26~git20120612.ad5f375-3
Severity: important
Forwarded: http://lists.nongnu.org/archive/html/tinycc-devel/2012-06/msg00037.html

The behavior on the following program is incorrect with tcc:

#include <stdio.h>

#define M1 (1 << (int) 1)
#define M2 (1 << (unsigned int) 1)
#define M3 (1 << (long) 1)
#define M4 (1 << (unsigned long) 1)
#define M5 (1 << (long long) 1)
#define M6 (1 << (unsigned long long) 1)

#define OUT(M) \
  printf ("%d %s\n", (int) sizeof(M), -M < 0 ? "signed" : "unsigned")

int main (void)
{
  OUT(M1);
  OUT(M2);
  OUT(M3);
  OUT(M4);
  OUT(M5);
  OUT(M6);
  return 0;
}

ISO C99 TC3 says: [6.5.7#3] "The integer promotions are performed on
each of the operands. The type of the result is that of the promoted
left operand."

Thus the type of the shift result should be int in the 6 cases.

Correct behavior (with gcc):
4 signed
4 signed
4 signed
4 signed
4 signed
4 signed

Incorrect behavior (with tcc):
4 signed
4 unsigned
8 signed
8 unsigned
8 signed
8 unsigned

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tcc depends on:
ii  dpkg          1.16.4.3
ii  install-info  4.13a.dfsg.1-10
ii  libc6         2.13-33

Versions of packages tcc recommends:
ii  libc6-dev [libc-dev]  2.13-33

tcc suggests no packages.

-- no debconf information

Information forwarded to debian-bugs-dist@lists.debian.org, Aurélien GÉRÔME <ag@debian.org>:
Bug#679123; Package tcc. (Wed, 27 Jun 2012 09:15:03 GMT) (full text, mbox, link).

Acknowledgement sent to Vincent Lefevre <vincent@vinc17.net>:
Extra info received and forwarded to list. Copy sent to Aurélien GÉRÔME <ag@debian.org>. (Wed, 27 Jun 2012 09:15:03 GMT) (full text, mbox, link).

Message #10 received at 679123@bugs.debian.org (full text, mbox, reply):

From: Vincent Lefevre <vincent@vinc17.net>
To: 679123@bugs.debian.org
Subject: Re: tcc: Incorrect shift result type with 64-bit ABI
Date: Wed, 27 Jun 2012 11:07:32 +0200
Note: this bug has been found when testing GNU MPFR. It is silently
built incorrectly with tcc due to the use of sizeof(), which is
equivalent to an unsigned long, in shift-count sub-expressions.
This can be seen with "make check", where many MPFR tests fail.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Information forwarded to debian-bugs-dist@lists.debian.org, Aurélien GÉRÔME <ag@debian.org>:
Bug#679123; Package tcc. (Wed, 27 Jun 2012 11:39:22 GMT) (full text, mbox, link).

Acknowledgement sent to Vincent Lefevre <vincent@vinc17.net>:
Extra info received and forwarded to list. Copy sent to Aurélien GÉRÔME <ag@debian.org>. (Wed, 27 Jun 2012 11:39:23 GMT) (full text, mbox, link).

Message #15 received at 679123@bugs.debian.org (full text, mbox, reply):

From: Vincent Lefevre <vincent@vinc17.net>
To: 679123@bugs.debian.org
Subject: Re: tcc: Incorrect shift result type with 64-bit ABI
Date: Wed, 27 Jun 2012 13:37:38 +0200
[Message part 1 (text/plain, inline)]
tags 679123 patch upstream
thanks

I've written a patch (attached).

Could you please look at it before the freeze?

It solves the problems with the testcase and with MPFR, but I've
tested it only on amd64.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[tcc-shift-type.patch (text/plain, attachment)]

Added tag(s) upstream and patch. Request was from Vincent Lefevre <vincent@vinc17.net> to control@bugs.debian.org. (Wed, 27 Jun 2012 11:45:42 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, Aurélien GÉRÔME <ag@debian.org>:
Bug#679123; Package tcc. (Wed, 27 Jun 2012 11:50:33 GMT) (full text, mbox, link).

Acknowledgement sent to "Thomas Preud'homme" <robotux@celest.fr>:
Extra info received and forwarded to list. Copy sent to Aurélien GÉRÔME <ag@debian.org>. (Wed, 27 Jun 2012 11:50:35 GMT) (full text, mbox, link).

Message #22 received at 679123@bugs.debian.org (full text, mbox, reply):

From: "Thomas Preud'homme" <robotux@celest.fr>
To: Vincent Lefevre <vincent@vinc17.net>, 679123@bugs.debian.org
Subject: Re: Bug#679123: tcc: Incorrect shift result type with 64-bit ABI
Date: Wed, 27 Jun 2012 13:47:23 +0200
[Message part 1 (text/plain, inline)]
Le mercredi 27 juin 2012 13:37:38, vous avez écrit :
> tags 679123 patch upstream
> thanks
> 
> I've written a patch (attached).
> 
> Could you please look at it before the freeze?

That's my goal but I'm quite busy unfortunetely. I'll do my best.

> 
> It solves the problems with the testcase and with MPFR, but I've
> tested it only on amd64.

Cheers.

[signature.asc (application/pgp-signature, inline)]

Added tag(s) pending. Request was from "Thomas Preud'homme" <robotux@celest.fr> to control@bugs.debian.org. (Wed, 27 Jun 2012 13:21:19 GMT) (full text, mbox, link).

Reply sent to Thomas Preud'homme <robotux@celest.fr>:
You have taken responsibility. (Wed, 27 Jun 2012 13:51:17 GMT) (full text, mbox, link).

Notification sent to Vincent Lefevre <vincent@vinc17.net>:
Bug acknowledged by developer. (Wed, 27 Jun 2012 13:51:17 GMT) (full text, mbox, link).

Message #29 received at 679123-close@bugs.debian.org (full text, mbox, reply):

From: Thomas Preud'homme <robotux@celest.fr>
To: 679123-close@bugs.debian.org
Subject: Bug#679123: fixed in tcc 0.9.26~git20120612.ad5f375-4
Date: Wed, 27 Jun 2012 13:50:53 +0000
Source: tcc
Source-Version: 0.9.26~git20120612.ad5f375-4

We believe that the bug you reported is fixed in the latest version of
tcc, which is due to be installed in the Debian FTP archive:

libtcc-dev_0.9.26~git20120612.ad5f375-4_amd64.deb
  to main/t/tcc/libtcc-dev_0.9.26~git20120612.ad5f375-4_amd64.deb
tcc_0.9.26~git20120612.ad5f375-4.debian.tar.gz
  to main/t/tcc/tcc_0.9.26~git20120612.ad5f375-4.debian.tar.gz
tcc_0.9.26~git20120612.ad5f375-4.dsc
  to main/t/tcc/tcc_0.9.26~git20120612.ad5f375-4.dsc
tcc_0.9.26~git20120612.ad5f375-4_amd64.deb
  to main/t/tcc/tcc_0.9.26~git20120612.ad5f375-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 679123@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Preud'homme <robotux@celest.fr> (supplier of updated tcc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 27 Jun 2012 15:14:25 +0200
Source: tcc
Binary: tcc libtcc-dev
Architecture: source amd64
Version: 0.9.26~git20120612.ad5f375-4
Distribution: unstable
Urgency: low
Maintainer: Aurélien GÉRÔME <ag@debian.org>
Changed-By: Thomas Preud'homme <robotux@celest.fr>
Description: 
 libtcc-dev - fast library for dynamic code generation
 tcc        - small ANSI C compiler
Closes: 679123
Changes: 
 tcc (0.9.26~git20120612.ad5f375-4) unstable; urgency=low
 .
   * debian/patches:
     + Cherry-pick patch fixing incorrect shift result type (Closes: #679123).
   * debian/control:
     + Update Vcs-Browser URL.
Checksums-Sha1: 
 2b39dda4c4c198c3c5530055433dd6e7fc03c658 2129 tcc_0.9.26~git20120612.ad5f375-4.dsc
 1c4b87af06ad140146fcdc7c383be22c539863c4 13330 tcc_0.9.26~git20120612.ad5f375-4.debian.tar.gz
 d15e219e8f63b3f238c4eba088aa8a9d8b633e21 156796 tcc_0.9.26~git20120612.ad5f375-4_amd64.deb
 65761095b67f9f8f993418ae2d86f7212a26b791 135842 libtcc-dev_0.9.26~git20120612.ad5f375-4_amd64.deb
Checksums-Sha256: 
 a00a0f9d84807f35ca90d147b238d7d6dbdaf04ae3b146bdc08106a659425e3f 2129 tcc_0.9.26~git20120612.ad5f375-4.dsc
 a5581ca8bac43adb8db656377b8b0f8831d01bd5a274c01639a41542a41c9549 13330 tcc_0.9.26~git20120612.ad5f375-4.debian.tar.gz
 600d1618ebdf54a9291d11d6a491b634ce61a0c8887a643c12aa4ac46d77955a 156796 tcc_0.9.26~git20120612.ad5f375-4_amd64.deb
 df91c3fe665d8dd5a5d7d8438bcfef4e0410df39ba1c1318285340557e6f5c10 135842 libtcc-dev_0.9.26~git20120612.ad5f375-4_amd64.deb
Files: 
 72fe75902a7496cb83ef2962e886050e 2129 devel optional tcc_0.9.26~git20120612.ad5f375-4.dsc
 bec8be0c19ed13189258b1bf1c73ec85 13330 devel optional tcc_0.9.26~git20120612.ad5f375-4.debian.tar.gz
 a82e23fbcab11b8fc039e99ddce5ecb3 156796 devel optional tcc_0.9.26~git20120612.ad5f375-4_amd64.deb
 c6b9ba10cd21b4ff7913ab5cabdacd7a 135842 libdevel optional libtcc-dev_0.9.26~git20120612.ad5f375-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJP6we6AAoJENADhS+9UlKemFcQALgCsGSwtbDWF/ZqC3cAQQxp
MuO8P0olqJs4YBt7xgD+xl/5YB0FviYKQsM99fCcmXaToop0xaZXyVaaK2J9s/1J
D/clTV07Yy4IyRgtP17NMj/jA/Gg2wFmbNwyJhSb06156JpdwxCS/O7q6AIbOpFP
Tb00RkgtIdWYIAfLk1PgPR3I53LWCW/wYDLuWPtSWUf9wCibRsSOfL5JVu83Ix3F
LQaGOO5M6umO3JG7k6/SJuZsD1HC9tM9/LqZ5HneNoV2a13rZ4I/xY0geErAQQNJ
RFEUszrQswcyVPnyGKrMLX93t4hYqV8x/Y6EfcQ2EymJEbkf2qT5sCTn9JdRCMOK
t8IrPZrC1oJ4XEkSIfkWDSOAO7nKSW7ELaeVkXwPQnlnOI8bIe2/LamFUwcS+jwX
fK0Jn9me6w8T5p6vKZ+me1YsydaknoQk34WJvLeJsQw9j54CFX8v4tlgk3yEpKl+
3tjomgA0/dezPnfg7lsY3GUnb2XDfH+QkxM7nflIUBWj66bjKZPXkp+IUnnvC43d
OdLWznMXfDdAGAxkDeI41mF5WippBoy/lYsnfjiywE5Mbfpk/VkB7dZXU0jgQK+T
aNX4JS4EGQNHutqNH0Ngn8SUIPJP4MHBUkwK4Gw2I44F0RL2qg+FR9lqBxIdUkyt
uyF51kIDMfqCxXxLoSqf
=7zpJ
-----END PGP SIGNATURE-----

Information forwarded to debian-bugs-dist@lists.debian.org, Aurélien GÉRÔME <ag@debian.org>:
Bug#679123; Package tcc. (Fri, 06 Jul 2012 12:43:08 GMT) (full text, mbox, link).

Acknowledgement sent to Vincent Lefevre <vincent@vinc17.net>:
Extra info received and forwarded to list. Copy sent to Aurélien GÉRÔME <ag@debian.org>. (Fri, 06 Jul 2012 12:43:13 GMT) (full text, mbox, link).

Message #34 received at 679123@bugs.debian.org (full text, mbox, reply):

From: Vincent Lefevre <vincent@vinc17.net>
To: 679123@bugs.debian.org
Subject: Re: Bug#679123: tcc: Incorrect shift result type with 64-bit ABI
Date: Fri, 6 Jul 2012 14:40:31 +0200
reopen 679123
found 679123 0.9.26~git20120612.ad5f375-4
thanks

On 2012-06-27 13:37:38 +0200, Vincent Lefevre wrote:
> I've written a patch (attached).

It was incorrect on an unsigned short first argument.
A new patch is available here:

http://repo.or.cz/w/tinycc.git/commitdiff/d27a0b35482b907357d76a9db4e0b18ec89cf979

and the tests (themselves tested with gcc) here:

http://repo.or.cz/w/tinycc.git/commitdiff/09b98a42a38b3c0bd6eb9de99dc8a4fc3951a760

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Bug reopened Request was from Vincent Lefevre <vincent@vinc17.net> to control@bugs.debian.org. (Fri, 06 Jul 2012 12:43:19 GMT) (full text, mbox, link).

No longer marked as fixed in versions tcc/0.9.26~git20120612.ad5f375-4. Request was from Vincent Lefevre <vincent@vinc17.net> to control@bugs.debian.org. (Fri, 06 Jul 2012 12:43:20 GMT) (full text, mbox, link).

Marked as found in versions tcc/0.9.26~git20120612.ad5f375-4. Request was from Vincent Lefevre <vincent@vinc17.net> to control@bugs.debian.org. (Fri, 06 Jul 2012 12:43:20 GMT) (full text, mbox, link).

Added tag(s) pending. Request was from "Thomas Preud'homme" <robotux@celest.fr> to control@bugs.debian.org. (Fri, 06 Jul 2012 14:24:03 GMT) (full text, mbox, link).

Reply sent to Thomas Preud'homme <robotux@celest.fr>:
You have taken responsibility. (Mon, 09 Jul 2012 13:51:22 GMT) (full text, mbox, link).

Notification sent to Vincent Lefevre <vincent@vinc17.net>:
Bug acknowledged by developer. (Mon, 09 Jul 2012 13:51:22 GMT) (full text, mbox, link).

Message #47 received at 679123-close@bugs.debian.org (full text, mbox, reply):

From: Thomas Preud'homme <robotux@celest.fr>
To: 679123-close@bugs.debian.org
Subject: Bug#679123: fixed in tcc 0.9.26~git20120612.ad5f375-5
Date: Mon, 09 Jul 2012 13:47:27 +0000
Source: tcc
Source-Version: 0.9.26~git20120612.ad5f375-5

We believe that the bug you reported is fixed in the latest version of
tcc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 679123@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Preud'homme <robotux@celest.fr> (supplier of updated tcc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 08 Jul 2012 17:36:15 +0200
Source: tcc
Binary: tcc libtcc-dev
Architecture: source amd64
Version: 0.9.26~git20120612.ad5f375-5
Distribution: unstable
Urgency: low
Maintainer: Thomas Preud'homme <robotux@celest.fr>
Changed-By: Thomas Preud'homme <robotux@celest.fr>
Description: 
 libtcc-dev - fast library for dynamic code generation
 tcc        - small ANSI C compiler
Closes: 677782 679123
Changes: 
 tcc (0.9.26~git20120612.ad5f375-5) unstable; urgency=low
 .
   * debian/patches:
     + Correctly handle integer promotion in patch fixing incorrect shift
       result type (Closes: #679123).
   * debian/control:
     + Set myself as Maintainer instead of Aurélien Gérôme as a result of him
       being MIA (Closes: #677782).
Checksums-Sha1: 
 ab42eeb3a84c7a697aa4796559c7d19b25ea46ed 2093 tcc_0.9.26~git20120612.ad5f375-5.dsc
 49e5bd4969e332b8f0b0f4b069e64c477409c4a4 13459 tcc_0.9.26~git20120612.ad5f375-5.debian.tar.gz
 eec421098fd6b77c03b0ca788f5b6429a7563576 156876 tcc_0.9.26~git20120612.ad5f375-5_amd64.deb
 d1389b00474bd57c53fe4a44dee3d067129a1a96 135932 libtcc-dev_0.9.26~git20120612.ad5f375-5_amd64.deb
Checksums-Sha256: 
 f8d1d50c891049a0a9b8bb278ed1bf88066edea77d572d9324e20c7dd08bef3d 2093 tcc_0.9.26~git20120612.ad5f375-5.dsc
 2da29dbd2163bd8dfd54e7fcf7b849eed31578cd578e44ca8351def5d6232621 13459 tcc_0.9.26~git20120612.ad5f375-5.debian.tar.gz
 263095a011ac5c3c7189766ab2e43dbf30087e1b28b1dcb59c6c1d290eae9d91 156876 tcc_0.9.26~git20120612.ad5f375-5_amd64.deb
 16b079467a329428b9ab37ca1e076fd7d2991c508ba5eb76a31179cd4139aabf 135932 libtcc-dev_0.9.26~git20120612.ad5f375-5_amd64.deb
Files: 
 dd0a8cf2804a6c8d2cbb9dc9d89cd466 2093 devel optional tcc_0.9.26~git20120612.ad5f375-5.dsc
 c63b4afe4e48e87e8746093d808591b6 13459 devel optional tcc_0.9.26~git20120612.ad5f375-5.debian.tar.gz
 7eef1e1022a894b80ccfcfebbc3505fa 156876 devel optional tcc_0.9.26~git20120612.ad5f375-5_amd64.deb
 5d02588bd2e444e75b9e37b1b4f60391 135932 libdevel optional libtcc-dev_0.9.26~git20120612.ad5f375-5_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJP+t2HAAoJENADhS+9UlKeZF4P/046JMwsfVpCqrxbW0f0B3jo
hfXR2Mij3A8gVnhYEu+YIUph2oEulfQa0d3wQDAWJVVmqduPoPZNzze/lKrQhIYf
NyFiYFPdtWit15804riCv3FcCreLvJbyzRiRwrHA5HO/DD78Q70UZJPTmsAOcSLF
lRAWCOUk7apirdWi8bhjsrHrCDF/2vPSz7KZYZp3mEhbztknx4Ct+R2LqqU4SIDC
XBE8A7y2yDePqVQ8xZj/9eh+QaG8V+xnE8uUPv7bEN/60PfqevVLeJGsCRjJ9TaG
gcPoFCH38Qui2LkZ4q+qtdHC1+al0AvTobmqNcZj7WM8gHIaL/4r2QYlXyGdvDID
hrEMnGyOyix5iUYl+rkX0UPCm54FaVJ6fiL4ycxkimvIwfo93B6rBYuSk8V5CLSo
v0vgTBiETzrLxj8nCWYW960vLvTcKQfGiAH0j49/DZUYSpoDGf3RkmnM+POgqV4V
/NsE0OxtsDwLYQP9GmNxWbMTYcQAH/HUz93nQ8sRt6jPglXRsKd1+okoawFrckF3
cEfqR2L0Q6TzzvTLE5EvatvJmDCSt5Kx1AukZVM6VqWYEsk3nFK5286DCBFp0IqZ
7jU7oGCXPJLsB6lPL7rERUx5PZIORAZavmrLhIgiaHG/ZiQhIGkXqrlLt8nq9h55
4odbvyfwnLbHo5oeGWj/
=BBqV
-----END PGP SIGNATURE-----

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 22 Aug 2012 07:30:27 GMT) (full text, mbox, link).

Send a report that this bug log contains spam.

Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Jul 15 23:54:22 2021; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.