Debian Bug report logs - #663564
cups-filters: 'make clean' leaves some object files over

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: cups-filters: 'make clean' leaves some object files over

Date: Mon, 12 Mar 2012 10:43:24 +0100

[Message part 1 (text/plain, inline)]

Package: cups-filters
Version: 1.0.4-1
Severity: normal
Tags: patch upstream

Hi,

currently, 'make clean' -- if run from the top-level source directory -- does
not entirely clean the source tree but leaves some object files in the
filter/fontembed and pdftoopvp/oprs sub-directories around. This is especially
frustrating if you are trying to build the Debian package twice in a row, as
dpkg-source will complain about untrackable differences in the source tree. The
attached patch adds calls to the clean rules in these sub-directories to the
Makefiles in the containing directories.

Furthermore, the Makedefs file is on the one hand removed in the distclean rule
but on the other hand unconditionally included in all the Makefiles. This makes
it imposible to e.g. run the clean rule twice in a row. I have therefore
included a conditional to only include Makedefs if Make is *not* run for any of
the clean rules. Since each Makefile in the sub-directories also includes
Makedefs, I decided to merely touch it in the clean rule of the top-level
Makefile. So 'make clean' is at least idempotent if run from the top-level
Makefile.

 - Fabian



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (901, 'testing'), (501, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[make-clean.patch (text/x-diff, attachment)]

Message #10 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: 663564@bugs.debian.org

Subject: Re: Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Mon, 12 Mar 2012 10:53:22 +0100

[Message part 1 (text/plain, inline)]

An alternative approach, maybe less intrusive: Instead of touching 
Makedefs, define the correct actual dependency in the top-level 
Makefile. This will cause configure to be run when 'make distclean' is 
called twice in a row, which is a bit tedious, but at least it's not a 
hack anymore but a solution. ;)

[make-clean2.patch (text/x-diff, attachment)]

Message #15 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: 663564@bugs.debian.org

Subject: Re: Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Wed, 14 Mar 2012 12:09:56 +0100

Am 12.03.2012 10:53, schrieb Fabian Greffrath:
> An alternative approach, maybe less intrusive: Instead of touching
> Makedefs, define the correct actual dependency in the top-level
> Makefile. This will cause configure to be run when 'make distclean' is
> called twice in a row, which is a bit tedious, but at least it's not a
> hack anymore but a solution. ;)

Hey, this would have perfectly fit into the 1.0.5 release! ;)

 - Fabian

Message #20 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Fabian Greffrath <fabian@greffrath.com>, 663564@bugs.debian.org

Subject: Re: [Pkg-cups-devel] Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Wed, 14 Mar 2012 12:26:22 +0100

Fabian Greffrath [2012-03-14 12:09 +0100]:
> Hey, this would have perfectly fit into the 1.0.5 release! ;)

I spoke to Till before the upload, he has this in the pipeline for
1.0.6.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Message #25 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Martin Pitt <mpitt@debian.org>

Cc: 663564@bugs.debian.org

Subject: Re: [Pkg-cups-devel] Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Wed, 14 Mar 2012 12:31:25 +0100

Am 14.03.2012 12:26, schrieb Martin Pitt:
> I spoke to Till before the upload, he has this in the pipeline for
> 1.0.6.

Good to know, thanks!

 - Fabian

Message #30 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Till Kamppeter <till.kamppeter@gmail.com>

To: Fabian Greffrath <fabian@greffrath.com>, 663564@bugs.debian.org

Subject: Re: [Pkg-cups-devel] Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Wed, 14 Mar 2012 13:37:51 +0100

Fabian, thank you for the patch. I have applied your second patch to the 
upstream BZR repository now. It will be incluced from cups-filters 1.0.6 on.

   Till

On 03/12/2012 10:53 AM, Fabian Greffrath wrote:
> An alternative approach, maybe less intrusive: Instead of touching
> Makedefs, define the correct actual dependency in the top-level
> Makefile. This will cause configure to be run when 'make distclean' is
> called twice in a row, which is a bit tedious, but at least it's not a
> hack anymore but a solution. ;)

Message #35 received at 663564@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Till Kamppeter <till.kamppeter@gmail.com>

Cc: 663564@bugs.debian.org

Subject: Re: [Pkg-cups-devel] Bug#663564: Acknowledgement (cups-filters: 'make clean' leaves some object files over)

Date: Wed, 14 Mar 2012 14:02:53 +0100

Am 14.03.2012 13:37, schrieb Till Kamppeter:
> Fabian, thank you for the patch. I have applied your second patch to
> the upstream BZR repository now. It will be incluced from cups-filters
> 1.0.6 on.

Nice, thanks!

 - Fabian

Message #40 received at 663564-close@bugs.debian.org (full text, mbox, reply):

From: Till Kamppeter <till.kamppeter@gmail.com>

To: 663564-close@bugs.debian.org

Subject: Bug#663564: fixed in cups-filters 1.0.7-1

Date: Wed, 21 Mar 2012 08:48:12 +0000

Source: cups-filters
Source-Version: 1.0.7-1

We believe that the bug you reported is fixed in the latest version of
cups-filters, which is due to be installed in the Debian FTP archive:

cups-filters_1.0.7-1.debian.tar.gz
  to main/c/cups-filters/cups-filters_1.0.7-1.debian.tar.gz
cups-filters_1.0.7-1.dsc
  to main/c/cups-filters/cups-filters_1.0.7-1.dsc
cups-filters_1.0.7-1_amd64.deb
  to main/c/cups-filters/cups-filters_1.0.7-1_amd64.deb
cups-filters_1.0.7.orig.tar.gz
  to main/c/cups-filters/cups-filters_1.0.7.orig.tar.gz
libcupsfilters-dev_1.0.7-1_amd64.deb
  to main/c/cups-filters/libcupsfilters-dev_1.0.7-1_amd64.deb
libcupsfilters1_1.0.7-1_amd64.deb
  to main/c/cups-filters/libcupsfilters1_1.0.7-1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 663564@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Till Kamppeter <till.kamppeter@gmail.com> (supplier of updated cups-filters package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 21 Mar 2012 09:18:55 +0100
Source: cups-filters
Binary: libcupsfilters1 cups-filters libcupsfilters-dev
Architecture: source amd64
Version: 1.0.7-1
Distribution: unstable
Urgency: low
Maintainer: Debian CUPS Maintainers <pkg-cups-devel@lists.alioth.debian.org>
Changed-By: Till Kamppeter <till.kamppeter@gmail.com>
Description: 
 cups-filters - OpenPrinting CUPS Filters
 libcupsfilters-dev - OpenPrinting CUPS Filters - Development files for the library
 libcupsfilters1 - OpenPrinting CUPS Filters - Shared library
Closes: 663564
Changes: 
 cups-filters (1.0.7-1) unstable; urgency=low
 .
   * New upstream release
      - cups-filters 1.0.7 release
      - pdftops: Added debug mode for investigating PostScript printer
        incompatibilities and interpreter bugs. Now sending a job with
        "lpr -o psdebug" makes the filter sending uncompressed PostScript.
      - pdftops: Additional workaround for a bug in the PostsSript interpreters
        of Brother printers, calling Ghostscript with special command line
        options (LP: #955553).
      - pdftopdf: Correct handling of PJL output and page_log messages on
        native PDF printers and on printers using a driver after pdftopdf
        (including PostScript printers).
      - texttopdf: Full fontconfig support, several bug fixes and improvements
        to make the output work on more different PDF interpreters, including
        built-in interpreters in printers.
      - Fixed cupsfilters.drv PPD generator and rastertopclx filter to make the
        supported HP DesignJet printers actually work.
      - parallel backend: Use same method as CUPS to overcome infinite loop
        on side channel errors (LP: #936647, CUPS STR #4044).
      - "make clean" and "make distclesn" work also correctly now when called
        repeatedly (Closes: #663564).
Checksums-Sha1: 
 24c8ae07e81089bb2cb60f5ceee58885166d769b 2498 cups-filters_1.0.7-1.dsc
 5ccc87109c4ab861654f0b18e07f10332c4dca9a 1012840 cups-filters_1.0.7.orig.tar.gz
 f73e2769f54e72c9bf797f7c3752c1bf3658d84f 37565 cups-filters_1.0.7-1.debian.tar.gz
 ed1e770c7d46b31e6112293bb4b591f5ded1b12b 64660 libcupsfilters1_1.0.7-1_amd64.deb
 1a4e18b0b2a15e2bb6cc4cfba98a5539a2844be6 382314 cups-filters_1.0.7-1_amd64.deb
 8473e3d84e70d0f79f1c67998c8b57f30f0bd3c1 75896 libcupsfilters-dev_1.0.7-1_amd64.deb
Checksums-Sha256: 
 089b166f373b8d18b7bd401973e4da5b918a352948aa0ea129a75b8e6919d006 2498 cups-filters_1.0.7-1.dsc
 4c03b975683bed0defe259eb5ce5f27098d4ef99f50b594dc470bb864c6de4e6 1012840 cups-filters_1.0.7.orig.tar.gz
 8e5ca9b758d6193d014df6c53ac10e1c833210381658cc388049aea850a490c5 37565 cups-filters_1.0.7-1.debian.tar.gz
 8298811f10cc5fb85c65511729bce173a3fd830406a63d845bbe323fd9596d42 64660 libcupsfilters1_1.0.7-1_amd64.deb
 2811136e445f70f6d18ae42bdb61eff264d58767639d68cc47dd0575eb118a2f 382314 cups-filters_1.0.7-1_amd64.deb
 8ea57619d59168bff407e6a5f5b00ceb311323ac4bd2bf0865438fd0feaeaf09 75896 libcupsfilters-dev_1.0.7-1_amd64.deb
Files: 
 6281fccddfc0b3b1b939a33257d805e2 2498 net optional cups-filters_1.0.7-1.dsc
 1037acd80b23a4becb740fd532fff5a8 1012840 net optional cups-filters_1.0.7.orig.tar.gz
 32b7383718ed75a236d878fa04e9c54e 37565 net optional cups-filters_1.0.7-1.debian.tar.gz
 fccbcfebe850f28984edf49dfb3f1d2c 64660 libs optional libcupsfilters1_1.0.7-1_amd64.deb
 03752b7e84e0bbae7d5fead1f53a6e50 382314 net optional cups-filters_1.0.7-1_amd64.deb
 498dee45f0920d081b9d60d5b64f164c 75896 libdevel optional libcupsfilters-dev_1.0.7-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPaY+fAAoJEPmIJawmtHufAYAP/2aufqVzFhaocPSfiwF1+mit
YWPEq18R3sTGQYzBd/81k08aS4AhRiRxWbcYWrR6J9gmvRi589xK4+UuicpncCXX
lh1J5QLbcGXzmBpuXpY3MfOLC2uhYkajQP0bY0ELDdMQX9ab4xUPj5HODCM4gZYY
YyQxDeSPc+HiDuLPbDwZXwXOmAnNaXN8WNXVqoPgtfkTRsNe6CUy8jbOOTFQzABq
Ha17EKhgh4qfqUB/V0gTzGy6NzOUI//fKsIzC0iKSKXzecnHcbAgxQrJou4finB5
oWQM8UMIKnKcLvm3/PJWj4sJE2+ZkRiP1Jfpl3c1DblTDlLdORk3E1EATMmL+XLQ
vHM/eLfMGH/bn65adLC7JgM72NQ5RE+U2Vh2d18OxjGagj2/Ti2IvoPQWWpfF001
5M/R0wqP39kc3WywNYfI7jtBX8UERAPU4LxDRyQl4m55XseuZFJSoQYI2ud2/TPb
zZ3SF3CVdM7n9TL45HcRVS7Wv65xq37x9vftipVJn5kYfV0HLiaUw3F4t744mNBO
raF+LtVUgvOFaa5dNotP0ZGB3xYPXUqSlUd38ErSLKOtEl0dOSro1L8h2stULWZB
O+8uXnXjBoXLB29IwU4bfaaDmp2CBaRZMeynqia5itUgVRWWegbvRE9/4wVijK3a
23PqNI3GdY/4A/BitLls
=KV9d
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.