Debian Bug report logs - #662300
egoboo: left and up movement does not work

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Erik Werner <martinerikwerner@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: egoboo: left and up movement does not work

Date: Mon, 05 Mar 2012 04:26:32 +0100

Package: egoboo
Version: 1:2.8.1-1
Severity: important

Dear Maintainer,
It appears that egoboo does not parse the KEY_UP and KEY_LEFT actions properly, when pressing UP the character moves down and when pressing LEFT the character moves right, but the DOWN and RIGTH keys do what they should.

I have tested remapping to WASD for movement with the same effect, so something
is going wrong somewhere else...

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages egoboo depends on:
ii  egoboo-data               1:2.8.1-1
ii  libc6                     2.13-26
ii  libenet1a                 1.3.3-2
ii  libgl1-mesa-glx [libgl1]  7.11.2-1
ii  libglu1-mesa [libglu1]    7.11.2-1
ii  libphysfs1                2.0.2-5
ii  libsdl-image1.2           1.2.12-1
ii  libsdl-mixer1.2           1.2.12-1
ii  libsdl-ttf2.0-0           2.0.11-1
ii  libsdl1.2debian           1.2.15-1

egoboo recommends no packages.

egoboo suggests no packages.

-- no debconf information

Message #14 received at 662300@bugs.debian.org (full text, mbox, reply):

From: Martin Erik Werner <martinerikwerner@gmail.com>

To: 662300@bugs.debian.org

Subject: maybe-patch

Date: Sat, 10 Mar 2012 22:30:05 +0100

[Message part 1 (text/plain, inline)]

I think that upstream SVN commit 1490 may contain a fix for this,
however the upstream bug is set to fixed without explanation, and the
commit message is simply:

Author: zefz <zefz@8ff2ee9d-8245-0410-912a-a7eda06b689b>
Date:   Thu Feb 10 18:38:19 2011 +0000

    - Fixed camera controls not working
    - Various optimizations and code cleanup
    - Fixed numerous bugs
    
    note: I haven't been able to test if any of the joystick stuff works
since I do not own one myself!

So it's not particularly helpful...

My guess is based on the change diffs, and this thread about the issue:
http://egoboo.sourceforge.net/forum/viewtopic.php?t=1177

-- 
Martin Erik Werner <martinerikwerner@gmail.com>

[signature.asc (application/pgp-signature, inline)]

Message #21 received at 662300@bugs.debian.org (full text, mbox, reply):

From: Martin Erik Werner <martinerikwerner@gmail.com>

To: 662300@bugs.debian.org

Cc: control <control@bugs.debian.org>

Subject: Patch to fix left-up movement bug

Date: Mon, 12 Mar 2012 04:18:41 +0100

[Message part 1 (text/plain, inline)]

tags 662300 + patch

Here is a patch which fixes this issue for me, it is based on a
suggestion at
http://egoboo.sourceforge.net/phpBB3/viewtopic.php?f=3&t=1177&p=61333#p61333, see the DEP-3 header for more information.

Please consider applying it.

Thanks.
-- 
Martin Erik Werner <martinerikwerner@gmail.com>

[fix-movement-bug.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 662300@bugs.debian.org (full text, mbox, reply):

From: Kalle Olavi Niemitalo <kon@iki.fi>

To: 662300@bugs.debian.org

Subject: Re: Bug#662300: Patch to fix left-up movement bug

Date: Tue, 15 May 2012 10:11:06 +0300

[Message part 1 (text/plain, inline)]

Martin Erik Werner <martinerikwerner@gmail.com> writes:

> Here is a patch which fixes this issue for me, it is based on a
> suggestion at
> http://egoboo.sourceforge.net/phpBB3/viewtopic.php?f=3&t=1177&p=61333#p61333, see the DEP-3 header for more information.

That patch adds casts to two control_is_pressed subtractions in
set_one_player_latch.  However, the bug also occurs in three
statements in camera_move.  IIRC, this causes sprites to
disappear when you try to rotate the camera.  Instead of adding
casts to each of those calls, I recommend changing
control_is_pressed so it returns int.

In https://egoboo.svn.sourceforge.net/svnroot/egoboo/branches/2.8.x/,
control_is_pressed has been renamed to input_device_control_active,
and game/camera.c and game/game.c no longer do arithmetic with its
return values.

[Message part 2 (application/pgp-signature, inline)]

Message #33 received at 662300@bugs.debian.org (full text, mbox, reply):

From: Martin Erik Werner <martinerikwerner@gmail.com>

To: 662300@bugs.debian.org

Subject: Re: Bug#662300: Patch to fix left-up movement bug

Date: Tue, 15 May 2012 12:24:47 +0200

[Message part 1 (text/plain, inline)]

On Tue, 2012-05-15 at 10:11 +0300, Kalle Olavi Niemitalo wrote:
> Martin Erik Werner <martinerikwerner@gmail.com> writes:
> 
> > Here is a patch which fixes this issue for me, it is based on a
> > suggestion at
> > http://egoboo.sourceforge.net/phpBB3/viewtopic.php?f=3&t=1177&p=61333#p61333, see the DEP-3 header for more information.
> 
> That patch adds casts to two control_is_pressed subtractions in
> set_one_player_latch.  However, the bug also occurs in three
> statements in camera_move.  IIRC, this causes sprites to
> disappear when you try to rotate the camera.  Instead of adding
> casts to each of those calls, I recommend changing
> control_is_pressed so it returns int.
> 
> In https://egoboo.svn.sourceforge.net/svnroot/egoboo/branches/2.8.x/,
> control_is_pressed has been renamed to input_device_control_active,
> and game/camera.c and game/game.c no longer do arithmetic with its
> return values.

Ah, a good idea, I was not aware of the other issues, I've modified the
patch to change the function to return ints instead. I've played through
a level with it and afaict it works as it should.

-- 
Martin Erik Werner <martinerikwerner@gmail.com>

[fix-up-left-movement-bug-v2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 662300-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 163629-done@bugs.debian.org,554320-done@bugs.debian.org,662258-done@bugs.debian.org,662280-done@bugs.debian.org,662300-done@bugs.debian.org,663529-done@bugs.debian.org,663604-done@bugs.debian.org,664126-done@bugs.debian.org,693870-done@bugs.debian.org,

Cc: egoboo@packages.debian.org, egoboo@packages.qa.debian.org

Subject: Bug#707930: Removed package(s) from unstable

Date: Fri, 17 May 2013 11:33:19 +0000

Version: 1:2.8.1-1+rm

Dear submitter,

as the package egoboo has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/707930

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)

Send a report that this bug log contains spam.