Debian Bug report logs - #659425
mgetty-fax: Uses perl4 corelibs without Depends

version graph

Package: mgetty-fax; Maintainer for mgetty-fax is Andreas Barth <aba@not.so.argh.org>; Source for mgetty-fax is src:mgetty.

Reported by: Dominic Hargreaves <dom@earth.li>

Date: Fri, 10 Feb 2012 23:54:01 UTC

Severity: normal

Found in version mgetty/1.1.36-1.6

Done: Andreas Barth <aba@ayous.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Fri, 10 Feb 2012 23:54:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dominic Hargreaves <dom@earth.li>:
New Bug report received and forwarded. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Fri, 10 Feb 2012 23:54:05 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Dominic Hargreaves <dom@earth.li>
To: submit@bugs.debian.org
Subject: mgetty-fax: Uses perl4 corelibs without Depends
Date: Fri, 10 Feb 2012 23:50:10 +0000
Package: mgetty-fax
Version: 1.1.36-1.6
Severity: normal
User: debian-perl@lists.debian.org
Usertags: perl4-corelibs

Dear maintainer,

This package currently uses one or more deprecated perl 4 era packages,
as shown on the lintian report[1]:

usr/sbin/faxrunqd:102 getopts.pl

As detailed at [2] we would like you to either add a dependency on

libperl4-corelibs-perl | perl (<< 5.12.3-7)

or (ideally) to replace their use with more modern equivalents.
We'd like to have this in place for wheezy, so that we can follow
cleanly the upstream deprecation cycle in wheezy+1.

If you prefer, I will NMU your package with the dependency added.

The wiki page [2] has references (taken from the source of the libraries
in question) for the recommended replacement libraries.

Thanks,
Dominic.

[1] <http://lintian.debian.org/tags/script-uses-perl4-libs-without-dep.html>
[2] <http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/Perl4CoreLibs>

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)




Information forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Sat, 11 Feb 2012 10:42:30 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andreas Barth <aba@ayous.org>:
Extra info received and forwarded to list. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Sat, 11 Feb 2012 10:42:35 GMT) Full text and rfc822 format available.

Message #10 received at 659425@bugs.debian.org (full text, mbox):

From: Andreas Barth <aba@ayous.org>
To: mgetty@muc.de
Cc: 659425@bugs.debian.org
Subject: faxrunqd uses getopts.pl
Date: Sat, 11 Feb 2012 10:41:42 +0100
Hi,

I received a bugreport that faxrunqd uses getops.pl, whereas modern
perl should use Getopt::Long or Getopt::Std.

Gert, what's your opinion on that? Do you want to take Getopt::* in
mgetty?


Andi


----- Forwarded message from Dominic Hargreaves <dom@earth.li> -----

From: Dominic Hargreaves <dom@earth.li>
Reply-To: Dominic Hargreaves <dom@earth.li>, 659425@bugs.debian.org
To: submit@bugs.debian.org
Subject: Bug#659425: mgetty-fax: Uses perl4 corelibs without Depends
Date: Fri, 10 Feb 2012 23:50:10 +0000

Package: mgetty-fax
Version: 1.1.36-1.6
Severity: normal
User: debian-perl@lists.debian.org
Usertags: perl4-corelibs

Dear maintainer,

This package currently uses one or more deprecated perl 4 era packages,
as shown on the lintian report[1]:

usr/sbin/faxrunqd:102 getopts.pl

As detailed at [2] we would like you to either add a dependency on

libperl4-corelibs-perl | perl (<< 5.12.3-7)

or (ideally) to replace their use with more modern equivalents.
We'd like to have this in place for wheezy, so that we can follow
cleanly the upstream deprecation cycle in wheezy+1.

If you prefer, I will NMU your package with the dependency added.

The wiki page [2] has references (taken from the source of the libraries
in question) for the recommended replacement libraries.

Thanks,
Dominic.

[1] <http://lintian.debian.org/tags/script-uses-perl4-libs-without-dep.html>
[2] <http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/Perl4CoreLibs>

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)





----- End forwarded message -----




Information forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Sat, 11 Feb 2012 12:07:08 GMT) Full text and rfc822 format available.

Acknowledgement sent to mgetty@muc.de:
Extra info received and forwarded to list. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Sat, 11 Feb 2012 12:07:16 GMT) Full text and rfc822 format available.

Message #15 received at 659425@bugs.debian.org (full text, mbox):

From: Gert Doering <gert@greenie.muc.de>
To: Andreas Barth <aba@ayous.org>, mgetty@muc.de, 659425@bugs.debian.org
Subject: Re: faxrunqd uses getopts.pl
Date: Sat, 11 Feb 2012 13:03:12 +0100
Hi,

On Sat, Feb 11, 2012 at 12:46:35PM +0100, Gert Doering wrote:
> On Sat, Feb 11, 2012 at 10:41:42AM +0100, Andreas Barth wrote:
> > I received a bugreport that faxrunqd uses getops.pl, whereas modern
> > perl should use Getopt::Long or Getopt::Std.
> > 
> > Gert, what's your opinion on that? Do you want to take Getopt::* in
> > mgetty?
> 
> I was young and didn't know better :-)

Uh.

Now *how* old exactly is the mgetty version in Debian...?

faxrunqd's CVS history lists...

# Revision 1.58  2002/03/19 12:20:45  gert      
# change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

gert

-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             gert@greenie.muc.de
fax: +49-89-35655025                        gert@net.informatik.tu-muenchen.de




Information forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Sat, 11 Feb 2012 12:07:40 GMT) Full text and rfc822 format available.

Acknowledgement sent to mgetty@muc.de:
Extra info received and forwarded to list. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Sat, 11 Feb 2012 12:07:54 GMT) Full text and rfc822 format available.

Message #20 received at 659425@bugs.debian.org (full text, mbox):

From: Gert Doering <gert@greenie.muc.de>
To: Andreas Barth <aba@ayous.org>, mgetty@muc.de, 659425@bugs.debian.org
Subject: Re: faxrunqd uses getopts.pl
Date: Sat, 11 Feb 2012 12:46:35 +0100
Hi,

On Sat, Feb 11, 2012 at 10:41:42AM +0100, Andreas Barth wrote:
> I received a bugreport that faxrunqd uses getops.pl, whereas modern
> perl should use Getopt::Long or Getopt::Std.
> 
> Gert, what's your opinion on that? Do you want to take Getopt::* in
> mgetty?

I was young and didn't know better :-)

Now, changing this to Getopt::Std is 10 minutes work, and I'm happy to
do so.  OTOH, getting a new release of mgetty out of the door is more
work (and I have a few pending changes that need to go in).

So what's easier for you?  Backport the patch (faxrunqd has changed
a bit since 1.1.37, so the patch might need a bit of adaption), or wait
for the next release?

gert

-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             gert@greenie.muc.de
fax: +49-89-35655025                        gert@net.informatik.tu-muenchen.de




Information forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Sat, 11 Feb 2012 12:36:22 GMT) Full text and rfc822 format available.

Acknowledgement sent to mgetty@muc.de:
Extra info received and forwarded to list. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Sat, 11 Feb 2012 12:36:25 GMT) Full text and rfc822 format available.

Message #25 received at 659425@bugs.debian.org (full text, mbox):

From: Gert Doering <gert@greenie.muc.de>
To: Andreas Barth <aba@ayous.org>, mgetty@muc.de, 659425@bugs.debian.org
Subject: Re: faxrunqd uses getopts.pl
Date: Sat, 11 Feb 2012 13:06:19 +0100
Hi,

On Sat, Feb 11, 2012 at 10:41:42AM +0100, Andreas Barth wrote:
> This package currently uses one or more deprecated perl 4 era packages,
> as shown on the lintian report[1]:
> 
> usr/sbin/faxrunqd:102 getopts.pl

Nothing better than automated source code "analysis" tools that just
grep for certain strings, and nobody that actually looks at the output...

Most likely, this is the CVS Log entry:

# Revision 1.58  2002/03/19 12:20:45  gert
# change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

(which is now in line 142, but could have been line 102 in 1.1.36)

Can someone teach this tool what a comment looks like, please?

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             gert@greenie.muc.de
fax: +49-89-35655025                        gert@net.informatik.tu-muenchen.de




Reply sent to Andreas Barth <aba@ayous.org>:
You have taken responsibility. (Sat, 11 Feb 2012 18:12:07 GMT) Full text and rfc822 format available.

Notification sent to Dominic Hargreaves <dom@earth.li>:
Bug acknowledged by developer. (Sat, 11 Feb 2012 18:12:07 GMT) Full text and rfc822 format available.

Message #30 received at 659425-done@bugs.debian.org (full text, mbox):

From: Andreas Barth <aba@ayous.org>
To: mgetty@muc.de
Cc: 659425-done@bugs.debian.org
Subject: Re: faxrunqd uses getopts.pl
Date: Sat, 11 Feb 2012 18:04:23 +0100
* Gert Doering (gert@greenie.muc.de) [120211 12:33]:
> Hi,
> 
> On Sat, Feb 11, 2012 at 12:46:35PM +0100, Gert Doering wrote:
> > On Sat, Feb 11, 2012 at 10:41:42AM +0100, Andreas Barth wrote:
> > > I received a bugreport that faxrunqd uses getops.pl, whereas modern
> > > perl should use Getopt::Long or Getopt::Std.
> > > 
> > > Gert, what's your opinion on that? Do you want to take Getopt::* in
> > > mgetty?
> > 
> > I was young and didn't know better :-)
> 
> Uh.
> 
> Now *how* old exactly is the mgetty version in Debian...?
> 
> faxrunqd's CVS history lists...
> 
> # Revision 1.58  2002/03/19 12:20:45  gert      
> # change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

Make that my fault for not checking the bugreport before forwarding it
to you.

Sorry, I assumed the perl team to be right when reporting the bug.

Closing the bug now, it's a false positive.


Andi




Information forwarded to debian-bugs-dist@lists.debian.org, Andreas Barth <aba@not.so.argh.org>:
Bug#659425; Package mgetty-fax. (Sun, 12 Feb 2012 11:30:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dominic Hargreaves <dom@earth.li>:
Extra info received and forwarded to list. Copy sent to Andreas Barth <aba@not.so.argh.org>. (Sun, 12 Feb 2012 11:30:04 GMT) Full text and rfc822 format available.

Message #35 received at 659425@bugs.debian.org (full text, mbox):

From: Dominic Hargreaves <dom@earth.li>
To: 659425@bugs.debian.org
Subject: Re: Bug#659425 closed by Andreas Barth <aba@ayous.org> (Re: faxrunqd uses getopts.pl)
Date: Sun, 12 Feb 2012 11:26:52 +0000
On Sat, Feb 11, 2012 at 06:12:07PM +0000, Debian Bug Tracking System wrote:

> Make that my fault for not checking the bugreport before forwarding it
> to you.
> 
> Sorry, I assumed the perl team to be right when reporting the bug.
> 
> Closing the bug now, it's a false positive.

Thanks, and sorry for not checking (I hadn't thought of people
putting comments in code about what it used to be like when designing
the lintian check :)

Cheers,
Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 12 Mar 2012 07:35:08 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Apr 24 20:57:59 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.