Debian Bug report logs - #659100
goplay: Avoid compile time warnings (patch from ubuntu)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: submit@bugs.debian.org

Subject: goplay: Avoid compile time warnings (patch from ubuntu)

Date: Wed, 08 Feb 2012 12:54:01 +0100

[Message part 1 (text/plain, inline)]

Package: goplay
Version: 0.4-1
Severity: normal
Tags: patch

I came across this patch in the Ubuntu package.  It get rid of some
compile time warnings.  Something to apply to the Debian version?
-- 
Happy hacking
Petter Reinholdtsen

[debian-changes-0.4-1ubuntu1 (text/x-patch, inline)]

Description: Upstream changes introduced in version 0.4-1ubuntu1
 This patch has been created by dpkg-source during the package build.
 Here's the last changelog entry, hopefully it gives details on why
 those changes were made:
 .
 goplay (0.4-1ubuntu1) maverick; urgency=low
 .
   * Merge from debian unstable.  Remaining changes:
     + src/pkgbrowser.cpp: Assign the return value from strtol() to an unused
       variable and mark it as unused.
 .
 The person named in the Author field signed this changelog entry.
Author: Michael Vogt <michael.vogt@ubuntu.com>

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>

--- goplay-0.4.orig/src/pkgbrowser.cpp
+++ goplay-0.4/src/pkgbrowser.cpp
@@ -303,7 +303,7 @@ int PackageBrowser::item_width(void *p)
 			case 'i': font = (Fl_Font)(font|FL_ITALIC); break;
 			case 'f': case 't': font = FL_COURIER; break;
 			case 'B':
-			case 'C': strtol(str, &str, 10); break;// skip a color number
+			case 'C': {long int __attribute__((unused)) unused = strtol(str, &str, 10);} break;// skip a color number
 			case 'F': font = (Fl_Font)strtol(str, &str, 10); break;
 			case 'S': tsize = strtol(str, &str, 10); break;
 			case '.': done = 1; break;
@@ -316,7 +316,7 @@ int PackageBrowser::item_width(void *p)
 	if (*str=='%' && '0'<=str[1] && str[1]<='9')
 	{
 		char *after;
-		/* int percent = */ strtol(str+1, &after, 10);
+		/* int percent = */ long int __attribute__((unused)) unused = strtol(str+1, &after, 10);
 		int steps = 0;
 		unsigned int bar = 0;
 		if (after && *after=='/')
@@ -384,7 +384,7 @@ void PackageBrowser::item_draw(void *p,
 						fl_rectf(x, y, w1, h);
 					}
 					else
-						strtol(str, &str, 10);
+						long int __attribute__((unused)) unused = strtol(str, &str, 10);
 					break;
 				case 'C': lcol = (Fl_Color)strtol(str, &str, 10); break;
 				case 'F': font = (Fl_Font)strtol(str, &str, 10); break;

Message #10 received at 659100-close@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@debian.org>

To: 659100-close@bugs.debian.org

Subject: Bug#659100: fixed in goplay 0.4-1.2

Date: Mon, 13 Feb 2012 23:02:25 +0000

Source: goplay
Source-Version: 0.4-1.2

We believe that the bug you reported is fixed in the latest version of
goplay, which is due to be installed in the Debian FTP archive:

goplay_0.4-1.2.debian.tar.gz
  to main/g/goplay/goplay_0.4-1.2.debian.tar.gz
goplay_0.4-1.2.dsc
  to main/g/goplay/goplay_0.4-1.2.dsc
goplay_0.4-1.2_i386.deb
  to main/g/goplay/goplay_0.4-1.2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659100@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated goplay package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 11 Feb 2012 22:40:08 +0000
Source: goplay
Binary: goplay
Architecture: source i386
Version: 0.4-1.2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 goplay     - games (and more) package browser using DebTags
Closes: 460921 470047 474603 490670 544532 615495 654733 659100
Changes: 
 goplay (0.4-1.2) unstable; urgency=low
 .
   * Non-maintainer upload based on NMU found on mentors.debian.net.
   * Add support for starting installed packages by clicking on the
     screen shot (Closes: #490670).
   * src/pkgbrowser.cpp: Assign the return value from strtol() to an
     unused variable and mark it as unused to avoid compiler warnings
     (Closes: #659100).  Patch from Michael Vogt and Ubuntu.
   * Make enough room for the "Already installed" text (Closes:
     #544532).  Patch by Timo Juhani Lindfors.
 .
 goplay (0.4-1.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Packaging update:
     - removed dh-buildinfo, autotools-dev
     + added missing build-deps, dh-autotools; build-deps optimised
     + compat and debhelper to version 9
     + default hardening (with the exception of fortify)
     + standards to 3.9.2
     + ept-cache replaced with apt-xapian-index in Depends
       (Closes: #615495 important:"goplay must be run as root at least
        once to function")
       (Closes: #460921 wishlist:"requires manual ept-cache reindex on
        the first start")
     + games-thumbnails moved to Recommends
       (Closes: #470047 wishlist:"please Recommends: games-thumbnails
        instead of Depends")
     + no longer depends on g++-4.5
       (Closes: #654733 important:"non-standard gcc/g++ used for build...")
     + build-time .xpm icon regeneration, no longer ship pre-built icon
       (imagemagick added to build-deps)
   * patch to introduce 'goscience' browser,
     thanks to Frederic Daniel Luc Lehobey
     (Closes: #474603 wishlist:"Please add a goscience browser")
   * debian/copyright:
     + updated list of contributors
     + little correction for DEP-5 compliance
Checksums-Sha1: 
 08ab0b5ad16daf8be74af1286aabe60564a85407 1226 goplay_0.4-1.2.dsc
 9b8aeba0df8a2702e1517fbdb6c78cf96252ea98 42303 goplay_0.4-1.2.debian.tar.gz
 5d9d0de499754854e4915768371805f298ea0061 264488 goplay_0.4-1.2_i386.deb
Checksums-Sha256: 
 cdebb9fbd2ce209b24148a8ceb4153ba9aa4b2d0d08533a27ff8eb7661b4e5bf 1226 goplay_0.4-1.2.dsc
 2981981eedb36170433d03ec9e3a9c9b4f4124034ef677504001682012af4ae2 42303 goplay_0.4-1.2.debian.tar.gz
 b1c3ed87509b5970286e9be6cb1d6f339adefccef86f16affe9a8f1168723b3f 264488 goplay_0.4-1.2_i386.deb
Files: 
 91c67542391474a22570c76c0280f6b7 1226 admin extra goplay_0.4-1.2.dsc
 15df8206f21d4b15b9d2997ce9dc6801 42303 admin extra goplay_0.4-1.2.debian.tar.gz
 dcc2976c59a115e13ce764e22e450442 264488 admin extra goplay_0.4-1.2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFPNu8x20zMSyow1ykRAoyAAKCY0adFcu4yv933jGKGfRu8LEhHKACdHc0n
4YqUxWaIkI6bOxfnMuSXJpU=
=gLUu
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.