Debian Bug report logs - #658954
Call-time pass-by-reference has been removed from php5 (>= 5.4)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ondřej Surý <ondrej@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Call-time pass-by-reference has been removed from php5 (>= 5.4)

Date: Mon, 06 Feb 2012 22:59:08 +0100

Package: php-imlib
Version: 0.7-3
Severity: important
User: pkg-php-maint@lists.alioth.debian.org
Usertags: php54

Dear maintainer,

package php-imlib currently fails to parse correctly with
PHP 5.4 with following error(s):

PHP Fatal error:  Call-time pass-by-reference has been removed in /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibImage.php on line 240
Errors parsing /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibImage.php
PHP Fatal error:  Call-time pass-by-reference has been removed in /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibPoly.php on line 150
Errors parsing /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibPoly.php
PHP Fatal error:  Call-time pass-by-reference has been removed in /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibText.php on line 105
Errors parsing /php-imlib-0.7-3/usr/share/php/Imlib/class.ImlibText.php

These error were generated by php in the lint mode.  To reproduce
please install php5-cli and run:

dpkg -L php-imlib | grep -E ".php[54]?" | xargs -i php -l {}

PHP 5.4 is planned to be included in wheezy, as such, this bug might
become RC if not fixed before 5.4 is uploaded to sid.

Thanks, 
--
Ondřej Surý <ondrej@debian.org>

-- System Information:
Debian Release: 6.0.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Message #14 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Steve Langasek <vorlon@debian.org>, 658954@bugs.debian.org

Subject: NMU for fixing #658954 (php-imlib)

Date: Wed, 09 May 2012 01:01:25 +0800

[Message part 1 (text/plain, inline)]

Hi,

Do you mind if I NMU php-imlib? The fix for "call-time
pass-by-reference" is quite trivial. I've attached the patch.

Cheers,

Thomas

[php-imlib_php54.patch (text/x-diff, attachment)]

Message #19 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Thomas Goirand <zigo@debian.org>

Cc: 658954@bugs.debian.org

Subject: Re: NMU for fixing #658954 (php-imlib)

Date: Wed, 9 May 2012 00:42:52 -0700

[Message part 1 (text/plain, inline)]

On Wed, May 09, 2012 at 01:01:25AM +0800, Thomas Goirand wrote:
> Do you mind if I NMU php-imlib? The fix for "call-time
> pass-by-reference" is quite trivial. I've attached the patch.

Yep, that's fine.  Thanks!

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org


> diff -u -N -r php-imlib-0.7/docs/class.ImlibImage.php php-imlib-0.7.new/docs/class.ImlibImage.php
> --- php-imlib-0.7/docs/class.ImlibImage.php	2001-01-10 08:22:19.000000000 +0000
> +++ php-imlib-0.7.new/docs/class.ImlibImage.php	2012-05-08 16:58:11.000000000 +0000
> @@ -237,7 +237,7 @@
>        if (!is_resource($this->id))
>           return false;
>  
> -      if (!imlib_dump_image($this->id,&$err,$quality))
> +      if (!imlib_dump_image($this->id,$err,$quality))
>           return false;
>        else
>           return true;
> diff -u -N -r php-imlib-0.7/docs/class.ImlibPoly.php php-imlib-0.7.new/docs/class.ImlibPoly.php
> --- php-imlib-0.7/docs/class.ImlibPoly.php	2001-01-09 19:53:21.000000000 +0000
> +++ php-imlib-0.7.new/docs/class.ImlibPoly.php	2012-05-08 16:58:41.000000000 +0000
> @@ -147,7 +147,7 @@
>        if (!is_resource($this->poly))
>           return false;
>  
> -      imlib_polygon_get_bounds($this->poly,&$x1,&$y1,&$x2,&$y2);
> +      imlib_polygon_get_bounds($this->poly,$x1,$y1,$x2,$y2);
>     }
>  
>     /**
> diff -u -N -r php-imlib-0.7/docs/class.ImlibText.php php-imlib-0.7.new/docs/class.ImlibText.php
> --- php-imlib-0.7/docs/class.ImlibText.php	2001-01-09 19:53:21.000000000 +0000
> +++ php-imlib-0.7.new/docs/class.ImlibText.php	2012-05-08 16:59:03.000000000 +0000
> @@ -102,7 +102,7 @@
>        if (!is_resource($this->fnt))
>           return false;
>  
> -      return imlib_get_text_size($this->fnt,$str,&$fw,&$fh,$dir);
> +      return imlib_get_text_size($this->fnt,$str,$fw,$fh,$dir);
>     }
>  
>     /**

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Steve Langasek <vorlon@debian.org>, 658954@bugs.debian.org

Subject: Proposed NMU

Date: Wed, 09 May 2012 18:19:51 +0800

[Message part 1 (text/plain, inline)]

Hi,

Having a deeper look, your php-imlib package is still using format 1.0,
which annoyed me. I've attached the changes which I propose to upload.
This changes to format 3.0 (quilt), puts the old patch into quilt
format, and adds my fix for the call-time pass-by-reference problem.

Please let me know if that's still ok to upload with these changes. I
believe it is, but I still think it's better to ask first... ;)

Cheers,

Thomas

[php-imlib-0.7-4_to_0.7-4.1.diff (text/x-diff, attachment)]

Message #29 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Thomas Goirand <zigo@debian.org>, 658954@bugs.debian.org

Subject: Re: Bug#658954: Proposed NMU

Date: Wed, 9 May 2012 07:53:20 -0700

[Message part 1 (text/plain, inline)]

On Wed, May 09, 2012 at 06:19:51PM +0800, Thomas Goirand wrote:
> Having a deeper look, your php-imlib package is still using format 1.0,
> which annoyed me. I've attached the changes which I propose to upload.
> This changes to format 3.0 (quilt), puts the old patch into quilt
> format, and adds my fix for the call-time pass-by-reference problem.

> Please let me know if that's still ok to upload with these changes. I
> believe it is, but I still think it's better to ask first... ;)

It is most definitely not ok.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Steve Langasek <vorlon@debian.org>

Cc: 658954@bugs.debian.org

Subject: Re: Bug#658954: Proposed NMU

Date: Wed, 09 May 2012 23:37:49 +0800

On 05/09/2012 10:53 PM, Steve Langasek wrote:
> On Wed, May 09, 2012 at 06:19:51PM +0800, Thomas Goirand wrote:
>> Having a deeper look, your php-imlib package is still using format 1.0,
>> which annoyed me. I've attached the changes which I propose to upload.
>> This changes to format 3.0 (quilt), puts the old patch into quilt
>> format, and adds my fix for the call-time pass-by-reference problem.
> 
>> Please let me know if that's still ok to upload with these changes. I
>> believe it is, but I still think it's better to ask first... ;)
> 
> It is most definitely not ok.

So, you prefer that I just apply the patch, and leave format 1.0 with
embedded patches?

Thomas

Message #39 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Thomas Goirand <zigo@debian.org>, 658954@bugs.debian.org

Subject: Re: Bug#658954: Proposed NMU

Date: Sun, 13 May 2012 13:29:51 -0700

[Message part 1 (text/plain, inline)]

On Wed, May 09, 2012 at 11:37:49PM +0800, Thomas Goirand wrote:
> On 05/09/2012 10:53 PM, Steve Langasek wrote:
> > On Wed, May 09, 2012 at 06:19:51PM +0800, Thomas Goirand wrote:
> >> Having a deeper look, your php-imlib package is still using format 1.0,
> >> which annoyed me. I've attached the changes which I propose to upload.
> >> This changes to format 3.0 (quilt), puts the old patch into quilt
> >> format, and adds my fix for the call-time pass-by-reference problem.

> >> Please let me know if that's still ok to upload with these changes. I
> >> believe it is, but I still think it's better to ask first... ;)

> > It is most definitely not ok.

> So, you prefer that I just apply the patch, and leave format 1.0 with
> embedded patches?

Yes.  This is the normal thing to do when NMUing a package.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

[signature.asc (application/pgp-signature, inline)]

Message #48 received at 658954@bugs.debian.org (full text, mbox, reply):

From: Luk Claes <luk@debian.org>

To: 658954@bugs.debian.org

Subject: php-imlib: diff for NMU version 0.7-4.1

Date: Thu, 5 Jul 2012 01:31:15 +0200

[Message part 1 (text/plain, inline)]

tags 658954 + patch
tags 658954 + pending
thanks

Dear Steve,

I've prepared an NMU for php-imlib (versioned as 0.7-4.1) with
Thomas' first patch and will have it uploaded soon.

Cheers

Luk

[php-imlib-0.7-4.1-nmu.diff (text/x-diff, attachment)]

Message #53 received at 658954-close@bugs.debian.org (full text, mbox, reply):

From: Luk Claes <luk@debian.org>

To: 658954-close@bugs.debian.org

Subject: Bug#658954: fixed in php-imlib 0.7-4.1

Date: Thu, 05 Jul 2012 00:17:29 +0000

Source: php-imlib
Source-Version: 0.7-4.1

We believe that the bug you reported is fixed in the latest version of
php-imlib, which is due to be installed in the Debian FTP archive:

php-imlib_0.7-4.1.diff.gz
  to main/p/php-imlib/php-imlib_0.7-4.1.diff.gz
php-imlib_0.7-4.1.dsc
  to main/p/php-imlib/php-imlib_0.7-4.1.dsc
php-imlib_0.7-4.1_i386.deb
  to main/p/php-imlib/php-imlib_0.7-4.1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 658954@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luk Claes <luk@debian.org> (supplier of updated php-imlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 04 Jul 2012 23:08:46 +0000
Source: php-imlib
Binary: php-imlib
Architecture: source i386
Version: 0.7-4.1
Distribution: unstable
Urgency: low
Maintainer: Steve Langasek <vorlon@debian.org>
Changed-By: Luk Claes <luk@debian.org>
Description: 
 php-imlib  - PHP Imlib2 Extension
Closes: 658954
Changes: 
 php-imlib (0.7-4.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Remove pass by references (Closes: #658954).
Checksums-Sha1: 
 1a482c7666b70d9df886f42eb6371cbc4aa1a8c1 1179 php-imlib_0.7-4.1.dsc
 31ab3d861141670e9bc7b2145a277910f4f7a301 5839 php-imlib_0.7-4.1.diff.gz
 b9921f694070b93354800567ff7fe594500c11b6 33932 php-imlib_0.7-4.1_i386.deb
Checksums-Sha256: 
 1202e69f690b258c6cf9004d6b5017e712d0d640eb41edfe6e8f37d8a761f65c 1179 php-imlib_0.7-4.1.dsc
 2d182ed78ea14aeda64435e20ce33238f4558e7058d32f5f020105ab446d86cf 5839 php-imlib_0.7-4.1.diff.gz
 4300c9797eb4cd7a5353368771e6607e5c7a8ff93dce007e99869661e6d16067 33932 php-imlib_0.7-4.1_i386.deb
Files: 
 d9ab77bcb69ccb6b9f7b8cfe6c6327c4 1179 php optional php-imlib_0.7-4.1.dsc
 a6696b08eccbd0706184e878996947cc 5839 php optional php-imlib_0.7-4.1.diff.gz
 5762f4c75eda9ff508a3ca2cef1f1af3 33932 php optional php-imlib_0.7-4.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk/02YwACgkQ+C5cwEsrK57piACeJw/NMw3hR7bCL2lAbggoY/Ps
Za0Anj80afRpmxoXDZLmtp78J9uG/kKf
=/ARY
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.