Debian Bug report logs - #657715
copyfiles should create non-existent target directories

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Marc Haber <mh+debian-packages@zugschlus.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: copyfiles should create non-existent target directories

Date: Sat, 28 Jan 2012 11:13:10 +0100

Package: schroot
Version: 1.4.24-1
Severity: wishlist

Hi,

when copying a file from a non-standard directory via the copyfiles
mechanism, this does not work:

$ schroot --begin-session --chroot=squeeze_build64 --session=build
E: 20copyfiles: cp: cannot create regular file `/var/lib/schroot/mount/build/etc/apt/apt.keys.input/zg20110.debian.zugschlus.de': No such file or directory
E: build: Chroot setup failed: stage=setup-start

Manually creating /var/lib/schroot/mount/build/etc/apt/apt.keys.input
inside the chroot fixes this issue.

The copyfiles mechanism should create target directories, if necessary.

Btw, just giving the directory /etc/apt/apt.keys.input in a copyfiles
file, this causes the directory with its entire contents to be copied
to the target. I am not sure whether this is the intended behavior. If
so, it should be documented, and copyfiles is kind of a misnomer for
this feature.

Greetings
Marc

Message #10 received at 657715@bugs.debian.org (full text, mbox, reply):

From: Roger Leigh <rleigh@codelibre.net>

To: Marc Haber <mh+debian-packages@zugschlus.de>, 657715@bugs.debian.org

Subject: Re: [buildd-tools-devel] Bug#657715: copyfiles should create non-existent target directories

Date: Sat, 28 Jan 2012 10:36:41 +0000

On Sat, Jan 28, 2012 at 11:13:10AM +0100, Marc Haber wrote:
> when copying a file from a non-standard directory via the copyfiles
> mechanism, this does not work:
> 
> $ schroot --begin-session --chroot=squeeze_build64 --session=build
> E: 20copyfiles: cp: cannot create regular file `/var/lib/schroot/mount/build/etc/apt/apt.keys.input/zg20110.debian.zugschlus.de': No such file or directory
> E: build: Chroot setup failed: stage=setup-start
> 
> Manually creating /var/lib/schroot/mount/build/etc/apt/apt.keys.input
> inside the chroot fixes this issue.
> 
> The copyfiles mechanism should create target directories, if necessary.

This would make sense.  Would a "mkdir -p" be sufficient, or should we
take steps to preserve the ownership and perms of every directory in
the path in the chroot?

> Btw, just giving the directory /etc/apt/apt.keys.input in a copyfiles
> file, this causes the directory with its entire contents to be copied
> to the target. I am not sure whether this is the intended behavior. If
> so, it should be documented, and copyfiles is kind of a misnomer for
> this feature.

Non-regular files get copied with "cp -a", so this is intended.  I'll
add it to the documentation.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.

Message #15 received at 657715@bugs.debian.org (full text, mbox, reply):

From: Marc Haber <mh+debian-bugs@zugschlus.de>

To: Roger Leigh <rleigh@codelibre.net>

Cc: 657715@bugs.debian.org

Subject: Re: [buildd-tools-devel] Bug#657715: copyfiles should create non-existent target directories

Date: Sat, 28 Jan 2012 15:03:44 +0100

On Sat, Jan 28, 2012 at 10:36:41AM +0000, Roger Leigh wrote:
> This would make sense.  Would a "mkdir -p" be sufficient, or should we
> take steps to preserve the ownership and perms of every directory in
> the path in the chroot?

Frankly, I have no idea about that. Maybe one would to like find -type
d | xargs cp --preserve=all

Greetins
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 31958061
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 31958062

Send a report that this bug log contains spam.