Debian Bug report logs - #657145
dkms: leaves unowned empty directores, e.g. /lib/modules/$KVERS/updates, after removal

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dkms: leaves unowned empty directores, e.g. /lib/modules/$KVERS/updates, after removal

Date: Tue, 24 Jan 2012 13:24:30 +0100

Package: dkms
Version: 2.2.0.3-1
Severity: important
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

there are several packages failing the piuparts test because unowned
directories are left on the system. These directories were created by
dkms when a kernel module was built and installed.

An example from
http://piuparts.debian.org/sid/fail/west-chamber-dkms_20100405+svn20110916.r119-1.log

2m15.4s ERROR: FAIL: Package purging left files on system:
  /lib/modules/3.1.0-1-amd64	 owned by: linux-headers-3.1.0-1-amd64
  /lib/modules/3.1.0-1-amd64/updates	 not owned

or from
http://piuparts.debian.org/sid/fail/blktap-dkms_2.0.91-1.log

0m46.0s ERROR: FAIL: Package purging left files on system:
  /lib/modules/3.1.0-1-amd64	 owned by: linux-headers-3.1.0-1-amd64
  /lib/modules/3.1.0-1-amd64/extra	 not owned
  /lib/modules/3.1.0-1-amd64/kernel	 not owned

All these tests are done in a minimal chroot with some kernel headers
installed but usually no kernel installed.

Testing more intensively by always installing kernel headers even if the
*-dkms package does not depend on them makes all *-dkms packages fail
the piuparts test.

Cheers,

Andreas

Message #10 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: 657145@bugs.debian.org

Cc: Andreas Beckmann <debian@abeckmann.de>

Subject: [PATCH] remove the directory where the module was installed

Date: Mon, 25 Jun 2012 11:46:11 +0200

after removing a module try to remove the path (below
/lib/modules/KVERS) were the module was installed to cleanup any
remaining empty directories
Closes: #657145
---
 dkms |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/dkms b/dkms
index 042acc0..c96cd8f 100644
--- a/dkms
+++ b/dkms
@@ -1579,6 +1579,9 @@ do_uninstall()
 	    echo $" - Uninstallation"
 	    echo $"   - Deleting from: $install_tree/$1${real_dest_module_location}/"
 	    rm -f "$install_tree/$1${real_dest_module_location}/${dest_module_name[$count]}$module_suffix"
+	    dir_to_remove="${real_dest_module_location#/}"
+	    while [ "${dir_to_remove}" != "${dir_to_remove#/}" ]; do dir_to_remove="${dir_to_remove#/}" ; done
+	    (cd "$install_tree/$1" && rmdir --parents --ignore-fail-on-non-empty "${dir_to_remove}" || true)
 	    echo $" - Original module"
 	    if [[ -e $dkms_tree/$module/original_module/$1/$2/${dest_module_name[$count]}$module_suffix ]]; then
 		case "$running_distribution" in
-- 
1.7.10

Message #17 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: 666023@bugs.debian.org, 657145@bugs.debian.org

Cc: Holger Levsen <holger@layer-acht.org>

Subject: prepared NMU for dkms (2.2.0.3-1.1)

Date: Sat, 21 Jul 2012 16:29:46 +0200

Hi,

I've prepared a NMU for dkms fixing two issues and Hloger Levsen has
agreed to review and sponsor this and upload to a DELEAYED queue.

dkms (2.2.0.3-1.1) unstable; urgency=low

  * Non-maintainer upload.
  * Do not fail if /lib/modules does not exist.  (Closes: #666023)
  * Remove the directory where the module was installed.  (Closes: #657145)

 -- Andreas Beckmann <debian@abeckmann.de>  Thu, 19 Jul 2012 22:20:45 +0200


git://github.com/anbe42/dkms.git
(3 commits ahead of git://git.debian.org/pkg-dkms/dkms.git)

http://mentors.debian.net/package/dkms
http://mentors.debian.net/debian/pool/main/d/dkms/dkms_2.2.0.3-1.1.dsc


Andreas

Message #22 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Andreas Beckmann <debian@abeckmann.de>

Cc: 666023@bugs.debian.org, 657145@bugs.debian.org

Subject: Re: prepared NMU for dkms (2.2.0.3-1.1)

Date: Sat, 21 Jul 2012 10:20:21 -0600

Hi Andreas,

On Samstag, 21. Juli 2012, Andreas Beckmann wrote:
> dkms (2.2.0.3-1.1) unstable; urgency=low
> 
>   * Non-maintainer upload.
>   * Do not fail if /lib/modules does not exist.  (Closes: #666023)
>   * Remove the directory where the module was installed.  (Closes: #657145)

uploaded to delayed-2.
 

thanks for your work,
cheers,
	Holger

Message #27 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Andreas Beckmann <debian@abeckmann.de>, 666023@bugs.debian.org

Cc: 657145@bugs.debian.org, Holger Levsen <holger@layer-acht.org>

Subject: Re: Bug#666023: prepared NMU for dkms (2.2.0.3-1.1)

Date: Sat, 21 Jul 2012 19:28:16 +0200

[Message part 1 (text/plain, inline)]

On Sat, Jul 21, 2012 at 16:29:46 +0200, Andreas Beckmann wrote:

> Hi,
> 
> I've prepared a NMU for dkms fixing two issues and Hloger Levsen has
> agreed to review and sponsor this and upload to a DELEAYED queue.
> 
You need to send the diff to the log, not just your changelog entry.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Andreas Beckmann <debian@abeckmann.de>, 666023@bugs.debian.org

Cc: 657145@bugs.debian.org, Holger Levsen <holger@layer-acht.org>

Subject: Re: Bug#666023: prepared NMU for dkms (2.2.0.3-1.1)

Date: Sat, 21 Jul 2012 19:43:10 +0200

[Message part 1 (text/plain, inline)]

On Sat, Jul 21, 2012 at 19:28:16 +0200, Julien Cristau wrote:

> On Sat, Jul 21, 2012 at 16:29:46 +0200, Andreas Beckmann wrote:
> 
> > Hi,
> > 
> > I've prepared a NMU for dkms fixing two issues and Hloger Levsen has
> > agreed to review and sponsor this and upload to a DELEAYED queue.
> > 
> You need to send the diff to the log, not just your changelog entry.
                                  ^ bug

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 657145@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: Julien Cristau <jcristau@debian.org>

Cc: 666023@bugs.debian.org, 657145@bugs.debian.org, Holger Levsen <holger@layer-acht.org>

Subject: debdiff for dkms NMU 2.2.0.3-1.1

Date: Sat, 21 Jul 2012 22:44:33 +0200

[Message part 1 (text/plain, inline)]

On 2012-07-21 19:43, Julien Cristau wrote:
>> You need to send the diff to the log, not just your changelog entry.
>                                   ^ bug

ACK. debdiff attached.

Andreas

[dkms_2.2.0.3-1.1.debdiff (text/plain, attachment)]

Message #42 received at 657145-close@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <debian@abeckmann.de>

To: 657145-close@bugs.debian.org

Subject: Bug#657145: fixed in dkms 2.2.0.3-1.1

Date: Mon, 23 Jul 2012 16:32:14 +0000

Source: dkms
Source-Version: 2.2.0.3-1.1

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 657145@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <debian@abeckmann.de> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 19 Jul 2012 22:20:45 +0200
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.2.0.3-1.1
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Andreas Beckmann <debian@abeckmann.de>
Description: 
 dkms       - Dynamic Kernel Module Support Framework
Closes: 657145 666023
Changes: 
 dkms (2.2.0.3-1.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Do not fail if /lib/modules does not exist.  (Closes: #666023)
   * Remove the directory where the module was installed.  (Closes: #657145)
Checksums-Sha1: 
 de8c4abe068c3f73d4831ce2a5d5f52239c66f71 1969 dkms_2.2.0.3-1.1.dsc
 0311fc4a0ab217f26bf31ea713da18549d8badb5 14927 dkms_2.2.0.3-1.1.debian.tar.gz
 5172c616442d968ff8b9001581c27e79130e6c94 77194 dkms_2.2.0.3-1.1_all.deb
Checksums-Sha256: 
 5ae37adbe59404b46f6c9b1a64a58492ff227bb377120a0041afb11c2fd27fe2 1969 dkms_2.2.0.3-1.1.dsc
 9edbedde82051dc366096e2bb91ac0af3b72378b9653894f7da0ee3d0b761ba6 14927 dkms_2.2.0.3-1.1.debian.tar.gz
 993b9db5bba71971ba77c64ffa3f2cde281d7b397cebde24af115384a69d8c71 77194 dkms_2.2.0.3-1.1_all.deb
Files: 
 218570f94e0e767208085eba824c0a68 1969 kernel optional dkms_2.2.0.3-1.1.dsc
 5165ec213ff5018ff55a7c90801bfcba 14927 kernel optional dkms_2.2.0.3-1.1.debian.tar.gz
 734ae2e7572288009c252e18be6b771f 77194 kernel optional dkms_2.2.0.3-1.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIUAwUBUArWOAkauFYGmqocAQiBGQ/2PjhZj5ShgcFz9VCim8+o4uRJWvUJbr2T
TFnwp7aHCCT0Wg9ojEgQPN9wl6DGIHRSnreuGXzVaWoilXbnDrmbmMeAXccoYqUJ
l/HA9eRYW0+K71yWPEgGnV2omU/IGBiknl9WWfOrD6emf6SY7dayHSDvY2FbuQip
UvHIBqDqceT+/p6je8VNjYCG5yFOyWVxlEkvW8DfKpXYXSpPtQvJYrVb4VKzpoH8
sKVvSZ2oaWr/2NyukJQa7VnlkNLAUhqe3iP7v+Yv1IxYNgoqiEc30Bg1Bx19hBjy
Yxc+f3iOdUKDzq6oS+NEXc4xWlsNwu8lMbB+a31n4+WXHH8/uJnc4cY54GT2+C2k
yVrfynDfhMTMobWvu828aJM7j1AiwKlPmtENwJS60NermQmrEALW/PlxZRXXQVVq
3lbS1SxCwERHyI70bQIIT4xF7ligVXIuMXi8G9q3CAV6Kk8n7UCycxd963GsXuWs
qwffMEUauX9sgjzm/tWgcUEWVS5iir6ovbiiCMp7Jo/lV7nMK8a7/8Ms+viMCQQc
1yYT1QxqJtRhuD2ArMbzq9xsoTBpc/lUSrybO8thg8v2xJ1qVRBbI1PwgHeafHoT
7Er8o8tnL45HaqTbTUTf/hVtPEVSsBCijB9IVtUGhUKv++1jHLQNQrAlWjciQR3r
VmQhJS4QAg==
=r7tK
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.