Debian Bug report logs - #652942
dhcp hook runs reload on shutdown (after service has been stopped)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dhcp hook runs reload on shutdown (after service has been stopped)

Date: Thu, 22 Dec 2011 01:25:43 +0100

Package: samba-common
Version: 2:3.6.1-3
Severity: important

Hi,

if you are using ifupdown and dhcp to manage your network device,
you'll get the following message on shutdown

INIT: Switching to runlevel: 0
INIT: Sending processes the TERM signal
Using makefile-style concurrent boot in runlevel 0.
Stopping deferred execution scheduler: atd.
Stopping MTA: exim4_listener.
Stopping VirtualBox Additions.
Stopping Avahi mDNS/DNS-SD Daemon: avahi-daemon.
Stopping Samba daemons: nmbd smbd.
Asking all remaining processes to terminate...done.
All processes ended within 1 seconds...done.
Stopping enhanced syslogd: rsyslogd.
Deconfiguring network interfaces...Internet Systems Consortium DHCP Client 4.2.2
Copyright 2004-2011 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

Listening on LPF/eth0/08:00:27:6f:bd:96
Sending on   LPF/eth0/08:00:27:6f:bd:96
Sending on   Socket/fallback
DHCPRELEASE on eth0 to 10.0.2.2 port 67
invoke-rc.d: -----------------------------------------------------
invoke-rc.d: WARNING: 'invoke-rc.d samba reload' called
invoke-rc.d: during shutdown sequence.
invoke-rc.d: enabling safe mode: initscript policy layer disabled
invoke-rc.d: -----------------------------------------------------
Reloading /etc/samba/smb.conf: smbd only.
done.
Saving the system clock.
Deactivating swap...done.
Unmounting local filesystems...done.
Will now halt.


See how the reload happens after samba has already been stopped.
This reload seems to be triggered by the dhcp enter hook.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages samba-common depends on:
ii  debconf [debconf-2.0]  1.5.41
ii  ucf                    3.0025+nmu2

Versions of packages samba-common recommends:
ii  samba-common-bin  2:3.6.1-3

samba-common suggests no packages.

-- debconf information excluded

Message #10 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Christian PERRIER <bubulle@debian.org>

To: Michael Biebl <biebl@debian.org>, 652942@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#652942: dhcp hook runs reload on shutdown (after service has been stopped)

Date: Thu, 22 Dec 2011 07:01:23 +0100

[Message part 1 (text/plain, inline)]

Quoting Michael Biebl (biebl@debian.org):
> Package: samba-common
> Version: 2:3.6.1-3
> Severity: important
> 
> Hi,
> 
> if you are using ifupdown and dhcp to manage your network device,
> you'll get the following message on shutdown

Hello Michael,

Apart from the annoying messge displayed, do you see a specific
problem with this? My concern is that it might not be so simple to add
code in the hook meant to detect that the interface is released
*during shutdown* and not for some other reason. 

What's suggested here is not doing the reload when an interface DHCP
lease is released during system shutdown but we want to keep the
reload when the lease is released in other situations. This might be
somehow tricky (is there an environment variable or something like
this that could be tested in the script?).

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Roderich Schupp <roderich.schupp@googlemail.com>

To: 652942@bugs.debian.org

Subject: Re: Bug#652942: dhcp hook runs reload on shutdown

Date: Wed, 11 Jan 2012 12:12:09 +0100

Hi Michael and Christian,

while this problem is mildly annoying when using the traditional sysv
init system
it is a major PITA when using systemd.
Systemd turns "invoke-rc.d samba reload" into "systemctl reload samba.service"
which of course cannot work this far into the shutdown sequence.
But it hangs _several minutes_ at that point until apparently a timeout kicks in
and the shutdown proceeds. Sometimes it hangs indefinitely and I have
to resort to sysreq-O or the hardware power button.

Cheers, Roderich

Message #20 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Arthur Marsh <arthur.marsh@internode.on.net>

To: Debian Bug Tracking System <652942@bugs.debian.org>

Subject: Re: dhcp hook runs reload on shutdown (after service has been stopped)

Date: Fri, 03 Feb 2012 01:32:09 +1030

Package: samba-common
Version: 2:3.6.2-1
Followup-For: Bug #652942

Hi, this problem still occurs on both an i386 machine and an AMD64 machine,
causing a delay in shutdown/reboot.

Any further ideas/suggestions?

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.3.0-rc2 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages samba-common depends on:
ii  debconf [debconf-2.0]  1.5.41
ii  ucf                    3.0025+nmu2

Versions of packages samba-common recommends:
ii  samba-common-bin  2:3.6.2-1

samba-common suggests no packages.

-- debconf information:
  samba-common/encrypt_passwords: true
  samba-common/do_debconf: true
* samba-common/dhcp: false
* samba-common/workgroup: MSHOME
  samba-common/title:

Message #25 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Christian PERRIER <bubulle@debian.org>

To: 652942@bugs.debian.org, 652942-submitter@bugs.debian.org

Subject: Do we really need to reload samba in DHCP enter hook?

Date: Wed, 9 May 2012 10:05:42 +0200

[Message part 1 (text/plain, inline)]

I actually wonder whether we really need to reload the samba daemons
when doing our magic in smb.conf in DHCP enter/exit hooks.

Indeed, after discussing with Volker, this is probably useless as nmbd
never re-register with a new WINS server, so to make what we want we
need to *restart* nmbd, not reload it.

I would actually be in favor of *not* reloading /etc/init.d/samba at
all...until we find better way to handle this (such as kniwing when we
are in the shutdown/reboot process).

[signature.asc (application/pgp-signature, inline)]

Message #33 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivo.dedecker@ugent.be>

To: Christian PERRIER <bubulle@debian.org>, 652942@bugs.debian.org

Subject: Re: [Pkg-samba-maint] Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Mon, 18 Jun 2012 23:12:45 +0200

On Wed, May 09, 2012 at 10:05:42AM +0200, Christian PERRIER wrote:
> I actually wonder whether we really need to reload the samba daemons
> when doing our magic in smb.conf in DHCP enter/exit hooks.
> 
> Indeed, after discussing with Volker, this is probably useless as nmbd
> never re-register with a new WINS server, so to make what we want we
> need to *restart* nmbd, not reload it.
> 
> I would actually be in favor of *not* reloading /etc/init.d/samba at
> all...until we find better way to handle this (such as kniwing when we
> are in the shutdown/reboot process).

Christian,

If I understand you correctly, you want us to drop the entire dhcp hook? There
might still be time to do this before the freeze.

Does anybody think we should keep the hook?

Cheers,

Ivo

Message #38 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Christian PERRIER <bubulle@debian.org>

To: 652942@bugs.debian.org, vorlon@debian.org

Subject: Re: [Pkg-samba-maint] Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Tue, 19 Jun 2012 08:08:46 +0200

[Message part 1 (text/plain, inline)]

Quoting Ivo De Decker (ivo.dedecker@ugent.be):

> If I understand you correctly, you want us to drop the entire dhcp hook? There

Yes.

> might still be time to do this before the freeze.

Except that I'm much less in "samba mode" than I was in May, but
you're here to help in this, now..:-)

> Does anybody think we should keep the hook?

Just say "Steve, do you agree", it will be clearer..:-)

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivo.dedecker@ugent.be>

To: Christian PERRIER <bubulle@debian.org>, 652942@bugs.debian.org

Cc: vorlon@debian.org, control@bugs.debian.org

Subject: Re: Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Tue, 19 Jun 2012 22:36:54 +0200

[Message part 1 (text/plain, inline)]

tags 652942 patch
thanks

Christian,

On Tue, Jun 19, 2012 at 08:08:46AM +0200, Christian PERRIER wrote:
> > If I understand you correctly, you want us to drop the entire dhcp hook? There
> 
> Yes.
> 
> > might still be time to do this before the freeze.
> 
> Except that I'm much less in "samba mode" than I was in May, but
> you're here to help in this, now..:-)

That was my point :)
Anyway, patch attached.

> > Does anybody think we should keep the hook?
> Just say "Steve, do you agree", it will be clearer..:-)

:)

Steve, what do you think? And if you agree, could you have a quick look at the
patch? I think I did everything that's needed for the cleanup, but I might
have forgotten something...

Cheers,

Ivo

[samba-remove-dhcp-hook.patch (text/x-diff, attachment)]

Message #52 received at 652942-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 652942-close@bugs.debian.org

Subject: Bug#652942: fixed in samba 2:3.6.6-1

Date: Wed, 27 Jun 2012 05:33:32 +0000

Source: samba
Source-Version: 2:3.6.6-1

We believe that the bug you reported is fixed in the latest version of
samba, which is due to be installed in the Debian FTP archive:

libnss-winbind_3.6.6-1_i386.deb
  to main/s/samba/libnss-winbind_3.6.6-1_i386.deb
libpam-smbpass_3.6.6-1_i386.deb
  to main/s/samba/libpam-smbpass_3.6.6-1_i386.deb
libpam-winbind_3.6.6-1_i386.deb
  to main/s/samba/libpam-winbind_3.6.6-1_i386.deb
libsmbclient-dev_3.6.6-1_i386.deb
  to main/s/samba/libsmbclient-dev_3.6.6-1_i386.deb
libsmbclient_3.6.6-1_i386.deb
  to main/s/samba/libsmbclient_3.6.6-1_i386.deb
libwbclient-dev_3.6.6-1_i386.deb
  to main/s/samba/libwbclient-dev_3.6.6-1_i386.deb
libwbclient0_3.6.6-1_i386.deb
  to main/s/samba/libwbclient0_3.6.6-1_i386.deb
samba-common-bin_3.6.6-1_i386.deb
  to main/s/samba/samba-common-bin_3.6.6-1_i386.deb
samba-common_3.6.6-1_all.deb
  to main/s/samba/samba-common_3.6.6-1_all.deb
samba-dbg_3.6.6-1_i386.deb
  to main/s/samba/samba-dbg_3.6.6-1_i386.deb
samba-doc-pdf_3.6.6-1_all.deb
  to main/s/samba/samba-doc-pdf_3.6.6-1_all.deb
samba-doc_3.6.6-1_all.deb
  to main/s/samba/samba-doc_3.6.6-1_all.deb
samba-tools_3.6.6-1_i386.deb
  to main/s/samba/samba-tools_3.6.6-1_i386.deb
samba_3.6.6-1.debian.tar.gz
  to main/s/samba/samba_3.6.6-1.debian.tar.gz
samba_3.6.6-1.dsc
  to main/s/samba/samba_3.6.6-1.dsc
samba_3.6.6-1_i386.deb
  to main/s/samba/samba_3.6.6-1_i386.deb
samba_3.6.6.orig.tar.bz2
  to main/s/samba/samba_3.6.6.orig.tar.bz2
smbclient_3.6.6-1_i386.deb
  to main/s/samba/smbclient_3.6.6-1_i386.deb
swat_3.6.6-1_i386.deb
  to main/s/samba/swat_3.6.6-1_i386.deb
winbind_3.6.6-1_i386.deb
  to main/s/samba/winbind_3.6.6-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 652942@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated samba package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 27 Jun 2012 06:03:17 +0200
Source: samba
Binary: samba samba-common-bin samba-common samba-tools smbclient swat samba-doc samba-doc-pdf libpam-smbpass libsmbclient libsmbclient-dev winbind libpam-winbind libnss-winbind samba-dbg libwbclient0 libwbclient-dev
Architecture: source i386 all
Version: 2:3.6.6-1
Distribution: unstable
Urgency: low
Maintainer: Debian Samba Maintainers <pkg-samba-maint@lists.alioth.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description: 
 libnss-winbind - Samba nameservice integration plugins
 libpam-smbpass - pluggable authentication module for Samba
 libpam-winbind - Windows domain authentication integration plugin
 libsmbclient - shared library for communication with SMB/CIFS servers
 libsmbclient-dev - development files for libsmbclient
 libwbclient-dev - Samba winbind client library - development files
 libwbclient0 - Samba winbind client library
 samba      - SMB/CIFS file, print, and login server for Unix
 samba-common - common files used by both the Samba server and client
 samba-common-bin - common files used by both the Samba server and client
 samba-dbg  - Samba debugging symbols
 samba-doc  - Samba documentation
 samba-doc-pdf - Samba documentation in PDF format
 samba-tools - Samba testing utilities
 smbclient  - command-line SMB/CIFS clients for Unix
 swat       - Samba Web Administration Tool
 winbind    - Samba nameservice integration server
Closes: 629406 649100 652942 653382 658245 678741
Changes: 
 samba (2:3.6.6-1) unstable; urgency=low
 .
   [ Ivo De Decker ]
   * Only enable swat in inetd.conf on first install. Closes: #658245
   * Minor lintian fixes.
   * Remove DHCP hook. Closes: #652942, #629406, #649100
   * Don't reload smbd when running from inetd. Closes: #678741
   * Don't start smbd when guest account doesn't exist. Closes: #653382
   * Only export public symbols in libsmbclient and libwbclient.
 .
   [ Christian Perrier ]
   * New upstream version
Checksums-Sha1: 
 f65e1c5196911112415139ba6c6f9172b4cbb82d 3062 samba_3.6.6-1.dsc
 450371e613d867a2d42555998cd3e83a47014123 29464478 samba_3.6.6.orig.tar.bz2
 cec9f1da2b8f80dfa73bf45905f7a726f8a7b3b6 392010 samba_3.6.6-1.debian.tar.gz
 ae946bb79abd2a590be3c108aa56da8ac8a9737a 8339462 samba_3.6.6-1_i386.deb
 5b97ab7b97e42723cc9a957eaa287f34dd0f2904 6404650 samba-common-bin_3.6.6-1_i386.deb
 fe639be4422ab460916363b6e23468b3c8e663cc 381040 samba-common_3.6.6-1_all.deb
 2599f8ab41a8480f594b840efd9f705f831c664d 11942892 samba-tools_3.6.6-1_i386.deb
 0600dd46a6728307a63e099ae22da419221d4c18 14397738 smbclient_3.6.6-1_i386.deb
 ecc82354432fd04586227f270b9b2924c5bf71d9 2305944 swat_3.6.6-1_i386.deb
 0fed0d48458db637fbc01e4230b49f1053173e8e 6814026 samba-doc_3.6.6-1_all.deb
 6a84f17dde71768c0b7f41579f94fe021a384719 7061784 samba-doc-pdf_3.6.6-1_all.deb
 c4db9dceb718a712ccc9ea3b837ce0aa732d4ba7 867816 libpam-smbpass_3.6.6-1_i386.deb
 2ca6bec056828dbd7e1567d5ce9126acec8af13a 2065250 libsmbclient_3.6.6-1_i386.deb
 9becc1c32b04f325b42c09b8a01edd74abdb314b 2943920 libsmbclient-dev_3.6.6-1_i386.deb
 4fd57926339f9e00a08da67ae89e01a6ffbfe784 4606800 winbind_3.6.6-1_i386.deb
 9a7aef4aed054eb4a3a991c790e7777df36cdb0b 106214 libpam-winbind_3.6.6-1_i386.deb
 b118d52c7f90f7f44c30386c02faf9e594a550ff 696138 libnss-winbind_3.6.6-1_i386.deb
 1af159948339004d15316eca8c121e7f10fb1dad 67722054 samba-dbg_3.6.6-1_i386.deb
 f7b84958646bc50b1ff71a3fa6dc79dd24ae408d 99054 libwbclient0_3.6.6-1_i386.deb
 b95114790908683c6e20d15f0e2bfc04acdeb5a3 83666 libwbclient-dev_3.6.6-1_i386.deb
Checksums-Sha256: 
 8db12e5768cc6b4739e91e0eced0f32f58a579a98498b856434e9e8ab114d382 3062 samba_3.6.6-1.dsc
 1141eb5f173534db8f8d7dd1aa8fed53404d719e4a65c610f3ef62fdcad783e6 29464478 samba_3.6.6.orig.tar.bz2
 8088bbdc4900bdbc437ff59c85734bdaf108a66945d733eb53d81f33b7edd1b8 392010 samba_3.6.6-1.debian.tar.gz
 2ec8a06487d7306be9c5ce52a47787173bf3689ba42f38a7ce06627b8746fe3b 8339462 samba_3.6.6-1_i386.deb
 f45f33086b89167f11803421d621c2e4798c65a906d009aee51ba3f7fd7229cb 6404650 samba-common-bin_3.6.6-1_i386.deb
 bf62d57c16ba5ab9d7f72f7206de1140f876b9a723172cddb15235d37ca4559e 381040 samba-common_3.6.6-1_all.deb
 7f98c327487e5875c4dddad3ea40f22f7647a3da464fe177563e8f3f3f65a7cb 11942892 samba-tools_3.6.6-1_i386.deb
 a513e07cf3f61c9552ca52e91078be720f8825ae9bde6e72f085618d6a27844a 14397738 smbclient_3.6.6-1_i386.deb
 350ef4b362ab3a50cf8bcea14971cab7e9d4c9745cfcbf4a6dc767de65cdea6a 2305944 swat_3.6.6-1_i386.deb
 14e72f6fa8cd420fca673027a4f1d514a0ddd9e5dab6702e665df53d297ed81e 6814026 samba-doc_3.6.6-1_all.deb
 19c01a2abdfde84d792e674e7e2182c4c2c62aa4101ccee5b732a298f3783265 7061784 samba-doc-pdf_3.6.6-1_all.deb
 ab3e39620d1d39e307eb6b5c9bd72fbfc4d5a5a1bd5c7d68bbb58c231dc69651 867816 libpam-smbpass_3.6.6-1_i386.deb
 2a0905fc399eceec951c4ad3d22e11f9bec8780e13541a0a22b371d49800727f 2065250 libsmbclient_3.6.6-1_i386.deb
 34f12d25bf16880b91987868f6680801ca885e2512e399dc476cab74f392aeb9 2943920 libsmbclient-dev_3.6.6-1_i386.deb
 639dc5d8ca4145f75750a8af272f5b484ec9d6efc12b562c9c1ce4d8226f3f8a 4606800 winbind_3.6.6-1_i386.deb
 5cfd69013bcc54c9144a8840bad50bb011428e05fe7c78c930b597396e7cd34f 106214 libpam-winbind_3.6.6-1_i386.deb
 cc963d59c0e85e67e1025074703eb9891e3db820161b919561276a58798c8947 696138 libnss-winbind_3.6.6-1_i386.deb
 3b0a095a7683730e1703f5698b62596b81b8d52d8b5fe64d0289f1a7066a09cb 67722054 samba-dbg_3.6.6-1_i386.deb
 2909c8cbf0dac65df96318c3e65621f2e9bc6cd06730cb3b4ba4318e7ba51771 99054 libwbclient0_3.6.6-1_i386.deb
 3741c41562f229b6cb249a3defeb1fa2b5c2205da8c1074b98ac32334a64fff2 83666 libwbclient-dev_3.6.6-1_i386.deb
Files: 
 b2c410b358426ab8ca73796578936c65 3062 net optional samba_3.6.6-1.dsc
 46b07ed027657917413f6bfc7234db38 29464478 net optional samba_3.6.6.orig.tar.bz2
 6fdd25f370b3ccf0a0ec2dd58a185aa3 392010 net optional samba_3.6.6-1.debian.tar.gz
 28fa5076afd9de0f9a4524d8b674e2e0 8339462 net optional samba_3.6.6-1_i386.deb
 780f2f97bfff3dacb8d22a4b1a0101b3 6404650 net optional samba-common-bin_3.6.6-1_i386.deb
 55aab9a23e8fcd235853e0412a2bda63 381040 net optional samba-common_3.6.6-1_all.deb
 3befa07288a68788825a9ad8fd4de712 11942892 net optional samba-tools_3.6.6-1_i386.deb
 ef1a862b7307934017f34dc3a8b83ab4 14397738 net optional smbclient_3.6.6-1_i386.deb
 ea4110c32a35d07dda04e355b0768724 2305944 net optional swat_3.6.6-1_i386.deb
 aeecdc950eceba2f7c0f47105bc88f9f 6814026 doc optional samba-doc_3.6.6-1_all.deb
 65c244dec6e89d002c172e6be79c00d6 7061784 doc optional samba-doc-pdf_3.6.6-1_all.deb
 f03c067f9f976040f97b3e2f77414290 867816 admin extra libpam-smbpass_3.6.6-1_i386.deb
 a9c605e342fb08e57ca5f507386299c0 2065250 libs optional libsmbclient_3.6.6-1_i386.deb
 1a8b2c31e71f8c3ef2ffa62c4ab80400 2943920 libdevel extra libsmbclient-dev_3.6.6-1_i386.deb
 a38e5a44e184659ba28110d88d544fe5 4606800 net optional winbind_3.6.6-1_i386.deb
 c8bf8b3f7a913a0fb69b8dac8c1c03b5 106214 net optional libpam-winbind_3.6.6-1_i386.deb
 ce7aa0834b60819da090635174755349 696138 net optional libnss-winbind_3.6.6-1_i386.deb
 8eb4f1e82cf107c7b7fdf872abbfface 67722054 debug extra samba-dbg_3.6.6-1_i386.deb
 94f9b5d68265f87f8c15fb8cb850ba29 99054 libs optional libwbclient0_3.6.6-1_i386.deb
 e882f4af3ff996adfc1633fefda22d87 83666 libdevel optional libwbclient-dev_3.6.6-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBT+qSSocvcCxNbiWoAQI+WxAApBbhjKBgNS46QWahm8mp8UjChxRA2bcN
PBO3wWLvMh0jtPQAdhifG97sMvvtg4r3Wc8sbf+H9mdXq6Pnyqy0vH40minB9rvF
ZrMNcHcuZr8hc2pSx+H550DLE2cRhICvqztroAhM24Bg8SBZXuxVo2JMQbRuVor5
KTjh7WyR32ApGlC3WkRLXHhVkOP/nrs09kITcPTMDKUleWNO6Kk0/1HtZ85TXqGS
hPb+h7hFrooZQCEOrmZRSbGfHPG7l+0azJpGoG3Q8YvvrAwar4jaIvcRfsuT00Wz
6Huo+0dS/pI5tH8661RcGywirceceSwjlNpr+ot9RgOTraDqxZrMauea5aKZroay
H0hL3+Dl3gN9waANnMg/Pn+xcFT+98sZCHuM83M7XuqTMxMsa32m/BB7NO6iv6WD
I3SYdtvwDTmdl2+az+CZI6G6adsst+x8bs6ZRliOrK1iRGOnbEy2qSkGD+ytDKx8
tyOEvjgq9jPu+x5YP97BjroJvJgeM/DuJXaJqux0ZjsB+zB4aommCOQaWtKmHjSO
iyJ5yNi1UENULOI/JS6XKsodkbveJnefy2DKKHqUNZcmsxpGyE/Uwj30LnH2bbyb
mw78OTFt3HPRCn2K7g/JCLyBTE5VkRXsu6O+HC5GvQ28epMWYO58/z03oLrtjouV
iIACVk73X+c=
=R8pQ
-----END PGP SIGNATURE-----

Message #57 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Ivo De Decker <ivo.dedecker@ugent.be>

Cc: Christian PERRIER <bubulle@debian.org>, 652942@bugs.debian.org

Subject: Re: Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Wed, 27 Jun 2012 09:25:46 -0700

On Tue, Jun 19, 2012 at 10:36:54PM +0200, Ivo De Decker wrote:
> On Tue, Jun 19, 2012 at 08:08:46AM +0200, Christian PERRIER wrote:
> > > If I understand you correctly, you want us to drop the entire dhcp hook? There

> > Yes.

> > > might still be time to do this before the freeze.

> > Except that I'm much less in "samba mode" than I was in May, but
> > you're here to help in this, now..:-)

> That was my point :)
> Anyway, patch attached.

> > > Does anybody think we should keep the hook?
> > Just say "Steve, do you agree", it will be clearer..:-)

> :)

> Steve, what do you think? And if you agree, could you have a quick look at the
> patch? I think I did everything that's needed for the cleanup, but I might
> have forgotten something...

Sigh.  So no, I definitely don't agree with this change; but I didn't get a
chance to review this patch and didn't see up to that point in the
discussion that anyone was proposing *dropping* the dhcp hook.  I thought we
were only talking about dropping the reload handling, not the entire hook!

I'm going to revert this change and reopen the bugs.  Whether or not nmbd is
reloading its config, dhcp wins registration is still valuable for client
software, and this change is a regression.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

> Index: samba-common.maintscript
> ===================================================================
> --- samba-common.maintscript	(revision 0)
> +++ samba-common.maintscript	(working copy)
> @@ -0,0 +1,3 @@
> +rm_conffile /etc/dhcp3/dhclient-enter-hooks.d/samba 2:3.6.5-8~ samba-common
> +rm_conffile /etc/dhcp/dhclient-enter-hooks.d/samba 2:3.6.5-8~ samba-common
> +rm_conffile /etc/samba/dhcp.conf 2:3.6.5-8~ samba-common
> Index: samba-common.dhcp
> ===================================================================
> --- samba-common.dhcp	(revision 4124)
> +++ samba-common.dhcp	(working copy)
> @@ -1,75 +0,0 @@
> -#!/bin/sh
> -
> -SAMBA_DHCP_CONF=/etc/samba/dhcp.conf
> -
> -netbios_setup() {
> -	# No need to continue if we're called with an unsupported option
> -
> -	case $reason in
> -	BOUND|RENEW|REBIND|REBOOT|EXPIRE|FAIL|RELEASE|STOP)
> -		;;
> -	*)
> -		return
> -		;;
> -	esac
> -
> -	umask 022
> -
> -	local other_servers=""
> -	local serverlist=""
> -
> -	# the destination file won't exist yet on the first run after 
> -	# installing samba
> -	if [ -e $SAMBA_DHCP_CONF ] && [ -s $SAMBA_DHCP_CONF ]
> -	then
> -		# don't continue if no settings have changed
> -		if [ "$new_netbios_name_servers" = "$old_netbios_name_servers" ] \
> -		   && [ "$new_netbios_scope" = "$old_netbios_scope" ] \
> -		   && [ -n "$new_netbios_name_servers" ]
> -		then
> -			return
> -		fi
> -
> -		# reparse our own file
> -		other_servers=`sed -n -e"s/[[:space:]]$interface:[^[:space:]]*//g; \
> -			s/^[[:space:]]*wins server[[:space:]]*=[[:space:]]*//pi" \
> -			$SAMBA_DHCP_CONF`
> -
> -		serverlist="$other_servers"
> -	fi
> -
> -	for server in $new_netbios_name_servers
> -	do
> -		serverlist="$serverlist $interface:$server"
> -	done
> -
> -	echo -n > ${SAMBA_DHCP_CONF}.new
> -
> -	# If we're updating on failure/expire, AND there are no WINS
> -	# servers for other interfaces, leave the file empty.
> -	if [ -z "$other_servers" ]
> -	then
> -		if [ "$reason" = FAIL ] || [ "$reason" = EXPIRE ]
> -		then
> -			mv ${SAMBA_DHCP_CONF}.new $SAMBA_DHCP_CONF
> -			return
> -		fi
> -	fi
> -
> -	if [ -n "$serverlist" ]
> -	then
> -		echo "   wins server =$serverlist" >> ${SAMBA_DHCP_CONF}.new
> -	fi
> -	if [ -n "$new_netbios_scope" ]
> -	then
> -		echo "   netbios scope = $new_netbios_scope" >> ${SAMBA_DHCP_CONF}.new
> -	fi
> -	mv ${SAMBA_DHCP_CONF}.new $SAMBA_DHCP_CONF
> -
> -	# reload the samba server
> -	# We don't necessarily have the samba package installed. #414841
> -	[ -x /etc/init.d/samba ] && /usr/sbin/invoke-rc.d samba reload
> -
> -}
> -
> -netbios_setup
> Index: rules
> ===================================================================
> --- rules	(revision 4124)
> +++ rules	(working copy)
> @@ -98,11 +98,6 @@
>  	mkdir -p $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/pkgconfig
>  	install -m 0644 source3/pkgconfig/wbclient.pc $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/pkgconfig
>  
> -	# Install samba-common's conffiles - they'll get moved later to their
> -	# correct place by dh_install
> -	mkdir -p $(DESTDIR)/etc/dhcp3/dhclient-enter-hooks.d
> -	install -m755 debian/samba-common.dhcp $(DESTDIR)/etc/dhcp3/dhclient-enter-hooks.d/samba
> -
>  override_dh_installpam:
>  	dh_installpam --name=samba
>  
> Index: samba-common.links
> ===================================================================
> --- samba-common.links	(revision 4124)
> +++ samba-common.links	(working copy)
> @@ -1 +0,0 @@
> -etc/dhcp3/dhclient-enter-hooks.d/samba etc/dhcp/dhclient-enter-hooks.d/samba
> Index: samba-common.dirs
> ===================================================================
> --- samba-common.dirs	(revision 4124)
> +++ samba-common.dirs	(working copy)
> @@ -1,5 +1,4 @@
>  etc/samba
> -etc/dhcp3/dhclient-enter-hooks.d
>  var/cache/samba
>  var/lib/samba
>  var/log/samba
> Index: control
> ===================================================================
> --- control	(revision 4124)
> +++ control	(working copy)
> @@ -57,6 +57,7 @@
>  Package: samba-common
>  Architecture: all
>  Multi-Arch: foreign
> +Pre-Depends: ${misc:Pre-Depends}
>  Depends: ucf, ${misc:Depends}
>  Replaces: samba (<< 3.0.20b-1), samba4-common (<< 4.0.0~alpha7-1)
>  Conflicts: samba4-common (<< 4.0.0~alpha7-1)
> Index: samba-common.postinst
> ===================================================================
> --- samba-common.postinst	(revision 4124)
> +++ samba-common.postinst	(working copy)
> @@ -11,11 +11,14 @@
>  NEWFILE=$TEMPDIR/smb.conf
>  CONFIG=/etc/samba/smb.conf
>  
> +OLDVERSION="$2"
> +
>  # ------------------------- Debconf questions start ---------------------
>  
>  configure_smb_conf() {
>  	local CONFIG
>  	CONFIG="$1"
> +	OLDVERSION="$2"
>  
>  	# Is the user configuring with debconf, or he/she prefers
>  	# swat/manual config?
> @@ -50,19 +53,9 @@
>  		        s/^\([[:space:]]*\)encrypt passwords[[:space:]]*=.*/\1encrypt passwords = ${ENCRYPT_PASSWORDS}/i" \
>  		"$CONFIG"
>  
> -	# Install DHCP support
> -	db_get samba-common/dhcp
> -	if [ "$RET" = true ] && \
> -	   ! grep -q dhcp.conf "$CONFIG"
> +	# Remove DHCP support prio to version 2:3.6.5-8
> +	if dpkg --compare-versions "$OLDVERSION" lt '2:3.6.5-8~'
>  	then
> -		sed -i -e "s/^\([[:space:]]*\)\[global\]/\1\[global\]/i
> -			/^[[:space:]]*\[global\]/,/^[[:space:]]*\[/ {
> -				/wins server[[:space:]]*=/a \\
> -\\
> -# If we receive WINS server info from DHCP, override the options above. \\
> -   include = /etc/samba/dhcp.conf
> -}" "$CONFIG"
> -	elif [ "$RET" != true ]; then
>  		sed -i -e '
>  		/^#[[:space:]]*If we receive WINS server info from DHCP, override the options above/d
>  		/^#*[[:space:]]*include[[:space:]]*=[[:space:]]*\/etc\/samba\/dhcp.conf/,/[^[:space:]]/ {
> @@ -75,7 +68,7 @@
>  
>  
>  if [ -e "$CONFIG" ]; then
> -	configure_smb_conf "$CONFIG"
> +	configure_smb_conf "$CONFIG" "$OLDVERSION"
>  fi
>  
>  mkdir -p "$TEMPDIR"
> Index: samba-common.install
> ===================================================================
> --- samba-common.install	(revision 4124)
> +++ samba-common.install	(working copy)
> @@ -1,6 +1,5 @@
>  etc/samba/
>  debian/gdbcommands etc/samba
> -etc/dhcp3/
>  usr/share/samba/lowcase.dat
>  debian/panic-action usr/share/samba
>  debian/smb.conf* usr/share/samba
> Index: samba-common.templates
> ===================================================================
> --- samba-common.templates	(revision 4124)
> +++ samba-common.templates	(working copy)
> @@ -2,19 +2,6 @@
>  Type: title
>  _Description: Samba server and utilities
>  
> -Template: samba-common/dhcp
> -Type: boolean
> -Default: false
> -_Description: Modify smb.conf to use WINS settings from DHCP?
> - If your computer gets IP address information from a DHCP server on the
> - network, the DHCP server may also provide information about WINS servers
> - ("NetBIOS name servers") present on the network.  This requires a
> - change to your smb.conf file so that DHCP-provided WINS settings will
> - automatically be read from /etc/samba/dhcp.conf.
> - .
> - The dhcp3-client package must be installed to take advantage of this
> - feature.
> -
>  Template: samba-common/do_debconf
>  Type: boolean
>  Default: true
> Index: samba-common.config
> ===================================================================
> --- samba-common.config	(revision 4124)
> +++ samba-common.config	(working copy)
> @@ -77,32 +77,3 @@
>  db_input medium samba-common/encrypt_passwords || true
>  db_go
>  
> -DHCPPRIORITY=medium
> -#if [ "$DEBCONF_RECONFIGURE" = 1 ] && [ -f /sbin/dhclient3 ]
> -if [ -f /sbin/dhclient3 ]
> -then
> -	DHCPPRIORITY=high
> -# TODO: see if we can detect that dhcp3-client is *going* to be installed,
> -# even if it isn't yet.
> -#elif dpkg-query -W --showformat='${Status}\n' dhcp3-client | grep ???
> -# unknown ok not-installed ? 
> -#	DHCPPRIORITY=high
> -fi
> -
> -FOUND=false
> -if [ -f $FILE ]; then
> -	if grep -q 'include[[:space:]]*=[[:space:]]*/etc/samba/dhcp.conf' $FILE
> -	then
> -		FOUND=true
> -	fi
> -	db_set samba-common/dhcp $FOUND
> -fi
> -
> -# we only prompt in one of three cases: the file doesn't exist yet, it
> -# has the context we need to add our include line, or the include line
> -# is already present.
> -if [ ! -f $FILE ] || grep -q -i 'wins server' $FILE || [ "$FOUND" = "true" ];
> -then
> -	db_input $DHCPPRIORITY samba-common/dhcp || true
> -	db_go
> -fi
> Index: changelog
> ===================================================================
> --- changelog	(revision 4124)
> +++ changelog	(working copy)
> @@ -1,3 +1,9 @@
> +samba (2:3.6.5-8) UNRELEASED; urgency=low
> +
> +  * Remove DHCP hook. Closes: #652942, #629406, #649100
> +
> + -- Ivo De Decker <ivo.dedecker@ugent.be>  Tue, 19 Jun 2012 21:19:29 +0200
> +
>  samba (2:3.6.5-7) unstable; urgency=low
>  
>    * Allow installing smbclient package together with newer versions of

Message #66 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Ivo De Decker <ivo.dedecker@ugent.be>

Cc: Christian PERRIER <bubulle@debian.org>, 652942@bugs.debian.org

Subject: Re: Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Wed, 27 Jun 2012 09:36:14 -0700

On Wed, Jun 27, 2012 at 09:25:46AM -0700, Steve Langasek wrote:
> Sigh.  So no, I definitely don't agree with this change; but I didn't get a
> chance to review this patch and didn't see up to that point in the
> discussion that anyone was proposing *dropping* the dhcp hook.  I thought we
> were only talking about dropping the reload handling, not the entire hook!

> I'm going to revert this change and reopen the bugs.  Whether or not nmbd is
> reloading its config, dhcp wins registration is still valuable for client
> software, and this change is a regression.

Also, the 'reload' is done there specifically so that smbd gets the new
config, because smbd *also* will talk to the configured wins for name
resolution - so this was quite deliberate and has nothing to do with nmbd,
which we know does nothing on reload.

So I'm restoring the full patch, including the reload in the dhcp hook.  The
systemd maintainers should fix their invoke-rc.d implementation to not have
broken timeouts.

> -- 
> Steve Langasek                   Give me a lever long enough and a Free OS
> Debian Developer                   to set it on, and I can move the world.
> Ubuntu Developer                                    http://www.debian.org/
> slangasek@ubuntu.com                                     vorlon@debian.org
> 
> > Index: samba-common.maintscript
> > ===================================================================
> > --- samba-common.maintscript	(revision 0)
> > +++ samba-common.maintscript	(working copy)
> > @@ -0,0 +1,3 @@
> > +rm_conffile /etc/dhcp3/dhclient-enter-hooks.d/samba 2:3.6.5-8~ samba-common
> > +rm_conffile /etc/dhcp/dhclient-enter-hooks.d/samba 2:3.6.5-8~ samba-common
> > +rm_conffile /etc/samba/dhcp.conf 2:3.6.5-8~ samba-common
> > Index: samba-common.dhcp
> > ===================================================================
> > --- samba-common.dhcp	(revision 4124)
> > +++ samba-common.dhcp	(working copy)
> > @@ -1,75 +0,0 @@
> > -#!/bin/sh
> > -
> > -SAMBA_DHCP_CONF=/etc/samba/dhcp.conf
> > -
> > -netbios_setup() {
> > -	# No need to continue if we're called with an unsupported option
> > -
> > -	case $reason in
> > -	BOUND|RENEW|REBIND|REBOOT|EXPIRE|FAIL|RELEASE|STOP)
> > -		;;
> > -	*)
> > -		return
> > -		;;
> > -	esac
> > -
> > -	umask 022
> > -
> > -	local other_servers=""
> > -	local serverlist=""
> > -
> > -	# the destination file won't exist yet on the first run after 
> > -	# installing samba
> > -	if [ -e $SAMBA_DHCP_CONF ] && [ -s $SAMBA_DHCP_CONF ]
> > -	then
> > -		# don't continue if no settings have changed
> > -		if [ "$new_netbios_name_servers" = "$old_netbios_name_servers" ] \
> > -		   && [ "$new_netbios_scope" = "$old_netbios_scope" ] \
> > -		   && [ -n "$new_netbios_name_servers" ]
> > -		then
> > -			return
> > -		fi
> > -
> > -		# reparse our own file
> > -		other_servers=`sed -n -e"s/[[:space:]]$interface:[^[:space:]]*//g; \
> > -			s/^[[:space:]]*wins server[[:space:]]*=[[:space:]]*//pi" \
> > -			$SAMBA_DHCP_CONF`
> > -
> > -		serverlist="$other_servers"
> > -	fi
> > -
> > -	for server in $new_netbios_name_servers
> > -	do
> > -		serverlist="$serverlist $interface:$server"
> > -	done
> > -
> > -	echo -n > ${SAMBA_DHCP_CONF}.new
> > -
> > -	# If we're updating on failure/expire, AND there are no WINS
> > -	# servers for other interfaces, leave the file empty.
> > -	if [ -z "$other_servers" ]
> > -	then
> > -		if [ "$reason" = FAIL ] || [ "$reason" = EXPIRE ]
> > -		then
> > -			mv ${SAMBA_DHCP_CONF}.new $SAMBA_DHCP_CONF
> > -			return
> > -		fi
> > -	fi
> > -
> > -	if [ -n "$serverlist" ]
> > -	then
> > -		echo "   wins server =$serverlist" >> ${SAMBA_DHCP_CONF}.new
> > -	fi
> > -	if [ -n "$new_netbios_scope" ]
> > -	then
> > -		echo "   netbios scope = $new_netbios_scope" >> ${SAMBA_DHCP_CONF}.new
> > -	fi
> > -	mv ${SAMBA_DHCP_CONF}.new $SAMBA_DHCP_CONF
> > -
> > -	# reload the samba server
> > -	# We don't necessarily have the samba package installed. #414841
> > -	[ -x /etc/init.d/samba ] && /usr/sbin/invoke-rc.d samba reload
> > -
> > -}
> > -
> > -netbios_setup
> > Index: rules
> > ===================================================================
> > --- rules	(revision 4124)
> > +++ rules	(working copy)
> > @@ -98,11 +98,6 @@
> >  	mkdir -p $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/pkgconfig
> >  	install -m 0644 source3/pkgconfig/wbclient.pc $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/pkgconfig
> >  
> > -	# Install samba-common's conffiles - they'll get moved later to their
> > -	# correct place by dh_install
> > -	mkdir -p $(DESTDIR)/etc/dhcp3/dhclient-enter-hooks.d
> > -	install -m755 debian/samba-common.dhcp $(DESTDIR)/etc/dhcp3/dhclient-enter-hooks.d/samba
> > -
> >  override_dh_installpam:
> >  	dh_installpam --name=samba
> >  
> > Index: samba-common.links
> > ===================================================================
> > --- samba-common.links	(revision 4124)
> > +++ samba-common.links	(working copy)
> > @@ -1 +0,0 @@
> > -etc/dhcp3/dhclient-enter-hooks.d/samba etc/dhcp/dhclient-enter-hooks.d/samba
> > Index: samba-common.dirs
> > ===================================================================
> > --- samba-common.dirs	(revision 4124)
> > +++ samba-common.dirs	(working copy)
> > @@ -1,5 +1,4 @@
> >  etc/samba
> > -etc/dhcp3/dhclient-enter-hooks.d
> >  var/cache/samba
> >  var/lib/samba
> >  var/log/samba
> > Index: control
> > ===================================================================
> > --- control	(revision 4124)
> > +++ control	(working copy)
> > @@ -57,6 +57,7 @@
> >  Package: samba-common
> >  Architecture: all
> >  Multi-Arch: foreign
> > +Pre-Depends: ${misc:Pre-Depends}
> >  Depends: ucf, ${misc:Depends}
> >  Replaces: samba (<< 3.0.20b-1), samba4-common (<< 4.0.0~alpha7-1)
> >  Conflicts: samba4-common (<< 4.0.0~alpha7-1)
> > Index: samba-common.postinst
> > ===================================================================
> > --- samba-common.postinst	(revision 4124)
> > +++ samba-common.postinst	(working copy)
> > @@ -11,11 +11,14 @@
> >  NEWFILE=$TEMPDIR/smb.conf
> >  CONFIG=/etc/samba/smb.conf
> >  
> > +OLDVERSION="$2"
> > +
> >  # ------------------------- Debconf questions start ---------------------
> >  
> >  configure_smb_conf() {
> >  	local CONFIG
> >  	CONFIG="$1"
> > +	OLDVERSION="$2"
> >  
> >  	# Is the user configuring with debconf, or he/she prefers
> >  	# swat/manual config?
> > @@ -50,19 +53,9 @@
> >  		        s/^\([[:space:]]*\)encrypt passwords[[:space:]]*=.*/\1encrypt passwords = ${ENCRYPT_PASSWORDS}/i" \
> >  		"$CONFIG"
> >  
> > -	# Install DHCP support
> > -	db_get samba-common/dhcp
> > -	if [ "$RET" = true ] && \
> > -	   ! grep -q dhcp.conf "$CONFIG"
> > +	# Remove DHCP support prio to version 2:3.6.5-8
> > +	if dpkg --compare-versions "$OLDVERSION" lt '2:3.6.5-8~'
> >  	then
> > -		sed -i -e "s/^\([[:space:]]*\)\[global\]/\1\[global\]/i
> > -			/^[[:space:]]*\[global\]/,/^[[:space:]]*\[/ {
> > -				/wins server[[:space:]]*=/a \\
> > -\\
> > -# If we receive WINS server info from DHCP, override the options above. \\
> > -   include = /etc/samba/dhcp.conf
> > -}" "$CONFIG"
> > -	elif [ "$RET" != true ]; then
> >  		sed -i -e '
> >  		/^#[[:space:]]*If we receive WINS server info from DHCP, override the options above/d
> >  		/^#*[[:space:]]*include[[:space:]]*=[[:space:]]*\/etc\/samba\/dhcp.conf/,/[^[:space:]]/ {
> > @@ -75,7 +68,7 @@
> >  
> >  
> >  if [ -e "$CONFIG" ]; then
> > -	configure_smb_conf "$CONFIG"
> > +	configure_smb_conf "$CONFIG" "$OLDVERSION"
> >  fi
> >  
> >  mkdir -p "$TEMPDIR"
> > Index: samba-common.install
> > ===================================================================
> > --- samba-common.install	(revision 4124)
> > +++ samba-common.install	(working copy)
> > @@ -1,6 +1,5 @@
> >  etc/samba/
> >  debian/gdbcommands etc/samba
> > -etc/dhcp3/
> >  usr/share/samba/lowcase.dat
> >  debian/panic-action usr/share/samba
> >  debian/smb.conf* usr/share/samba
> > Index: samba-common.templates
> > ===================================================================
> > --- samba-common.templates	(revision 4124)
> > +++ samba-common.templates	(working copy)
> > @@ -2,19 +2,6 @@
> >  Type: title
> >  _Description: Samba server and utilities
> >  
> > -Template: samba-common/dhcp
> > -Type: boolean
> > -Default: false
> > -_Description: Modify smb.conf to use WINS settings from DHCP?
> > - If your computer gets IP address information from a DHCP server on the
> > - network, the DHCP server may also provide information about WINS servers
> > - ("NetBIOS name servers") present on the network.  This requires a
> > - change to your smb.conf file so that DHCP-provided WINS settings will
> > - automatically be read from /etc/samba/dhcp.conf.
> > - .
> > - The dhcp3-client package must be installed to take advantage of this
> > - feature.
> > -
> >  Template: samba-common/do_debconf
> >  Type: boolean
> >  Default: true
> > Index: samba-common.config
> > ===================================================================
> > --- samba-common.config	(revision 4124)
> > +++ samba-common.config	(working copy)
> > @@ -77,32 +77,3 @@
> >  db_input medium samba-common/encrypt_passwords || true
> >  db_go
> >  
> > -DHCPPRIORITY=medium
> > -#if [ "$DEBCONF_RECONFIGURE" = 1 ] && [ -f /sbin/dhclient3 ]
> > -if [ -f /sbin/dhclient3 ]
> > -then
> > -	DHCPPRIORITY=high
> > -# TODO: see if we can detect that dhcp3-client is *going* to be installed,
> > -# even if it isn't yet.
> > -#elif dpkg-query -W --showformat='${Status}\n' dhcp3-client | grep ???
> > -# unknown ok not-installed ? 
> > -#	DHCPPRIORITY=high
> > -fi
> > -
> > -FOUND=false
> > -if [ -f $FILE ]; then
> > -	if grep -q 'include[[:space:]]*=[[:space:]]*/etc/samba/dhcp.conf' $FILE
> > -	then
> > -		FOUND=true
> > -	fi
> > -	db_set samba-common/dhcp $FOUND
> > -fi
> > -
> > -# we only prompt in one of three cases: the file doesn't exist yet, it
> > -# has the context we need to add our include line, or the include line
> > -# is already present.
> > -if [ ! -f $FILE ] || grep -q -i 'wins server' $FILE || [ "$FOUND" = "true" ];
> > -then
> > -	db_input $DHCPPRIORITY samba-common/dhcp || true
> > -	db_go
> > -fi
> > Index: changelog
> > ===================================================================
> > --- changelog	(revision 4124)
> > +++ changelog	(working copy)
> > @@ -1,3 +1,9 @@
> > +samba (2:3.6.5-8) UNRELEASED; urgency=low
> > +
> > +  * Remove DHCP hook. Closes: #652942, #629406, #649100
> > +
> > + -- Ivo De Decker <ivo.dedecker@ugent.be>  Tue, 19 Jun 2012 21:19:29 +0200
> > +
> >  samba (2:3.6.5-7) unstable; urgency=low
> >  
> >    * Allow installing smbclient package together with newer versions of
> 
> 
> 
> 

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Message #75 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 652942@bugs.debian.org

Subject: dhcp hook runs reload on shutdown (after service has been stopped)

Date: Tue, 28 Aug 2012 23:43:44 +0200

[Message part 1 (text/plain, inline)]

Just wanted to add, that the same issue happens during boot.
As ifupdown is run before the samba init script, it can happen 
that the dhcp hook tries to reload samba even if it hasn't been started yet.

If you want to keep the hook, could you simply change it to 

diff --git a/dhcp3/dhclient-enter-hooks.d/samba b/dhcp3/dhclient-enter-hooks.d/samba
index 94b00f0..8e68055 100755
--- a/dhcp3/dhclient-enter-hooks.d/samba
+++ b/dhcp3/dhclient-enter-hooks.d/samba
@@ -68,7 +68,7 @@ netbios_setup() {
 
        # reload the samba server
        # We don't necessarily have the samba package installed. #414841
-       [ -x /etc/init.d/samba ] && /usr/sbin/invoke-rc.d samba reload
+       [ -x /etc/init.d/samba ] && /etc/init.d/samba status >/dev/null && /usr/sbin/invoke-rc.d samba reload
 
 }
 
And alternative could be to omit the reload during boot-up or shutdown.
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #80 received at 652942@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Steve Langasek <vorlon@debian.org>, 652942@bugs.debian.org, Michael Biebl <biebl@debian.org>

Subject: Re: Bug#652942: Do we really need to reload samba in DHCP enter hook?

Date: Thu, 5 Feb 2015 10:04:50 +0100

[Message part 1 (text/plain, inline)]

Control: tag -1 pending patch

Hello all,

Steve Langasek [2012-06-27  9:36 -0700]:
> So I'm restoring the full patch, including the reload in the dhcp hook.  The
> systemd maintainers should fix their invoke-rc.d implementation to not have
> broken timeouts.

Michael Biebl [2012-08-28 23:43 +0200]:
> Just wanted to add, that the same issue happens during boot.
> As ifupdown is run before the samba init script, it can happen 
> that the dhcp hook tries to reload samba even if it hasn't been started yet.

This problem isn't specific to samba, it happens with other use cases
too, like postfix (https://bugs.debian.org/624599). We discussed a
more general fix for this recently, which I just reported to
https://bugs.debian.org/635777.

This will solve this problem too, so I think we can close this bug
report.

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #87 received at 652942-done@bugs.debian.org (full text, mbox, reply):

From: Mathieu Parent <math.parent@gmail.com>

To: 652942-done@bugs.debian.org

Subject: CLosing

Date: Tue, 18 Jul 2017 23:27:20 +0200

This has been fixed by #635777. in systemd.

Regards

-- 
Mathieu Parent

Send a report that this bug log contains spam.