Debian Bug report logs - #648867
please install bash completion script

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dustin Kirkland <kirkland@ubuntu.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: tmux: minor packaging fixes (bash completion, postinst safeguarding)

Date: Tue, 15 Nov 2011 12:36:55 -0600

[Message part 1 (text/plain, inline)]

Subject: tmux: minor packaging fixes (bash completion, postinst safeguarding)
Package: tmux
Version: 1.5-1
Severity: minor

Howdy!  I have a pair of minor packaging fixes for tmux that I'd like
to get into Ubuntu by way of Debian.

 1) We have some backports of tmux to older Ubuntu releases that are
throwing some postinst warnings.  These can be avoided with a couple
of simple tests (testing for the existence of the conffile in
question, and the utility used to remove it)
 2) tmux ships a bash completion function, but it's not being
installed into /etc/bash_completion.d/tmux; I've tested it and it
works pretty well; it would be very nice if Debian installed it

I have a patch that fixes both of these.  You may or may not want to
take it as is.  The postinst part should be pretty simple/clean.  The
bash completion bit I solved with a symlink from
/etc/bash_completion.d/tmux to the completion script in the docs
location.  It looks like most of the other bash completion scripts are
technically conffiles (which seems silly to me), so perhaps you want
to handle this differently.

Thanks!
-- 
:-Dustin

Dustin Kirkland
Ubuntu Core Developer

[tmux.patch (text/x-patch, attachment)]

Message #10 received at 648867@bugs.debian.org (full text, mbox, reply):

From: Romain Francoise <rfrancoise@debian.org>

To: Dustin Kirkland <kirkland@ubuntu.com>

Cc: 648867@bugs.debian.org

Subject: Re: Bug#648867: tmux: minor packaging fixes (bash completion, postinst safeguarding)

Date: Thu, 17 Nov 2011 19:42:03 +0100

Hi Dustin,

Thanks for the patch. My review below:

Dustin Kirkland <kirkland@ubuntu.com> writes:

> The postinst part should be pretty simple/clean.

I suspect it's also incorrect. In a normal upgrade scenario the preinst
first moves tmux-cleanup to tmux-cleanup.dpkg-remove, so the test you
added in postinst cannot match. As a result, the dpkg-maintscript-helper
call is skipped, which leaves the .dpkg-remove file behind.

> The bash completion bit I solved with a symlink from
> /etc/bash_completion.d/tmux to the completion script in the docs
> location. It looks like most of the other bash completion scripts are
> technically conffiles (which seems silly to me), so perhaps you want to
> handle this differently.

I see at least two reasons not to do it this way: 1) some people drop
/usr/share/doc using dpkg path filters on space-constrained systems, and
2) debhelper automatically compresses files larger than 4KB under
/usr/share/doc so if the file ever grows past that, it will break.

The latter could be worked around, but I'd rather just not have to deal
with bash completion at all. What's the procedure to have this file
included in the bash-completion package?

-- 
Romain Francoise <rfrancoise@debian.org>
http://people.debian.org/~rfrancoise/

Message #21 received at 648867@bugs.debian.org (full text, mbox, reply):

From: Courtney Bane <debian-bugs-6752@cbane.org>

To: Debian Bug Tracking System <648867@bugs.debian.org>

Subject: Re: please install bash completion script

Date: Thu, 14 Mar 2013 10:07:50 -0500

[Message part 1 (text/plain, inline)]

> I see at least two reasons not to do it this way: 1) some people drop
> /usr/share/doc using dpkg path filters on space-constrained systems, and
> 2) debhelper automatically compresses files larger than 4KB under
> /usr/share/doc so if the file ever grows past that, it will break.

> The latter could be worked around, but I'd rather just not have to deal
> with bash completion at all. What's the procedure to have this file
> included in the bash-completion package?

The modern way of integrating with bash-completion (since version 2.0)
is to install the completion file as
/usr/share/bash-completion/completions/<progname>, and it will be picked
up automatically. I've attached a patch against the version of tmux in
unstable (modifying debian/rules and debian/dirs) to do this.

[tmux-bash-completion.patch (text/x-diff, attachment)]

Message #26 received at 648867@bugs.debian.org (full text, mbox, reply):

From: Romain Francoise <rfrancoise@debian.org>

To: Courtney Bane <debian-bugs-6752@cbane.org>

Cc: 648867@bugs.debian.org

Subject: Re: Bug#648867: please install bash completion script

Date: Thu, 14 Mar 2013 17:18:37 +0100

Courtney Bane <debian-bugs-6752@cbane.org> writes:

> The modern way of integrating with bash-completion (since version 2.0)
> is to install the completion file as
> /usr/share/bash-completion/completions/<progname>, and it will be picked
> up automatically. I've attached a patch against the version of tmux in
> unstable (modifying debian/rules and debian/dirs) to do this.

Thanks. I don't use bash but from a cursory look the bash completion file
included in tmux appears to be very incomplete, it basically only
completes command names and doesn't complete options, aliases or
session/window names like zsh does.

In your opinion, is this file useful enough to be shipped in the package?
I don't want to get bug reports about it, it's not supported upstream (it
hasn't been updated since 2010).

-- 
Romain Francoise <rfrancoise@debian.org>
http://people.debian.org/~rfrancoise/

Message #31 received at 648867@bugs.debian.org (full text, mbox, reply):

From: Courtney Bane <debian-bugs-6752@cbane.org>

To: Romain Francoise <rfrancoise@debian.org>

Cc: 648867@bugs.debian.org

Subject: Re: Bug#648867: please install bash completion script

Date: Thu, 21 Mar 2013 16:06:19 -0500

On Thu, Mar 14, 2013 at 05:18:37PM +0100, Romain Francoise wrote:
> In your opinion, is this file useful enough to be shipped in the package?
> I don't want to get bug reports about it, it's not supported upstream (it
> hasn't been updated since 2010).

It's been useful enough for me that I've installed it on my systems.
I've started writing a more full-featured one; once I finish that, I'll
send it upstream.

Message #36 received at 648867@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: Debian Bug Tracking System <648867@bugs.debian.org>

Subject: Re: please install bash completion script

Date: Thu, 09 Oct 2014 00:53:11 -0400

Package: tmux
Version: 1.9-6
Followup-For: Bug #648867

I also think the bash completion file should be installed in the proper
location, even if it's incomplete. Having it in here:

/usr/share/doc/tmux/examples/bash_completion_tmux.sh

... is pretty much useless, it belongs in

/usr/share/bash-completion/completions

like the other 592 completions I currently have available there.

Even if it's incomplete, I think it's better than nothing - not having
autcompletion on "tmux attach" seems a little ridiculous at this
point...

A.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tmux depends on:
ii  libc6           2.19-11
ii  libevent-2.0-5  2.0.21-stable-1.1
ii  libtinfo5       5.9+20140913-1

tmux recommends no packages.

tmux suggests no packages.

-- no debconf information

Message #41 received at 648867-close@bugs.debian.org (full text, mbox, reply):

From: Romain Francoise <rfrancoise@debian.org>

To: 648867-close@bugs.debian.org

Subject: Bug#648867: fixed in tmux 2.2~git20160206-1

Date: Sat, 06 Feb 2016 18:36:35 +0000

Source: tmux
Source-Version: 2.2~git20160206-1

We believe that the bug you reported is fixed in the latest version of
tmux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 648867@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Romain Francoise <rfrancoise@debian.org> (supplier of updated tmux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 06 Feb 2016 19:10:40 +0100
Source: tmux
Binary: tmux
Architecture: source
Version: 2.2~git20160206-1
Distribution: experimental
Urgency: medium
Maintainer: Romain Francoise <rfrancoise@debian.org>
Changed-By: Romain Francoise <rfrancoise@debian.org>
Description:
 tmux       - terminal multiplexer
Closes: 644366 648867
Changes:
 tmux (2.2~git20160206-1) experimental; urgency=medium
 .
   * New upstream snapshot, from Git commit 7669cfb330.
   * debian/docs: use new merged example configuration file, the examples
     directory has been removed upstream (closes: #644366, #648867).
Checksums-Sha1:
 efa7d50f032a6057376680ccf11f7e94be8cd41b 1965 tmux_2.2~git20160206-1.dsc
 99f63aae2b921ec47d65acc1d603f847937c3786 470905 tmux_2.2~git20160206.orig.tar.gz
 f042eaeb5c04478ed1d70daac1ed4d8da0112028 11980 tmux_2.2~git20160206-1.debian.tar.xz
Checksums-Sha256:
 2a07b23c363838d42916f512770b8abd37b5cd007b8720934b1fd2ff838a5d35 1965 tmux_2.2~git20160206-1.dsc
 57d250d978bb9b383c8e83d8bee67a61fe1b195684185f3d129d8fd9151e89ad 470905 tmux_2.2~git20160206.orig.tar.gz
 be245e1d03a3f9e81be871db7f9ea41be018d2501a81d5f1c331017fa10d4b47 11980 tmux_2.2~git20160206-1.debian.tar.xz
Files:
 a14fd1fcfcb924cdf04d9319e42758f9 1965 admin optional tmux_2.2~git20160206-1.dsc
 4cdfab93aea418d798d77d86abd066fc 470905 admin optional tmux_2.2~git20160206.orig.tar.gz
 f0a71926bae75116e6eb8cec6cb77f20 11980 admin optional tmux_2.2~git20160206-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWtjsGAAoJEK0V9DXwX5YttW4QAJVqeOBgKbsBk5ZhzCahf4tF
W7gTElWkSBsSuWI0dnARpIO/06YjbTOMn0xymxWi8bl8n8wL8ACHAWLIN8jGNew4
v+qPovgS+5xIIXfAXh14PEBM968DC2jkcfdIFFs27OvNldUsH1VMlRfcltPwev+6
R2SeqZa2xpKBkhYC+hRljCopTkSt6niqOtKXgAHIP0g7w386tx5N6qnJjX9Zr+/A
JT17YmkZLQz0pWzYfC+frGKxLv4YG+qp47Wzm/LKUcGGFSI/zbpvFdwvGSQMFwr3
jvb4QAUpCnda9r25pra7zgQCgE+SDb9j25Hl3a/hv8awuHV9WVkSC/6UGPHaM0JI
kuHWJpl3a7YnP1bbxrFMyBLMijjXnCMzxZGmtiwpqIdQQ7EKcRGuiSs/m1FC+QnU
v/jc4/q/42IYnGkCBzTvPi4Im5sfaPOn0Gyx6mtARJTKTkBYsi3X7V8sZOlmR2Bh
aEASCEMDmPrlEeanE/ePnCh5sNnsV4415zoDYz0secnoqZbXCMr9E0sjT0mHOkEQ
AGk3s100A5L2vmEE0B5fCzMOTgV2XgyZ2DBnJbzt2NOjXIuOfLfzZYc0WrHsA3zS
c5314ViisoN90HRJwFy7TjFTuql51Vy8ATAptg6eWVPFSn4QkxQLD+1WXAIauBBq
blCNa1Xr9Xx/LVEtKOtO
=dFZV
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.