Debian Bug report logs - #648161
autopkgtest: Extracting sources with ~ or + in the version fails

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Debian BTS Submit <submit@bugs.debian.org>

Subject: autopkgtest: Extracting sources with ~ or + in the version fails

Date: Wed, 9 Nov 2011 10:29:32 +0100

Package: autopkgtest
Version: 2.0.1

When trying to run adt-run against a source package (.dsc) which has +
or ~ in the file name, the files that get copied into the temporary
directory have a wrong name with these characters quoted, leading to
unpack failure. You can reproduce this by getting any package with a ~
or ~ in the version, e. g.:

$ apt-get source aoeui
$ sudo adt-run aoeui_1.5~dfsg-1.dsc --- adt-virt-null
[...]
adt-run: trace: $ dsc0-extract: sh -ec <SCRIPT> x /tmp/tmp.4yBupdkPq9/dsc0-build/tmpdir /tmp/tmp.4yBupdkPq9/dsc0/aoeui_1.5~dfsg-1.dsc
+ spec=/tmp/tmp.4yBupdkPq9/dsc0/aoeui_1.5~dfsg-1.dsc
+ pwd
+ origpwd=/tmp/tmp.4yBupdkPq9/dsc0-build
+ cd /tmp/tmp.4yBupdkPq9/dsc0-build
+ TMPDIR=/tmp/tmp.4yBupdkPq9/dsc0-build/tmpdir
+ rm -rf -- /tmp/tmp.4yBupdkPq9/dsc0-build/tmpdir
+ export TMPDIR
+ mkdir -- /tmp/tmp.4yBupdkPq9/dsc0-build/tmpdir
+ dpkg-source -x /tmp/tmp.4yBupdkPq9/dsc0/aoeui_1.5~dfsg-1.dsc
dpkg-source: error: cannot open /tmp/tmp.4yBupdkPq9/dsc0/aoeui_1.5~dfsg-1.dsc: No such file or directory
blame: arg:aoeui_1.5~dfsg-1.dsc dsc:aoeui
badpkg: rules extract failed with exit code 2
adt-run: erroneous package: rules extract failed with exit code 2

I added an "ls -l `dirname $spec`" before the dpkg-source call, which reveals:

+ dirname /tmp/tmp.FzK6XZJXXA/dsc0/aoeui_1.5~dfsg-1.dsc
+ ls -l /tmp/tmp.FzK6XZJXXA/dsc0
total 80
-rw-r--r-- 1 root root  4088 Nov  9 10:22 aoeui_1.5%7Edfsg-1.debian.tar.gz
-rw-r--r-- 1 root root  1173 Nov  9 10:22 aoeui_1.5%7Edfsg-1.dsc
-rw-r--r-- 1 root root 71964 Nov  9 10:22 aoeui_1.5%7Edfsg.orig.tar.gz
+ dpkg-source -x /tmp/tmp.FzK6XZJXXA/dsc0/aoeui_1.5~dfsg-1.dsc

I. e. something is erroneously quoting the file names in the temporary
dsc0 dir. I added debugging to all usages of urllib.quote() and other
places which might be related, but unfortunately I'm not able to
figure out which part of the code actually copies the files and
damages their name. So currently I'm not able to fix this.

The workaround is to extract the source package yourself and run with
"--built-tree ." instead of against the .dsc.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Message #10 received at 648161@bugs.debian.org (full text, mbox, reply):

From: Jean-Baptiste Lallement <jean-baptiste.lallement@canonical.com>

To: 648161@bugs.debian.org

Subject: [PATCH] Fix quoting of filenames

Date: Sun, 15 Apr 2012 17:24:08 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

This patch avoids quoting of filenames when copyup/copydown is called. 
It fixes run of adt-run against packages like aoeui_1.5~dfsg-1.dsc or 
postgresql-client_9.1+129_all.deb

-- 
Jean-Baptiste
IRC: jibel

[autopkgtest.648161.dontquotefilenames.patch (text/x-patch, attachment)]

Message #15 received at 648161-close@bugs.debian.org (full text, mbox, reply):

From: Ian Jackson <ijackson@chiark.greenend.org.uk>

To: 648161-close@bugs.debian.org

Subject: Bug#648161: fixed in autopkgtest 2.1.0

Date: Mon, 11 Jun 2012 01:32:09 +0000

Source: autopkgtest
Source-Version: 2.1.0

We believe that the bug you reported is fixed in the latest version of
autopkgtest, which is due to be installed in the Debian FTP archive:

autopkgtest-xenlvm_2.1.0_all.deb
  to main/a/autopkgtest/autopkgtest-xenlvm_2.1.0_all.deb
autopkgtest_2.1.0.dsc
  to main/a/autopkgtest/autopkgtest_2.1.0.dsc
autopkgtest_2.1.0.tar.gz
  to main/a/autopkgtest/autopkgtest_2.1.0.tar.gz
autopkgtest_2.1.0_all.deb
  to main/a/autopkgtest/autopkgtest_2.1.0_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 648161@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ian Jackson <ijackson@chiark.greenend.org.uk> (supplier of updated autopkgtest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 11 Jun 2012 02:05:49 +0100
Source: autopkgtest
Binary: autopkgtest autopkgtest-xenlvm
Architecture: source all
Version: 2.1.0
Distribution: sid
Urgency: low
Maintainer: Autopkgtest team <autopkgtest-devel@lists.alioth.debian.org>
Changed-By: Ian Jackson <ijackson@chiark.greenend.org.uk>
Description: 
 autopkgtest - automatic as-installed testing for Debian packages
 autopkgtest-xenlvm - Xen/LVM2 based testbed snapshot system
Closes: 647882 648161 667001 667022 669721 670648
Changes: 
 autopkgtest (2.1.0) unstable; urgency=low
 .
   Bugfixes:
   * Remove our strange apt config on exit.
     Partial fix to #648142, from Timo Lindfors.
   * Suppress apt-listbugs and apt-listchanges.  Michael Prokop.
   * Fix parsing of "@" dependencies.  Colin Watson.  Closes: #667022.
   * Fix NameError re "f" in restriction parsing.
     Martin Pitt.  Closes: #647882.
   * Improve handling of schroot root-users and root-groups.
     Colin Watson.  Closes: #667001.
   * Correctly handle quoting of copyup/copydown filenames.  Fixes
     but where we couldn't cope with packages' filenames containing
     + and ~.  Report from Martin Pitt.  Closes: #648161.
 .
   Documentation fixes:
   * Clarify the spec to say that copyup/down takes encoded filenames.
   * Fix the spec to refer to `breaks-testbed' rather than `breaks-computer'.
     Report from Jakub Wilk.  Closes: #669721.
   * Manpage should refer to `*' in tests file's Depends field, not `@'.
     Report from Jakub Wilk.  Closes: #670648.
 .
   Packaging fixes:
   * Add Recommends against pbuilder, whose dependency resolver adt-run
     uses.
   * Remove runner/tmp on debian/rules clean, and add it to .gitignore,
     for convenience.
Checksums-Sha1: 
 a586df1c4d9979eeff662c53dfefe0b86a365e43 1201 autopkgtest_2.1.0.dsc
 e9ffa4b8f72e3a37af96c2c218a91cf337bab09a 75673 autopkgtest_2.1.0.tar.gz
 a02913fbc6cf7608eee71d8b3b9a0ecec3e033da 64898 autopkgtest_2.1.0_all.deb
 c316bcaf14eccf7cf2f7f62aa1d372f99b46704b 26386 autopkgtest-xenlvm_2.1.0_all.deb
Checksums-Sha256: 
 a5e3b6c54d2daf1b59d78dba73a489cdc5dd386ab669803ae9b7365cc18da6ca 1201 autopkgtest_2.1.0.dsc
 b1c568098185ce1433c6bc8488d8b92d0332293b482316a4ceabad2733064bf4 75673 autopkgtest_2.1.0.tar.gz
 b12d4ce4146c05190163992655792b0d5344c298e551fc0e8ea48085ac8073a3 64898 autopkgtest_2.1.0_all.deb
 353e718a3141c52468e65fa29c51bd6f2096f157dd8eeed0e6ca6698bb335cfe 26386 autopkgtest-xenlvm_2.1.0_all.deb
Files: 
 5d710eb8d282fe6310564e913b597e15 1201 devel optional autopkgtest_2.1.0.dsc
 ac1e47f17f2580eea7f5fe5a4ddfe55f 75673 devel optional autopkgtest_2.1.0.tar.gz
 182c84dbb07cc9e3f7e55af00141682c 64898 devel optional autopkgtest_2.1.0_all.deb
 c869c8922be6e9b49f2cad4861e53470 26386 devel optional autopkgtest-xenlvm_2.1.0_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBCAAGBQJP1UgAAAoJEOPjOSNItQ05jGgH/2ojy/wyKz5d0qNV3HDQdNku
vlpxKcj1Rz8SySpxtUVKSggdC5QrjkHjY0IuxDUgSzPjKhRTT8VuI/6+k/WMaeEw
ArIERTWRQduotl4CWBtbChGWD5JGYOhG80MJ+5gKrJDf+BygXsCV95i30IJD54uU
gvIgzfKgZH8vBb5ciww8lnQ/MVFXrgvFk77ZAKxkdVdat0hkZEAlTyoKYrVo+vJW
6l1MO0fL0BIwF8SQB6VFLeMgo9whkAwkEY6bs/53Kn9xcimkCTGI+NivPz9cTr6D
xzjfruZwt1quoHRpNyYlYPFhvp5Pg9gxcjzzMJoIRfHoFxFJxvxdH0QeIeC/wMA=
=Auoy
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.