Debian Bug report logs - #646882
git-pbuilder: ARCH should have a sane default

version graph

Package: git-buildpackage; Maintainer for git-buildpackage is Guido Günther <agx@sigxcpu.org>; Source for git-buildpackage is src:git-buildpackage.

Reported by: Antoine Beaupré <anarcat@debian.org>

Date: Fri, 28 Oct 2011 05:06:01 UTC

Severity: normal

Found in version git-buildpackage/0.5.32

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Guido Günther <agx@sigxcpu.org>:
Bug#646882; Package git-buildpackage. (Fri, 28 Oct 2011 05:06:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Antoine Beaupré <anarcat@koumbit.org>:
New Bug report received and forwarded. Copy sent to Guido Günther <agx@sigxcpu.org>. (Fri, 28 Oct 2011 05:06:04 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Antoine Beaupré <anarcat@koumbit.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: git-pbuilder: ARCH should have a sane default
Date: Fri, 28 Oct 2011 01:02:50 -0400
Package: git-buildpackage
Version: 0.5.32
Severity: normal

The manpage of git-pbuilder says the following:

       [...] It configures pdebuild to use cowbuilder by default,
       passes appropriate options to debbuild, and sets the base path
       for cowbuilder based on the environment variable DIST and, if
       set, the environment variable ARCH.

Reading this, I was understanding the ARCH variable to be
optional. Indeed, later it says:

       [...] If DIST is set, its value is the target distribution and
       /var/cache/pbuilder/base-dist.cow is used instead. [...]  If
       ARCH is set, its value is the target architecture and
       /var/cache/pbuilder/base-dist-arch.cow is used, with dist being
       set to "sid" if DIST was not set.

Now either the documentation is incorrect, or the implementation is
incorrect because just using:

DIST=sid git-pbuilder login

actually looks for /var/cache/pbuilder/base.cow:

anarcat@marcos:charybdis$ DIST=sid git-pbuilder login
Base directory /var/cache/pbuilder/base.cow does not exist

This is quite confusing because it looks like DIST is completely
ignored, as the results are identical to not using DIST:

anarcat@marcos:charybdis$ git-pbuilder login
Base directory /var/cache/pbuilder/base.cow does not exist

At the very least, I would expect git-pbuilder to look for
base-dist.cow, as mentionned in the documentation.

I believe, however, that it would be more coherent to look for
base-$DIST-$ARCH.cow by default, and have $ARCH default to something
like "amd64" (or rather dpkg --print-architecture).

But that would be an improvement that would not really be necessary. I
do believe this is a bug and not just a feature request however, as
DIST alone doesn't work as expected.

Thanks,

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_CA.utf8, LC_CTYPE=fr_CA.utf8 (charmap=UTF-8) (ignored: LC_ALL set to fr_CA.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages git-buildpackage depends on:
ii  devscripts       2.11.1   
ii  git [git-core]   1:1.7.7-2
ii  git-core         1:1.7.7-2
ii  python           2.7.2-9  
ii  python-dateutil  1.5-1    
ii  python2.6        2.6.7-3  
ii  python2.7        2.7.2-5  

Versions of packages git-buildpackage recommends:
ii  cowbuilder    0.65
ii  pristine-tar  1.15

Versions of packages git-buildpackage suggests:
ii  python-notify  0.1.1-3
ii  unzip          6.0-5  

-- no debconf information




Information forwarded to debian-bugs-dist@lists.debian.org, Guido Günther <agx@sigxcpu.org>:
Bug#646882; Package git-buildpackage. (Fri, 28 Oct 2011 05:18:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Russ Allbery <rra@debian.org>:
Extra info received and forwarded to list. Copy sent to Guido Günther <agx@sigxcpu.org>. (Fri, 28 Oct 2011 05:18:03 GMT) Full text and rfc822 format available.

Message #10 received at 646882@bugs.debian.org (full text, mbox):

From: Russ Allbery <rra@debian.org>
To: Antoine Beaupré <anarcat@koumbit.org>
Cc: 646882@bugs.debian.org
Subject: Re: Bug#646882: git-pbuilder: ARCH should have a sane default
Date: Thu, 27 Oct 2011 22:15:24 -0700
Antoine Beaupré <anarcat@koumbit.org> writes:

> Now either the documentation is incorrect, or the implementation is
> incorrect because just using:

> DIST=sid git-pbuilder login

> actually looks for /var/cache/pbuilder/base.cow:

> anarcat@marcos:charybdis$ DIST=sid git-pbuilder login
> Base directory /var/cache/pbuilder/base.cow does not exist

It looks for /var/cache/pbuilder/base-sid.cow first, and then looks for
/var/cache/pbuilder/base.cow.  The error message only lists the last thing
that it looks for, but it does look for both.  I'm not entirely sure how
to make the error message less confusing, but I'm pretty sure it is
behaving as documented.

Perhaps what's confusing is that it special-cases a DIST of sid and falls
back to base.cow if base-sid.cow doesn't exist.

> I believe, however, that it would be more coherent to look for
> base-$DIST-$ARCH.cow by default, and have $ARCH default to something
> like "amd64" (or rather dpkg --print-architecture).

We could do that.  Similar to checking for DIST first, it could check for
DIST-ARCH first, then DIST, then just base.cow.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>




Changed Bug submitter to 'Antoine Beaupré <anarcat@debian.org>' from 'Antoine Beaupré <anarcat@koumbit.org>' Request was from Antoine Beaupré <anarcat@debian.org> to control@bugs.debian.org. (Tue, 08 Nov 2011 01:48:16 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed Apr 16 07:27:46 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.