Debian Bug report logs - #643564
isc-dhcp-server: responds to vlan tagged packets on untagged interface

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Simon Richter <sjr@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: isc-dhcp-server: responds to vlan tagged packets on untagged interface

Date: Tue, 27 Sep 2011 17:07:34 +0200

Package: isc-dhcp-server
Version: 4.1.1-P1-15+squeeze3
Severity: normal

Hi,

I have a setup where the server is connected to a switch via a trunking port --
however the switch management is untagged, so I have to run the DHCP server on
both the regular interface and the vlan interfaces.

When a request comes in with a tagged packet, it is seen twice, and responded to
with two different configurations, i.e. I see

<- DISCOVER via eth1.2
-> OFFER via eth1.2
<- DISCOVER via eth1
-> OFFER via eth1
<- REQUEST via eth1.2
-> ACK via eth1.2
<- REQUEST via eth1
-> NAK via eth1

I'm not sure if this is more than an annoyance, but I doubt it should happen.

   Simon

-- System Information:
Debian Release: 6.0.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages isc-dhcp-server depends on:
ii  debconf [debconf-2. 1.5.36.1             Debian configuration management sy
ii  debianutils         3.4                  Miscellaneous utilities specific t
ii  isc-dhcp-common     4.1.1-P1-15+squeeze3 common files used by all the isc-d
ii  libc6               2.11.2-10            Embedded GNU C Library: Shared lib
ii  lsb-base            3.2-23.2squeeze1     Linux Standard Base 3.2 init scrip

isc-dhcp-server recommends no packages.

Versions of packages isc-dhcp-server suggests:
pn  isc-dhcp-server-ldap          <none>     (no description available)

-- Configuration Files:
/etc/dhcp/dhcpd.conf changed [not included]

-- debconf information excluded

Message #12 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Herbert Xu <herbert@gondor.apana.org.au>

To: 643564@bugs.debian.org, 643564-submitter@bugs.debian.org

Subject: dhcp: Stop using obsolete SOCK_PACKET and skip VLAN-tagged packets

Date: Sun, 26 Feb 2012 14:51:45 +1100

Hi:

Here's a hack I just made up to make DHCP skip tagged packets.
In order to do so I've switched from the long-obsolete SOCK_PACKET
interface to AF_PACKET+SOCK_RAW.

Obviously you'll need to clean this up.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/common/lpf.c b/common/lpf.c
index e5dd1e2..36a14ee 100644
--- a/common/lpf.c
+++ b/common/lpf.c
@@ -35,6 +35,7 @@
 #include <asm/types.h>
 #include <linux/filter.h>
 #include <linux/if_ether.h>
+#include <linux/if_packet.h>
 #include <netinet/in_systm.h>
 #include "includes/netinet/ip.h"
 #include "includes/netinet/udp.h"
@@ -65,11 +66,13 @@ void if_reinitialize_receive (info)
 int if_register_lpf (info)
 	struct interface_info *info;
 {
+	int val;
 	int sock;
-	struct sockaddr sa;
+	struct ifreq tmp;
+	struct sockaddr_ll sa;
 
 	/* Make an LPF socket. */
-	if ((sock = socket(PF_PACKET, SOCK_PACKET,
+	if ((sock = socket(PF_PACKET, SOCK_RAW,
 			   htons((short)ETH_P_ALL))) < 0) {
 		if (errno == ENOPROTOOPT || errno == EPROTONOSUPPORT ||
 		    errno == ESOCKTNOSUPPORT || errno == EPFNOSUPPORT ||
@@ -84,11 +87,20 @@ int if_register_lpf (info)
 		log_fatal ("Open a socket for LPF: %m");
 	}
 
+	val = 1;
+	setsockopt(sock, SOL_PACKET, PACKET_AUXDATA, &val, sizeof(val));
+
+	memcpy(&tmp, info->ifp, sizeof(tmp));
+	if (ioctl(sock, SIOCGIFINDEX, &tmp) < 0) {
+		log_fatal("Error getting interface index for \"%s\": %m", 
+			  tmp.ifr_name);
+	}
+
 	/* Bind to the interface name */
 	memset (&sa, 0, sizeof sa);
-	sa.sa_family = AF_PACKET;
-	strncpy (sa.sa_data, (const char *)info -> ifp, sizeof sa.sa_data);
-	if (bind (sock, &sa, sizeof sa)) {
+	sa.sll_family = AF_PACKET;
+	sa.sll_ifindex = tmp.ifr_ifindex;
+	if (bind (sock, (struct sockaddr *)&sa, sizeof sa)) {
 		if (errno == ENOPROTOOPT || errno == EPROTONOSUPPORT ||
 		    errno == ESOCKTNOSUPPORT || errno == EPFNOSUPPORT ||
 		    errno == EAFNOSUPPORT || errno == EINVAL) {
@@ -294,7 +306,6 @@ ssize_t send_packet (interface, packet, raw, len, from, to, hto)
 	double hh [16];
 	double ih [1536 / sizeof (double)];
 	unsigned char *buf = (unsigned char *)ih;
-	struct sockaddr sa;
 	int result;
 	int fudge;
 
@@ -312,21 +323,25 @@ ssize_t send_packet (interface, packet, raw, len, from, to, hto)
 				(unsigned char *)raw, len);
 	memcpy (buf + ibufp, raw, len);
 
-	/* For some reason, SOCK_PACKET sockets can't be connected,
-	   so we have to do a sentdo every time. */
-	memset (&sa, 0, sizeof sa);
-	sa.sa_family = AF_PACKET;
-	strncpy (sa.sa_data,
-		 (const char *)interface -> ifp, sizeof sa.sa_data);
-
-	result = sendto (interface -> wfdesc,
-			 buf + fudge, ibufp + len - fudge, 0, &sa, sizeof sa);
+	result = send (interface -> wfdesc,
+		       buf + fudge, ibufp + len - fudge, 0);
 	if (result < 0)
 		log_error ("send_packet: %m");
 	return result;
 }
 #endif /* USE_LPF_SEND */
 
+struct tpacket_auxdata_new
+{
+	__u32           tp_status;
+	__u32           tp_len;
+	__u32           tp_snaplen;
+	__u16           tp_mac;
+	__u16           tp_net;
+	__u16           tp_vlan_tci;
+	__u16           tp_padding;
+};
+
 #ifdef USE_LPF_RECEIVE
 ssize_t receive_packet (interface, buf, len, from, hfrom)
 	struct interface_info *interface;
@@ -340,11 +355,38 @@ ssize_t receive_packet (interface, buf, len, from, hfrom)
 	unsigned char ibuf [1536];
 	unsigned bufix = 0;
 	unsigned paylen;
-
-	length = read (interface -> rfdesc, ibuf, sizeof ibuf);
+	struct cmsghdr *cmsg;
+	union {
+		struct cmsghdr cmsg;
+		char buf[CMSG_SPACE(sizeof(struct tpacket_auxdata_new))];
+	} cmsg_buf;
+	struct msghdr msg = {};
+	struct iovec iov;
+
+	iov.iov_base = ibuf;
+	iov.iov_len = sizeof ibuf;
+	msg.msg_iov = &iov;
+	msg.msg_iovlen = 1;
+	msg.msg_control = &cmsg_buf;
+	msg.msg_controllen = sizeof cmsg_buf;
+
+	length = recvmsg (interface -> rfdesc, &msg, 0);
 	if (length <= 0)
 		return length;
 
+	for (cmsg = CMSG_FIRSTHDR(&msg); cmsg; cmsg = CMSG_NXTHDR(&msg, cmsg)) {
+		struct tpacket_auxdata_new *aux;
+
+		if (cmsg->cmsg_len < CMSG_LEN(sizeof(struct tpacket_auxdata_new)) ||
+		    cmsg->cmsg_level != SOL_PACKET ||
+		    cmsg->cmsg_type != PACKET_AUXDATA)
+			continue;
+
+		aux = (struct tpacket_auxdata_new *)CMSG_DATA(cmsg);
+		if (aux->tp_vlan_tci != 0)
+			return 0;
+	}
+
 	bufix = 0;
 	/* Decode the physical header... */
 	offset = decode_hw_header (interface, ibuf, bufix, hfrom);

Message #22 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Peter Vanpoucke <peter.vanpoucke@heppie.be>

To: 643564@bugs.debian.org

Subject: isc-dhcp-server: responds to vlan tagged packets on untagged interface

Date: Sun, 14 Apr 2013 12:54:08 +0200

Package: isc-dhcp-server
Version: 4.1.1-P1-15+squeeze8

Hi

It seems this bug persists in the squeeze8 version of this package.  The proposed change of Herbert Xu didn't make it in Wheezy either.  Is there an other way to solve this issue?

Kind regards

Peter Vanpoucke

Message #27 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Lorin Weilenmann <lorin.weilenmann@gmail.com>

To: 643564@bugs.debian.org

Subject: still an open issue

Date: Fri, 28 Feb 2014 12:39:32 +0100

[Message part 1 (text/plain, inline)]

I'd also appreciate if this bug could be fixed.

[Message part 2 (text/html, inline)]

Message #32 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Judy Hao <Judy.Hao@brocade.com>

To: "643564@bugs.debian.org" <643564@bugs.debian.org>

Subject: Any plan to resolove this bug

Date: Fri, 28 Mar 2014 10:54:19 -0700

[Message part 1 (text/plain, inline)]

Hi,

We are also experiencing the same issue. Any plan to get this bug resolved?

Thanks,

Judy Hao
Brocade/Vyatta
jhao@brocade.com

[Message part 2 (text/html, inline)]

Message #37 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Jan Černohorský <jan.cernohorsky@ssps.cz>

To: <643564@bugs.debian.org>

Subject: On Jessie version 4.3.1 still the same problem

Date: Wed, 22 Oct 2014 18:10:38 +0200

[Message part 1 (text/plain, inline)]

Hi,
I tested it in cooperation with Slavek Banko with backport version 4.3.1 from Jessie and the problem still exist.
 
Jan Cernohorsky
Secondary Technical School in Prague

[Message part 2 (text/html, inline)]

Message #42 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Jan Černohorský <jan.cernohorsky@ssps.cz>

To: <643564@bugs.debian.org>

Subject: Still the same problem on Wheezy

Date: Wed, 22 Oct 2014 18:03:14 +0200

[Message part 1 (text/plain, inline)]

Hi,
I have the same problem on Debian Wheezy. Version isc-dhcp-server – 4.2.2.dfsg.1-5+deb70u6 .
 
DHCPRELEASE of 173.27.253.22 from 38:60:77:ec:02:a2 (ZAST-02) via eth0 (found) 
DHCPRELEASE of 173.27.253.22 from 38:60:77:ec:02:a2 via eth0.253 (found) 
DHCPDISCOVER from 38:60:77:ec:02:a2 (ZAST-02) via eth0 
DHCPDISCOVER from 38:60:77:ec:02:a2 via eth0.253 
DHCPOFFER on 173.27.253.22 to 38:60:77:ec:02:a2 (ZAST-02) via eth0.253 
DHCPREQUEST for 173.27.253.22 (173.27.253.254) from 38:60:77:ec:02:a2 (ZAST-02) via eth0: wrong network. 
DHCPNAK on 173.27.253.22 to 38:60:77:ec:02:a2 via eth0 
DHCPREQUEST for 173.27.253.22 (173.27.253.254) from 38:60:77:ec:02:a2 (ZAST-02) via eth0.253 
DHCPACK on 173.27.253.22 to 38:60:77:ec:02:a2 (ZAST-02) via eth0.253
 
ZAST-02 is on tagged vlan on eth0.253.
Any plan to get this bug resolved?
 
Thanks,
 
Jan Cernohorsky
Secondary Technical School in Prague

[Message part 2 (text/html, inline)]

Message #55 received at 643564@bugs.debian.org (full text, mbox, reply):

From: Lorin Weilenmann <lorin.weilenmann@gmail.com>

To: 643564@bugs.debian.org

Subject: Fixed in upstream

Date: Thu, 7 May 2015 09:49:47 +0200

[Message part 1 (text/plain, inline)]

Hi,

Just wanted to mention that according to the changelog, this has been fixed
in upstream (since isc-dhcp 4.3.2b1, 4.3.2 has been released some days ago).
See ftp://ftp.isc.org/isc/dhcp/4.3.2/dhcp-4.3.2-RELNOTES

[quote]

- Modified linux packet handling such that packets received via VLAN are now
  seen only by the VLAN interface. Prior to this, such packets were seen by
  both the VLAN interface and its parent (physical) interface, causing the
  server to respond to both.  Note this remains an issue for non-Linux OSs.
  Thanks to Jiri Popelka at Red Hat for the patch.
  [ISC-Bugs #37415]
  [ISC-Bugs #37133]
  [ISC-Bugs #36668]
  [ISC-Bugs #36652]

[/quote]

So all we'd need is a new package with the source from upstream.

Cheers,

Lorin

[Message part 2 (text/html, inline)]

Message #60 received at 643564-close@bugs.debian.org (full text, mbox, reply):

From: Michael Gilbert <mgilbert@debian.org>

To: 643564-close@bugs.debian.org

Subject: Bug#643564: fixed in isc-dhcp 4.3.2-1

Date: Mon, 11 May 2015 00:49:08 +0000

Source: isc-dhcp
Source-Version: 4.3.2-1

We believe that the bug you reported is fixed in the latest version of
isc-dhcp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 643564@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Gilbert <mgilbert@debian.org> (supplier of updated isc-dhcp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 10 May 2015 22:44:17 +0000
Source: isc-dhcp
Binary: isc-dhcp-server isc-dhcp-dbg isc-dhcp-server-ldap isc-dhcp-common isc-dhcp-dev isc-dhcp-client isc-dhcp-client-udeb isc-dhcp-relay
Architecture: source
Version: 4.3.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ISC DHCP maintainers <pkg-dhcp-devel@lists.alioth.debian.org>
Changed-By: Michael Gilbert <mgilbert@debian.org>
Description:
 isc-dhcp-client - DHCP client for automatically obtaining an IP address
 isc-dhcp-client-udeb - ISC DHCP Client for debian-installer (udeb)
 isc-dhcp-common - common files used by all of the isc-dhcp packages
 isc-dhcp-dbg - ISC DHCP server for automatic IP address assignment (debuging sym
 isc-dhcp-dev - API for accessing and modifying the DHCP server and client state
 isc-dhcp-relay - ISC DHCP relay daemon
 isc-dhcp-server - ISC DHCP server for automatic IP address assignment
 isc-dhcp-server-ldap - DHCP server that uses LDAP as its backend
Closes: 353161 643564 652739 773476 781768
Changes:
 isc-dhcp (4.3.2-1) unstable; urgency=medium
 .
   * New upstream stable release.
     - Many fixes to incorrect checksumming (closes: #353161, #652739).
     - VLAN packets now only seen on VLAN interfaces (closes: #643564).
   * Remove references to old dhcp3 packages (closes: #773476).
   * Replace signing key with new upstream version.
   * Fix typo in debug script (closes: #781768).
   * Drop bind from the upstream tarball.
   * Drop transitional debug packages.
   * Drop dhcp3 conffile handling.
   * Update debian/copyright.
Checksums-Sha1:
 c88db5731fce07024072ff4e31a9def1e21a156e 3224 isc-dhcp_4.3.2-1.dsc
 b926ba6510654f839d03895076ed038d91184061 1098189 isc-dhcp_4.3.2.orig.tar.gz
 e3d7aab692823b8421bca47e4c79df4dc135e660 77564 isc-dhcp_4.3.2-1.debian.tar.xz
Checksums-Sha256:
 f64ec4a2a889e051b88cc3b92977c360e59a5b9aac58d3bb10d7ad12bbea321b 3224 isc-dhcp_4.3.2-1.dsc
 b572785a995511286f1be0e76388d1c3b76ee23652f722beb2f5eba3ac66c606 1098189 isc-dhcp_4.3.2.orig.tar.gz
 51356579e0be414c40f3507d5a8453265f86e0ebf9de75a99f885cf4443d6e4f 77564 isc-dhcp_4.3.2-1.debian.tar.xz
Files:
 438e84cd36401834724bbe2169b4e5fb 3224 net important isc-dhcp_4.3.2-1.dsc
 b17e61d8142f5a81d4ed833dbd72e12a 1098189 net important isc-dhcp_4.3.2.orig.tar.gz
 c3163ec653ef6046e369da34e7aa2245 77564 net important isc-dhcp_4.3.2-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQQcBAEBCgAGBQJVT/lgAAoJELjWss0C1vRzqeof/00JvfOtBmZSR8JH3sOaQpHy
jd+/nXVZ6OSDtgIHOjqmd31ucNE5czqPfv6BXL50lg/YNmJSwCKmHGLnJpDLaFbA
jsJY8QR6pv72LWszz59aa35OWluWEYWTL+kPFmUOvdGYrRpekM8ulCSlNm0/gz2z
hhd+HsMVgeow1vWRu+YIXmzoMEF8lct10ChpivKbdxSxLjaXIYRzPSURlwu04W+G
HmsV48a9fbzV1ek+kfiZgWnxbTX/nPDsfwWtTrzyZc+7fbwnBHHDc41gEerEYHbz
BnbyrantiwauVh3iBLXZmRMjdOqJ7mvMo8hCQR7cfxpkgyWRwswKxt76Eg73hkW3
+KzY7A4AiovRTDTyNeoHsJ6XzXHGOhp96h7SLS3hXoBwjTmyOPZbqKHkTXpFLlC/
D6cXXeL4NErpikH0qhYNa0iMn0gKkecBZaVUbj+wcwU47citblptghuN44b14ZS4
kWhCPiogcm6j/sFEWeEFaXM+fu24deI2m9LobaolCxd5gFkyINQlaafjpkjpKKS7
1c+97ktDnvs9lLnv6QntS3YsnKYO+msnZO5NBdvMP8FMrShJodMdRCQG0NIUU1Vm
Kg8dDdYo49iIHj1l0V6KsyQdsJV+cnUvHY8xQtDJ0wR/5ldWHddRNAVzZ+iu67r4
C/XpoBUEVeWoceUbadrH1KBJUuYAH6lD3HvxM1zJDdOpS9Myx4d/0Io5F+ULAQu/
V5YZ4GmzYSGGvw5mMRFsHHTsqSWP2JT0lpDiwwsZ9gTxOhQLrYj4d6JR0p+DvYvx
IxcI7Hmv9kkV0+4u39HqwS5SeCK8LxCbdffFJv8Gdg2wGHvYysCrMR1aEGDkLZG+
63nH04nWX9ZwWGERnnYk+LuV875D3JtAP5u9oyfVh/ymQ0Mx57OjAKCeB+6erwMH
IhZKhFoz1D+5Rahw4Hv/m3FoREsAl7DSfnUwHBZ/5cDqVe9skibTsdmt2LLWu9J+
ajfWn1ZUobxS/Aiymdcy+JBd1ZK28DF7Jf/t8RHJDpwgqAIzBVdtYuRzaM5aM3HH
QkFdYsaC2/jktcb1AZ10OXVnj6lAPanbYW4nqdJs/N69epkWaFFykc7JUdDuUFOG
bcWx9ajreERj7yKh7znMa8MbK3TfdWKh7M2dZ2oDhJdm/x+D4OeHAaAQIc9UzhUn
tnVg3uvhRSocL6G0IpcrDwVxk+5VCfeA9+akYH4xh7Qm6/o0NgxdCPYqSoOkyKmk
R9jTeN2821sbojla2k7aKjGGG4zGFmaNLllNuwyChjJHqOBX45RWhZLZWX4g1sKa
7Cm6KJDHitLoVBr38xE6ct+SU8UB6bUVzMlCPa08p1YskHWN3iVeZfGSUXcL8CE=
=hZXN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.