Debian Bug report logs - #636512
acl: Fix FTBFS on hurd-i386

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Svante Signell <srs@kth.se>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: acl: Fix FTBFS on hurd-i386

Date: Wed, 03 Aug 2011 19:36:27 +0200

[Message part 1 (text/plain, inline)]

Package: acl
Version: 2.2.51-3
Severity: important
Tags: patch
User: debian-hurd@lists.debian.org
Usertags: hurd

Hi,

currently acl does not compile on hurd-i386. The problem is a PATH_MAX
definition which is not supported on GNU/Hurd. Attached are two patches
which fixes these issues. First patch is conditioned on __GNU__ and will
not affect other systems, while the second patch is changing behaviour
for all systems (and assuming getline is available).

Thanks,
Svante

[fix_ftbfs4hurd.patch (text/x-patch, attachment)]

[alt_fix_ftbfs4hurd.patch (text/x-patch, attachment)]

Message #10 received at 636512@bugs.debian.org (full text, mbox, reply):

From: Aníbal Monsalve Salazar <anibal@debian.org>

To: srs@kth.se, 636512@bugs.debian.org

Cc: debian-hurd@lists.debian.org

Subject: Re: Bug#636512: acl: Fix FTBFS on hurd-i386

Date: Mon, 29 Aug 2011 21:55:10 +1000

[Message part 1 (text/plain, inline)]

On Wed, Aug 03, 2011 at 07:36:27PM +0200, Svante Signell wrote:
>Package: acl
>Version: 2.2.51-3
>Severity: important
>Tags: patch
>User: debian-hurd@lists.debian.org
>Usertags: hurd
>
>Hi,
>
>currently acl does not compile on hurd-i386. The problem is a PATH_MAX
>definition which is not supported on GNU/Hurd. Attached are two patches
>which fixes these issues. First patch is conditioned on __GNU__ and will
>not affect other systems, while the second patch is changing behaviour
>for all systems (and assuming getline is available).
>
>Thanks,
>Svante

I don't have a hurd system and would like to know if acl compiled with
the first patch still works correctly on a hurd system.

>--- acl-2.2.51/setfacl/parse.c.orig	2010-01-22 23:00:28.000000000 +0000
>+++ acl-2.2.51/setfacl/parse.c	2011-08-03 17:03:19.000000000 +0000
>@@ -419,7 +419,13 @@
> 	  bytes for "# file: ". Not a good solution but for now it is the
> 	  best I can do without too much impact on the code. [tw]
> 	*/
>+
>+#ifdef __GNU__
>+	char *linebuf;
>+	size_t dummy = 0;
>+#else
> 	char linebuf[(4*PATH_MAX)+9];
>+#endif
> 	char *cp;
> 	char *p;
> 	int comments_read = 0;
>@@ -449,9 +455,13 @@
> 		if (line)
> 			(*line)++;
> 
>+#ifdef __GNU__
>+		if (getline(&linebuf, &dummy, file) == -1)
>+			break;
>+#else
> 		if (fgets(linebuf, sizeof(linebuf), file) == NULL)
> 			break;
>-		
>+#endif		
> 		comments_read = 1;
> 
> 		p = strrchr(linebuf, '\0');
>@@ -473,7 +483,12 @@
> 					goto fail;
> 				*path_p = (char*)malloc(strlen(cp)+1);
> 				if (!*path_p)
>+				  {
>+#ifdef __GNU__
>+				    free (linebuf);
>+#endif
> 					return -1;
>+				  }
> 				strcpy(*path_p, cp);
> 			}
> 		} else if (strncmp(cp, "owner:", 6) == 0) {
>@@ -522,13 +537,24 @@
> 		}
> 	}
> 	if (ferror(file))
>+	  {
>+#ifdef __GNU__
>+	    free (linebuf);
>+#endif
> 		return -1;
>+	  }
>+#ifdef __GNU__
>+	free (linebuf);
>+#endif
> 	return comments_read;
> fail:
> 	if (path_p && *path_p) {
> 		free(*path_p);
> 		*path_p = NULL;
> 	}
>+#ifdef __GNU__
>+	free (linebuf);
>+#endif
> 	return -EINVAL;
> }
> 

>--- acl-2.2.51/setfacl/parse.c.orig	2010-01-22 23:00:28.000000000 +0000
>+++ acl-2.2.51/setfacl/parse.c		2011-08-03 17:10:24.000000000 +0000
>@@ -419,7 +419,9 @@
> 	  bytes for "# file: ". Not a good solution but for now it is the
> 	  best I can do without too much impact on the code. [tw]
> 	*/
>-	char linebuf[(4*PATH_MAX)+9];
>+
>+	char *linebuf;
>+	size_t dummy = 0;
> 	char *cp;
> 	char *p;
> 	int comments_read = 0;
>@@ -449,9 +451,8 @@
> 		if (line)
> 			(*line)++;
> 
>-		if (fgets(linebuf, sizeof(linebuf), file) == NULL)
>+		if (getline(&linebuf, &dummy, file) == -1)
> 			break;
>-		
> 		comments_read = 1;
> 
> 		p = strrchr(linebuf, '\0');
>@@ -472,8 +473,10 @@
> 				if (*path_p)
> 					goto fail;
> 				*path_p = (char*)malloc(strlen(cp)+1);
>-				if (!*path_p)
>-					return -1;
>+				if (!*path_p) {
>+				  free (linebuf);
>+				  return -1;
>+				}
> 				strcpy(*path_p, cp);
> 			}
> 		} else if (strncmp(cp, "owner:", 6) == 0) {
>@@ -521,14 +524,18 @@
> 				*flags = f;
> 		}
> 	}
>-	if (ferror(file))
>-		return -1;
>+	if (ferror(file)) {
>+	   free (linebuf);
>+	   return -1;
>+	}
>+	free (linebuf);
> 	return comments_read;
> fail:
> 	if (path_p && *path_p) {
> 		free(*path_p);
> 		*path_p = NULL;
> 	}
>+	free (linebuf);
> 	return -EINVAL;
> }
> 

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 636512@bugs.debian.org (full text, mbox, reply):

From: Svante Signell <srs@kth.se>

To: Aníbal Monsalve Salazar <anibal@debian.org>

Cc: 636512@bugs.debian.org, debian-hurd@lists.debian.org

Subject: Re: Bug#636512: acl: Fix FTBFS on hurd-i386

Date: Mon, 29 Aug 2011 15:00:10 +0200

On Mon, 2011-08-29 at 21:55 +1000, Aníbal Monsalve Salazar wrote:
> On Wed, Aug 03, 2011 at 07:36:27PM +0200, Svante Signell wrote:
> >Package: acl
> >Version: 2.2.51-3
> >Severity: important
> >Tags: patch
> >User: debian-hurd@lists.debian.org
> >Usertags: hurd
> >
> >Hi,
> >
> >currently acl does not compile on hurd-i386. The problem is a PATH_MAX
> >definition which is not supported on GNU/Hurd. Attached are two patches
> >which fixes these issues. First patch is conditioned on __GNU__ and will
> >not affect other systems, while the second patch is changing behaviour
> >for all systems (and assuming getline is available).
> >
> >Thanks,
> >Svante
> 
> I don't have a hurd system and would like to know if acl compiled with
> the first patch still works correctly on a hurd system.

I would assume it would build OK. Currently this package is more or less
a dummy packages since it depends on libattr1 which does not yet support
the Linux API for extended attributes.

Samuel, correct me if I'm wrong here!

Message #20 received at 636512@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Aníbal Monsalve Salazar <anibal@debian.org>, 636512@bugs.debian.org

Cc: srs@kth.se, debian-hurd@lists.debian.org

Subject: Re: Bug#636512: acl: Fix FTBFS on hurd-i386

Date: Thu, 3 Nov 2011 01:23:01 +0100

Hello,

acl is now blocking the whole KDE stuff.

Aníbal Monsalve Salazar, le Mon 29 Aug 2011 21:55:10 +1000, a écrit :
> I don't have a hurd system and would like to know if acl compiled with
> the first patch still works correctly on a hurd system.

How to test that?
Please help us to help you.

Samuel

Message #25 received at 636512-close@bugs.debian.org (full text, mbox, reply):

From: Anibal Monsalve Salazar <anibal@debian.org>

To: 636512-close@bugs.debian.org

Subject: Bug#636512: fixed in acl 2.2.51-4

Date: Fri, 04 Nov 2011 03:17:14 +0000

Source: acl
Source-Version: 2.2.51-4

We believe that the bug you reported is fixed in the latest version of
acl, which is due to be installed in the Debian FTP archive:

acl_2.2.51-4.debian.tar.bz2
  to main/a/acl/acl_2.2.51-4.debian.tar.bz2
acl_2.2.51-4.dsc
  to main/a/acl/acl_2.2.51-4.dsc
acl_2.2.51-4_mipsel.deb
  to main/a/acl/acl_2.2.51-4_mipsel.deb
libacl1-dev_2.2.51-4_mipsel.deb
  to main/a/acl/libacl1-dev_2.2.51-4_mipsel.deb
libacl1_2.2.51-4_mipsel.deb
  to main/a/acl/libacl1_2.2.51-4_mipsel.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 636512@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <anibal@debian.org> (supplier of updated acl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 04 Nov 2011 12:00:03 +1100
Source: acl
Binary: acl libacl1-dev libacl1
Architecture: source mipsel
Version: 2.2.51-4
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Changed-By: Anibal Monsalve Salazar <anibal@debian.org>
Description: 
 acl        - Access control list utilities
 libacl1    - Access control list shared library
 libacl1-dev - Access control list static libraries and headers
Closes: 636512
Changes: 
 acl (2.2.51-4) unstable; urgency=low
 .
   * Fix FTBFS on hurd-i386
     Add 11-636512-fix-ftbfs4hurd.patch
     Patch by Svante Signell
     Closes: 636512
Checksums-Sha1: 
 03fac832ebc7203f381418fc21f9ed9fa4467b6c 2012 acl_2.2.51-4.dsc
 23e212f6a802568a90ae82be746cea0194e76acb 7161 acl_2.2.51-4.debian.tar.bz2
 1398e5b8aacc9fb3c9f0d8fa335b9949a460d940 69218 acl_2.2.51-4_mipsel.deb
 17d2a834a82a5624f99677232839709f5ad1ab1e 92062 libacl1-dev_2.2.51-4_mipsel.deb
 c91388a2839098b287998f5bf9f35a38fee06623 28194 libacl1_2.2.51-4_mipsel.deb
Checksums-Sha256: 
 33d58271f4bd043c3e1bafba9c5f95b35a80f54b0c210ccfb3cc30a692de1413 2012 acl_2.2.51-4.dsc
 af93e5c3c31645c8abae8f8694eda8558b53afacc6cd8fdc15c126bc2d2767d6 7161 acl_2.2.51-4.debian.tar.bz2
 081546267ced224333155aaa442779a1efd5ff18d1874b9d4999e6201749a0fb 69218 acl_2.2.51-4_mipsel.deb
 cc9a1a36d02b369f84eeea34426412e1410eeac739fbce4e2e02f077693642b0 92062 libacl1-dev_2.2.51-4_mipsel.deb
 4c97d966e504d1bad77fbfd2b14f2ab5c7984a06a52b69e825ff207c15898c24 28194 libacl1_2.2.51-4_mipsel.deb
Files: 
 3732095e8f18dece901620a543abce61 2012 utils optional acl_2.2.51-4.dsc
 b822ead7cdf96b75da95e0fc49e9065e 7161 utils optional acl_2.2.51-4.debian.tar.bz2
 160ead6099d01e7a95a3e63449fd7f5c 69218 utils optional acl_2.2.51-4_mipsel.deb
 ddc0a5439ac0d3e868132693f684773e 92062 libdevel extra libacl1-dev_2.2.51-4_mipsel.deb
 52caa0a71686ad432a0b8fd4665eb0fd 28194 libs required libacl1_2.2.51-4_mipsel.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOs0NCAAoJEHxWrP6UeJfYyccQAM4IK7eW8hDYI+bG+ueW86Ip
V25LBVyiKebmkMX5HHvZgOHECfNXXqzA5ffr9oLwPrJmXOz6Ggggp6aj7gPtnFB/
CWK9tIpEbHY0LSl5dajKukP7uiUnYsPPvX4May6aKwwR+YFLPX9ZMwiKeu2KGYLU
Xc+d8bSLnB74infJ0XUwFIbchEA1bTdH4wyNMGSwC9QunNWiKsY2Jez5Yj8AUPCR
KgX4i9TEz6uq7v5TiALp0cyCTVi66dRJ1N701EBSskxqdhY9o8f6ckdiIoNaZMEW
/m0vgd1u94zx+zOh+mYS8SGFq1hGPijLtX8LU2bdl4iQvni3pHu1Z0q03gQ+nJNX
i/YVKxAPQtKk1WnUprdReQnHjhNGJtEtKbJ+yIUres+hKUN4pl8q2ODo2jcZgGr/
eGe5HBA3rzUrnty9mU3u1wrYXI4hlT6Qwy7m9Hxf1wpMNPykzqI3Qfpv844yVuL8
1CNpjh3t2nzShNgAMS0Si8SXoP0zDUSoJPdvmrBmoCY6o2VRIrXBQ64Hwej1ghyz
l7sFVWCeut74FqhA/pKfVCWhafFiRC0KfBXO9Ss6GMhkwqzhbigBjISyHgMIL67f
uzaN6VFZbhQyvPWp7fwJGnfmTX1bJTeF3lDmCoI5D4F8ATvBGeAvSeh5/6R6XfwD
i9GB8WWi11656nn8bLVa
=BW+R
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.