Debian Bug report logs - #636228
"git log --all" includes boring refs like refs/notes/*

version graph

Package: git; Maintainer for git is Gerrit Pape <pape@smarden.org>; Source for git is src:git.

Reported by: martin f krafft <madduck@debian.org>

Date: Mon, 1 Aug 2011 15:39:12 UTC

Severity: wishlist

Tags: upstream

Found in version git/1:1.7.5.4-1

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Gerrit Pape <pape@smarden.org>:
Bug#636228; Package gitk. (Mon, 01 Aug 2011 15:39:14 GMT) Full text and rfc822 format available.

Acknowledgement sent to martin f krafft <madduck@debian.org>:
New Bug report received and forwarded. Copy sent to Gerrit Pape <pape@smarden.org>. (Mon, 01 Aug 2011 15:39:14 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: martin f krafft <madduck@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: ability to hide refs/notes/* namespace
Date: Mon, 1 Aug 2011 12:36:31 +0200
[Message part 1 (text/plain, inline)]
Package: gitk
Version: 1:1.7.5.4-1
Severity: wishlist
File: /usr/bin/gitk
Tags: upstream

Git notes are managed in a separate DAG in the same repo. I would be
tempted to argue that noone really cares about this implementation
detail, especially not if you can manage Git notes via gitk's
interface.

Please provide the ability to hide commits only reachable from the
refs/notes/commit ref.

I would say that these should be hidden by default.

Please also make the refname (refs/notes/commit) configurable and
extensible (allow multiple ones to be specified).

This feature could also be used to hide pristine-tar branches, or
refs/top-bases/*, so it might be worthwhile to make (or just name)
it more generic.

Maybe an additional option could control whether refs should be
shown in gitk on commits, when they are reachable from visible
refs. For instance, I might choose to hide refs/top-bases/*, but
some other path (from a branch head) might include commits
referenced by refs/top-bases/*. In this case it would be good if the
refs/top-bases/* refs didn't show up in the standard gitk display,
but some users might want to make this configurable. I would say it
should default to now show.

Upon inspection of the gitk references, I found that gitk allows one
to specify which refs to include. My feature request is the
opposite, an exclude filter.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_NZ, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gitk depends on:
ii  git                          1:1.7.5.4-1 fast, scalable, distributed revisi
ii  tk                           8.5.0-2     The Tk toolkit for Tcl and X11 (de

gitk recommends no packages.

Versions of packages gitk suggests:
pn  git-doc                       <none>     (no description available)

-- no debconf information


-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
[digital_signature_gpg.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Gerrit Pape <pape@smarden.org>:
Bug#636228; Package gitk. (Tue, 02 Aug 2011 20:33:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jonathan Nieder <jrnieder@gmail.com>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <pape@smarden.org>. (Tue, 02 Aug 2011 20:33:03 GMT) Full text and rfc822 format available.

Message #10 received at 636228@bugs.debian.org (full text, mbox):

From: Jonathan Nieder <jrnieder@gmail.com>
To: martin f krafft <madduck@debian.org>
Cc: 636228@bugs.debian.org
Subject: Re: ability to hide refs/notes/* namespace
Date: Tue, 2 Aug 2011 22:27:52 +0200
retitle 636228 "git log --all" includes boring refs like refs/notes/*
reassign 636228 git 1:1.7.5.4-1
quit

Hi Martin,

martin f krafft wrote:

> Git notes are managed in a separate DAG in the same repo. I would be
> tempted to argue that noone really cares about this implementation
> detail, especially not if you can manage Git notes via gitk's
> interface.

Does "gitk --branches --tags --remotes" do the trick?  If not, what do
you think a good UI would look like?

(Example: a new option used like "gitk --all --exclude=notes", with a
configuration variable "[log] excluderef" to determine a default set
of excluded refs.  Probably needs some tweak to prevent confusion when
commands like "gitk <name of a notes ref>" or "gitk
--glob=refs/notes/*" show nothing.)




Changed Bug title to '"git log --all" includes boring refs like refs/notes/*' from 'ability to hide refs/notes/* namespace' Request was from Jonathan Nieder <jrnieder@gmail.com> to control@bugs.debian.org. (Tue, 02 Aug 2011 20:33:05 GMT) Full text and rfc822 format available.

Bug reassigned from package 'gitk' to 'git'. Request was from Jonathan Nieder <jrnieder@gmail.com> to control@bugs.debian.org. (Tue, 02 Aug 2011 20:33:06 GMT) Full text and rfc822 format available.

Bug No longer marked as found in versions git/1:1.7.5.4-1. Request was from Jonathan Nieder <jrnieder@gmail.com> to control@bugs.debian.org. (Tue, 02 Aug 2011 20:33:06 GMT) Full text and rfc822 format available.

Bug Marked as found in versions git/1:1.7.5.4-1. Request was from Jonathan Nieder <jrnieder@gmail.com> to control@bugs.debian.org. (Tue, 02 Aug 2011 20:33:07 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Gerrit Pape <pape@smarden.org>:
Bug#636228; Package git. (Tue, 02 Aug 2011 22:15:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to martin f krafft <madduck@debian.org>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <pape@smarden.org>. (Tue, 02 Aug 2011 22:15:07 GMT) Full text and rfc822 format available.

Message #23 received at 636228@bugs.debian.org (full text, mbox):

From: martin f krafft <madduck@debian.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: 636228@bugs.debian.org
Subject: Re: ability to hide refs/notes/* namespace
Date: Wed, 3 Aug 2011 00:13:56 +0200
[Message part 1 (text/plain, inline)]
also sprach Jonathan Nieder <jrnieder@gmail.com> [2011.08.02.2227 +0200]:
> Does "gitk --branches --tags --remotes" do the trick?  If not, what do
> you think a good UI would look like?

Since notes are also shown in the commit message display of gitk
(cf. #636226), having their DAG show up seems redundant. In
addition, the notes commits are an implementation detail. Therefore,
I tend to think that refs/notes/* or at least refs/notes/commit
should /not/ show up unless /explicitly/ selected, e.g. with
--notes…

> (Example: a new option used like "gitk --all --exclude=notes", with a
> configuration variable "[log] excluderef" to determine a default set
> of excluded refs.  Probably needs some tweak to prevent confusion when
> commands like "gitk <name of a notes ref>" or "gitk
> --glob=refs/notes/*" show nothing.)

… or unless a ref within that DAG is specified explicitly.

My original suggestion was not to special-case notes, but to provide
a generic exclude mechanism. Other candidates I can think of are
refs/heads/pristine-tar (probably a Debian-only configuration
default) and refs/top-bases/* (arguably a default, since most people
do not use TopGit (yet)).

I think a configuration option list of refs to exclude, which is set
to refs/notes/* by default (adding refs/heads/pristine-tar on
Debian) would do. Since gitk only shows commits reachable by visible
refs, this would do, and it would provide everyone with the ability
to further adapt gitk to their own preference.

Thank you for your consideration!

-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
 
"first get your facts; then you can distort them at your leisure."
                                                       -- mark twain
[digital_signature_gpg.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 11:27:24 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.