Debian Bug report logs - #616018
acroread.sh completion breaks bash_completion

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michal Hocko <mstsxfx@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: bash_completion adds a space at the end of every diretory name and other issues with completing (e.g. sudo)

Date: Tue, 1 Mar 2011 21:57:24 +0100

Package: bash-completion
Version: 1:1.3-1
Severity: important

Hi,
since the last (? I really do not remember after which update but it was
quite recently) bash_completion is not working as expected. 

For example ls /e[TAB] expands into ls /etc[SPACE] while the directory
is apparently not empty. Other example is sudo. It used to auto-complete
sudo /etc/init.d/openvpn start O[TAB] to OpenvpnName but now it doesn't
do anything.

I have seen a similar issue on the Arch Linux forums
(https://bbs.archlinux.org/viewtopic.php?id=113158) but the proposed
solution (remove _filedir function definition from the
'/etc/bash_completion.d/acroread) didn't work.

What really works for me is to either downgrade to the stable version or
replace /etc/bash_completion file by the one from the stable release.
The diff between testing and stable version is, however, too big and the
only one that mentions sudo doesn't seem to be relevant so I assume a
deeper problem.

Is this a known issue? I do not see anything in the bug tracker. Is
there anything that would help with debugging?


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-rc6-00166-g493f335 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash

Versions of packages bash-completion depends on:
ii  bash                          4.1-3      The GNU Bourne Again SHell

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

-- 
Michal Hocko

Message #10 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Ville Skyttä <ville.skytta@iki.fi>

To: Michal Hocko <mstsxfx@gmail.com>, 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: bash_completion adds a space at the end of every diretory name and other issues with completing (e.g. sudo)

Date: Tue, 01 Mar 2011 23:20:24 +0200

FWIW the file that should be modified is 
/etc/bash_completion.d/acroread.sh (note *.sh) at least when the Adobe 
Reader rpm package is installed.  Don't know about other systems.  You 
did start a new shell after modifying the file, right?

If that doesn't help, do a "set -x" in a shell, then do "ls /et<TAB>" 
and post the output.

Message #15 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Mikhail Lukyanchenko <ml@uptimebox.ru>

To: 616018@bugs.debian.org

Subject: Re: bash_completion adds a space at the end of every diretory name and other issues with completing (e.g. sudo)

Date: Mon, 7 Mar 2011 10:49:56 +0300

I can confirm that removing `/etc/bash_completion.d/acroread.sh`
solves the problem.

--
Regards,
  Mikhail

Message #20 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Robert Helling <helling@atdotde.de>

To: 616018@bugs.debian.org

Subject: Re: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 17:22:32 +0100

It seems that lines 11/12

    COMPREPLY=( ${COMPREPLY[@]:-} $( compgen -f -X "$xspec" -- "$cur" ) \
            $( compgen -d -- "$cur" ) )

are the offenders. Unfortunately, this looks like line noise to me...

Robert

Message #25 received at 616018@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: Robert Helling <helling@atdotde.de>

Cc: 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 18:06:57 +0100

[Message part 1 (text/plain, inline)]

On Tue, 22 Mar 2011 17:22:32 +0100, Robert Helling wrote:

> It seems that lines 11/12
> 
>     COMPREPLY=( ${COMPREPLY[@]:-} $( compgen -f -X "$xspec" -- "$cur" ) \
>             $( compgen -d -- "$cur" ) )
> 
> are the offenders. Unfortunately, this looks like line noise to me...

Robert,
please read Ville's message

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616018#10

It's probably acroread's completion fault.

David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, attachment)]

Message #34 received at 616018@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: helling@lmu.de

Cc: 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 18:18:10 +0100

[Message part 1 (text/plain, inline)]

On Tue, 22 Mar 2011 18:14:43 +0100 (CET), Robert C. Helling wrote:

> On Tue, 22 Mar 2011, David Paleino wrote:
> 
> > On Tue, 22 Mar 2011 17:22:32 +0100, Robert Helling wrote:
> >
> >> It seems that lines 11/12
> >>
> >>     COMPREPLY=( ${COMPREPLY[@]:-} $( compgen -f -X "$xspec" -- "$cur" ) \
> >>             $( compgen -d -- "$cur" ) )
> >>
> >> are the offenders. Unfortunately, this looks like line noise to me...
> >
> > Robert,
> > please read Ville's message
> >
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616018#10
> >
> > It's probably acroread's completion fault.
> 
> I was referring to that mail. The two lines I quoted are from 
> /etc/bash_completion.d/acroread.sh
> 
> I just figured I need to comment out those two lines for the bug to go 
> away for me. It is my understanding, that acroread is not run, it is just 
> the file that handles completions for lines starting with
> 
> $ acroread ...
> 
> But the bug occurs also for
> 
> $ ls /e[TAB]
> [..]

Yes, because "acroread.sh" redefines completion functions used by each other
completion installed.

My mail meant: acroread.sh is not shipped by us. It's shipped by acroread's
package, thus we can't really do anything :/

Kindly,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[signature.asc (application/pgp-signature, attachment)]

Message #39 received at 616018@bugs.debian.org (full text, mbox, reply):

From: "Robert C. Helling" <helling@lmu.de>

To: David Paleino <dapal@debian.org>

Cc: 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 18:14:43 +0100 (CET)

On Tue, 22 Mar 2011, David Paleino wrote:

> On Tue, 22 Mar 2011 17:22:32 +0100, Robert Helling wrote:
>
>> It seems that lines 11/12
>>
>>     COMPREPLY=( ${COMPREPLY[@]:-} $( compgen -f -X "$xspec" -- "$cur" ) \
>>             $( compgen -d -- "$cur" ) )
>>
>> are the offenders. Unfortunately, this looks like line noise to me...
>
> Robert,
> please read Ville's message
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616018#10
>
> It's probably acroread's completion fault.

I was referring to that mail. The two lines I quoted are from 
/etc/bash_completion.d/acroread.sh

I just figured I need to comment out those two lines for the bug to go 
away for me. It is my understanding, that acroread is not run, it is just 
the file that handles completions for lines starting with

$ acroread ...

But the bug occurs also for

$ ls /e[TAB]

as this is wrongly completed to

$ ls /etc[SPACE]

rather than

$ ls /etc/

I would be surprised if the bug is not in those two lines somehow but in 
acroread itself.

Just my $.02

Robert

-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
		      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
    stupid .sig\n";   http://www.atdotde.de

Message #44 received at 616018@bugs.debian.org (full text, mbox, reply):

From: "Robert C. Helling" <helling@lmu.de>

To: David Paleino <dapal@debian.org>

Cc: 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 18:44:57 +0100 (CET)

On Tue, 22 Mar 2011, David Paleino wrote:

> On Tue, 22 Mar 2011 18:14:43 +0100 (CET), Robert C. Helling wrote:
>
>> On Tue, 22 Mar 2011, David Paleino wrote:

> My mail meant: acroread.sh is not shipped by us. It's shipped by acroread's
> package, thus we can't really do anything :/

Ok, I see. Now, I filed a bug report with adobe.com pointing to this page. 
Let's see what happens.

Thanks for your clarification.

Robert

-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
		      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
    stupid .sig\n";   http://www.atdotde.de

Message #49 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Robby Workman <rworkman@slackware.com>

To: helling@atdotde.de, 616018@bugs.debian.org

Cc: David Paleino <dapal@debian.org>, "Robert C. Helling" <helling@lmu.de>, debian-bugs-dist@lists.debian.org, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>

Subject: Re: [Bash-completion-devel] Bug#616018: Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 10:56:22 -0700 (PDT)

On Tue, 22 Mar 2011, Robert C. Helling wrote:

> On Tue, 22 Mar 2011, David Paleino wrote:
>
>> On Tue, 22 Mar 2011 18:14:43 +0100 (CET), Robert C. Helling wrote:
>> 
>>> On Tue, 22 Mar 2011, David Paleino wrote:
>
>> My mail meant: acroread.sh is not shipped by us. It's shipped by acroread's
>> package, thus we can't really do anything :/
>
> Ok, I see. Now, I filed a bug report with adobe.com pointing to this page. 
> Let's see what happens.


I thought this was already fixed by them in their latest release.

-RW

Message #54 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Ville Skyttä <ville.skytta@iki.fi>

To: 616018@bugs.debian.org

Subject: Re: [Bash-completion-devel] Bug#616018: Bug#616018: Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Tue, 22 Mar 2011 22:59:07 +0200

On 03/22/2011 07:56 PM, Robby Workman wrote:
> On Tue, 22 Mar 2011, Robert C. Helling wrote:
> 
>> Ok, I see. Now, I filed a bug report with adobe.com pointing to this page. 
>> Let's see what happens.

How did you find out where to file the report, and do you have a link to
the report?

Back in October, I searched for a way to file the bug, and the closest I
could find at that time was to post on their forums which is what I did,
but haven't seen any responses:
    http://forums.adobe.com/thread/745833

> I thought this was already fixed by them in their latest release.

The 9.4.2 US English *.deb and *.rpm available from their site still
(re)define the _filedir() function.  As long as that happens and we use
it, pretty much all bets are off - I wouldn't spend time finding out
exactly what bits in their implementation are the ones that cause problems.

I'm tempted to add a "readonly -f _filedir" in bash_completion to make
it clearer to people that something's wrong, and to protect our
implementation from being overridden.  The acroread completion shipped
by Adobe should continue to work just as it does now if it ended up
using our _filedir().

But on the other hand, we have a "namespace prefix" roadmap item for 2.0
for all functions in bash-completion which when/if implemented would
make this particular issue moot as it stands now.
http://wiki.debian.org/Teams/BashCompletion/Proposals/Roadmap

Message #59 received at 616018@bugs.debian.org (full text, mbox, reply):

From: "Robert C. Helling" <helling@lmu.de>

To: Ville Skyttä <ville.skytta@iki.fi>, 616018@bugs.debian.org

Cc: debian-bugs-dist@lists.debian.org, Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>

Subject: Re: Bug#616018: [Bash-completion-devel] Bug#616018: Bug#616018: Bug#616018: bash_completion adds a space at the end of every diretory name, and other issues with completing (e.g. sudo)

Date: Wed, 23 Mar 2011 12:45:54 +0100 (CET)

[Message part 1 (text/plain, inline)]

On Tue, 22 Mar 2011, Ville Skyttä wrote:

> On 03/22/2011 07:56 PM, Robby Workman wrote:
>> On Tue, 22 Mar 2011, Robert C. Helling wrote:
>>
>>> Ok, I see. Now, I filed a bug report with adobe.com pointing to this page.
>>> Let's see what happens.
>
> How did you find out where to file the report, and do you have a link to
> the report?
>
> Back in October, I searched for a way to file the bug, and the closest I
> could find at that time was to post on their forums which is what I did,
> but haven't seen any responses:
>    http://forums.adobe.com/thread/745833

When I tried yesterday, their forums were down so I could not search 
there. So I went to www.adobe.com clicked on "Contact Adobe" on the 
bottom, selected "Feedback" and clicked "Report a bug" which brings up a 
web form where I briefly described the bug and pointed to the page in the 
Debian bug tracking.

Best
Robert

-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
		      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
    stupid .sig\n";   http://www.atdotde.de

Message #79 received at 616018@bugs.debian.org (full text, mbox, reply):

From: "FedEx SmartPost" <anne@funmuseum.org>

To: <616018@bugs.debian.org>

Subject: Shipment delivery problem #34286

Date: Tue, 8 Nov 2016 18:06:36 +0300

[Message part 1 (text/plain, inline)]

Hello,
Courier was unable to deliver the parcel to you. Please, open email attachment to print shipment label.
Jule Tesmer - Area Manager FedEx , CA
Sincerely

[FedEx.doc (application/msword, attachment)]

Message #84 received at 616018@bugs.debian.org (full text, mbox, reply):

From: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>

To: <616018@bugs.debian.org>, <mstsxfx@gmail.com>

Subject: Bug#616018: Updating flags and preparing to close

Date: Fri, 9 Nov 2018 22:17:32 -0200

Control: tags -1 + unreproducible
Control: tags -1 - wontfix

According to Debian's webpage on PDFs [1], Adobe's Acrobat Reader
(acroread), can be installed from two different sources:

1. deb-multimedia.org

I downloaded the .deb files from this server and none of them contains
a completion file.

    wget http://www.deb-multimedia.org/pool/non-free/a/adobereader-enu/acroread_9.5.5-dmo2_i386.deb
    wget http://www.deb-multimedia.org/pool/non-free/a/adobereader-enu/acroread-data_9.5.5-dmo2_all.deb
    wget http://www.deb-multimedia.org/pool/non-free/a/adobereader-enu/acroread-plugins_9.5.5-dmo2_i386.deb
    wget http://www.deb-multimedia.org/pool/main/a/acroread-debian-files/acroread-debian-files_9.5.8_amd64.deb
    wget http://www.deb-multimedia.org/pool/non-free/a/adobereader-enu/acroread-l10n-en_9.5.5-dmo2_all.deb

    find . -maxdepth 1 -name "*acroread*" \
         -exec dpkg-deb --contents {} \; \
    | grep completion
    (no output)

2. Adobe's FTP server [2]

While the latest .deb file does contain a completion file, it is empty,
thus, installing it under /etc/bash_completion.d/ (yes, it was
installed in the obsolete directory), did not reproduce the problem.

    wget ftp://ftp.adobe.com/pub/adobe/reader/unix/9.x/9.5.5/enu/AdbeRdr9.5.5-1_i386linux_enu.deb

    dpkg-deb --extract AdbeRdr9.5.5-1_i386linux_enu.deb expand/
    cat expand/etc/bash_completion.d/acroread.sh 
    (no output)

Since I cannot reproduce this bug, I'll add the unreproducible tag to
it and leave it open for some time.  Afterwards, I'll close the bug.

If you have more information about it, do not resitate to reopen the bug.


Michal,

Are you still able to reproduce this bug?
(I know it's been a very long time, sorry to bother, but I'm trying to
solve Debian's bash-completion problems, including very old ones)


[1] https://wiki.debian.org/PDF
[2] ftp://ftp.adobe.com/pub/adobe/reader/unix/9.x/

Message #93 received at 616018@bugs.debian.org (full text, mbox, reply):

From: Michal Hocko <mstsxfx@gmail.com>

To: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>

Cc: 616018@bugs.debian.org

Subject: Re: Bug#616018: Updating flags and preparing to close

Date: Sat, 10 Nov 2018 10:42:45 +0100

I do not see the problem anymore.
-- 
Michal Hocko

Message #98 received at 616018-close@bugs.debian.org (full text, mbox, reply):

From: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>

To: <616018-close@bugs.debian.org>

Subject: Re: Bug#616018: Updating flags and preparing to close

Date: Sat, 17 Nov 2018 13:17:24 -0200

Closing as unreproducible.

Please do not hesitate to reopen if you have more information.

Send a report that this bug log contains spam.