Debian Bug report logs - #606993
subdownloader: always fail to download selected subs

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: florian <fgruel@hotmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: subdownloader: always fail to download selected subs

Date: Mon, 13 Dec 2010 20:17:02 +0100

Package: subdownloader
Version: 2.0.14-1
Severity: grave
Justification: renders package unusable


When launched from commandline, this message appears for all selected subtitle

Traceback (most recent call last):
  File "/usr/share/subdownloader/gui/main.py", line 1043, in onButtonDownload
    destinationPath = self.getDownloadPath(sub.getVideo(), sub)
  File "/usr/share/subdownloader/gui/main.py", line 1012, in getDownloadPath
    downloadFullPath = os.path.join(folderPath, subFileName).decode('utf8')
  File "/usr/lib/python2.6/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 13: ordinal not in range(128)


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages subdownloader depends on:
ii  python                  2.6.6-3+squeeze2 interactive high-level object-orie
ii  python-crypto           2.1.0-2          cryptographic algorithms and proto
ii  python-kaa-metadata     0.7.7-2+b1       Media Metadata for Python
ii  python-support          1.0.10           automated rebuilding support for P

Versions of packages subdownloader recommends:
ii  python-qt4                    4.7.3-1+b1 Python bindings for Qt4

subdownloader suggests no packages.

-- no debconf information

Message #10 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Sandro Tosi <morph@debian.org>

To: florian <fgruel@hotmail.com>, 606993@bugs.debian.org, Ivan Garcia <ivangarcia@subdownloader.net>, Marco Ferreira <mferreira@subdownloader.net>, Marco Rodrigues <gothicx@gmail.com>

Subject: Re: [Python-apps-team] Bug#606993: subdownloader: always fail to download selected subs

Date: Sat, 25 Dec 2010 15:10:28 +0100

Hi all,

On Mon, Dec 13, 2010 at 20:17, florian <fgruel@hotmail.com> wrote:
> Package: subdownloader
> Version: 2.0.14-1
> Severity: grave
> Justification: renders package unusable
>
>
> When launched from commandline, this message appears for all selected subtitle
>
> Traceback (most recent call last):
>  File "/usr/share/subdownloader/gui/main.py", line 1043, in onButtonDownload
>    destinationPath = self.getDownloadPath(sub.getVideo(), sub)
>  File "/usr/share/subdownloader/gui/main.py", line 1012, in getDownloadPath
>    downloadFullPath = os.path.join(folderPath, subFileName).decode('utf8')
>  File "/usr/lib/python2.6/encodings/utf_8.py", line 16, in decode
>    return codecs.utf_8_decode(input, errors, True)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 13: ordinal not in range(128)

the problem is easily replicable with:

$ python -c "import os.path ; print os.path.join('/tmp/',
u'\xe9').decode('utf8')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python2.6/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in
position 5: ordinal not in range(128)

That's because one of the 2 parameters is already encoded (the '/tmp/'
one, which is a string) while the other is unicode. The solution here
is either make both params a string, and then decode after the join()
or just remove the ".decode('utf8')":

$ python -c "import os.path ; print os.path.join('/tmp/', u'\xe9')"
/tmp/é

since join() returns a unicode object in that case.

What do the subdownloader developers think about it?

Even if the bug is annoying, I don't think it deserves an RC severity
in Debian: anynow against downgrading it to important?

Cheers,
-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi

Message #15 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Sandro Tosi <morph@debian.org>, 606993@bugs.debian.org

Cc: florian <fgruel@hotmail.com>, Ivan Garcia <ivangarcia@subdownloader.net>, Marco Ferreira <mferreira@subdownloader.net>, Marco Rodrigues <gothicx@gmail.com>

Subject: Re: Bug#606993: [Python-apps-team] Bug#606993: subdownloader: always fail to download selected subs

Date: Tue, 28 Dec 2010 00:31:16 +0100

[Message part 1 (text/plain, inline)]

On Sat, Dec 25, 2010 at 15:10:28 +0100, Sandro Tosi wrote:

> Even if the bug is annoying, I don't think it deserves an RC severity
> in Debian: anynow against downgrading it to important?
> 
If that means the program is unable to handle non-ascii filenames, then
grave sounds correct to me.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien@klein.st>

To: 606993@bugs.debian.org

Subject: Patch for this bug

Date: Fri, 9 Nov 2012 22:28:52 +0100

[Message part 1 (text/plain, inline)]

Hi,

The following patch (already applied upstream [0]) fixes this bug.

I've prepared a NMU (versioned as 2.0.14-1.1) and uploaded it to
mentors.d.n [1], please review and upload.

Thanks,
   +Emilien

[0] http://bazaar.launchpad.net/~subdownloader-developers/subdownloader/trunk/revision/552
[1] http://mentors.debian.net/package/subdownloader

[fix-non-ascii-download-path.patch (application/octet-stream, attachment)]

Message #33 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien@klein.st>

To: 606993@bugs.debian.org

Subject: Re: Patch for this bug

Date: Fri, 23 Nov 2012 21:33:16 +0100

Hi Python Applications Packaging Team and Marco Rodrigues,

Please have a look at the patch I sent to fix this "Severity: grave"
bug which caused the removal of SubDownloader from the archive.
As mentioned in my previous mail, I've prepared a NMU [0] for this, it
would be nice if you could check it.

Thanks,
    +Emilien

[0] http://mentors.debian.net/package/subdownloader

Message #38 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien@klein.st>

To: 606993@bugs.debian.org

Subject: Re: Patch for this bug

Date: Sun, 17 Feb 2013 20:21:49 +0100

Hi,

I've sent a patch fixing this grave issue and created a NMU [0] a bit
over 3 months ago, please review it and upload to unstable.
This bug caused the removal of subdownloader from testing, which is too bad...

Please let us know if this package is not maintained anymore, as a
user of it I'll gladly take care of the Debian packaging....

Thanks,
    +Emilien

[0] http://mentors.debian.net/package/subdownloader

2012/11/23 Emilien Klein <emilien@klein.st>:
> Hi Python Applications Packaging Team and Marco Rodrigues,
>
> Please have a look at the patch I sent to fix this "Severity: grave"
> bug which caused the removal of SubDownloader from the archive.
> As mentioned in my previous mail, I've prepared a NMU [0] for this, it
> would be nice if you could check it.
>
> Thanks,
>     +Emilien
>
> [0] http://mentors.debian.net/package/subdownloader



--
   +Emilien

Message #43 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien+debian@klein.st>

To: 606993@bugs.debian.org, gothicx@gmail.com, python-apps-team@lists.alioth.debian.org

Subject: No response from maintainer

Date: Fri, 1 Mar 2013 21:03:50 +0100

Hi Marco Rodrigues and the Python Applications Packaging Team,

The subdownloader package you co-maintain has a grave bug [0] which
resulted in the package being removed from Testing more than 2 years
ago.

This bug has been fixed in version 2.0.18 (4 releases later than
2.0.14 packaged in Debian).
I've patched that specific bug and uploaded a NMU to mentors.d.n [1],
please review and upload.

Additionally, as I didn't get any answer back from you on any of my
emails over the last 4 months, I am wondering if you are still willing
to maintain this package? I would be willing to give a helping hand,
and get the newest version packaged (the one currently packaged is 2.5
years old).

Cheers,
   +Emilien
[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606993
[1] http://mentors.debian.net/package/subdownloader

Message #48 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Marco Rodrigues <gothicx@gmail.com>

To: Emilien Klein <emilien+debian@klein.st>

Cc: 606993@bugs.debian.org, python-apps-team@lists.alioth.debian.org

Subject: Re: No response from maintainer

Date: Fri, 1 Mar 2013 21:16:07 +0100

[Message part 1 (text/plain, inline)]

Hi Emilien,

Which e-mail did you try to contact me? gothicx@sapo.pt? That one I really
don't check it =(

I'm not so active lately unfortunately, but I'm glad you want to help to
maintain it. You can perhaps ask someone from the Python Apps Team to
upload it for you.

Thanks for the help.

Best regards.

--
Marco Rodrigues
http://www.marblehole.com


On Fri, Mar 1, 2013 at 9:03 PM, Emilien Klein <emilien+debian@klein.st>wrote:

> Hi Marco Rodrigues and the Python Applications Packaging Team,
>
> The subdownloader package you co-maintain has a grave bug [0] which
> resulted in the package being removed from Testing more than 2 years
> ago.
>
> This bug has been fixed in version 2.0.18 (4 releases later than
> 2.0.14 packaged in Debian).
> I've patched that specific bug and uploaded a NMU to mentors.d.n [1],
> please review and upload.
>
> Additionally, as I didn't get any answer back from you on any of my
> emails over the last 4 months, I am wondering if you are still willing
> to maintain this package? I would be willing to give a helping hand,
> and get the newest version packaged (the one currently packaged is 2.5
> years old).
>
> Cheers,
>    +Emilien
> [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606993
> [1] http://mentors.debian.net/package/subdownloader
>

[Message part 2 (text/html, inline)]

Message #53 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien+debian@klein.st>

To: Marco Rodrigues <gothicx@gmail.com>

Cc: 606993@bugs.debian.org, python-apps-team@lists.alioth.debian.org

Subject: Re: No response from maintainer

Date: Sun, 3 Mar 2013 18:33:48 +0100

Hi Marco,

2013/3/1 Marco Rodrigues <gothicx@gmail.com>:
> Which e-mail did you try to contact me? gothicx@sapo.pt? That one I really
> don't check it =(

No problem, most important is that we got in touch at last.

> I'm not so active lately unfortunately, but I'm glad you want to help to
> maintain it. You can perhaps ask someone from the Python Apps Team to upload
> it for you.

Is there someone on the Python Apps Team that would be willing to
upload the NMU I prepared? It's uploaded to mentors.d.n [0]?

   +Emilien
[0] http://mentors.debian.net/package/subdownloader

Message #58 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: Emilien Klein <emilien+debian@klein.st>, 606993@bugs.debian.org

Subject: Re: Bug#606993: No response from maintainer

Date: Sat, 1 Jun 2013 11:49:20 +0200

[Message part 1 (text/plain, inline)]

Hi Emilien,

On 2013-03-03 18:33:48, Emilien Klein wrote:
> Is there someone on the Python Apps Team that would be willing to
> upload the NMU I prepared? It's uploaded to mentors.d.n [0]?
> 
>    +Emilien
> [0] http://mentors.debian.net/package/subdownloader

Thanks for your work on this bug.

I just wanted to take a look at the NMU and apparently it got removed
from m.d.n. Could you reupload it so we can get that RC bug fixed?

Regards
-- 
Sebastian Ramacher

[signature.asc (application/pgp-signature, inline)]

Message #63 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien+debian@klein.st>

To: 606993@bugs.debian.org

Cc: Sebastian Ramacher <sramacher@debian.org>

Subject: Re: Bug#606993: No response from maintainer

Date: Sat, 1 Jun 2013 20:03:49 +0200

Hi Sebastian,

2013/6/1 Sebastian Ramacher <sramacher@debian.org>:
> Hi Emilien,
>
> On 2013-03-03 18:33:48, Emilien Klein wrote:
>> Is there someone on the Python Apps Team that would be willing to
>> upload the NMU I prepared? It's uploaded to mentors.d.n [0]?
>>
>>    +Emilien
>> [0] http://mentors.debian.net/package/subdownloader
>
> Thanks for your work on this bug.
>
> I just wanted to take a look at the NMU and apparently it got removed
> from m.d.n. Could you reupload it so we can get that RC bug fixed?

Reuploaded! (it might take a few minutes to show up on mentors.d.n)

Thanks for looking into it.
   +Emilien

Message #68 received at 606993@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: 606993@bugs.debian.org

Subject: subdownloader: diff for NMU version 2.0.14-1.1

Date: Thu, 13 Jun 2013 18:56:08 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 + pending

I've uploaded the maintainer ACKed NMU prepared by Emilien Klein to DELAYED/1.
It is versioned as 2.0.14-1.1) and the diff is attached to this message.

Regards
-- 
Sebastian Ramacher

[subdownloader-2.0.14-1.1-nmu.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #75 received at 606993-close@bugs.debian.org (full text, mbox, reply):

From: Emilien Klein <emilien+debian@klein.st>

To: 606993-close@bugs.debian.org

Subject: Bug#606993: fixed in subdownloader 2.0.14-1.1

Date: Fri, 14 Jun 2013 17:22:17 +0000

Source: subdownloader
Source-Version: 2.0.14-1.1

We believe that the bug you reported is fixed in the latest version of
subdownloader, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 606993@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emilien Klein <emilien+debian@klein.st> (supplier of updated subdownloader package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 10 Nov 2012 12:43:07 +0100
Source: subdownloader
Binary: subdownloader
Architecture: source all
Version: 2.0.14-1.1
Distribution: unstable
Urgency: low
Maintainer: Python Applications Packaging Team <python-apps-team@lists.alioth.debian.org>
Changed-By: Emilien Klein <emilien+debian@klein.st>
Description: 
 subdownloader - subtitle download/upload manager for video files
Closes: 606993
Changes: 
 subdownloader (2.0.14-1.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * debian/patches/fix-non-ascii-download-path.patch:
     + Fix downloading subtitles in folders containing non-ASCII characters
       (Closes: #606993), (LP: #913453, #306589)
   * debian/source/format:
     Update to "3.0 (quilt)" to apply the previous patch in a proper way
Checksums-Sha1: 
 e22fdb6aff2c899b9e96674eb1d85264ccd99077 2118 subdownloader_2.0.14-1.1.dsc
 5eeda789872179647e5b01f09b5409aa74e66fa6 4713 subdownloader_2.0.14-1.1.debian.tar.gz
 20209fc27681f0a6609d22448fa463749490cf95 704432 subdownloader_2.0.14-1.1_all.deb
Checksums-Sha256: 
 34033e451c466963f778f71a13f6ff2cca84f4f606a10846528b4fcfd79476b8 2118 subdownloader_2.0.14-1.1.dsc
 cb19b87f7f1f20516487c7574921f15a6aedefea8944c1153c7b8888d3d63621 4713 subdownloader_2.0.14-1.1.debian.tar.gz
 2eb9139706c960e4d54e585b5fc811aca5ccfa838cae42e15297ccd85bc54f84 704432 subdownloader_2.0.14-1.1_all.deb
Files: 
 6a8322e6e2692fecb32826801ca86bbd 2118 utils optional subdownloader_2.0.14-1.1.dsc
 adc1a2f2aabcfe81a50b620ebdd7555e 4713 utils optional subdownloader_2.0.14-1.1.debian.tar.gz
 fca794e55749264eb8be749c7acf1ae4 704432 utils optional subdownloader_2.0.14-1.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRufkoAAoJEGny/FFupxmTg8sP/R0YRoD1BDhOaWmYg7O8FS1l
7cGWsr6jIze+bx7I+rJeH3XRADNAkYdSOrKAKnlm8TIw7WnvZPiG9BcWAjrTffUM
J6AVQ6J5T71CtIuFs8431xF5FSoHUQb5vRdC4kB2StuH1NOV1xDZi4NDM7ooihgG
Q45avj72C+KV9BRqObczlsa26Z3S8ggEP7QHrs5XIG15R0eeLZ1GqnZzXq7qi8mR
VJQQ5ZKWTYnrIbxPpsVjF828yUBs9oHJRYqMa22f6eZu5wTZkNRD/ygmG3G3oDrb
tmNOpAvChgpy9zlpyMXFVfLi47vYMFQ1BmAarFDK+gmEfJwa1xAcNoDDO81/AxDX
Ah9/X43EaBnSWa2w8by0qqFWBarYbVjwBjPReTztQXPssQ/yPXy1xi18YU4+K6Fj
amtBr/4OrK19t4WR6vhytH3qtCv2cO2ARUm5dvIIAfMgftHtwf3jqLweDvRRaoq+
sfOSpZhj7gAMrVgMMf1GpRYk/aLonJx0xmNtwA+TkWy6dPQrxo5lTpg0dK6qPAXC
7fYWar/2hcNiwQQ4Ex4TfyG2YRpGM/xB3x7xMi20GMJ3S7JI50jeKotCdUm7gSfu
q9ARdJzikqBbObldypiSpmntFL1+yEWm+UAvCpxLJWnMqxs/gHHfJ6WlYU2hl+M4
f5285Hycj407gud19DgB
=+xMP
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.