Debian Bug report logs - #603405
gucharmap: missing source code needed to update unicode tables

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Dwayne C. Litzenberger" <dlitz@dlitz.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: gucharmap: missing source code needed to update unicode tables

Date: Sat, 13 Nov 2010 14:06:12 -0500

Source: gucharmap
Version: 1:2.30.3-1
Justification: Policy 2.2.1
Severity: serious

The source package for gucharmap contains 7 automatically generated files:

    gucharmap/unicode-blocks.h
    gucharmap/unicode-categories.h
    gucharmap/unicode-names.h
    gucharmap/unicode-nameslist.h
    gucharmap/unicode-scripts.h
    gucharmap/unicode-unihan.h
    gucharmap/unicode-versions.h

Each of these files contains the following header, making reference to a
script called "gen-guch-unicode-tables.pl":

    /* THIS IS A GENERATED FILE. CHANGES WILL BE OVERWRITTEN. */
    /* Generated by ./gen-guch-unicode-tables.pl */
    /* Generated from UCD version 5.2.0 */

I was trying to add support for the new Indian Rupee Symbol (U+20B9), but 
the gen-guch-unicode-tables.pl script and the Unicode Character Database, 
which form part of gucharmap's source code, were missing from the Debian 
source package.

I've marked this bug with a severity of "serious", since it violates the 
DFSG requirement that a program include source code, as well as the GPL 
requirement that the program be accompanied with its complete corresponding 
source code ("the preferred form of the work for making modifications to 
it").

My suggestion for fixing this bug is as follows:

    1. Include gen-guch-unicode-tables.pl in the gucharmap package;
    2. Add unicode-data to the build-dependencies of gucharmap; and
    3. Run gen-guch-unicode-tables.pl as part of the build process, using 
       the UCD from the unicode-data package.

There is some information at http://bugs.debian.org/318304 that may be 
helpful in fixing this bug.

Regards,
- Dwayne

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.35.4 (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gucharmap depends on:
ii  gconf2                        2.28.1-6   GNOME configuration database syste
ii  libatk1.0-0                   1.30.0-1   The ATK accessibility toolkit
ii  libc6                         2.11.2-7   Embedded GNU C Library: Shared lib
ii  libcairo2                     1.8.10-6   The Cairo 2D vector graphics libra
ii  libgconf2-4                   2.28.1-6   GNOME configuration database syste
ii  libglib2.0-0                  2.24.2-1   The GLib library of C routines
ii  libgtk2.0-0                   2.20.1-2   The GTK+ graphical user interface 
ii  libgtk2.0-bin                 2.20.1-2   The programs for the GTK+ graphica
ii  libgucharmap7                 1:2.30.3-1 Unicode browser widget library (sh
ii  libpango1.0-0                 1.28.3-1   Layout and rendering of internatio

Versions of packages gucharmap recommends:
ii  yelp                     2.30.1+webkit-1 Help browser for GNOME

gucharmap suggests no packages.

-- no debconf information

-- 
Dwayne C. Litzenberger <dlitz@dlitz.net>
 OpenPGP: 19E1 1FE8 B3CF F273 ED17  4A24 928C EC13 39C2 5CF7

Message #10 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Josselin Mouette <joss@debian.org>

To: "Dwayne C. Litzenberger" <dlitz@dlitz.net>, 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Sun, 14 Nov 2010 02:28:33 +0100

[Message part 1 (text/plain, inline)]

Le samedi 13 novembre 2010 à 14:06 -0500, Dwayne C. Litzenberger a
écrit : 
> I was trying to add support for the new Indian Rupee Symbol (U+20B9), but 
> the gen-guch-unicode-tables.pl script and the Unicode Character Database, 
> which form part of gucharmap's source code, were missing from the Debian 
> source package.

The perl script looks like it was omitted from the tarballs. For the
Unicode tables, this is of course intentional, since that would make 
8 MB more data just for them.

> My suggestion for fixing this bug is as follows:
> 
>      1. Include gen-guch-unicode-tables.pl in the gucharmap package;
>      2. Add unicode-data to the build-dependencies of gucharmap; and
>      3. Run gen-guch-unicode-tables.pl as part of the build process, using 
>         the UCD from the unicode-data package.

Patches are welcome; as for myself, I have more interesting things to
do. I already tried to do this kind of things to “auto-generated” files
in GTK+, and it turned out to be a disaster to implement, because you
need a specific version of the source files if you want to be sure there
is no side effect.

Cheers,
-- 
 .''`.      Josselin Mouette
: :' :
`. `'  “If you behave this way because you are blackmailed by someone,
  `-    […] I will see what I can do for you.”  -- Jörg Schilling

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: "Dwayne C. Litzenberger" <dlitz@dlitz.net>, 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Thu, 23 Dec 2010 20:18:58 +0100

[Message part 1 (text/plain, inline)]

user release.debian.org@packages.debian.org
usertag 603405 squeeze-can-defer
tag 603405 squeeze-ignore
kthxbye

On Sat, Nov 13, 2010 at 14:06:12 -0500, Dwayne C. Litzenberger wrote:

> Source: gucharmap
> Version: 1:2.30.3-1
> Justification: Policy 2.2.1
> Severity: serious
> 
> The source package for gucharmap contains 7 automatically generated files:
> 
Not a blocker for squeeze.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Arne Wichmann <aw@anhrefn.saar.de>

To: 603405@bugs.debian.org

Subject: Ping

Date: Sat, 16 Jun 2012 14:51:11 +0200

[Message part 1 (text/plain, inline)]

This serious bug is now unhandled for 18 months. Is there any plan to find
a solution for this?

cu

AW
-- 
[...] If you don't want to be restricted, don't agree to it. If you are
coerced, comply as much as you must to protect yourself, just don't support
it. Noone can free you but yourself. (crag, on Debian Planet)
Arne Wichmann (aw@linux.de)

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Arne Wichmann <aw@anhrefn.saar.de>, 603405@bugs.debian.org

Subject: Re: Bug#603405: Ping

Date: Sat, 16 Jun 2012 18:00:13 +0200

[Message part 1 (text/plain, inline)]

On 16.06.2012 14:51, Arne Wichmann wrote:
> This serious bug is now unhandled for 18 months. Is there any plan to find
> a solution for this?

Not that I know of.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #32 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: 603405@bugs.debian.org

Subject: Re: gucharmap: missing source code needed to update unicode tables

Date: Sat, 16 Jun 2012 13:18:57 -0700

[Message part 1 (text/plain, inline)]

tags 603405 patch
thanks

The script needed for this is actually shipped in the current upstream
versions of gucharmap, so we just need to tweak it a litle bit for use with
the unicode-data package and run it at build time.  The attached patch
addresses this.

I'm uploading this patch as an NMU to DELAYED/2-days.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

[gucharmap-603405.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Steve Langasek <vorlon@debian.org>, 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Sat, 16 Jun 2012 23:28:36 +0200

[Message part 1 (text/plain, inline)]

On 16.06.2012 22:18, Steve Langasek wrote:
> tags 603405 patch
> thanks
> 
> The script needed for this is actually shipped in the current upstream
> versions of gucharmap, so we just need to tweak it a litle bit for use with
> the unicode-data package and run it at build time.  The attached patch
> addresses this.
> 
> I'm uploading this patch as an NMU to DELAYED/2-days.
> 

Thanks for the patch, Steve.

An odd thing I noticed, is that gen-guch-unicode-tables.pl is run twice:

configure/libgucharmap-2-90-dev::
	cd gucharmap && ./gen-guch-unicode-tables.pl ...

It is run after ./configure, but apparently it is run a second time just
before make install?

It also seems to modify files (unicode-unihan.h) which are not properly
cleaned up and would end up in a debdiff if built twice in a row.

If you can have a look at this, this would be great.
Otherwise I will have try to fix this myself.

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #44 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Steve Langasek <vorlon@debian.org>, 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Sat, 16 Jun 2012 23:33:15 +0200

[Message part 1 (text/plain, inline)]

On 16.06.2012 23:28, Michael Biebl wrote:

> It also seems to modify files (unicode-unihan.h) which are not properly
> cleaned up and would end up in a debdiff if built twice in a row.

From a cursory glance, we might want to clean up gucharmap/unicode-* on
clean::
	rm -f gucharmap/unicode-*

We could also use
clean::
	grep -l "Generated by ./gen-guch-unicode-tables.pl" gucharmap/* | xargs rm

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #49 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Sat, 16 Jun 2012 14:54:52 -0700

[Message part 1 (text/plain, inline)]

On Sat, Jun 16, 2012 at 11:28:36PM +0200, Michael Biebl wrote:
> On 16.06.2012 22:18, Steve Langasek wrote:
> > tags 603405 patch
> > thanks

> > The script needed for this is actually shipped in the current upstream
> > versions of gucharmap, so we just need to tweak it a litle bit for use with
> > the unicode-data package and run it at build time.  The attached patch
> > addresses this.

> > I'm uploading this patch as an NMU to DELAYED/2-days.

> Thanks for the patch, Steve.

> An odd thing I noticed, is that gen-guch-unicode-tables.pl is run twice:

> configure/libgucharmap-2-90-dev::
> 	cd gucharmap && ./gen-guch-unicode-tables.pl ...

> It is run after ./configure, but apparently it is run a second time just
> before make install?

I noticed this as well, I have no idea why this is happening.

> It also seems to modify files (unicode-unihan.h) which are not properly
> cleaned up and would end up in a debdiff if built twice in a row.

They're cleaned up via debian/clean:

diff -Nru gucharmap-3.4.1.1/debian/clean gucharmap-3.4.1.1/debian/clean
--- gucharmap-3.4.1.1/debian/clean      1970-01-01 00:00:00.000000000 +0000
+++ gucharmap-3.4.1.1/debian/clean      2012-06-16 19:34:08.000000000 +0000
@@ -0,0 +1 @@
+gucharmap/unicode-*.h

Removing the file in the clean target via dh_clean will cause it to be
automatically excluded from the diff.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

[signature.asc (application/pgp-signature, inline)]

Message #54 received at 603405@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Steve Langasek <vorlon@debian.org>

Cc: 603405@bugs.debian.org

Subject: Re: Bug#603405: gucharmap: missing source code needed to update unicode tables

Date: Sun, 17 Jun 2012 00:06:52 +0200

[Message part 1 (text/plain, inline)]

On 16.06.2012 23:54, Steve Langasek wrote:
> On Sat, Jun 16, 2012 at 11:28:36PM +0200, Michael Biebl wrote:
>> On 16.06.2012 22:18, Steve Langasek wrote:
>>> tags 603405 patch
>>> thanks
> 
>>> The script needed for this is actually shipped in the current upstream
>>> versions of gucharmap, so we just need to tweak it a litle bit for use with
>>> the unicode-data package and run it at build time.  The attached patch
>>> addresses this.
> 
>>> I'm uploading this patch as an NMU to DELAYED/2-days.
> 
>> Thanks for the patch, Steve.
> 
>> An odd thing I noticed, is that gen-guch-unicode-tables.pl is run twice:
> 
>> configure/libgucharmap-2-90-dev::
>> 	cd gucharmap && ./gen-guch-unicode-tables.pl ...
> 
>> It is run after ./configure, but apparently it is run a second time just
>> before make install?
> 
> I noticed this as well, I have no idea why this is happening.

Seems we have to use a stamp file, so I'll probably change that to
something like that:

post-patches:: debian/stamp-gen-unicode-tables

debian/stamp-gen-unicode-tables:
	cd gucharmap && ./gen-guch-unicode-tables.pl $(UNICODE_DATA_VERSION)
/usr/share/unicode
	touch debian/stamp-gen-unicode-tables

clean::
	rm -f debian/stamp-gen-unicode-tables


>> It also seems to modify files (unicode-unihan.h) which are not properly
>> cleaned up and would end up in a debdiff if built twice in a row.
> 
> They're cleaned up via debian/clean:
> 
> diff -Nru gucharmap-3.4.1.1/debian/clean gucharmap-3.4.1.1/debian/clean
> --- gucharmap-3.4.1.1/debian/clean      1970-01-01 00:00:00.000000000 +0000
> +++ gucharmap-3.4.1.1/debian/clean      2012-06-16 19:34:08.000000000 +0000
> @@ -0,0 +1 @@
> +gucharmap/unicode-*.h
> 
> Removing the file in the clean target via dh_clean will cause it to be
> automatically excluded from the diff.
> 

Ah, I apparently missed that file. I was only looking at the clean::
rule in debian/rules.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #59 received at 603405-close@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 603405-close@bugs.debian.org

Subject: Bug#603405: fixed in gucharmap 1:3.4.1.1-2

Date: Sun, 17 Jun 2012 15:49:37 +0000

Source: gucharmap
Source-Version: 1:3.4.1.1-2

We believe that the bug you reported is fixed in the latest version of
gucharmap, which is due to be installed in the Debian FTP archive:

gir1.2-gucharmap-2.90_3.4.1.1-2_amd64.deb
  to main/g/gucharmap/gir1.2-gucharmap-2.90_3.4.1.1-2_amd64.deb
gucharmap_3.4.1.1-2.debian.tar.gz
  to main/g/gucharmap/gucharmap_3.4.1.1-2.debian.tar.gz
gucharmap_3.4.1.1-2.dsc
  to main/g/gucharmap/gucharmap_3.4.1.1-2.dsc
gucharmap_3.4.1.1-2_amd64.deb
  to main/g/gucharmap/gucharmap_3.4.1.1-2_amd64.deb
libgucharmap-2-90-7_3.4.1.1-2_amd64.deb
  to main/g/gucharmap/libgucharmap-2-90-7_3.4.1.1-2_amd64.deb
libgucharmap-2-90-dev_3.4.1.1-2_amd64.deb
  to main/g/gucharmap/libgucharmap-2-90-dev_3.4.1.1-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 603405@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <biebl@debian.org> (supplier of updated gucharmap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 17 Jun 2012 16:39:23 +0200
Source: gucharmap
Binary: gucharmap libgucharmap-2-90-dev libgucharmap-2-90-7 gir1.2-gucharmap-2.90
Architecture: source amd64
Version: 1:3.4.1.1-2
Distribution: unstable
Urgency: low
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Michael Biebl <biebl@debian.org>
Description: 
 gir1.2-gucharmap-2.90 - GObject introspection data for the Unicode browser widget library
 gucharmap  - Unicode character picker and font browser
 libgucharmap-2-90-7 - Unicode browser widget library (shared library)
 libgucharmap-2-90-dev - Unicode browser widget library (development headers)
Closes: 603405
Changes: 
 gucharmap (1:3.4.1.1-2) unstable; urgency=low
 .
   [ Steve Langasek ]
   * debian/patches/unicode-source-generation.patch: compatibility with
     the unicode-data package.
   * debian/rules, debian/clean, debian/control: build-depend on unicode-data
     and generate our unicode header files at package build time, to ensure
     that we actually can.  Closes: #603405.
 .
   [ Michael Biebl ]
   * Use a stamp file to avoid running gen-guch-unicode-tables.pl twice.
   * Point Vcs-* to unstable branch.
   * Drop explicit Build-Depends on gir1.2-pango-1.0 and gir1.2-gtk-3.0.
   * Drop debian/patches/spelling_fixes.patch since we re-generate
     gucharmap/unicode-*.h during build, so patching the pre-generated file is
     pointless. This spelling fix needs to go into unicode-data. (See #677896)
Checksums-Sha1: 
 811ab51a58d43f824059c8fe8fa825369827572f 2546 gucharmap_3.4.1.1-2.dsc
 a25de99c06f6369cb6defd360ad86cbf12b8d360 11419 gucharmap_3.4.1.1-2.debian.tar.gz
 60d318889dcc4fe72476f88ad757519a236993c2 1715424 gucharmap_3.4.1.1-2_amd64.deb
 031802cd2923f5eab5dcb61a9ddafecdf4c6f368 251240 libgucharmap-2-90-dev_3.4.1.1-2_amd64.deb
 c3c9bc953d795b9f011aa7408cb1062315de694e 1553916 libgucharmap-2-90-7_3.4.1.1-2_amd64.deb
 27ba1c71fd4d5034c912e737bbf540e9e008b9ae 220340 gir1.2-gucharmap-2.90_3.4.1.1-2_amd64.deb
Checksums-Sha256: 
 df17ea977cee85c8c1a6d5b7371b74ef81e3919c64550689f55d50fabb24abe0 2546 gucharmap_3.4.1.1-2.dsc
 5d53f225d5e6f68af738799ae6682b4b5854c4bdfbab7bc3c13c7557f1016c4b 11419 gucharmap_3.4.1.1-2.debian.tar.gz
 0e846d3288cfe869c7e383ac3a2ef34d213fb844745d3780b5ef8bcaa67214fa 1715424 gucharmap_3.4.1.1-2_amd64.deb
 242f7c91047821082dd1315b0d92072f4ad8c52a0777ddca4cde1f8069f36c0e 251240 libgucharmap-2-90-dev_3.4.1.1-2_amd64.deb
 7cd9faf50ade6333bb57458f87765f163c54224ef4cb6acdd0c5f6957283951b 1553916 libgucharmap-2-90-7_3.4.1.1-2_amd64.deb
 05e6c30aae51c7b9a4addf6201fdd76a1c7fb71c8f491c7f4e0c0d92c8400c5a 220340 gir1.2-gucharmap-2.90_3.4.1.1-2_amd64.deb
Files: 
 236c786eff3090f118544fdd79411e98 2546 gnome optional gucharmap_3.4.1.1-2.dsc
 91ac13ce0bb2fe30c589d7893de87a30 11419 gnome optional gucharmap_3.4.1.1-2.debian.tar.gz
 d2856baf1e5804cb1cc9b1c622e2a8fe 1715424 gnome optional gucharmap_3.4.1.1-2_amd64.deb
 49e3fa04dd4b11a0098e3eab96c70c47 251240 libdevel optional libgucharmap-2-90-dev_3.4.1.1-2_amd64.deb
 c9d941d0a1f16073c04702d5b89bd2cc 1553916 libs optional libgucharmap-2-90-7_3.4.1.1-2_amd64.deb
 6edf5870858969b032d7fc67d0edbdb4 220340 introspection optional gir1.2-gucharmap-2.90_3.4.1.1-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJP3fdyAAoJEGrh3w1gjyLcJx0P/jHUwJK6BaFhZTIjXmPilDO1
w1mSEz1zkPMPx+FSVsPx0GjXqP9VKwPPtiunkNMdyYlPQMgNmSMEUz0S1KZRGpF5
Zqu5ypV1TnzwIIWVEtjUyBu5DDH80NZsJwilcmIUFWlDySQhO8Zv7Hno/hejppJ0
2oW4IY636NvKTTMgg3p+M2i5WwLbInAKZrxLJIiv9t96u2sKMOtkQkIi3dz4HEA+
hOr4c5J7Cvo6pOmSS5MMfjAaA1onxkqW2UM5ju0f94HVrXi55bRVhI+DkamO71lI
vhccwTigTa1Zq+lfHID9NtHIYh0qSjXTdKstjmUn6t8qu1aUpdvrpJ53xqnE6Aw2
ktM3T3oxNdczQvgkzFxWoeXHAR0QVqUwVWjdjFQKON09k4hJts38rtYatVELNsCC
j2nUoLqw4v++uY9F16MNmwiE7etWxbMwXbIURhkP5yx+LbwthT6R55RrzsHXgEE/
Uk1aucw1vnR2igMaO0+XkZNGh66UzcErAgKsO/OzKcBizJw7izNiDf85qwuhp/kV
jooVvSyoNB1boNnpsejpE2wREjQI5Ly3uHXtvAu0NLnO8tMOQtgHdl4Tm9zIRxc1
kDJOf4tAQkwABxq/ebVfsEd9Pov2aijgEnGZjcU6c+b3BXaLPiWf2LSoHguokS+Z
OEKR9QZ+bGWHru+dsExf
=+Llj
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.