Debian Bug report logs - #601259
FTBFS if only built with Python >=2.6

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Luke Faraone <lfaraone@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: FTBFS if only built with Python >=2.6

Date: Sun, 24 Oct 2010 13:55:53 -0400

Package: python-keyczar
Version: 0.6~b.061709-2
Severity: serious
Justification: fails to build from source (but built successfully in the past)

When attempting to build this package with pyversions of  2.6-, the
package FTBFS because it expects there to be a "build/lib" directory.
Versions of Python after 2.5.x do not create this directory. 

I'll prepare an upload that fixes this and other problems shortly.

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick
  APT policy: (500, 'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-22-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Message #14 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Luke Faraone <lfaraone@debian.org>

To: 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Sun, 24 Oct 2010 15:59:43 -0400

[Message part 1 (text/plain, inline)]

On 10/24/2010 03:22 PM, Jakub Wilk wrote:
> * Luke Faraone <lfaraone@debian.org>, 2010-10-24, 13:55:
>> When attempting to build this package with pyversions of  2.6-, the
>> package FTBFS because it expects there to be a "build/lib" directory.
>> Versions of Python after 2.5.x do not create this directory.
> 
> AFAIK we haven't removed Python 2.5 from the set of supported versions yet.

Right, I was unclear whether this would merit "does-not-build" or not.
My apologies.

> The patch you committed is incorrect: the package will FTBFS on some
> architectures or if DEB_* variables were not exported into environment.

I've added the following:
    DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
    DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)

What architectures would it FTBFS on?

-- 
╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛

[signature.asc (application/pgp-signature, attachment)]

Message #19 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Luke Faraone <lfaraone@debian.org>, 601259@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Sun, 24 Oct 2010 21:22:20 +0200

[Message part 1 (text/plain, inline)]

user debian-python@lists.debian.org
usertags 601259 + python2.5-removal
severity 601259 important
tags 601259 - pending
thanks

* Luke Faraone <lfaraone@debian.org>, 2010-10-24, 13:55:
>When attempting to build this package with pyversions of  2.6-, the
>package FTBFS because it expects there to be a "build/lib" directory.
>Versions of Python after 2.5.x do not create this directory.

AFAIK we haven't removed Python 2.5 from the set of supported versions yet.

The patch you committed is incorrect: the package will FTBFS on some 
architectures or if DEB_* variables were not exported into environment.

-- 
Jakub Wilk

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Luke Faraone <lfaraone@debian.org>, 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Sun, 24 Oct 2010 23:14:05 +0200

[Message part 1 (text/plain, inline)]

On Sun, Oct 24, 2010 at 15:59:43 -0400, Luke Faraone wrote:

> I've added the following:
>     DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
>     DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)
> 
The usual way to do this is with ?= so that the environment takes
precedence (also the build architecture usually doesn't matter, so you
may want to double check that you didn't really want DEB_HOST_ARCH_OS
here).

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #33 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Christian Kastner <debian@kvr.at>

To: Luke Faraone <lfaraone@debian.org>, 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Mon, 25 Oct 2010 00:21:25 +0200

[Message part 1 (text/plain, inline)]

On 10/24/2010 09:59 PM, Luke Faraone wrote:
> On 10/24/2010 03:22 PM, Jakub Wilk wrote:
>> * Luke Faraone <lfaraone@debian.org>, 2010-10-24, 13:55:
>>> When attempting to build this package with pyversions of  2.6-, the
>>> package FTBFS because it expects there to be a "build/lib" directory.
>>> Versions of Python after 2.5.x do not create this directory.
>> AFAIK we haven't removed Python 2.5 from the set of supported versions yet.
> 
> Right, I was unclear whether this would merit "does-not-build" or not.
> My apologies.
> 
>> The patch you committed is incorrect: the package will FTBFS on some
>> architectures or if DEB_* variables were not exported into environment.
> 
> I've added the following:
>     DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
>     DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)

Why use the DEB_* stuff at all? The way I see it, the following should
change to PYTHONPATH should sufficed:

PYTHONPATH=$(shell ls -d $(CURDIR)/build/lib* | head -n 1)

ie, pick the first lib directory found instead of hard-coding the 2.5
lib directory.

Christian

[601259.patch (text/x-diff, inline)]

Index: trunk/debian/rules
===================================================================
--- trunk/debian/rules	(revision 14743)
+++ trunk/debian/rules	(working copy)
@@ -9,18 +9,11 @@
 %:
 	dh $@
 
-DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
-DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)
-
 override_dh_auto_test:
 ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
 	set -e ; \
 	cd tests/keyczar/; \
 	for py in $(PYVERS); do  \
-		if [ "$$py" \< "2.6" ]; then \
-			PYTHONPATH=$(CURDIR)/build/lib python$$py alltests.py; \
-		else \
-			PYTHONPATH=$(CURDIR)/build/lib.$(DEB_BUILD_ARCH_OS)-$(DEB_HOST_GNU_CPU)-$$py python$$py alltests.py; \
-    		fi; \
+		PYTHONPATH=$(shell ls -d $(CURDIR)/build/lib* | head -n 1) python$$py alltests.py; \
 	done
 endif

[signature.asc (application/pgp-signature, attachment)]

Message #38 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Mon, 25 Oct 2010 00:40:26 +0200

[Message part 1 (text/plain, inline)]

* Luke Faraone <lfaraone@debian.org>, 2010-10-24, 15:59:
>> The patch you committed is incorrect: the package will FTBFS on some
>> architectures or if DEB_* variables were not exported into environment.
>
>I've added the following:
>    DEB_BUILD_ARCH_OS := $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
>    DEB_HOST_GNU_CPU := $(shell dpkg-architecture -qDEB_HOST_GNU_CPU)
>
>What architectures would it FTBFS on?

armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use 
something like:

$(shell python -c 'import distutils.util as d; print d.get_platform()')

or, better, use wildcards.

-- 
Jakub Wilk

[signature.asc (application/pgp-signature, inline)]

Message #43 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Luke Faraone <luke@faraone.cc>

To: 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Mon, 25 Oct 2010 12:15:09 -0400

[Message part 1 (text/plain, inline)]

On 10/24/2010 06:40 PM, Jakub Wilk wrote:
> armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use
> something like:
> 
> $(shell python -c 'import distutils.util as d; print d.get_platform()')

Okay, I've committed the above. Is this solution acceptable to everyone?

-- 
╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛

[signature.asc (application/pgp-signature, attachment)]

Message #48 received at 601259@bugs.debian.org (full text, mbox, reply):

From: Christian Kastner <debian@kvr.at>

To: 601259@bugs.debian.org

Subject: Re: Bug#601259: FTBFS if only built with Python >=2.6

Date: Tue, 26 Oct 2010 00:30:50 +0200

[Message part 1 (text/plain, inline)]

On 10/25/2010 06:15 PM, Luke Faraone wrote:
> On 10/24/2010 06:40 PM, Jakub Wilk wrote:
>> armel, hppa, mips, powerpc, maybe s390, plus all non-Linux ones. Use
>> something like:
>>
>> $(shell python -c 'import distutils.util as d; print d.get_platform()')
> 
> Okay, I've committed the above. Is this solution acceptable to everyone?

No major objections on my part, I just consider my patch simpler. This
is a module, not an extension, so the build result is identical -- which
is why dh_pysupport grabs only one version. An elaborate construction to
run the tests using the build from the corresponding Python version
appears overly complex to me.

Again, this is just a comment. I'm fine either way as long as it fixes
the bug.

Christian

[signature.asc (application/pgp-signature, attachment)]

Message #53 received at 601259-close@bugs.debian.org (full text, mbox, reply):

From: Luke Faraone <lfaraone@debian.org>

To: 601259-close@bugs.debian.org

Subject: Bug#601259: fixed in python-keyczar 0.6~b.061709-3

Date: Tue, 09 Nov 2010 03:47:06 +0000

Source: python-keyczar
Source-Version: 0.6~b.061709-3

We believe that the bug you reported is fixed in the latest version of
python-keyczar, which is due to be installed in the Debian FTP archive:

python-keyczar_0.6~b.061709-3.debian.tar.gz
  to main/p/python-keyczar/python-keyczar_0.6~b.061709-3.debian.tar.gz
python-keyczar_0.6~b.061709-3.dsc
  to main/p/python-keyczar/python-keyczar_0.6~b.061709-3.dsc
python-keyczar_0.6~b.061709-3_all.deb
  to main/p/python-keyczar/python-keyczar_0.6~b.061709-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 601259@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luke Faraone <lfaraone@debian.org> (supplier of updated python-keyczar package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 08 Nov 2010 22:29:17 -0500
Source: python-keyczar
Binary: python-keyczar
Architecture: source all
Version: 0.6~b.061709-3
Distribution: unstable
Urgency: low
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Luke Faraone <lfaraone@debian.org>
Description: 
 python-keyczar - Toolkit for safe and simple cryptography for Python
Closes: 601259 601264
Changes: 
 python-keyczar (0.6~b.061709-3) unstable; urgency=low
 .
   * Team upload.
 .
   [ Christian Kastner ]
   * debian/control:
     - Bump Standards-Version to 3.9.1 (no changes needed)
 .
   [ Luke Faraone ]
   * debian/rules:
     - Handle cases when Python 2.5 is not used during build. Fixes FTBFS when
       running tests. Closes: #601259
   * debian/patches:
     - Remove 0001-workaround-deprecated-interface
       This patch did not work with older versions of PyCrypto. Closes: #601264
     - Added 0001-use-os-urandom-for-entropy
       This cherry-picked patch uses os.urandom() directly for entropy.
Checksums-Sha1: 
 01850118be7afd8a093cce0573913ecf21373ec9 2087 python-keyczar_0.6~b.061709-3.dsc
 520a58dbac30596c10383f429d73a79a3197bfda 3823 python-keyczar_0.6~b.061709-3.debian.tar.gz
 c821631863fa0f7a122c6a5df9392ede8e57efe7 22502 python-keyczar_0.6~b.061709-3_all.deb
Checksums-Sha256: 
 72590462c16e6185c7a173e3cdfacc9b6eb6704fc17543cbf0cbb4a60272d32a 2087 python-keyczar_0.6~b.061709-3.dsc
 808963f7787e96df11525401b4404aeae07d32c3cb3122a24cae8d9bc54636ed 3823 python-keyczar_0.6~b.061709-3.debian.tar.gz
 abbe80a2ef28e73369e37a571eef1a6c2f4c9fbd460f94e58300ed5a075c3531 22502 python-keyczar_0.6~b.061709-3_all.deb
Files: 
 730d36b284abb859df94ec281508d61e 2087 python optional python-keyczar_0.6~b.061709-3.dsc
 61b4f9ead9f5941b64cf0ab497a53135 3823 python optional python-keyczar_0.6~b.061709-3.debian.tar.gz
 ed6eb5a8e7130fa40cfa661a4cd63fdc 22502 python optional python-keyczar_0.6~b.061709-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJM2MHpAAoJEJcyXdj5/dUGHB4P/09eucrpsrNP+bDuxXFcxQHS
gGaPfJ1HzzoeUaf7w5OhAzI1/mFiW+uJrttiprxWM9EfPNosPu+cbb369ZKfQN4p
cLs//ECN5dToEZEYqk3wbGuO98V69QIB1P1AXELtVDRYsa3l0LLAOWaGKNo9JZVb
/tweYLkquo+tnuRJXQPZizoqNbiOjjwae9pYpzN6EyLFf6Gn/O0R8nftXrOQHiu5
q8PoiMgps26nelACKZMHgls6kxKLONSu2vhpCcZKO9Puy5qYUHbpQXf5x+A5neC+
JmSiEwhGgPdQWqgv620aoXDz6+70KTecyaio4wXyM4SDHAKkJrBCBwJad28AhoXA
/MjPNEeaXL3RCnfVJG6AB8GwfNWnvB6RywzU+/3+ZLBAh5/Z4HXfXMJP428yC3s/
GYrhphjGMtyhM4z8RHNPN3fXie2rhVfn5vPqZAWWZkcCRQXdXmgAteaiTDLQyrMi
kgkJ2KQWg5ECHqut+wKgLTQ4jrVqykCmHv5wsoOLAFXFMHqgjYHDLRPWbdNyMGiJ
IGc8hPt+b/pWUHzaasq06PWEqYYSwhtBETqVVMpCgH87LOen/Kjrw71WON60nZbc
tdxDsMTFUG6j1N2LTVsn19+WnIDTdVfRWfxLeEr1UT/X7oYzX0pbVlmaRAwdGAq5
SJZylMHayr3HDj9jwoK5
=ZTJK
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.