Debian Bug report logs - #595698
www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list

Package: www.debian.org; Maintainer for www.debian.org is Debian WWW Team <debian-www@lists.debian.org>;

Reported by: Simon Paillard <spaillard@debian.org>

Date: Sun, 5 Sep 2010 21:57:05 UTC

Severity: important

Tags: patch

Done: David Prévot <david@tilapin.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian WWW Team <debian-www@lists.debian.org>:
Bug#595698; Package www.debian.org. (Sun, 05 Sep 2010 21:57:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to Simon Paillard <spaillard@debian.org>:
New Bug report received and forwarded. Copy sent to Debian WWW Team <debian-www@lists.debian.org>. (Sun, 05 Sep 2010 21:57:07 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Simon Paillard <spaillard@debian.org>
To: submit@bugs.debian.org
Subject: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
Date: Sun, 5 Sep 2010 23:56:36 +0200
Package: www.debian.org
Severity: important

Hi,

As experienced since today with the announcement of Lenny 5.0.6, dos
(CRLF) end of lines doesn't match some regex.

As a consequence, the announce did not appear in any News listing
(either homepage or /News/ /News/2010), while a french translation
without CRLF of the same file does appear.

Affected file :
english/template/debian/recent_list.wml

Maybe other regex in the website are affected as well.

Other way could be a pre-commit hook that forbids or issues a warning
on CRLF. 

-- 
Simon Paillard




Information forwarded to debian-bugs-dist@lists.debian.org, Debian WWW Team <debian-www@lists.debian.org>:
Bug#595698; Package www.debian.org. (Sat, 12 Feb 2011 20:15:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to David Prévot <davidp@altern.org>:
Extra info received and forwarded to list. Copy sent to Debian WWW Team <debian-www@lists.debian.org>. (Sat, 12 Feb 2011 20:15:06 GMT) Full text and rfc822 format available.

Message #10 received at 595698@bugs.debian.org (full text, mbox):

From: David Prévot <davidp@altern.org>
To: 595698@bugs.debian.org
Subject: Re: Bug#595698: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
Date: Sat, 12 Feb 2011 16:11:52 -0400
[Message part 1 (text/plain, inline)]
tags 595698 patch
thanks

Hi,

Le 05/09/2010 17:56, Simon Paillard a écrit :
> As experienced since today with the announcement of Lenny 5.0.6, dos
> (CRLF) end of lines doesn't match some regex.
> 
> As a consequence, the announce did not appear in any News listing
> (either homepage or /News/ /News/2010), while a french translation
> without CRLF of the same file does appear.
> 
> Affected file :
> english/template/debian/recent_list.wml
> 
> Maybe other regex in the website are affected as well.

The attached patch relax associated regexps to match even if the closing
tag is not at the end of line (which will also make it match tags if
they are followed by spaces for example).

> Other way could be a pre-commit hook that forbids or issues a warning
> on CRLF. 

Regards

David

[relax_eol_for_define-tag.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Added tag(s) patch. Request was from David Prévot <davidp@altern.org> to control@bugs.debian.org. (Sat, 12 Feb 2011 20:15:08 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Debian WWW Team <debian-www@lists.debian.org>:
Bug#595698; Package www.debian.org. (Sun, 24 Apr 2011 17:42:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to David Prévot <david@tilapin.org>:
Extra info received and forwarded to list. Copy sent to Debian WWW Team <debian-www@lists.debian.org>. (Sun, 24 Apr 2011 17:42:06 GMT) Full text and rfc822 format available.

Message #17 received at 595698@bugs.debian.org (full text, mbox):

From: David Prévot <david@tilapin.org>
To: Simon Paillard <simon.paillard@resel.enst-bretagne.fr>, 595698@bugs.debian.org
Subject: Re: Bug#595698: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
Date: Sun, 24 Apr 2011 13:39:29 -0400
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Le 12/02/2011 16:11, David Prévot a écrit :
> tags 595698 patch

Simon, anyone, any comment on the patch?

http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=relax_eol_for_define-tag.patch;att=1;bug=595698

If noone objects, I'll commit it in a few days (and yes, I use it
locally for more than two month, it solves the issue spotted earlier,
and I do wonder why I didn't commit it earlier ;-).

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJNtGBQAAoJELgqIXr9/gnyzlcQAJdZf59YEcIsEIYU6SCwm5Wb
KQ7rAgZ9iCzFCcawidTfXFLnSa0aoKULGCRDnEIJDgTyznBxU/p0Mt8Dv8SMrDDb
/W5dduAXTrI4CXfXxiDZ99nYyUC7A+6N4jHAoru9ErmQPPBR7wLcK3igbvy2gPBU
sevUVq2hW7np1AtgU3XUUrDAuPBNJT957grmcNvUIFzqHJXz9NEifBZjZc6ltTZU
cri4azTCaSVQPCE06M0HqzORbGr0mk/SHHuBmhzEt1agsZhEHiTRdc/lInDQfjNf
ToIzAYRyyG87M/WOvZqfwgbvhNYi1EvmNl8iyxyoRQpt6tZd3URl6Dr5NVOiGXRa
+zpAzpokDvSWDWyrDJ+rbLpoGKXCB2MUAiZ2Dqf2Qt3/aF5jKuT0NAKNKimqtF9N
3oMSQ25tKi5rW+A/+CuqstkhL5kMgDk/AzeOvFFB7dKA/rsOl/HRxAmjkZFMf36g
kt5ngUzqj6oGoO2dKS+TUVvyuFj4O617w73xEyVqS/5Q1QTT+6U17dyQxXehNeY0
i+NGwbuCFvHPMGkfL1rXrwToFMpM8tRojvaCWQLGh6HxID5wauqFhUSiDpDBgbkN
TvY9uweJUlhYZNw7e6Tkmi+nIsPE9F8xYaqO+wmmoB0gcNczdoRzc9DorufszIRo
FcTSXbHpPg4SBiE61aId
=D369
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Debian WWW Team <debian-www@lists.debian.org>:
Bug#595698; Package www.debian.org. (Tue, 26 Apr 2011 18:33:10 GMT) Full text and rfc822 format available.

Acknowledgement sent to Simon Paillard <spaillard@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian WWW Team <debian-www@lists.debian.org>. (Tue, 26 Apr 2011 18:33:10 GMT) Full text and rfc822 format available.

Message #22 received at 595698@bugs.debian.org (full text, mbox):

From: Simon Paillard <spaillard@debian.org>
To: 595698@bugs.debian.org
Subject: Re: Bug#595698: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
Date: Tue, 26 Apr 2011 20:28:45 +0200
On Sun, Apr 24, 2011 at 01:39:29PM -0400, David Prévot wrote:
> Le 12/02/2011 16:11, David Prévot a écrit :
> > tags 595698 patch
> 
> Simon, anyone, any comment on the patch?
> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=relax_eol_for_define-tag.patch;att=1;bug=595698
> 
> If noone objects, I'll commit it in a few days (and yes, I use it
> locally for more than two month, it solves the issue spotted earlier,
> and I do wonder why I didn't commit it earlier ;-).

Perfect, I guess you grepped for '$/' ?

-- 
Simon Paillard




Reply sent to David Prévot <david@tilapin.org>:
You have taken responsibility. (Thu, 28 Apr 2011 03:48:03 GMT) Full text and rfc822 format available.

Notification sent to Simon Paillard <spaillard@debian.org>:
Bug acknowledged by developer. (Thu, 28 Apr 2011 03:48:03 GMT) Full text and rfc822 format available.

Message #27 received at 595698-done@bugs.debian.org (full text, mbox):

From: David Prévot <david@tilapin.org>
To: Simon Paillard <spaillard@debian.org>, 595698-done@bugs.debian.org
Subject: Re: Bug#595698: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
Date: Wed, 27 Apr 2011 23:44:59 -0400
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Le 26/04/2011 14:28, Simon Paillard a écrit :
> On Sun, Apr 24, 2011 at 01:39:29PM -0400, David Prévot wrote:
>> Le 12/02/2011 16:11, David Prévot a écrit :
>>> tags 595698 patch
>>
>> Simon, anyone, any comment on the patch?
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=relax_eol_for_define-tag.patch;att=1;bug=595698
>>
>> If noone objects, I'll commit it in a few days (and yes, I use it
>> locally for more than two month, it solves the issue spotted earlier,
>> and I do wonder why I didn't commit it earlier ;-).
> 
> Perfect, I guess you grepped for '$/' ?

'>$/' actually, so there might still exist other corner cases. Since
there are already many CRFL files that don't break anything (and I fixed
some faulty headers while taking care of the breadcrumbs: the build
could now fails if a file is broken on that regard, which may actually
be a good point, better anyway than the silent error that triggered this
BR).

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJNuOK5AAoJELgqIXr9/gnyx0AP/1MoW+7x11ojXbhqmMJs5knG
5USHnErtLMTwkGI36+Oc2rJVP2soWzarkVZYYu430Uu2fBwl4yM5AxXflfir5qok
OXuu+Oef8baF0TA/KpruMC5XEeTbFkD1STw7H/f1vuu5xOTB2KEtA7RUqLoi0m7K
O4yo28ZJt9WuAqIZsVP+3x5eK4AmzjCAFQzDc9ahc2ysPxICLixKvpVe+jiPtReT
3oskIVJ5uBvty/HjVfxXBYynS7KSzUDJqG5jNjXjr+XSziy3eSsYhEwpOAYxYErY
C/+ZCFHe+Z4CofTeSh/CX2Wo34VGr2/ka0SZqkqO0xywZQ1i28iA+BC7ynUmfWU5
xD4rwD6VIsZiRhS7BpJ10JM6MpueiScXyNcFrTbX1sN8ckCB83ZGF2l3x45cqCw8
MrJWz72DY8Cym8Ssv7w9WplqcWRzbV619xa/sbmYQ6XKKeIP08BQYJcBAnbS80nq
c/f+ORSDn7E7xpvnv10EjqLT+7JVFkMSl0EQsjCXRbSRAlDAl3vY3MVnhfpnYE9b
+xCgx1yyrv0Gbdw9ljxvm7ceWTpz87+A7DWXThWrNmIqLADhW/CJMj77FQz7wHjN
U753H+WLuckqFpYk6PS3vWho/42fpVSxoiDy7UIXCR6LXsnyQCYakxKazIAxvFAO
KRgK9qnu8qyvzm/0md6u
=LW/z
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 26 May 2011 07:42:52 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Apr 20 23:35:02 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.