Debian Bug report logs - #592714
creoleparser: FTBFS without Python 2.5: lib directory in python and in debian/rules does not match

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alfonso Cepeda Caballos <cepeda@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: [FTBFS]: lib directory in python and in debian/rules does not match

Date: Thu, 12 Aug 2010 11:01:04 +0200

[Message part 1 (text/plain, inline)]

Package: creoleparser
Version: 0.7.2-3
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch


In debian/rules line:

PYTHONPATH=$(CURDIR)/build/lib $$py $(CURDIR)/build/lib/creoleparser/__init__.py;

assumes that the build is in build/lib directory, but
distutils.core.setup builds in build/lib-$PLAT directory that prevents
the build.

*** /tmp/tmpgBVHk7
In Ubuntu, we've applied the attached patch to achieve the following:

  * [FTBFS] debian/rules: changed build dir from lib-$PLAT to lib
    (LP: #616540)

We thought you might be interested in doing the same. 

[tmpryJU7t (text/x-diff, attachment)]

Message #12 received at 592714@bugs.debian.org (full text, mbox, reply):

From: Piotr Ożarowski <piotr@debian.org>

To: Alfonso Cepeda Caballos <cepeda@gmail.com>

Cc: 592714@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#592714: [FTBFS]: lib directory in python and in debian/rules does not match

Date: Mon, 16 Aug 2010 16:21:33 +0200

[Alfonso Cepeda Caballos, 2010-08-12]
>  	for py in $(PYVERS); do  \
> -	    $$py setup.py build; \
> +	    $$py setup.py build --build-lib=build/lib; \
>  	done

I don't think it's the right fix. You will overwrite previously
generated files this way (it's arch:all package so if .py files are
equal, it will not break the module).
-- 
Piotr Ożarowski                         Debian GNU/Linux Developer
www.ozarowski.pl          www.griffith.cc           www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

Message #17 received at 592714@bugs.debian.org (full text, mbox, reply):

From: Alfonso Cepeda Caballos <cepeda@gmail.com>

To: Piotr Ożarowski <piotr@debian.org>

Cc: 592714@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#592714: [FTBFS]: lib directory in python and in debian/rules does not match

Date: Mon, 16 Aug 2010 17:42:20 +0200

First of all, can you check that the package does not build in debian?
In Ubuntu it doesn't:
http://launchpadlibrarian.net/50119957/buildlog_ubuntu-maverick-i386.creoleparser_0.7.2-3_FAILEDTOBUILD.txt.gz

and I think that provided that testing uses the same python package,
it won't build, but I can be wrong, and right now I cannot download a
debian pbuilder image to test. I mean, maybe this is just an ubuntu
issue, but I think it isn't.


About the patch, I think there is no previously generated files, and
as far as it is arch:all, the lib should be build/lib and not
build/lib-$ARCH.

Anyway the current build outputs:

creating build
creating build/lib.linux-i686-2.6
creating build/lib.linux-i686-2.6/creoleparser
copying creoleparser/core.py -> build/lib.linux-i686-2.6/creoleparser
copying creoleparser/dialects.py -> build/lib.linux-i686-2.6/creoleparser
copying creoleparser/__init__.py -> build/lib.linux-i686-2.6/creoleparser
copying creoleparser/elements.py -> build/lib.linux-i686-2.6/creoleparser

as you can see, python setup function does not create build/lib, so
there should not be any overwriting.

If you think it is better to maintain the build/lib.$ARCH structure,
then, in debian/rules:

PYTHONPATH=$(CURDIR)/build/lib $$py
$(CURDIR)/build/lib/creoleparser/__init__.py; \

should be changed to $(CURDIR)/build/lib.$PLAT where $PLAT is the
output of  distutils.util.get_platform(), but I'd rather the
--build-lib=build/lib solution.

I have tested that package build with the patch is equal to
python-creoleparser_0.7.2-3_all.deb

Anyway I do not use python very much, so I can be wrong.

On 16 August 2010 16:21, Piotr Ożarowski <piotr@debian.org> wrote:
> I don't think it's the right fix. You will overwrite previously
> generated files this way (it's arch:all package so if .py files are
> equal, it will not break the module).

-- 
Proudly working on an Ubuntu lucid 10.04

Message #22 received at 592714@bugs.debian.org (full text, mbox, reply):

From: Fabrice Coutadeur <fabricesp@ubuntu.com>

To: Debian Bug Tracking System <592714@bugs.debian.org>

Subject: creoleparser: How about this patch?

Date: Sat, 18 Sep 2010 10:38:55 +0200

[Message part 1 (text/plain, inline)]

Package: creoleparser
Version: 0.7.2-3
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch

Hi,

I thinks this patch is cleaner, as it just move the test after the installation, to have a predictable fix path. Is it ok?

Thanks,
Fabrice

*** /tmp/tmpyIeasc


-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid-proposed'), (500, 'lucid')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-25-generic (SMP w/2 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[tmpy_KByH (text/x-diff, attachment)]

Message #27 received at 592714-done@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 592714-done@bugs.debian.org

Subject: Re: Bug#592714: creoleparser: How about this patch?

Date: Fri, 1 Apr 2011 12:41:33 +0200

Version: 0.7.3-1

* Fabrice Coutadeur <fabricesp@ubuntu.com>, 2010-09-18, 10:38:
>I thinks this patch is cleaner, as it just move the test after the 
>installation, to have a predictable fix path. Is it ok?

Fabrice's patch was applied in 0.7.3-1, closing the bug.

-- 
Jakub Wilk

Send a report that this bug log contains spam.