Debian Bug report logs - #591604
uboot-envtools: fw_setenv refuses to set ethaddr, even though it can be set via uboot directly

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: uboot-envtools: fw_setenv refuses to set ethaddr, even though it can be set via uboot directly

Date: Wed, 04 Aug 2010 01:12:10 -0400

Package: uboot-envtools
Version: 20081215-2
Severity: normal

when i try to use fw_setenv for the ethaddr variable on a Marvell
guruplug, i get this error (mac address is anonymized):

0 root@moo:~# fw_setenv ethaddr 00:f0:43:XX:XX:XX
Can't overwrite "ethaddr"
1 root@moo:~# 

however, i'm able to reset the variable from the uboot bootloader directly:

Marvell>> setenv ethaddr 00:f0:43:XX:XX:XX
Marvell>> save

after which, the mac address does actually change (though i needed an
extra reboot).

So the source for fw_setenv seems to be unnecessarily restrictive.

Thanks for maintaining uboot-envtools!

   --dkg

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
Architecture: armel (armel)

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, 591604@bugs.debian.org

Cc: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#591604: uboot-envtools: fw_setenv refuses to set ethaddr, even though it can be set via uboot directly

Date: Tue, 22 Feb 2011 23:54:08 +0100

On Wed, Aug 04, 2010, Daniel Kahn Gillmor wrote:
> when i try to use fw_setenv for the ethaddr variable on a Marvell
> guruplug, i get this error (mac address is anonymized):
> 0 root@moo:~# fw_setenv ethaddr 00:f0:43:XX:XX:XX
> Can't overwrite "ethaddr"
> 1 root@moo:~# 

 I'm not sure why that's the case, but the latest version of the code in
 u-boot seems to be enforcing that you can't change this, nor serial#.
 This might be to protect users from shooting themselves in the foot by
 destroying potentially valuable data?

        /*
         * Delete any existing definition
         */
        if (oldval) {
                /*
                 * Ethernet Address and serial# can be set only once
                 */
                if ((strcmp (name, "ethaddr") == 0) ||
                        (strcmp (name, "serial#") == 0)) {
                        fprintf (stderr, "Can't overwrite \"%s\"\n", name);
                        errno = EROFS;
                        return -1;
                }

 in which case, maybe we need a force flag

-- 
Loïc Minier

Message #20 received at 591604@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, 591604@bugs.debian.org

Subject: Re: uboot-envtools: fw_setenv refuses to set ethaddr, even though it can be set via uboot directly

Date: Thu, 02 Oct 2014 11:16:55 -0700

[Message part 1 (text/plain, inline)]

Control: tags -1 upstream moreinfo

On 2010-08-03, Daniel Kahn Gillmor wrote:
> when i try to use fw_setenv for the ethaddr variable on a Marvell
> guruplug, i get this error (mac address is anonymized):
>
> 0 root@moo:~# fw_setenv ethaddr 00:f0:43:XX:XX:XX
> Can't overwrite "ethaddr"
> 1 root@moo:~# 
>
> however, i'm able to reset the variable from the uboot bootloader directly:
...
> So the source for fw_setenv seems to be unnecessarily restrictive.

It may be because you were using a fw_setenv without any
platform-specific build options.

I'm wondering if using fw_setenv explicitly built for guruplug will work
any better. Version 2014.07+dfsg1-2 in jessie and
2014.10~rc2+dfsg1-2~exp1 in experimental ships a fw_printenv/fw_setenv
that is built specifically for each platform in
/usr/lib/u-boot/PLATFORM/fw_*. It seems some platforms may set values
for allowing this to be changed (ENV_FLAGS_VARACCESS_PREVENT_OVERWR and
ENV_FLAGS_VARACCESS_PREVENT_NONDEF_OVERWR in tools/env/fw_env.c), and a
build specifically for the guruplug may work for you.

I was planning on reverting back to a generic env tools build, though
I'd be curious if it works with a platform-specific build.


live well,
  vagrant

[Message part 2 (application/pgp-signature, inline)]

Message #27 received at 591604@bugs.debian.org (full text, mbox, reply):

From: drEagle <dreagle@doukki.net>

To: 591604@bugs.debian.org

Subject: Fixed upstream

Date: Sat, 04 Apr 2015 18:24:59 +0200

This may be fixed since : http://git.denx.de/?p=u-boot.git;a=commit;h=aa701b94336b358798d676eef12a7b90bdac23f5

Message #36 received at 591604-done@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: 591604-done@bugs.debian.org

Subject: Re: Bug#591604: Fixed upstream

Date: Fri, 10 Jan 2020 21:23:26 -0800

[Message part 1 (text/plain, inline)]

Version: 2012.04.01-1

On 2015-04-04, drEagle wrote:
> This may be fixed since : http://git.denx.de/?p=u-boot.git;a=commit;h=aa701b94336b358798d676eef12a7b90bdac23f5

Ok, marking as done with the version in Debian that contained that commit.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.