Debian Bug report logs - #590268
ltsp-server: Try to umount /opt/ltsp/i386//proc during chroot build

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: submit@bugs.debian.org

Subject: ltsp-server: Try to umount /opt/ltsp/i386//proc during chroot build

Date: Sun, 25 Jul 2010 14:51:35 +0200

Package:  ltsp-server
Version:  5.2.3-1
Severity: minor
Tags:     patch

When the chroot_mount function is used like this in the ltsp build
code

  chroot_mount proc /proc "-t proc"

the resulting code end up adding /opt/ltsp/i386//proc to
$CHROOT_MOUNTED.  I propose to handle mount paths with and without
leading / differently to avoid this.

Here is a patch implementing the change:

--- ltsp-5.2.3-pere/server/ltsp-build-client    2010-07-06 05:38:10.000000000 +0200
+++ ltsp-5.2.3/server/ltsp-build-client 2010-07-25 14:38:29.000000000 +0200
@@ -119,9 +119,18 @@
 # $2 - where to mount (skip the chroot path)
 # $3 - mount extra params
 chroot_mount() {
-    if mount $3 $1 $ROOT/$2; then
-        CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT/$2"
-    fi
+    case "$2" in
+       /*)
+           if mount $3 $1 $ROOT$2; then
+               CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT$2"
+           fi
+           ;;
+       *)
+           if mount $3 $1 $ROOT/$2; then
+               CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT/$2"
+           fi
+           ;;
+    esac
 }

 ####################################

Happy hacking,
-- 
Petter Reinholdtsen

Message #10 received at 590268-close@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: 590268-close@bugs.debian.org

Subject: Bug#590268: fixed in ltsp 5.2.4-1

Date: Sat, 31 Jul 2010 14:33:26 +0000

Source: ltsp
Source-Version: 5.2.4-1

We believe that the bug you reported is fixed in the latest version of
ltsp, which is due to be installed in the Debian FTP archive:

ltsp-client-builder_5.2.4-1_all.udeb
  to main/l/ltsp/ltsp-client-builder_5.2.4-1_all.udeb
ltsp-client-core_5.2.4-1_i386.deb
  to main/l/ltsp/ltsp-client-core_5.2.4-1_i386.deb
ltsp-client_5.2.4-1_i386.deb
  to main/l/ltsp/ltsp-client_5.2.4-1_i386.deb
ltsp-server-standalone_5.2.4-1_all.deb
  to main/l/ltsp/ltsp-server-standalone_5.2.4-1_all.deb
ltsp-server_5.2.4-1_all.deb
  to main/l/ltsp/ltsp-server_5.2.4-1_all.deb
ltsp_5.2.4-1.debian.tar.gz
  to main/l/ltsp/ltsp_5.2.4-1.debian.tar.gz
ltsp_5.2.4-1.dsc
  to main/l/ltsp/ltsp_5.2.4-1.dsc
ltsp_5.2.4.orig.tar.gz
  to main/l/ltsp/ltsp_5.2.4.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 590268@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated ltsp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 31 Jul 2010 09:27:44 -0400
Source: ltsp
Binary: ltsp-server ltsp-server-standalone ltsp-client-core ltsp-client ltsp-client-builder
Architecture: source all i386
Version: 5.2.4-1
Distribution: unstable
Urgency: low
Maintainer: LTSP Debian/Ubuntu Maintainers <pkg-ltsp-devel@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Description: 
 ltsp-client - complete LTSP client environment
 ltsp-client-builder - build an LTSP environment in the installer target (udeb)
 ltsp-client-core - basic LTSP client environment
 ltsp-server - basic LTSP server environment
 ltsp-server-standalone - complete LTSP server environment
Closes: 590268 590318
Changes: 
 ltsp (5.2.4-1) unstable; urgency=low
 .
   * New upstream version:
     - ltsp-build-client: chroot_mount function: strip off / from specified
       mount points (Closes: #590268).  Thanks to Petter Reinholdtsen.
     - ltsp-build-client: simplify unmounting of /proc/sys/fs/binfmt_misc mount
       in chroot (Closes: #590318).  Patch by Petter Reinholdtsen.
     - ltsp-chroot: fix argument processing for --arch and --base.
     - ltsp-init-common: Make missing file/dir warnings a little less alarming
       in bind_mounts function.
     - Add wrapper for rdesktop screen script to work with pasuspender.
     - initramfs-tools udhcpc hook: Set broadcast address (LP #604276).
 .
   * Drop patch for /media/cdrom, applied upstream.
   * Update Standards-Version to 3.9.1, no changes necessary.
Checksums-Sha1: 
 371b39d1a58e3b0652ab4da90233174d6e769b40 2195 ltsp_5.2.4-1.dsc
 9029e6c59b4451bef66610d56469d01afb270b28 683043 ltsp_5.2.4.orig.tar.gz
 3d3d7a140fadfbcdcc1a1989d98542c7f96522dc 78733 ltsp_5.2.4-1.debian.tar.gz
 ed3e4323a57e84baa978ba4280ace610e22f05de 225258 ltsp-server_5.2.4-1_all.deb
 a078055a051519bd44e2016321c5dd3963ac23f4 129826 ltsp-server-standalone_5.2.4-1_all.deb
 5d3e9510211b9d3eb319da3c5eede6c35d34ae6e 9354 ltsp-client-builder_5.2.4-1_all.udeb
 9c518a15730c87d27e9945ea9d3bb000d4152841 197770 ltsp-client-core_5.2.4-1_i386.deb
 50dc6dfd8f9c99ec57b7d91bf702e3161f87231e 128908 ltsp-client_5.2.4-1_i386.deb
Checksums-Sha256: 
 fe5a8a25ed552228b4cbc76d4372e94d58575cc1897a06130153f94c510239f6 2195 ltsp_5.2.4-1.dsc
 56b34aaaafc4136dbce1d811fc66904b7f1f9e7412246612405ba785e528e526 683043 ltsp_5.2.4.orig.tar.gz
 894ac1ec3cf6a5522ac870a7233f55a82093b752315d1c90064c42b62c998ad4 78733 ltsp_5.2.4-1.debian.tar.gz
 b0a55912a255cc55a674fa7989ec1039431abaff7fe4b7f10e8a76441b65c278 225258 ltsp-server_5.2.4-1_all.deb
 c36c6f3d1d75e28db1bc51eac818665ba1983ff2a3e4e469f3cd030ce4a7f21b 129826 ltsp-server-standalone_5.2.4-1_all.deb
 e63bc3f18151e5133dee797169a6a16d82de2789f79b24f90494932b794f2982 9354 ltsp-client-builder_5.2.4-1_all.udeb
 31f2ad0a5536ae1e227f89d0b3b64eeed8817126409d0e4cc6ba7a23a398f509 197770 ltsp-client-core_5.2.4-1_i386.deb
 f930fd77e3266ca0cbc8d3c6b1b38c23c6d7fe871487a56ccf49f24d963f3f1b 128908 ltsp-client_5.2.4-1_i386.deb
Files: 
 9b63d47ff31e2fb417301e6d882537ff 2195 misc extra ltsp_5.2.4-1.dsc
 5ca46e46b0ea298b1b1710fab41f523e 683043 misc extra ltsp_5.2.4.orig.tar.gz
 94d4dd6fd4f77985bc8424127ba33459 78733 misc extra ltsp_5.2.4-1.debian.tar.gz
 43e4ad7766cd63e36877358e5ccfe652 225258 misc extra ltsp-server_5.2.4-1_all.deb
 f88d103a4ce3cbdb989d6b2abffed577 129826 misc extra ltsp-server-standalone_5.2.4-1_all.deb
 a7feed5bc54be13811b50bb74ce6259b 9354 debian-installer extra ltsp-client-builder_5.2.4-1_all.udeb
 a0ff0eac005caa4e8761413f40a2444c 197770 misc extra ltsp-client-core_5.2.4-1_i386.deb
 4c64b54a559bb1e2fc83fca366b1274a 128908 misc extra ltsp-client_5.2.4-1_i386.deb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJMVCwyAAoJEAMEK/Djv2x4VOgP/29lyjb4QC6lh2sQI7C2yRZZ
B63DZKxV1CCrgtRRhR4V+Flu1FnzK9/PRb1ra9EDmhkGhU4FaqOZZqurtnZojo2J
IihPbOXuHMwnaA5ziEnZ5niPubtI/0lp/Lpihm1GvOCZOJObTdT7LX2G/p6wScPr
RtUkH0skOCX3TXlEeLlPHCOohIpLiiM6KfneMcCyEpDqfo4ACbrOngwHY1zMhDUB
OTp9+pNauJaZWFYi10D6qa+NS/PLYfzjXE9K2Ljq1qJ3Z2Ez27hklO92GNaoMhvO
AugAQqYgKIaY1j7paQE3wMLsQSgH1nqMtXGcV2GamGqTNxCf/j/eePL8uafBgc/K
8yHF63mT6Cd2qFKnwUjzR4aeBKex4fE78yNHTqeD5a631KkIt3u95JM78QwgDmlB
uaCrThI/rKwquvS3AY9pUsWea7QIVOCAlsccGDuou9DBRIbx6fgQ4aYA4Gzsqz7l
du0Fcg9GHJwsbakfHA5h0841KR2XI6PVJXB4Eo+pjhAHEjHrhZ5S5RWwTBjZtBQG
mj4fvVSyQFDXlvzxg47OYI9EDh9KoLTz8S6XhrOD76xKOcPCk8NvtjLRla2OP5CN
ovdpQhePvKOMNiF60hWje+bEA6oFwhN1pSgfoNxsbuuaJPf6R/1TYE0gUbbC2fQs
8OQBZTzLRNKlQ2m+tZ41
=9Dzz
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.