Debian Bug report logs - #588873
lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Iain Lane <laney@ubuntu.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Mon, 12 Jul 2010 23:39:10 +0100

Package: lintian
Version: 2.4.2ubuntu1
Severity: wishlist

Hello Lintian maintainers,

I'd like to propose a new check which is analogous to
patch-system-but-direct-changes-in-diff but for 3.0 (quilt).

(or perhaps this check could just be extended: thoughts?)

Here we would look to see whether the package declares 3.0 (quilt) and
if so, check if single-debian-patch is not set in debian/source/format
	and there is a debian-changes-xxx patch. If yes, spit out a warning.

What do you think? If the consensus is that this is a good idea then
I'll have a go at implementing.

Cheers v much,
Iain

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-proposed'), (500, 'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-7-server (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils       2.20.51.20100710-1ubuntu2 The GNU assembler, linker and bina
ii  diffstat       1.47-1build1              produces graph of changes introduc
ii  dpkg-dev       1.15.7.2ubuntu2           Debian package development tools
ii  file           5.03-5ubuntu1             Determines file type using "magic"
ii  gettext        0.17-11ubuntu1            GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1         Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24                    Perl interface to libapt-pkg
ii  libclass-acces 0.34-1                    Perl module that automatically gen
ii  libipc-run-per 0.89-1                    Perl module for running processes
ii  libparse-debia 1.1.1-2ubuntu2            parse Debian changelogs and output
ii  libtimedate-pe 1.1900-1                  Time and date functions for Perl
ii  liburi-perl    1.54-1                    module to manipulate and access UR
ii  locales        2.11+git20100304-6        common files for locale support
ii  man-db         2.5.7-3                   on-line manual pager
ii  perl [libdiges 5.10.1-12ubuntu1          Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
ii  libtext-template-perl         1.45-1     Text::Template perl module
ii  man-db                        2.5.7-3    on-line manual pager

-- no debconf information

Message #10 received at 588873@bugs.debian.org (full text, mbox, reply):

From: Russ Allbery <rra@debian.org>

To: Iain Lane <laney@ubuntu.com>

Cc: 588873@bugs.debian.org

Subject: Re: Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Sun, 25 Jul 2010 18:29:06 -0700

Iain Lane <laney@ubuntu.com> writes:

> I'd like to propose a new check which is analogous to
> patch-system-but-direct-changes-in-diff but for 3.0 (quilt).

> (or perhaps this check could just be extended: thoughts?)

> Here we would look to see whether the package declares 3.0 (quilt) and
> if so, check if single-debian-patch is not set in debian/source/format
> 	and there is a debian-changes-xxx patch. If yes, spit out a warning.

> What do you think? If the consensus is that this is a good idea then
> I'll have a go at implementing.

Most of my packages intentionally have only that patch.  Maybe only
trigger it if debian/source/patch-header doesn't exist and mention that if
this is intentional, creating that file allows adding a custom header to
the generated patch explaining why this is done?  That could avoid the
numerous false positives of patch-system-but-direct-changes-in-diff and
make it less wild-guessy.

Otherwise, seems like a good idea to me.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

Message #15 received at 588873@bugs.debian.org (full text, mbox, reply):

From: Iain Lane <laney@ubuntu.com>

To: 588873@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Tue, 27 Jul 2010 00:42:08 +0100

[Message part 1 (text/plain, inline)]

tags 588873 + patch
thanks

Hiya,

On Sun, Jul 25, 2010 at 06:29:06PM -0700, Russ Allbery wrote:
>Iain Lane <laney@ubuntu.com> writes:
>
>> I'd dlike to propose a new check which is analogous to
>> patch-system-but-direct-changes-in-diff but for 3.0 (quilt).
>
> [...]
>
>> What do you think? If the consensus is that this is a good idea then
>> I'll have a go at implementing.
>
>Most of my packages intentionally have only that patch.  Maybe only
>trigger it if debian/source/patch-header doesn't exist and mention that if
>this is intentional, creating that file allows adding a custom header to
>the generated patch explaining why this is done?  That could avoid the
>numerous false positives of patch-system-but-direct-changes-in-diff and
>make it less wild-guessy.
>
>Otherwise, seems like a good idea to me.

Thanks. This was easier than I thought it would be to cook up: attached.

My first Lintian patch; please review for code style.

It might be worth checking for single-debian-patch and no patch-header 
too, but that would be something else.

Cheers,
Iain

[0001-Add-check-for-direct-changes-in-3.0-quilt-packages.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 588873@bugs.debian.org (full text, mbox, reply):

From: Iain Lane <laney@ubuntu.com>

To: 588873@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Thu, 21 Apr 2011 16:04:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

On Tue, Jul 27, 2010 at 12:42:08AM +0100, Iain Lane wrote:
>tags 588873 + patch
>thanks
>
>Hiya,
>
>On Sun, Jul 25, 2010 at 06:29:06PM -0700, Russ Allbery wrote:
>>Iain Lane <laney@ubuntu.com> writes:
>>
>>>I'd dlike to propose a new check which is analogous to
>>>patch-system-but-direct-changes-in-diff but for 3.0 (quilt).
>>
>>[...]
>>
>>>What do you think? If the consensus is that this is a good idea then
>>>I'll have a go at implementing.
>>
>>Most of my packages intentionally have only that patch.  Maybe only
>>trigger it if debian/source/patch-header doesn't exist and mention that if
>>this is intentional, creating that file allows adding a custom header to
>>the generated patch explaining why this is done?  That could avoid the
>>numerous false positives of patch-system-but-direct-changes-in-diff and
>>make it less wild-guessy.
>>
>>Otherwise, seems like a good idea to me.
>
>Thanks. This was easier than I thought it would be to cook up: attached.
>
>My first Lintian patch; please review for code style.
>
>It might be worth checking for single-debian-patch and no 
>patch-header too, but that would be something else.

Ping — any chance of a review/merge?

Iain

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 588873@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Iain Lane <laney@ubuntu.com>, 588873@bugs.debian.org

Subject: Re: Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Fri, 22 Apr 2011 08:48:19 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-04-21 17:04, Iain Lane wrote:
> Hi,
> 
> On Tue, Jul 27, 2010 at 12:42:08AM +0100, Iain Lane wrote:
>> tags 588873 + patch
>> thanks
>>
>> Hiya,
>>
>>> [...]
>>
>> Thanks. This was easier than I thought it would be to cook up: attached.
>>
>> My first Lintian patch; please review for code style.
>>
>> It might be worth checking for single-debian-patch and no patch-header
>> too, but that would be something else.
> 
> Ping — any chance of a review/merge?
> 
> Iain

Hey,

Sorry for the long wait.

Personally I am okay with the patch; would it be possible to convince
you to write a test case for this tag (see t/tests/README for howto/hints)?
  Feel free to submit the test in a separate patch.

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNsSSzAAoJEAVLu599gGRCw0sQAJQkehd6Oeb6+uYwLCECqpIk
TASOneGwJM6ivLtuY+2vT2efYXDpNt87Aa77HxjtQWlzqyDina8x56BZvSCT094z
rfFV+bQq4TW5PvmvBS8sBIphNZhqMpEctSMm6K6rRFYjysalDkfBNiC4k9J3koRn
BSPGw0+55UoCMXLQR9CSI8xd8vmdzCoemBLz2z/Dza1vcVScljnd/1oeW/Ml/j5I
WGkhvbvJM4uQD/zJgJy2PSgEZTEzReevOCD/DLxXqH9sNvIKE9O0Gs+tL2xNGC6W
WTzozkkUJ+Mb8II/Uv1fmQWUrJkK1l0vCUcJwlnWU5c7udoBmMw3mhkHrKN1SjVu
ZR9uDfwiP9y8KBYOZuNrlCpQt3e04W6LjfFvQCtdKYlb26TDDGhmgKNijmqHE3QD
oto4DGN70bGyoJuLoJ4eSVGvEIzSrFfQ+3zjP1uBKBCeRgrfOHVI9p6/Nv4dgU1F
+l9UyO3/rwdk7+R2KKsx68BzDjqZas+l7Dm7B16uXq2ddfdt/RP/XgpptheS1qlZ
IfKUFqsNqUemEBsLzPdGXLW1/g2+XmIwvoz73pHSsYxBB7IlMI4LqJhIGB0Y5kV0
S2lefkuDPCUWqU5G+hAzllboX/cObYj9710Uc0JZB9MHoSklLLaI93kgXgRVICkK
7AFWTGgkN73e5uljIE0o
=hztH
-----END PGP SIGNATURE-----

Message #32 received at 588873@bugs.debian.org (full text, mbox, reply):

From: Iain Lane <laney@ubuntu.com>

To: 588873@bugs.debian.org

Subject: Re: Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch

Date: Sun, 24 Apr 2011 19:01:36 +0100

[Message part 1 (text/plain, inline)]

Hi,

On Fri, Apr 22, 2011 at 08:48:19AM +0200, Niels Thykier wrote:
>On 2011-04-21 17:04, Iain Lane wrote:
>> Hi,
>> 
>> On Tue, Jul 27, 2010 at 12:42:08AM +0100, Iain Lane wrote:
>>> tags 588873 + patch
>>> thanks
>>>
>>> Hiya,
>>>
>>>> [...]
>>>
>>> Thanks. This was easier than I thought it would be to cook up: attached.
>>>
>>> My first Lintian patch; please review for code style.
>>>
>>> It might be worth checking for single-debian-patch and no patch-header
>>> too, but that would be something else.
>> 
>> Ping — any chance of a review/merge?
>> 
>> Iain
>
>Hey,
>
>Sorry for the long wait.
>
>Personally I am okay with the patch; would it be possible to convince
>you to write a test case for this tag (see t/tests/README for howto/hints)?
>  Feel free to submit the test in a separate patch.

Yep, here you go. I rebased the original patch too to resolve the
changelog conflict.

Good to see Lintian active :-)

Iain

[0001-Add-check-for-direct-changes-in-3.0-quilt-packages.patch (text/x-diff, attachment)]

[0002-Add-test-for-format-3.0-but-debian-changes-patch.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 588873-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 588873-close@bugs.debian.org

Subject: Bug#588873: fixed in lintian 2.5.0

Date: Tue, 10 May 2011 22:25:31 +0000

Source: lintian
Source-Version: 2.5.0

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_2.5.0.dsc
  to main/l/lintian/lintian_2.5.0.dsc
lintian_2.5.0.tar.gz
  to main/l/lintian/lintian_2.5.0.tar.gz
lintian_2.5.0_all.deb
  to main/l/lintian/lintian_2.5.0_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 588873@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 10 May 2011 20:44:32 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.0
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description: 
 lintian    - Debian package checker
Closes: 588873 607694 614715 617991 622888 623390 623780 623878 624149 626038 626210
Changes: 
 lintian (2.5.0) unstable; urgency=low
 .
   * Summary of tag changes:
     + Added:
       - duplicate-files
       - format-3.0-but-debian-changes-patch
       - extended-description-contains-empty-paragraph
       - git-patches-not-exported
 .
   * checks/binaries:
     + [NT] Fixed false-positive embedded-library.  Lintian incorrectly
       assumed that none of these binary packages would contain a source
       version in their source field.  (Closes: #626038)
   * checks/copyright-file.desc:
     + [ADB] Correct a spelling mistake ("coypright" -> "copyright") in the
       description of copyright-refers-to-deprecated-bsd-license-file;
       thanks, Kees Cook.  (Closes: #623780)
   * checks/description{,.desc}:
     + [NT] Check for empty paragraphs in extended description.  Thanks to
       Gerfried Fuchs for the patch.
   * checks/duplicate-files{,.desc}:
     + [NT] Added to check for duplicate files in usr/share/doc.  Thanks to
       Axel Beckert for the suggestion.  (Closes: #614715)
   * check/fields:
     + [NT] Accepted pach from Antonio Terceiro to add Ruby-Version as a
       accepted field in binary packages.  Thanks to Vincent Carmona for
       the report.  (Closes: #623390)
   * check/files:
     + [NT] Accepted multiple patches (merged into one) from Marcelo Jorge
       Vieira to detect a number of new javascript libraries.
       (Closes: #623878)
   * checks/patch-systems{,.desc}:
     + [NT] Detect when 3.0 (quilt) packages have a debian-changes-VERSION
       patch without a patch header.  Thanks to Iain Lane for suggestion
       and patch.  (Closes: #588873)
   * checks/debian-source-dir{,.desc}:
     + [NT] Applied patch from David Bremner to enable
       git-patches-not-exported.  (Closes: #607694)
   * checks/java:
     + [NT] Tightened the regex for finding java libraries and restricted
       missing-classpath tag to only be emitted for packages that actually
       contain at least one jar file we check.  This fixes false-positives
       for packages that depended on libX-java-doc packages or packages
       that only contain jar files we ignore.
   * check/scripts{,.desc}:
     + [NT] Accepted patch from Antonio Terceiro to allow ruby-interpreter
       as alternative to ruby for /usr/bin/ruby scripts.
       (Closes: #626210)
 .
   * data/common/source-fields:
     + [NT] Accepted pach from Antonio Terceiro to add Ruby-Version as a
       accepted field in binary packages.  Thanks to Vincent Carmona for
       the report.
 .
   * lib/Lintian/ProcessableGroup.pm:
     + [NT] Properly handle if the changes file is located directly in the
       file system root.  Thanks to Trent W. Buck for the bug report.
       (Closes: #624149)
   * lib/Lintian/Tags.pm:
     + [NT] Allow overrides to use wildcards anywhere instead of only in
       the beginning or the end.  Thanks to Steve R. Langasek for the
       report.  (Closes: #617991)
     + [NT] Allow simple architecture overrides such as [i386] or [!i386].
       Architecture wildcards are not supported yet.  The actual syntax
       for the architecture the same as the one used in the Build-Depends.
       Thanks to Andreas Beckmann for the bug report and the solution
       proposal.  (Closes: #622888)
Checksums-Sha1: 
 e5ff5d46d2b702f03b72849c4bbf1100f93b3915 2402 lintian_2.5.0.dsc
 fa7a65c2fdf28b4b70aae5ce866a08f49b571fe9 924659 lintian_2.5.0.tar.gz
 5c5cc472d276835bc8e28f11bfb548ba26803d2c 585644 lintian_2.5.0_all.deb
Checksums-Sha256: 
 e343e2d8bebb2c5b5315c3c0e70948a988919364bfe4be8918bdc62f0dcd7af5 2402 lintian_2.5.0.dsc
 22b2ae111fd45809f7c8933b25069079cbbbfa0352b1212c12f4fd8235f97dea 924659 lintian_2.5.0.tar.gz
 e70932268f2ac11f2be032ad2dc07a761205940dbd71959cbf578ca75302082c 585644 lintian_2.5.0_all.deb
Files: 
 087aa590f74b65781e24571c3c31da07 2402 devel optional lintian_2.5.0.dsc
 bccd22190c9f171116eadb45322c6a65 924659 devel optional lintian_2.5.0.tar.gz
 29b06fe0632a663d9c096f4a2cb644ad 585644 devel optional lintian_2.5.0_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJNyZlrAAoJEAVLu599gGRCylgP/1T6fvHkeDgKv1pET+jiDGG7
WTCr3UTTja3Wo0Nz/8Zx1OP0r7pCpqvIod4+YLvXWa+Nd1ZG3rskgGX83zMM065n
aYdIrhUsv7XauT0A509Ddpj6yOTeTZv9wx1/Vn6qu3CkiPx6oc+DrOs5F/8CXz+E
fhq6l5pwPUkvqYpx29DpHW/levX8nuSk8h7yexDMAZ6c5hQn4I7EoOBrhOHpU5QM
NkveAkmYe+ZnpoKF3QW9mQVy8wkx9WdBST0ivmDI3Zpz1bNYArkJfEWL+CbvL85V
QF6LjToQywItQk8l9X639by3YFt3SF4esVjA7L8f7/ZvUCdhkkY1BZxX+mnDavKr
TWkFQTYaz/RLB9kEU7RqrSG1y6nsFOnj7kkWOZaQ0rT6D+mScL1rzojP96C9cWEf
Gl+8Y/INrEXfmX4uVrBXyCSQWBBOoucEl1C12MxI1dcDAi11a9YVYG0pl0XWeiJR
ZIGad5t5PxRuI3LpJtM9r+022Bf6lFP76SfCShe5rlGbY7ApxUSTT7tDlWJYfJfO
+StB4A8eR6EBGwCSRLD1eXHz2hzy4nHoHTyygwNGPodhp23eY9DrzIYXlxySedZe
tNygnS6XujZcS0CRTrtSpf9EYuyncvQBLFJeMwLD+Y+z9FnHyTJlup2j0fp0vwg0
P4IzHcH96P7xPCrVOCbZ
=sKoJ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.