Debian Bug report logs - #588306
unreachable code in do_netmount

Package: live-boot; Maintainer for live-boot is Live Systems Maintainers <debian-live@lists.debian.org>; Source for live-boot is src:live-boot.

Reported by: Colin Watson <cjwatson@ubuntu.com>

Date: Wed, 7 Jul 2010 08:51:02 UTC

Severity: normal

Tags: moreinfo

Done: Daniel Baumann <daniel@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Live Project <debian-live@lists.debian.org>:
Bug#588306; Package live-initramfs. (Wed, 07 Jul 2010 08:51:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Colin Watson <cjwatson@ubuntu.com>:
New Bug report received and forwarded. Copy sent to Debian Live Project <debian-live@lists.debian.org>. (Wed, 07 Jul 2010 08:51:05 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Colin Watson <cjwatson@ubuntu.com>
To: submit@bugs.debian.org
Subject: live-initramfs: Unreachable code in do_netmount
Date: Wed, 7 Jul 2010 09:49:06 +0100
Package: live-initramfs
Version: 1.236.2-1
Severity: normal
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu maverick

do_netmount is called in exactly one place:

        if [ ! -z "${NETBOOT}" ] || [ ! -z "${FETCH}" ] || [ ! -z "${HTTPFS}" ] || [ ! -z "${FTPFS}" ]
        then
                if do_netmount

That function then contains code guarded by this conditional:

        if [ -z "${NETBOOT}" ] && [ -z "${FETCH}" ] && \
           [ -z "${HTTPFS}" ] && [ -z "${FTPFS}" ]
        then

That code can therefore never be called.  When is it supposed to be run?

-- 
Colin Watson                                       [cjwatson@ubuntu.com]




Information forwarded to debian-bugs-dist@lists.debian.org, Debian Live Project <debian-live@lists.debian.org>:
Bug#588306; Package live-initramfs. (Wed, 07 Jul 2010 10:09:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Marco Amadori <amadorim@vdavda.com>:
Extra info received and forwarded to list. Copy sent to Debian Live Project <debian-live@lists.debian.org>. (Wed, 07 Jul 2010 10:09:06 GMT) Full text and rfc822 format available.

Message #10 received at 588306@bugs.debian.org (full text, mbox):

From: Marco Amadori <amadorim@vdavda.com>
To: 588306@bugs.debian.org
Subject: Re: Bug#588306: live-initramfs: Unreachable code in do_netmount
Date: Wed, 7 Jul 2010 11:35:31 +0200
In data mercoledì 7 luglio 2010 10:49:06, Colin Watson ha scritto:

> do_netmount is called in exactly one place:
> 
>         if [ ! -z "${NETBOOT}" ] || [ ! -z "${FETCH}" ] || [ ! -z
> "${HTTPFS}" ] || [ ! -z "${FTPFS}" ] then
>                 if do_netmount
> 
> That function then contains code guarded by this conditional:
> 
>         if [ -z "${NETBOOT}" ] && [ -z "${FETCH}" ] && \
>            [ -z "${HTTPFS}" ] && [ -z "${FTPFS}" ]
>         then

It is "do_netsetup" that contains that code, not "do_netmount", so the rest of 
"do_netsetup" will be executed.

It seems to me that this bug should be tagged invalid for that reason.

> That code can therefore never be called.  When is it supposed to be run?

That code seems to be added when the networking of live-initramfs leveraged 
the initramfs-tools one.

It is quite a time since I didn't personally tested that netboot (cifs or nfs) 
code, did you found that it currently do not work? If that is the case please 
open a new bug report and I'll do a regression test/fix cycle.

-- 
ESC:wq

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.





Added tag(s) moreinfo. Request was from Daniel Baumann <daniel@debian.org> to control@bugs.debian.org. (Wed, 07 Jul 2010 18:12:09 GMT) Full text and rfc822 format available.

Changed Bug title to 'unreachable code in do_netmount' from 'live-initramfs: Unreachable code in do_netmount' Request was from Daniel Baumann <daniel@debian.org> to control@bugs.debian.org. (Fri, 16 Jul 2010 03:03:14 GMT) Full text and rfc822 format available.

Bug reassigned from package 'live-initramfs' to 'live-boot'. Request was from Daniel Baumann <daniel@debian.org> to control@bugs.debian.org. (Fri, 16 Jul 2010 03:09:02 GMT) Full text and rfc822 format available.

Bug No longer marked as found in versions live-initramfs/1.236.2-1. Request was from Daniel Baumann <daniel@debian.org> to control@bugs.debian.org. (Fri, 16 Jul 2010 03:09:03 GMT) Full text and rfc822 format available.

Reply sent to daniel@debian.org:
You have taken responsibility. (Thu, 02 Sep 2010 08:57:13 GMT) Full text and rfc822 format available.

Notification sent to Colin Watson <cjwatson@ubuntu.com>:
Bug acknowledged by developer. (Thu, 02 Sep 2010 08:57:13 GMT) Full text and rfc822 format available.

Message #23 received at 588306-done@bugs.debian.org (full text, mbox):

From: Daniel Baumann <daniel@debian.org>
To: 588306-done@bugs.debian.org, 588306-submitter@bugs.debian.org
Subject: Re: unreachable code in do_netmount
Date: Thu, 02 Sep 2010 10:53:35 +0200
you're claiming that do_netmount() contains the guard, but that's not
true (it does stuff before a guard which is run for all netboot
variants, and then contains a guard that is tighter than all netboot
variants to do stuff only needed for those specific netboot variants),
so no dead code (though, it's dead ugly :), however, closing this bug.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/




Message sent on to Colin Watson <cjwatson@ubuntu.com>:
Bug#588306. (Thu, 02 Sep 2010 08:57:15 GMT) Full text and rfc822 format available.

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 01 Oct 2010 07:29:02 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed Apr 16 05:24:17 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.