Debian Bug report logs - #579639
Netbook enhancements

version graph

Package: squirrelmail; Maintainer for squirrelmail is Jeroen van Wolffelaar <jeroen@wolffelaar.nl>; Source for squirrelmail is src:squirrelmail.

Reported by: Andrew Buckeridge <andrewb@bgc.com.au>

Date: Thu, 29 Apr 2010 11:48:01 UTC

Severity: wishlist

Merged with 579632

Found in version squirrelmail/2:1.4.15-4+lenny2

Forwarded to https://sourceforge.net/tracker/?func=detail&aid=2994524&group_id=311&atid=350311

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Jeroen van Wolffelaar <jeroen@wolffelaar.nl>:
Bug#579639; Package squirrelmail. (Thu, 29 Apr 2010 11:48:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andrew Buckeridge <andrewb@bgc.com.au>:
New Bug report received and forwarded. Copy sent to Jeroen van Wolffelaar <jeroen@wolffelaar.nl>. (Thu, 29 Apr 2010 11:48:05 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Andrew Buckeridge <andrewb@bgc.com.au>
To: submit@bugs.debian.org
Subject: Netbook enhancements
Date: Thu, 29 Apr 2010 19:45:22 +0800
Package: squirrelmail
Version: 2:1.4.15-4+lenny2
Severity: wishlist

The options in squirrelmail to edit are all over the shop and a waste
of SVGA space. When overseas I noticed that these would not fit on
netbook display when a reasonable font size was used.

The inconsistency issue is a bit like #421152 which is also a wishlist
item for upstream.

These are not skinable so I will need it changed if it is not to revert
on every update.

I hacked up /usr/share/squirrelmail/src/read_body.php

The logic might be a mess, but this just tidies up display.

Folder	Edit option text	New text
======	================	========
Sent	Edit Message as New	Edit
Drafts	Resume Draft		Edit
INBOX	Forward			Edit (only threading)
INBOX	Forward as Attachment	Forward (any other way?)

> /usr/share/squirrelmail/po/squirrelmail.pot:733:msgid "Edit Message as New"
> /usr/share/squirrelmail/src/read_body.php:567:        $comp_alt_string = _("Edit Message as New");
Change to "Edit".

> /usr/share/squirrelmail/po/squirrelmail.pot:730:msgid "Resume Draft"
> /usr/share/squirrelmail/src/read_body.php:564:        $comp_alt_string = _("Resume Draft");
Change to "Edit".

> /usr/share/squirrelmail/po/squirrelmail.pot:739:msgid "Forward"
> /usr/share/squirrelmail/po/squirrelmail.pot:1584:msgid "Prepend Signature before Reply/Forward Text"
> /usr/share/squirrelmail/src/read_body.php:641:    $s .= makeComposeLink($comp_action_uri, _("Forward"));
Change to "Edit".

> /usr/share/squirrelmail/po/squirrelmail.pot:742:msgid "Forward as Attachment"
> /usr/share/squirrelmail/po/squirrelmail.pot:1557:msgid "Enable Forward as Attachment"
> /usr/share/squirrelmail/src/read_body.php:646:        $s .= makeComposeLink($comp_action_uri, _("Forward as Attachment"));
Change to "Forward".

I have changed 4 lines in /usr/share/squirrelmail/src/read_body.php

> --- read_body.php.ori   2009-05-19 22:43:01.000000000 +0800
> +++ read_body.php       2010-04-29 18:25:08.000000000 +0800
> @@ -561,10 +561,10 @@
>  
>      if (($mailbox == $draft_folder) && ($save_as_draft)) {
>          $comp_alt_uri = $comp_uri . '&amp;smaction=draft';
> -        $comp_alt_string = _("Resume Draft");
> +        $comp_alt_string = _("Edit");
>      } else if (handleAsSent($mailbox)) {
>          $comp_alt_uri = $comp_uri . '&amp;smaction=edit_as_new';
> -        $comp_alt_string = _("Edit Message as New");
> +        $comp_alt_string = _("Edit");
>      }
>      if (isset($comp_alt_uri)) {
>          $s .= $topbar_delimiter;
> @@ -638,12 +638,12 @@
>      $s .= '</small></td>' . "\n" .
>            html_tag( 'td', '', 'right', '', 'width="33%" nowrap' ) . '<small>';
>      $comp_action_uri = $comp_uri . '&amp;smaction=forward';
> -    $s .= makeComposeLink($comp_action_uri, _("Forward"));
> +    $s .= makeComposeLink($comp_action_uri, _("Edit"));
>  
>      if ($enable_forward_as_attachment) {
>          $comp_action_uri = $comp_uri . '&amp;smaction=forward_as_attachment';
>          $s .= $topbar_delimiter;
> -        $s .= makeComposeLink($comp_action_uri, _("Forward as Attachment"));
> +        $s .= makeComposeLink($comp_action_uri, _("Forward"));
>      }
>  
>      $comp_action_uri = $comp_uri . '&amp;smaction=reply';




Information forwarded to debian-bugs-dist@lists.debian.org, Jeroen van Wolffelaar <jeroen@wolffelaar.nl>:
Bug#579639; Package squirrelmail. (Thu, 29 Apr 2010 12:18:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andrew Buckeridge <andrewb@bgc.com.au>:
Extra info received and forwarded to list. Copy sent to Jeroen van Wolffelaar <jeroen@wolffelaar.nl>. (Thu, 29 Apr 2010 12:18:04 GMT) Full text and rfc822 format available.

Message #10 received at 579639@bugs.debian.org (full text, mbox):

From: Andrew Buckeridge <andrewb@bgc.com.au>
To: 579639@bugs.debian.org
Subject: Drafts folder
Date: Thu, 29 Apr 2010 19:49:45 +0800
Package: squirrelmail
Version: 2:1.4.15-4+lenny2
Severity: wishlist

My change resulted in two Edit options for Drafts folder.
They were very similar. Now I have:

Folder	Edit option text	New text
======	================	========
Sent	Edit Message as New	Edit
Drafts	Resume Draft		Resume
INBOX	Forward			Edit (only threading)
INBOX	Forward as Attachment	Forward (any other way?)

Forwarding inline is useless for any forensics, but a way preserving
just threading in re-purposed email sometimes is useful. Now a bit
cryptic.

> --- read_body.php.ori   2009-05-19 22:43:01.000000000 +0800
> +++ read_body.php       2010-04-29 19:09:52.000000000 +0800
> @@ -561,10 +561,10 @@
>  
>      if (($mailbox == $draft_folder) && ($save_as_draft)) {
>          $comp_alt_uri = $comp_uri . '&amp;smaction=draft';
> -        $comp_alt_string = _("Resume Draft");
> +        $comp_alt_string = _("Resume");
>      } else if (handleAsSent($mailbox)) {
>          $comp_alt_uri = $comp_uri . '&amp;smaction=edit_as_new';
> -        $comp_alt_string = _("Edit Message as New");
> +        $comp_alt_string = _("Edit");
>      }
>      if (isset($comp_alt_uri)) {
>          $s .= $topbar_delimiter;
> @@ -638,12 +638,12 @@
>      $s .= '</small></td>' . "\n" .
>            html_tag( 'td', '', 'right', '', 'width="33%" nowrap' ) . '<small>';
>      $comp_action_uri = $comp_uri . '&amp;smaction=forward';
> -    $s .= makeComposeLink($comp_action_uri, _("Forward"));
> +    $s .= makeComposeLink($comp_action_uri, _("Edit"));
>  
>      if ($enable_forward_as_attachment) {
>          $comp_action_uri = $comp_uri . '&amp;smaction=forward_as_attachment';
>          $s .= $topbar_delimiter;
> -        $s .= makeComposeLink($comp_action_uri, _("Forward as Attachment"));
> +        $s .= makeComposeLink($comp_action_uri, _("Forward"));
>      }
>  
>      $comp_action_uri = $comp_uri . '&amp;smaction=reply';




Information forwarded to debian-bugs-dist@lists.debian.org, Jeroen van Wolffelaar <jeroen@wolffelaar.nl>:
Bug#579639; Package squirrelmail. (Fri, 30 Apr 2010 03:24:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andrew Buckeridge <andrewb@bgc.com.au>:
Extra info received and forwarded to list. Copy sent to Jeroen van Wolffelaar <jeroen@wolffelaar.nl>. (Fri, 30 Apr 2010 03:24:04 GMT) Full text and rfc822 format available.

Message #15 received at 579639@bugs.debian.org (full text, mbox):

From: Andrew Buckeridge <andrewb@bgc.com.au>
To: 579639@bugs.debian.org
Subject: sourceforge.net SquirrelMail ID: 2994524
Date: Fri, 30 Apr 2010 11:21:58 +0800
Package: squirrelmail
Version: 2:1.4.15-4+lenny2
Severity: wishlist

I have posted similar in SourceForge
https://sourceforge.net/tracker/?func=detail&aid=2994524&group_id=311&atid=350311




Set Bug forwarded-to-address to 'https://sourceforge.net/tracker/?func=detail&aid=2994524&group_id=311&atid=350311'. Request was from Thijs Kinkhorst <thijs@debian.org> to control@bugs.debian.org. (Sun, 02 May 2010 13:45:06 GMT) Full text and rfc822 format available.

Forcibly Merged 579632 579639. Request was from Thijs Kinkhorst <thijs@debian.org> to control@bugs.debian.org. (Sun, 24 Jul 2011 15:00:07 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Apr 18 16:00:09 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.