Debian Bug report logs - #577886
mozvoikko: FTBFS: nscore.h:406:2: error: #warning libxul SDK was configured with char16_t support, but now building without

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@lucas-nussbaum.net>

To: submit@bugs.debian.org

Subject: mozvoikko: FTBFS: nscore.h:406:2: error: #warning libxul SDK was configured with char16_t support, but now building without

Date: Thu, 15 Apr 2010 10:00:33 +0200

Source: mozvoikko
Version: 1.0-4
Severity: serious
Tags: squeeze sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20100415 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> g++ -c -g -O2 -Wall -Werror -Wno-non-virtual-dtor -fno-rtti -fno-exceptions -fPIC -I/usr/include/xulrunner-1.9.1/unstable -I/usr/include/nspr   -include mozilla-config.h -include xpcom-config.h -DSYSTEM_LIBVOIKKO -o mozVoikko.o mozVoikko.cpp
> In file included from /usr/include/xulrunner-1.9.1/unstable/nsXPCOMStrings.h:42,
>                  from /usr/include/xulrunner-1.9.1/unstable/nsStringAPI.h:53,
>                  from mozVoikkoSpell.hxx:25,
>                  from mozVoikko.cpp:28:
> /usr/include/xulrunner-1.9.1/unstable/nscore.h:406:2: error: #warning libxul SDK was configured with char16_t support, but now building without
> In file included from mozVoikkoSpell.hxx:25,
>                  from mozVoikko.cpp:28:
> /usr/include/xulrunner-1.9.1/unstable/nsStringAPI.h:1066:4: error: #warning Using conversions for literal strings. Please consider using 2-bytes wchar_t or char16_t instead
> make[2]: *** [mozVoikko.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2010/04/15/mozvoikko_1.0-4_lsid64.buildlog

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.

-- 
| Lucas Nussbaum
| lucas@lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas@nussbaum.fr             GPG: 1024D/023B3F4F |

Message #10 received at 577886@bugs.debian.org (full text, mbox, reply):

From: Harri Pitkänen <hatapitk@iki.fi>

To: 577886@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: mozvoikko: FTBFS: nscore.h:406:2

Date: Fri, 16 Apr 2010 21:53:41 +0300

tags 577886 + patch
thanks

This bug is due to build configuration difference between xulrunner and 
mozvoikko. Xulrunner is now built with -std=gnu++0x, attached patch adds the 
same option to mozvoikko build. This fixes the build and short testing 
suggests that the extension seems to work on amd64.

I know nothing about the reasons behind the decision to use -std=gnu++0x for 
xulrunner and whether extensions are supposed to be built this way in the 
future. If this should be the standard configuration then I'd suggests that 
this option should be set automatically through pkg-config for all xulrunner 
using applications instead of patching this package.

Harri

--- rules       (revision 3315)
+++ rules       (working copy)
@@ -27,7 +27,7 @@
        dh_testdir

        # Add here commands to compile the package.
-       $(MAKE) -f Makefile.xulrunner extension-files
+       CFLAGS=-std=gnu++0x $(MAKE) -f Makefile.xulrunner extension-files

        touch $@

Message #17 received at 577886@bugs.debian.org (full text, mbox, reply):

From: Heikki Mäntysaari <heikki.mantysaari@linux.fi>

To: 577886@bugs.debian.org

Subject: Re: Bug#577886: mozvoikko: FTBFS: nscore.h:406:2

Date: Mon, 19 Apr 2010 07:49:17 +0300

pe, 2010-04-16 kello 21:53 +0300, Harri Pitkänen kirjoitti:
> tags 577886 + patch
> thanks
> 
> This bug is due to build configuration difference between xulrunner and 
> mozvoikko. Xulrunner is now built with -std=gnu++0x, attached patch adds the 
> same option to mozvoikko build. This fixes the build and short testing 
> suggests that the extension seems to work on amd64.

Thanks for the patch!

I'll try to figure out why such a change has been done and apply your
patch if necessary.

-- 
Heikki Mäntysaari

Message #22 received at 577886@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: Mike Hommey <mh@glandium.org>

Cc: Debian Mozilla Extension Maintainers <pkg-mozext-maintainers@lists.alioth.debian.org>, heikki.mantysaari@linux.fi, 577886@bugs.debian.org

Subject: Re: [Pkg-mozext-maintainers] icedove-dev vs xulrunner-1.9.1-dev

Date: Tue, 20 Apr 2010 12:45:56 -0400

[Message part 1 (text/plain, inline)]

for those just getting looped in, this discussion is archived in the
thread starting at:

 http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/2010-April/000487.html

On 04/13/2010 03:46 AM, Mike Hommey wrote:
> On Mon, Apr 12, 2010 at 06:13:38PM -0400, Daniel Kahn Gillmor wrote:
>> possibly even more worrisome, some of the include files seem to
>> differ slightly, even in the directories labeled "stable", e.g.
>> HAVE_CPP_2BYTE_WCHAR_T is defined in icedove/stable/xpcom-config.h,
> 
> This should definitely be changed. I'm on my way for a better "fix" on
> xulrunner that I hope will be applied to icedove. I'll come back later
> with that.

http://bugs.debian.org/577886 looks like another concern related to wide
character types, as is (maybe) this bug related to firegpg in ubuntu:
https://bugs.launchpad.net/ubuntu/+source/firegpg/+bug/515872

Can you describe your plan (or point to docs about it)?  What do we need
to do to get it applied to icedove as well?

Thanks for having thought through all this, Mike.  I wish i understood
the situation better so i could be more helpful.

Regards,

	--dkg

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 577886@bugs.debian.org (full text, mbox, reply):

From: Mike Hommey <mh@glandium.org>

To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Cc: Debian Mozilla Extension Maintainers <pkg-mozext-maintainers@lists.alioth.debian.org>, heikki.mantysaari@linux.fi, 577886@bugs.debian.org

Subject: Re: [Pkg-mozext-maintainers] icedove-dev vs xulrunner-1.9.1-dev

Date: Tue, 20 Apr 2010 19:24:32 +0200

On Tue, Apr 20, 2010 at 12:45:56PM -0400, Daniel Kahn Gillmor wrote:
> for those just getting looped in, this discussion is archived in the
> thread starting at:
> 
>  http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/2010-April/000487.html
> 
> On 04/13/2010 03:46 AM, Mike Hommey wrote:
> > On Mon, Apr 12, 2010 at 06:13:38PM -0400, Daniel Kahn Gillmor wrote:
> >> possibly even more worrisome, some of the include files seem to
> >> differ slightly, even in the directories labeled "stable", e.g.
> >> HAVE_CPP_2BYTE_WCHAR_T is defined in icedove/stable/xpcom-config.h,
> > 
> > This should definitely be changed. I'm on my way for a better "fix" on
> > xulrunner that I hope will be applied to icedove. I'll come back later
> > with that.
> 
> http://bugs.debian.org/577886 looks like another concern related to wide
> character types, as is (maybe) this bug related to firegpg in ubuntu:
> https://bugs.launchpad.net/ubuntu/+source/firegpg/+bug/515872
> 
> Can you describe your plan (or point to docs about it)?  What do we need
> to do to get it applied to icedove as well?

Previously, xulrunner was built without -fshort-wchar. Building with has
several different problems, one being that it's not possible to mix
libraries built with -fshort-wchar and others built without (which iirc
happened), and another one being that it's not possible to use
-fshort-wchar on ARM at all.

What -fshort-wchar allows, on mozilla, is to be able to have literal
strings in utf-16 directly. Without -fshort-wchar, literal strings are
actually converted from ascii at runtime.

But that without considering HAVE_CPP_2BYTE_WCHAR_T.
HAVE_CPP_2BYTE_WCHAR_T is set when xulrunner has been built with
-fshort-wchar, and that ends up in xpcom-config.h.
In turn, in nsLiteralString.h and nsStringAPI.h, the definitions for
literal strings that use constructs that only work with -fshort-wchar
are #ifdef'ed with HAVE_CPP_2BYTE_WCHAR_T. Which means that building
against a SDK that was built with -fshort-wchar needs the -fshort-wchar
flag.

This particular issue was fixed a long time ago, and is probably the
root of the problem with firegpg on ubuntu: either -fshort-wchar doesn't
end up in the .pc file in the -dev package or firegpg doesn't take the
cflags value from the .pc file.

Anyways, in the mozilla 1.9.2 branch, there is a new way to get literal
strings in utf-16 without -fshort-wchar, which is to use new C++0x
constructs. These, in turn, require the -std=gnu++0x option. But I don't
feel this option needs to be in the .pc file.

Again, the build time choice is set in stone in xpcom-config.h.

The latest xulrunner version in unstable has has a backport of this new
check in configure, plus some c++0x fixes, and a diversion from upstream
which is the cause of bug #577886: It allows to properly use whatever
options has been set on gcc command line despite what is set in
xpcom-config.h, but warns when there is a difference. It also warns when
the runtime conversion is used instead of really literal strings.
#577886 is due to mozvoikko being built with -Werror, and turning the
warning into an error.

While the former warnings may be removed, or moved at another location
(it is currently in nscore.h but actually a lot of things are including
nscore.h that don't need the string literals, so in the end it probably
wasn't the right location), the latter will remain.
Please note that it doesn't really make a difference if you build with
-fshort-wchar when xulrunner was built with -std=gnu++0x and vice-versa,
but IMHO, -fshort-wchar should be avoided for the reasons given above.

I got Lucas to send me the build logs from all the build-rdeps from
xulrunner built against the latest version, which allows me to verify
some of them are definitely not doing the right thing (such as galeon
and kazehakase which are doing their own -fshort-wchar check instead of
taking what is in the .pc file). I overlooked the fact that it actually
broke mozvoikko, but dealing with these warnings is definitely in my
TODO-list.

FWIW, the relevant upstream (mozilla) bugs are:
https://bugzilla.mozilla.org/show_bug.cgi?id=559278
https://bugzilla.mozilla.org/show_bug.cgi?id=502301
https://bugzilla.mozilla.org/show_bug.cgi?id=502298

Mike

Message #32 received at 577886-close@bugs.debian.org (full text, mbox, reply):

From: Heikki Mäntysaari <heikki.mantysaari@linux.fi>

To: 577886-close@bugs.debian.org

Subject: Bug#577886: fixed in mozvoikko 1.0-5

Date: Wed, 23 Jun 2010 16:22:44 +0000

Source: mozvoikko
Source-Version: 1.0-5

We believe that the bug you reported is fixed in the latest version of
mozvoikko, which is due to be installed in the Debian FTP archive:

mozvoikko_1.0-5.debian.tar.gz
  to main/m/mozvoikko/mozvoikko_1.0-5.debian.tar.gz
mozvoikko_1.0-5.dsc
  to main/m/mozvoikko/mozvoikko_1.0-5.dsc
mozvoikko_1.0-5_i386.deb
  to main/m/mozvoikko/mozvoikko_1.0-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 577886@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Heikki Mäntysaari <heikki.mantysaari@linux.fi> (supplier of updated mozvoikko package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 20 Jun 2010 20:29:26 +0300
Source: mozvoikko
Binary: mozvoikko
Architecture: source i386
Version: 1.0-5
Distribution: unstable
Urgency: low
Maintainer: Heikki Mäntysaari <heikki.mantysaari@linux.fi>
Changed-By: Heikki Mäntysaari <heikki.mantysaari@linux.fi>
Description: 
 mozvoikko  - Finnish spell-checker extension for Iceweasel
Closes: 577886
Changes: 
 mozvoikko (1.0-5) unstable; urgency=low
 .
   * Add cflag -std=gnu++0x. Closes: #577886. Thanks to Harri Pitkänen.
   * Add $(misc:Depends} dependency.
   * Switch to dpkg-source 3.0 (quilt) format
Checksums-Sha1: 
 258f5f3ff6d8df6dfdfb92379cc6ae282c7c07e5 1056 mozvoikko_1.0-5.dsc
 5b46f5ca459a5e4cbe1630218ad6dc8ecdfc8bd1 3113 mozvoikko_1.0-5.debian.tar.gz
 379643414e24ce2667ae493504adb8efcece29cc 27404 mozvoikko_1.0-5_i386.deb
Checksums-Sha256: 
 d18a9819c057d57b49f51c0d003b2d10ca00178411f41220908034e699154dba 1056 mozvoikko_1.0-5.dsc
 5717fe1378e72ae3a26ab1b70dfb570ebf55d70a37e599fd95ddfe475f4aa352 3113 mozvoikko_1.0-5.debian.tar.gz
 5a54e27f64b7ddccd80ff7d429f88381c9b5ac40f74f47485f9b91e4b8e00c45 27404 mozvoikko_1.0-5_i386.deb
Files: 
 167e281b907ed6df2caf4396ce72871c 1056 web optional mozvoikko_1.0-5.dsc
 3ad29d7bea3bc74c14efad597cb6af3b 3113 web optional mozvoikko_1.0-5.debian.tar.gz
 7fb22b0b2e1047a45c15862f349e49ca 27404 web optional mozvoikko_1.0-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkwiD9wACgkQgtffbfx/bQ+t9wCgrlaB9UAXBwKrdpGCPnKQVacc
8U8AoKZbTacl/voOjcaxqoS7ghKU6xJm
=EdUx
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.