Debian Bug report logs - #573551
Debian's service provider should use update-rc.d enable/disable

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: martin f krafft <madduck@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Debian's service provider should use update-rc.d enable/disable

Date: Fri, 12 Mar 2010 10:42:59 +0100

[Message part 1 (text/plain, inline)]

Package: puppet-common
Version: 0.25.4-2
Severity: normal
File: /usr/lib/ruby/1.8/puppet/provider/service/debian.rb
Tags: patch upstream

With dependency-based booting (insserv), update-rc.d
start/stop/defaults don't work anymore (#XXXXXX). However, there are
neew commands disable/enable, which are exactly what you want in the
puppet case. Attached is the (tested) patch.

Thanks,

-- System Information:
Debian Release: squeeze/sid
Architecture: i386 (i686)

Kernel: Linux 2.6.33-2-686 (SMP w/1 CPU core)
Locale: LANG=en_GB, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages puppet-common depends on:
ii  adduser                      3.112       add and remove users and groups
ii  libopenssl-ruby              4.2         OpenSSL interface for Ruby
ii  libruby [libxmlrpc-ruby]     4.2         Libraries necessary to run Ruby 1.
ii  libshadow-ruby1.8            1.4.1-8     Interface of shadow password for R
ii  ruby1.8                      1.8.7.249-1 Interpreter of object-oriented scr

puppet-common recommends no packages.

puppet-common suggests no packages.

-- no debconf information


-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems

[puppet-service-debian.patch (text/x-diff, attachment)]

[digital_signature_gpg.asc (application/pgp-signature, inline)]

Message #10 received at 573551@bugs.debian.org (full text, mbox, reply):

From: martin f krafft <madduck@debian.org>

To: 573551@bugs.debian.org

Subject: Re: Bug#573551: Debian's service provider should use update-rc.d enable/disable

Date: Fri, 12 Mar 2010 12:21:44 +0100

[Message part 1 (text/plain, inline)]

also sprach martin f krafft <madduck@debian.org> [2010.03.12.1042 +0100]:
> With dependency-based booting (insserv), update-rc.d
> start/stop/defaults don't work anymore (#XXXXXX). However, there are

#573550 that is.

-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems

[digital_signature_gpg.asc (application/pgp-signature, inline)]

Message #19 received at 573551-close@bugs.debian.org (full text, mbox, reply):

From: Stig Sandbeck Mathisen <ssm@debian.org>

To: 573551-close@bugs.debian.org

Subject: Bug#573551: fixed in puppet 2.6.4-1

Date: Wed, 02 Feb 2011 16:02:15 +0000

Source: puppet
Source-Version: 2.6.4-1

We believe that the bug you reported is fixed in the latest version of
puppet, which is due to be installed in the Debian FTP archive:

puppet-common_2.6.4-1_all.deb
  to main/p/puppet/puppet-common_2.6.4-1_all.deb
puppet-el_2.6.4-1_all.deb
  to main/p/puppet/puppet-el_2.6.4-1_all.deb
puppet-testsuite_2.6.4-1_all.deb
  to main/p/puppet/puppet-testsuite_2.6.4-1_all.deb
puppet_2.6.4-1.debian.tar.gz
  to main/p/puppet/puppet_2.6.4-1.debian.tar.gz
puppet_2.6.4-1.dsc
  to main/p/puppet/puppet_2.6.4-1.dsc
puppet_2.6.4-1_all.deb
  to main/p/puppet/puppet_2.6.4-1_all.deb
puppet_2.6.4.orig.tar.gz
  to main/p/puppet/puppet_2.6.4.orig.tar.gz
puppetmaster-common_2.6.4-1_all.deb
  to main/p/puppet/puppetmaster-common_2.6.4-1_all.deb
puppetmaster-passenger_2.6.4-1_all.deb
  to main/p/puppet/puppetmaster-passenger_2.6.4-1_all.deb
puppetmaster_2.6.4-1_all.deb
  to main/p/puppet/puppetmaster_2.6.4-1_all.deb
vim-puppet_2.6.4-1_all.deb
  to main/p/puppet/vim-puppet_2.6.4-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 573551@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stig Sandbeck Mathisen <ssm@debian.org> (supplier of updated puppet package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 26 Jan 2011 16:10:56 +0100
Source: puppet
Binary: puppet-common puppet puppetmaster-common puppetmaster puppetmaster-passenger vim-puppet puppet-el puppet-testsuite
Architecture: source all
Version: 2.6.4-1
Distribution: experimental
Urgency: low
Maintainer: Stig Sandbeck Mathisen <ssm@debian.org>
Changed-By: Stig Sandbeck Mathisen <ssm@debian.org>
Description: 
 puppet     - Centralized configuration management - agent startup and compatib
 puppet-common - Centralized configuration management
 puppet-el  - syntax highlighting for puppet manifests in emacs
 puppet-testsuite - Centralized configuration management - test suite
 puppetmaster - Centralized configuration management - master startup and compati
 puppetmaster-common - Puppet master common scripts
 puppetmaster-passenger - Centralised configuration management - master setup to run under
 vim-puppet - syntax highlighting for puppet manifests in vim
Closes: 573551 602336 602698 605510 605512
Changes: 
 puppet (2.6.4-1) experimental; urgency=low
 .
   [ Micah Anderson ]
   * Make puppetqd honor flags from /etc/default/puppetqd (Closes: #605510)
   * Remove the puppetqd PID file on stop (Closes: #605512)
   * Add ext/puppetstoredconfigclean to puppetmaster:/usr/sbin
   * Patch ext/logcheck/puppet to handle new puppet-master
     Compiled log lines (Closes: #602336)
   * Fix puppetqd initscript PID location
   * Fix /etc/default/puppetmaster comments to match new section headings
   * Fix puppetmaster/README.Debian to match new section headings
   * Fix Should-Start init header in puppet initscript
 .
   [ Mathias Gug ]
   * New upstream version.
 .
   [ Stig Sandbeck Mathisen ]
   * debian/puppetmaster.logrotate: send SIGUSR2 on log rotation (Closes:
     #602698)
   * puppet-common: Add versioned dependency on sysv-rc
 .
   [ martin f krafft ]
   * Use update-rc.d enable/disable in the "debian" provider in the
     "service" type (Closes: #573551)
Checksums-Sha1: 
 058aa4426d6bf0b9a80a0a4f6faf3af129e67d5c 1541 puppet_2.6.4-1.dsc
 a1c5d315060e88cdd130f5150ca3528c643f223b 1543727 puppet_2.6.4.orig.tar.gz
 0b53c4b2c418d52fde37a20e942958980331bc4f 32530 puppet_2.6.4-1.debian.tar.gz
 2e6578891238c4b63c4b11ccbe9eab3332ea8c7f 752256 puppet-common_2.6.4-1_all.deb
 d37b544a6744b19d67fe9f0b8aee034fc7680c97 210652 puppet_2.6.4-1_all.deb
 d165c63d64bc1ae5b9746bfad2eeae594523b514 209462 puppetmaster-common_2.6.4-1_all.deb
 8991384eb4937c2db27586d1de874c909c1cde29 205538 puppetmaster_2.6.4-1_all.deb
 051102dea84b0584f998a0b857e4debf07643d0f 203502 puppetmaster-passenger_2.6.4-1_all.deb
 34f62ab733c1ffd49c969b1de16427d0991c0fc7 202284 vim-puppet_2.6.4-1_all.deb
 848562bc5699f6a1499d96a262654b3046422ac2 204160 puppet-el_2.6.4-1_all.deb
 ee2a1124ca836d0befa27e25b9c1ca48e28cbd57 888746 puppet-testsuite_2.6.4-1_all.deb
Checksums-Sha256: 
 ab9f683064a9973139bb91e5bdc1af08869f5959f9eb734dba5b6c6ba7cc03db 1541 puppet_2.6.4-1.dsc
 74ff51039736297dd89a4dd2ec7075ea2dc0b284fa30f83e62a81d0a309a2e2f 1543727 puppet_2.6.4.orig.tar.gz
 a4b1165a3a205893ca5fcf7f10ca2ceac8516b16efb11fb6473e0cdc9e5df796 32530 puppet_2.6.4-1.debian.tar.gz
 cfc1e9680db2f629ee870c401e00fccd51cfe5716e55733e4048b70a229819a8 752256 puppet-common_2.6.4-1_all.deb
 1a84209996bcb9deab87a248683cce6a861d0d06b788a4ec7217e9f2150cc349 210652 puppet_2.6.4-1_all.deb
 b53e5378a2f450fb99039c3ed0bd8678773b294c91c03e18971e37fcd0fea78b 209462 puppetmaster-common_2.6.4-1_all.deb
 fe0a209d9ea504f4c2a7846f54fd75a89e19c402edfaa0eed0789a7ee2c0d095 205538 puppetmaster_2.6.4-1_all.deb
 fe63a949bea4b816289acd1d1c7b0760321cc8345a6493d856200d79158ad448 203502 puppetmaster-passenger_2.6.4-1_all.deb
 d2d62370ce944cd16462549adf0c5e61b5f54e17b7a6c4bc8e6f566595ef4736 202284 vim-puppet_2.6.4-1_all.deb
 ab8851f51a4f03ecd23ceaf3a6d285dcb2f11323dc875c1326b844d24dd4169d 204160 puppet-el_2.6.4-1_all.deb
 d7b09af87e361271a94cb9fb55e61b76ce26c0fbb3727770dea358382925784e 888746 puppet-testsuite_2.6.4-1_all.deb
Files: 
 fecd381d438f5dde321c5b455b795c23 1541 admin optional puppet_2.6.4-1.dsc
 a673965b860a62084a8995f776a1c3ba 1543727 admin optional puppet_2.6.4.orig.tar.gz
 0b8a3f6ee5ce1c65aa7b85cbdbeb729a 32530 admin optional puppet_2.6.4-1.debian.tar.gz
 a3ebf50b5f734cd1717366889bd1130c 752256 admin optional puppet-common_2.6.4-1_all.deb
 2ca6828422de1b04d0fbd2f32da8c83d 210652 admin optional puppet_2.6.4-1_all.deb
 0730b212cbfb9826efd7ec5d5c312d74 209462 admin optional puppetmaster-common_2.6.4-1_all.deb
 a22204e410e893a471fd3b1d50bb4c7e 205538 admin optional puppetmaster_2.6.4-1_all.deb
 4ce990f48ce6bf608d58e0874c5f0333 203502 admin optional puppetmaster-passenger_2.6.4-1_all.deb
 f461152ee3a12770f1d7e5031996e419 202284 admin optional vim-puppet_2.6.4-1_all.deb
 a76ee24eb8215b30e42f03cd80df3a7f 204160 admin optional puppet-el_2.6.4-1_all.deb
 db39eae2ea7ec6ca541292dcbbd49544 888746 admin optional puppet-testsuite_2.6.4-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1JfX4ACgkQQONU2fom4u7TdACfdlgOHej4jLmPZAIG1e6Fg56f
mRQAn3EG0+qCCEtxH4KEh1CLbDJ5ZoWw
=Vom6
-----END PGP SIGNATURE-----

Message #24 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Tim Connors <twc@aao.gov.au>

To: 573551@bugs.debian.org

Cc: 573550@bugs.debian.org, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>, control@bugs.debian.org

Subject: affects squeeze, package has only been updated in testing

Date: Mon, 21 Feb 2011 14:29:30 +1100 (EST)

reopen 573551
thanks

The fix in 2.6.4-1 in testing is all well and good, but the bug applies to
stable.  Stable has the removed "update-rc.d stop" feature, and so in
stable, I can't actually convince puppet to ensure the service is stopped.

Ideally, update-rc.d wouldn't have completely removed a feature (failing
silently) that hadn't even been flagged as deprecated (as far as I'm
aware) in oldstable, without providing any forwards or backwards
compatibility (in oldstable, you can't run 'update-rc.d disable' because
that doesn't exist, and in stable, you can't run 'update-rc.d stop'
because it silently fails to do anything useful.  Who thought that would
be a good idea?

-- 
Tim Connors                      |  ✉ Australian Astronomical Observatory
  ➥ http://site.aao.gov.au/twc   |    Coonabarabran, NSW 2357, Australia
 ❨✸ Telescope Operator/Sysadmin  |  ☎ +61 2 6842 6286

Message #31 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Faidon Liambotis <paravoid@debian.org>

To: 573551@bugs.debian.org

Cc: Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: affects squeeze, package has only been updated in testing

Date: Wed, 2 Mar 2011 15:38:10 +0200

On Mon, Feb 21, 2011 at 02:29:30PM +1100, Tim Connors wrote:
> The fix in 2.6.4-1 in testing is all well and good, but the bug applies to
> stable.  Stable has the removed "update-rc.d stop" feature, and so in
> stable, I can't actually convince puppet to ensure the service is stopped.

I also got bitten by this.

Apparently this case is summarized to this:
  * changes in update-rc.d to accommodate for dependency-based booting
    broke puppet's functionality to enable/disable services, i.e. rules
    like:
        service {"postgresql": enable => false }
  * this was reported in this bug and fixed with puppet 2.6.4-1
  * squeeze includes the new update-rc.d but has puppet 2.6.2-4
  * => a default squeeze installation does not work wrt this feature
    (a regression from lenny)

The patch is trivial (2 lines). It'd be nice if it could be applied to
2.6.2-4 and incorporated into a stable point release.

I already contacted Martin on IRC and he said he's too busy to work on
it.

Can someone from the rest of puppet maintainers have a look? It should
be really easy.

Regards,
Faidon

Message #36 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Faidon Liambotis <paravoid@debian.org>, 573551@bugs.debian.org, 573551@bugs.debian.org

Cc: Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Wed, 02 Mar 2011 11:28:46 -0500

[Message part 1 (text/plain, inline)]

On Wed, 2 Mar 2011 15:38:10 +0200, Faidon Liambotis <paravoid@debian.org> wrote:
> On Mon, Feb 21, 2011 at 02:29:30PM +1100, Tim Connors wrote:
> > The fix in 2.6.4-1 in testing is all well and good, but the bug applies to
> > stable.  Stable has the removed "update-rc.d stop" feature, and so in
> > stable, I can't actually convince puppet to ensure the service is stopped.
> 
> I also got bitten by this.

Yesterday, I spent a couple hours because of this. I could have sworn we
fixed it in the package, but you are right, it was only fixed in
2.6.4-1, and not the version that is in stable.

> The patch is trivial (2 lines). It'd be nice if it could be applied to
> 2.6.2-4 and incorporated into a stable point release.

I agree, I also would like to see this. I'm not aware of how point
releases work for this round, but I'm happy to help make that
happen. 

Additionally, I think that we can push 2.6.4-1 into backports now.

Micah

[Message part 2 (application/pgp-signature, inline)]

Message #41 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: 573551@bugs.debian.org, Faidon Liambotis <paravoid@debian.org>, 573551@bugs.debian.org, 573551@bugs.debian.org

Cc: Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Thu, 03 Mar 2011 12:31:07 -0500

[Message part 1 (text/plain, inline)]

On Wed, 02 Mar 2011 11:28:46 -0500, micah anderson <micah@riseup.net> wrote:
> Additionally, I think that we can push 2.6.4-1 into backports now.

I uploaded a backport of 2.6.4-1 yesterday, pending NEW approval from
backports.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #46 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Faidon Liambotis <paravoid@debian.org>

To: micah anderson <micah@riseup.net>

Cc: 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Sat, 5 Mar 2011 01:40:15 +0200

On Thu, Mar 03, 2011 at 12:31:07PM -0500, micah anderson wrote:
> On Wed, 02 Mar 2011 11:28:46 -0500, micah anderson <micah@riseup.net> wrote:
> > Additionally, I think that we can push 2.6.4-1 into backports now.
> 
> I uploaded a backport of 2.6.4-1 yesterday, pending NEW approval from
> backports.

Thanks. Although personally I'd prefer sticking to just squeeze 'till a
major upgrade.

What can we do to have this backported in squeeze as well? Can I do
anything to help? I can NMU but I maybe you prefer handling this as a
maintainer upload, no?

Best regards,
Faidon

Message #51 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Faidon Liambotis <paravoid@debian.org>

Cc: 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Fri, 04 Mar 2011 19:19:03 -0500

[Message part 1 (text/plain, inline)]

On Sat, 5 Mar 2011 01:40:15 +0200, Faidon Liambotis <paravoid@debian.org> wrote:
> On Thu, Mar 03, 2011 at 12:31:07PM -0500, micah anderson wrote:
> > On Wed, 02 Mar 2011 11:28:46 -0500, micah anderson <micah@riseup.net> wrote:
> > > Additionally, I think that we can push 2.6.4-1 into backports now.
> > 
> > I uploaded a backport of 2.6.4-1 yesterday, pending NEW approval from
> > backports.
> 
> Thanks. Although personally I'd prefer sticking to just squeeze 'till a
> major upgrade.
> 
> What can we do to have this backported in squeeze as well? Can I do
> anything to help? I can NMU but I maybe you prefer handling this as a
> maintainer upload, no?

I'm just waiting for confirmation from the rest of the team that there
are no other issues to put into a stable point release. Once I have
that, I'll upload.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #56 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Faidon Liambotis <paravoid@debian.org>

Cc: 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Thu, 10 Mar 2011 16:53:57 -0500

[Message part 1 (text/plain, inline)]

On Sat, 5 Mar 2011 01:40:15 +0200, Faidon Liambotis <paravoid@debian.org> wrote:
> On Thu, Mar 03, 2011 at 12:31:07PM -0500, micah anderson wrote:
> > On Wed, 02 Mar 2011 11:28:46 -0500, micah anderson <micah@riseup.net> wrote:
> What can we do to have this backported in squeeze as well? Can I do
> anything to help? I can NMU but I maybe you prefer handling this as a
> maintainer upload, no?

I sent the request to debian-release to have this put in as a stable
point release update, but I'm afraid that I am now unsure that it is a
proper fix. One way to help would be to help me sort this out.

The enable portion of the diff looks like this:

@@ -43,6 +43,6 @@ Puppet::Type.type(:service).provide :debian, :parent => :init do

   def enable
     update_rc "-f", @resource[:name], "remove"
-    update_rc @resource[:name], "defaults"
+    update_rc @resource[:name], "enable"
   end
 end

This seems to throw errors if no symlinks exist for the service. Perhaps
this is fine if all that is ever being done is to re-enable a previously
disabled service, is that true?

However, it is called right after an 'update-rc.d remove' which seems
like it would break, for example:

First we make sure that a service is properly enabled:
# invoke-rc.d --query ssh start
# echo $?
104
(according to invoke-rc.d 104 means that its properly enabled)

so lets disable it using the mechanism that puppet would use with this
patch to disable it, and then once its disabled, we will enable it again
and see the problem:

# update-rc.d -f ssh remove
update-rc.d: using dependency based boot sequencing
# echo $?
0
# update-rc.d ssh disable
update-rc.d: using dependency based boot sequencing
update-rc.d: error: no runlevel symlinks to modify, aborting!
# echo $?
1
# invoke-rc.d --query ssh start
105

(note 105 is behavior uncertain)

So that would be the state it is in when we do an enable, now lets do
the enable that puppet would do:

# update-rc.d -f ssh remove
update-rc.d: using dependency based boot sequencing
# echo $?
0
# update-rc.d ssh enable
update-rc.d: using dependency based boot sequencing
update-rc.d: error: no runlevel symlinks to modify, aborting!
# echo $?
1
# invoke-rc.d --query ssh start
# echo $?
105

And again, we are in an unknown state. 

So... I'm a little puzzled about what the right way to do this is. Is
using insserv directly the right way to do this? Can we count on insserv
being available on all squeeze systems, and dependency-based initscripts
enabled? What if they are not?

This would also make backporting to lenny a problem because "update-rc.d
foo {en,dis}able' would not work right, but this is less of a concern.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #61 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Faidon Liambotis <paravoid@debian.org>

To: micah anderson <micah@riseup.net>

Cc: 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Mon, 21 Mar 2011 17:02:41 +0200

Hi micah,

Sorry for the very late reply.

On Thu, Mar 10, 2011 at 04:53:57PM -0500, micah anderson wrote:
> # update-rc.d -f ssh remove
> update-rc.d: using dependency based boot sequencing
> # echo $?
> 0
> # update-rc.d ssh disable
> update-rc.d: using dependency based boot sequencing
> update-rc.d: error: no runlevel symlinks to modify, aborting!
> # echo $?
> 1
> # invoke-rc.d --query ssh start
> 105
> 
> (note 105 is behavior uncertain)

Indeed, you are absolutely right, I confirm the above.

With my very limited, only on dependency-based booting-enabled, systems,
it seems that
    update-rc.d $foo enable
counteracts
    update-rc.d $foo disable
properly, as long as you don't call "remove" at any point.

So, removing the
    update_rc "-f", @resource[:name], "remove"
line before "enable" should be fine.

However, I'm not sure how that would interact with systems upgraded from
lenny. I'll check that and get back to you, hopefully soon.

> So... I'm a little puzzled about what the right way to do this is. Is
> using insserv directly the right way to do this? Can we count on insserv
> being available on all squeeze systems, and dependency-based initscripts
> enabled? What if they are not?

I'm not sure about that. Doesn't seem right in any way.

FWIW, there's a related discussion at debian-devel these days, see
<20110304113539.GA10734@upsilon.cc>.

> This would also make backporting to lenny a problem because "update-rc.d
> foo {en,dis}able' would not work right, but this is less of a concern.

I guess you can document that and change that back, for the limited time
that lenny would still live.

Regards,
Faidon

Message #66 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Faidon Liambotis <paravoid@debian.org>

Cc: 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>, martin f krafft <madduck@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Mon, 21 Mar 2011 19:47:07 -0400

[Message part 1 (text/plain, inline)]

On Mon, 21 Mar 2011 17:02:41 +0200, Faidon Liambotis <paravoid@debian.org> wrote:
> Sorry for the very late reply.

No problem. It looks like we missed this stable point release, but we
can get the next one!

> On Thu, Mar 10, 2011 at 04:53:57PM -0500, micah anderson wrote:
...
> > (note 105 is behavior uncertain)
> 
> Indeed, you are absolutely right, I confirm the above.

Ok, good, I'm glad I'm not insane... or am I?

> With my very limited, only on dependency-based booting-enabled, systems,
> it seems that
>     update-rc.d $foo enable
> counteracts
>     update-rc.d $foo disable
> properly, as long as you don't call "remove" at any point.
> 
> So, removing the
>     update_rc "-f", @resource[:name], "remove"
> line before "enable" should be fine.

This does seem like it might work, although I'm concerned about the
corner cases, and:

> However, I'm not sure how that would interact with systems upgraded from
> lenny. I'll check that and get back to you, hopefully soon.

this as well. Please do get back as soon as you test this.

> FWIW, there's a related discussion at debian-devel these days, see
> <20110304113539.GA10734@upsilon.cc>.

Thanks, I'll have a read.

> > This would also make backporting to lenny a problem because "update-rc.d
> > foo {en,dis}able' would not work right, but this is less of a concern.
> 
> I guess you can document that and change that back, for the limited time
> that lenny would still live.

True, thats not difficult.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #71 received at 573551@bugs.debian.org (full text, mbox, reply):

From: martin f krafft <madduck@debian.org>

To: micah anderson <micah@riseup.net>

Cc: Faidon Liambotis <paravoid@debian.org>, 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Tue, 22 Mar 2011 07:39:40 +0100

[Message part 1 (text/plain, inline)]

also sprach micah anderson <micah@riseup.net> [2011.03.22.0047 +0100]:
> > So, removing the
> >     update_rc "-f", @resource[:name], "remove"
> > line before "enable" should be fine.
> 
> This does seem like it might work, although I'm concerned about the
> corner cases, and:
> 
> > However, I'm not sure how that would interact with systems upgraded from
> > lenny. I'll check that and get back to you, hopefully soon.
> 
> this as well. Please do get back as soon as you test this.

For the case that the links were previously removed, why not call
update-rc.d with 'defaults' before enable. This will not do anything
if the links exist, but it will install default links if they do not
exist.

-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
 
"gott ist tot! und wir haben ihn getötet."
                                                 - friedrich nietzsche

[digital_signature_gpg.asc (application/pgp-signature, inline)]

Message #76 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: martin f krafft <madduck@debian.org>

Cc: Faidon Liambotis <paravoid@debian.org>, 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Wed, 23 Mar 2011 21:26:41 -0400

[Message part 1 (text/plain, inline)]

On Tue, 22 Mar 2011 07:39:40 +0100, martin f krafft <madduck@debian.org> wrote:
> also sprach micah anderson <micah@riseup.net> [2011.03.22.0047 +0100]:
> > > So, removing the
> > >     update_rc "-f", @resource[:name], "remove"
> > > line before "enable" should be fine.
> > 
> > This does seem like it might work, although I'm concerned about the
> > corner cases, and:
> > 
> > > However, I'm not sure how that would interact with systems upgraded from
> > > lenny. I'll check that and get back to you, hopefully soon.
> > 
> > this as well. Please do get back as soon as you test this.
> 
> For the case that the links were previously removed, why not call
> update-rc.d with 'defaults' before enable. This will not do anything
> if the links exist, but it will install default links if they do not
> exist.

The proposed fix is similar to what you and Faidon have suggested, along
with some tests. Unless someone screams really soon, this is going to be
the upstream change, so take a second and have a look:

https://github.com/MaxMartin/puppet/commit/be5c00cc9687e73dad15455f8429f0c2ab5667e5

micah

[Message part 2 (application/pgp-signature, inline)]

Message #81 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Faidon Liambotis <paravoid@debian.org>

To: micah anderson <micah@riseup.net>

Cc: martin f krafft <madduck@debian.org>, 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Thu, 24 Mar 2011 03:36:47 +0200

On Wed, Mar 23, 2011 at 09:26:41PM -0400, micah anderson wrote:
> The proposed fix is similar to what you and Faidon have suggested, along
> with some tests. Unless someone screams really soon, this is going to be
> the upstream change, so take a second and have a look:
> 
> https://github.com/MaxMartin/puppet/commit/be5c00cc9687e73dad15455f8429f0c2ab5667e5

That patch seems to only fix "disable", no?

Regards,
Faidon

Message #86 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Faidon Liambotis <paravoid@debian.org>

Cc: martin f krafft <madduck@debian.org>, 573551@bugs.debian.org, Tim Connors <twc@aao.gov.au>, Stig Sandbeck Mathisen <ssm@debian.org>

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Thu, 24 Mar 2011 19:15:45 -0400

[Message part 1 (text/plain, inline)]

On Thu, 24 Mar 2011 03:36:47 +0200, Faidon Liambotis <paravoid@debian.org> wrote:
> On Wed, Mar 23, 2011 at 09:26:41PM -0400, micah anderson wrote:
> > The proposed fix is similar to what you and Faidon have suggested, along
> > with some tests. Unless someone screams really soon, this is going to be
> > the upstream change, so take a second and have a look:
> > 
> > https://github.com/MaxMartin/puppet/commit/be5c00cc9687e73dad15455f8429f0c2ab5667e5
> 
> That patch seems to only fix "disable", no?

Yes, that is correct. The enable case was not changed, because the way
that puppet is enabling a service with the new update-rc.d seems to work
fine. It seems like its only the disable case that is no longer
working. 

Is that wrong, it could be! So if you know otherwise, please do tell me
how.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #91 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Robert Terhaar <rterhaar@atlanticdynamic.com>

To: 573551@bugs.debian.org

Subject: Re: Bug#573551: affects squeeze, package has only been updated in testing

Date: Sun, 10 Apr 2011 18:33:59 -0400

I seem to be hitting this bug with the latest Puppet package (2.6.6-1~bpo60+1) from backports in squeeze.

service{'puppet': enable => false} throws:

err: /Stage[main]/Puppet/Service[puppet]/enable: change from true to false failed: Execution of '/usr/sbin/update-rc.d puppet disable' returned 1: update-rc.d: error: no runlevel symlinks to modify, aborting!

and 

/usr/sbin/update-rc.d puppet disable
update-rc.d: using dependency based boot sequencing
update-rc.d: error: no runlevel symlinks to modify, aborting!

Message #96 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Robert Terhaar <rterhaar@atlanticdynamic.com>

To: 573551@bugs.debian.org

Date: Sun, 10 Apr 2011 18:41:25 -0400

Quick update, 

I found that I hit this bug only when I force the service provider type to "debian" via resource override. 

e.g., 
When I have this set, I hit the bug: 

Service { provider => "debian" }

Message #101 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Nicolas Bourbaki <ncl.bourbaki@gmail.com>

To: 573551@bugs.debian.org

Subject: Debian's service provider should use update-rc.d enable/disable

Date: Fri, 27 May 2011 14:27:58 +0200

Hi there,

We are using puppet to configure Ubuntu clients and with the upstream
fix services are no longer managed (symlinks are not created)

I can confirm that using update-rc.d with 'defaults' instead of
'enable' by changing it in 'provider/service/debian.rb' fix the issue
and services are managed (symlinks created).

This is a critical bug for us as we can no longer ensure that services
are run at the client startup.

Regards,

Nicolas.

Message #106 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Stig Sandbeck Mathisen <ssm@debian.org>

To: 573551@bugs.debian.org, 573551-submitter@bugs.debian.org

Subject: Re: [Pkg-puppet-devel] Bug#573551: Debian's service provider should use update-rc.d enable/disable

Date: Fri, 27 May 2011 16:04:40 +0200

Nicolas Bourbaki <ncl.bourbaki@gmail.com> writes:

> We are using puppet to configure Ubuntu clients and with the upstream
> fix services are no longer managed (symlinks are not created)
>
> I can confirm that using update-rc.d with 'defaults' instead of
> 'enable' by changing it in 'provider/service/debian.rb' fix the issue
> and services are managed (symlinks created).
>
> This is a critical bug for us as we can no longer ensure that services
> are run at the client startup.

If you could provide puppet and ubuntu versions, it would help. Any
other direct pointers to the information you refers to would also be
nice.

Thanks,
-- 
Stig Sandbeck Mathisen <ssm@debian.org>

Message #114 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Nicolas Bourbaki <ncl.bourbaki@gmail.com>

To: 573551@bugs.debian.org

Subject: Re: Debian's service provider should use update-rc.d enable/disable

Date: Tue, 31 May 2011 11:26:15 +0200

Hi,

The issue occurs on Ubuntu Natty 11.04. Puppet version is :
 puppet 2.6.4-2ubuntu2

Regarding steps to reproduce, for instance manage ssh service:
purge it on the client (to be sure):
  update-rc.d -f ssh remove
then restart puppet (I have a class that manage the ssh service)
1st pass:
notice: /Stage[main]/Intranet::Services/Service[ssh]/enable: enable
changed 'false' to 'true'
-> it does not create any symlinks in /etc/rcX.d/SXXssh

Nth pass:
notice: /Stage[main]/Intranet::Services/Service[ssh]/enable: enable
changed 'false' to 'true'
-> still no symlinks and the message is repeated

If I modify provider/service/debian.rb and switch the update-rc.d
argument back to "defaults"
1st pass:
notice: /Stage[main]/Intranet::Services/Service[ssh]/enable: enable
changed 'false' to 'true'
-> Symlinks are created and the service is launched at the machine startup.

Regards,

Nicolas.

2011/5/27 Nicolas Bourbaki <ncl.bourbaki@gmail.com>:
> Hi there,
>
> We are using puppet to configure Ubuntu clients and with the upstream
> fix services are no longer managed (symlinks are not created)
>
> I can confirm that using update-rc.d with 'defaults' instead of
> 'enable' by changing it in 'provider/service/debian.rb' fix the issue
> and services are managed (symlinks created).
>
> This is a critical bug for us as we can no longer ensure that services
> are run at the client startup.
>
> Regards,
>
> Nicolas.
>

Message #119 received at 573551@bugs.debian.org (full text, mbox, reply):

From: micah anderson <micah@riseup.net>

To: Nicolas Bourbaki <ncl.bourbaki@gmail.com>, 573551@bugs.debian.org, 573551@bugs.debian.org

Subject: Re: [Pkg-puppet-devel] Bug#573551: Debian's service provider should use update-rc.d enable/disable

Date: Tue, 31 May 2011 10:51:55 -0400

[Message part 1 (text/plain, inline)]

On Tue, 31 May 2011 11:26:15 +0200, Nicolas Bourbaki <ncl.bourbaki@gmail.com> wrote:
> Hi,
> 
> The issue occurs on Ubuntu Natty 11.04. Puppet version is :
>  puppet 2.6.4-2ubuntu2

This issue hasn't been resolved until 2.6.7.

micah

[Message part 2 (application/pgp-signature, inline)]

Message #124 received at 573551@bugs.debian.org (full text, mbox, reply):

From: Nicolas Bourbaki <ncl.bourbaki@gmail.com>

To: micah anderson <micah@riseup.net>

Cc: 573551@bugs.debian.org

Subject: Re: [Pkg-puppet-devel] Bug#573551: Debian's service provider should use update-rc.d enable/disable

Date: Wed, 1 Jun 2011 15:04:23 +0200

Hi,

Then I'll use puppet to distribute a corrected provider to fit my need.
Cheers for the info.

Nicolas.

2011/5/31 micah anderson <micah@riseup.net>:
> On Tue, 31 May 2011 11:26:15 +0200, Nicolas Bourbaki <ncl.bourbaki@gmail.com> wrote:
>> Hi,
>>
>> The issue occurs on Ubuntu Natty 11.04. Puppet version is :
>>  puppet 2.6.4-2ubuntu2
>
> This issue hasn't been resolved until 2.6.7.
>
> micah
>

Message #129 received at 573551-submitter@bugs.debian.org (full text, mbox, reply):

From: Micah Anderson <micah@debian.org>

To: control@bugs.debian.org

Cc: 573551-submitter@bugs.debian.org

Subject: closing 573551

Date: Thu, 09 Jun 2011 13:13:30 -0400

close 573551 2.6.8-1
thanks
-- 

Message #134 received at 573551-submitter@bugs.debian.org (full text, mbox, reply):

From: Micah Anderson <micah@debian.org>

To: control@bugs.debian.org

Cc: 573551-submitter@bugs.debian.org

Subject: closing 573551

Date: Thu, 09 Jun 2011 13:13:46 -0400

close 573551 2.6.8-1
thanks

I previously said:

>This issue hasn't been resolved until 2.6.7.

but the reality is that it wasn't actually resolved until 2.6.8 (which
is available in sid, wheezy and stable-backports).

micah
-- 

Message #139 received at 573551-close@bugs.debian.org (full text, mbox, reply):

From: Micah Anderson <micah@debian.org>

To: 573551-close@bugs.debian.org

Subject: Bug#573551: fixed in puppet 2.6.2-5

Date: Sun, 12 Jun 2011 13:54:54 +0000

Source: puppet
Source-Version: 2.6.2-5

We believe that the bug you reported is fixed in the latest version of
puppet, which is due to be installed in the Debian FTP archive:

puppet-common_2.6.2-5_all.deb
  to main/p/puppet/puppet-common_2.6.2-5_all.deb
puppet-el_2.6.2-5_all.deb
  to main/p/puppet/puppet-el_2.6.2-5_all.deb
puppet-testsuite_2.6.2-5_all.deb
  to main/p/puppet/puppet-testsuite_2.6.2-5_all.deb
puppet_2.6.2-5.debian.tar.gz
  to main/p/puppet/puppet_2.6.2-5.debian.tar.gz
puppet_2.6.2-5.dsc
  to main/p/puppet/puppet_2.6.2-5.dsc
puppet_2.6.2-5_all.deb
  to main/p/puppet/puppet_2.6.2-5_all.deb
puppetmaster_2.6.2-5_all.deb
  to main/p/puppet/puppetmaster_2.6.2-5_all.deb
vim-puppet_2.6.2-5_all.deb
  to main/p/puppet/vim-puppet_2.6.2-5_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 573551@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Micah Anderson <micah@debian.org> (supplier of updated puppet package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 22 May 2011 15:49:13 -0400
Source: puppet
Binary: puppet puppetmaster puppet-common vim-puppet puppet-el puppet-testsuite
Architecture: source all
Version: 2.6.2-5
Distribution: stable
Urgency: low
Maintainer: Puppet Package Maintainers <pkg-puppet-devel@lists.alioth.debian.org>
Changed-By: Micah Anderson <micah@debian.org>
Description: 
 puppet     - Centralized configuration management - agent startup and compatib
 puppet-common - Centralized configuration management
 puppet-el  - syntax highlighting for puppet manifests in emacs
 puppet-testsuite - Centralized configuration management - test suite
 puppetmaster - Centralized configuration management - master startup and compati
 vim-puppet - syntax highlighting for puppet manifests in vim
Closes: 573551
Changes: 
 puppet (2.6.2-5) stable; urgency=low
 .
   [ Micah Anderson ]
   * Fix puppet service provider to properly use update-rc.d disable API,
     (Closes: #573551)
Checksums-Sha1: 
 1e765d9e40ebca40c99c7c1c606e1b1802572b4a 2136 puppet_2.6.2-5.dsc
 911f78134a9a0a622315b37cfc7b3585ea396813 33629 puppet_2.6.2-5.debian.tar.gz
 b9f6ae6474bf08fde6ded591e4de9f493f230bd1 209460 puppet_2.6.2-5_all.deb
 79c1c5235b8e9801a53afdc3d373a91102b45216 212346 puppetmaster_2.6.2-5_all.deb
 acee33ee136228cc2c85b025d3f0dd3349a6b9f2 747596 puppet-common_2.6.2-5_all.deb
 ab9c2280bcace77acbdb5154238ec61ca3aa4635 200052 vim-puppet_2.6.2-5_all.deb
 cfdbeac868d0fa6fc679755af96d6982e2c81271 202434 puppet-el_2.6.2-5_all.deb
 173181d4d1ea41defd50627a8754e0eeccf7601b 885244 puppet-testsuite_2.6.2-5_all.deb
Checksums-Sha256: 
 a79b5171f7a96fc8c9d7799ad01bb861a21908ae07bd50a3d9e09db7c156502a 2136 puppet_2.6.2-5.dsc
 1b26806446595ba6a33cd9818b4ffbb93f356733719b77adcd94327c5982f85b 33629 puppet_2.6.2-5.debian.tar.gz
 5ea7f120705f77c7aacd3c360aa0ca9a6e6ab22fe8fbc2847ff2b2b08ce29952 209460 puppet_2.6.2-5_all.deb
 7ec10079a50963f098809e304b7d9cd93d43d9f5ab716081da06a68169ad93ca 212346 puppetmaster_2.6.2-5_all.deb
 40b56bfe0e99d390137677ea6edeed34aa4f936f1815e90646e60c8773c960ca 747596 puppet-common_2.6.2-5_all.deb
 66e9d03cfbe8e5fa9667df13197e11e1eccb3b7cd32a0d1574aeadfaf06916b0 200052 vim-puppet_2.6.2-5_all.deb
 2c7bb1e57a82454ec062d8266abe4bb782fc1862d59f89b69203f63beaba33f4 202434 puppet-el_2.6.2-5_all.deb
 afbaf29b359e64bd03f83dc7a51b0ac7a56d9e92e95757bb4f4b11856adc051b 885244 puppet-testsuite_2.6.2-5_all.deb
Files: 
 185c51a3894f8d72aff4ba2d6c65c735 2136 admin optional puppet_2.6.2-5.dsc
 2ecba021c20cb43b9d756d730c544d86 33629 admin optional puppet_2.6.2-5.debian.tar.gz
 882cba86842e899ad636ea7d24b9df8b 209460 admin optional puppet_2.6.2-5_all.deb
 0540e8c4b9a54d82882a6f52ea19fed4 212346 admin optional puppetmaster_2.6.2-5_all.deb
 cb8ecd3d6f8291f4a56f4d9cdc9ff0b0 747596 admin optional puppet-common_2.6.2-5_all.deb
 e00073e60f439eaea88a28ab85e1f83c 200052 admin optional vim-puppet_2.6.2-5_all.deb
 be881549ef8ca7c20ed36d221279007d 202434 admin optional puppet-el_2.6.2-5_all.deb
 2dbf94b8d841cc2c73f4233654958fbf 885244 admin optional puppet-testsuite_2.6.2-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCgAGBQJN879jAAoJEIy/mjIoYaeQg24QAJL+STTOizvcMroDCekzO3PX
Urm7P85A0ITEoQdeFLowmqexxwrzOUsCHtRZvjHxxKV045E7H46EtfHpk6v6LLOB
TBaBUFhpli6JT7vkYriU8+jWtVRS8pJvb3wFi1XSVo/fdlT7O4JGdlpzFHWMeoDh
hyUxyHzpRXHp9Pyn1fhEP+wEZNdyCkrGvKd48aYzN73/YqCgTWjkSu0KU0nxkmuu
uTVmF6iokf9V/XTZMj6FBE2ccJwCTi47CaqnRajBwp3MyQQUKl6chv2amQeaXJOw
NGdcjUGdF4RxpQzyJ8S8dG1Gi150hlQxo6mPyMDGTX6VzCwR09gZ2iDy7utkZb+e
KnRWdjng8gBnOxu1urirCzEXabKCP5Vj0KgOmb6smN1vYxpZQA2L4ttfeubVSY7N
1+oOO1QlVsXyuk/+w5it0FUx2IbD240tJXk/J2cxsvDf5Em2v03RoSyIN76M092Y
ITKjW93n2F0M19TeBmnH0BrRQQ4NHMTKUJNEwU4Dc5eOH4w/VF9gbETD0+cDESaM
g6tb2qfnnK1ts7Igh73jZMa8o/h3DkHoVReOnlDooEyaOgS9KrjLQxnJbRhZTMPW
7mK3/GZueb7odroRp7eO0ZOlEP89nnTmcdrGme14sGAjuteLtHeT5Z7EI87NO/bC
SU/XlgYRszk1msKpwlwV
=w/j4
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.