Debian Bug report logs - #572261
slirpvde: Massive memory leak

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Irving-Beer <wisq-deb@wisq.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: slirpvde: Massive memory leak

Date: Tue, 2 Mar 2010 13:17:04 -0500

[Message part 1 (text/plain, inline)]

Package: vde2
Version: 2.2.3-3
Severity: important
Tags: patch

slirpvde leaks over 1600 bytes per packet received, even tiny ones
like pings.  This makes it practically unusable for a production
system in the current state.

I've attached a patch to fix the leak.

-- System Information:
Debian Release: 5.0.3
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages vde2 depends on:
ii  adduser                       3.110      add and remove users and groups
ii  libc6                         2.10.2-5   Embedded GNU C Library: Shared lib
ii  libpcap0.8                    1.0.0-6    system interface for user-level pa
ii  libvde0                       2.2.3-3    Virtual Distributed Ethernet - sup
ii  libvdeplug2                   2.2.2-3    Virtual Distributed Ethernet - Plu

vde2 recommends no packages.

Versions of packages vde2 suggests:
ii  qemu                       0.11.1-2      fast processor emulator
ii  qemu-kvm [kvm]             0.11.1+dfsg-1 Full virtualization on x86 hardwar
pn  vde2-cryptcab              <none>        (no description available)

-- no debconf information

[slirp.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 572261@bugs.debian.org (full text, mbox, reply):

From: Adrian Irving-Beer <wisq@wisq.net>

To: 572261@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#572261: Acknowledgement (slirpvde: Massive memory leak)

Date: Tue, 2 Mar 2010 13:38:58 -0500

[Message part 1 (text/plain, inline)]

tags 572261 - patch
thanks

Okay, turns out my patch was a bit naive -- it's been a while since I
did any serious C coding.

The patch is bad but the problem is real.  I can trigger it via pings,
via regular TCP traffic, etc.

I'll see if I can come up with another patch soon, since this is a
rather critical bug for me.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 572261@bugs.debian.org (full text, mbox, reply):

From: Adrian Irving-Beer <wisq-deb@wisq.net>

To: 572261@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#572261: New patch

Date: Tue, 2 Mar 2010 16:01:35 -0500

[Message part 1 (text/plain, inline)]

tags 572261 + patch
thanks

Okay, this one doesn't leak *or* crash, so I think it's at least
vaguely correct. :)

Valgrind was getting confused by the memory buffers and blaming
slirp_input(), since that's where the original malloc() (via m_get)
occurs.  (Is that buffering really necessary?  Last I heard, GNU libc
takes steps to prevent memory fragmentation by doing its own internal
overallocation and handing out pieces of that to malloc() calls.)

The real source of the leak were in places like tcp_output() and
others, which prepare buffers for if_output().  They get queued for
sending, and eventually dequeued, but never m_free()d.

I'm not sure if the VDE developers intended for the m_free() to go in
if_output() or if_encap(), but it's not in either, and that's the
actual source of the leak.

[slirp.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 572261-close@bugs.debian.org (full text, mbox, reply):

From: Filippo Giunchedi <filippo@debian.org>

To: 572261-close@bugs.debian.org

Subject: Bug#572261: fixed in vde2 2.3.1-1

Date: Wed, 03 Nov 2010 10:02:52 +0000

Source: vde2
Source-Version: 2.3.1-1

We believe that the bug you reported is fixed in the latest version of
vde2, which is due to be installed in the Debian FTP archive:

libvde-dev_2.3.1-1_amd64.deb
  to main/v/vde2/libvde-dev_2.3.1-1_amd64.deb
libvde0_2.3.1-1_amd64.deb
  to main/v/vde2/libvde0_2.3.1-1_amd64.deb
libvdeplug-dev_2.3.1-1_amd64.deb
  to main/v/vde2/libvdeplug-dev_2.3.1-1_amd64.deb
libvdeplug3_2.3.1-1_amd64.deb
  to main/v/vde2/libvdeplug3_2.3.1-1_amd64.deb
vde2-cryptcab_2.3.1-1_amd64.deb
  to main/v/vde2/vde2-cryptcab_2.3.1-1_amd64.deb
vde2_2.3.1-1.diff.gz
  to main/v/vde2/vde2_2.3.1-1.diff.gz
vde2_2.3.1-1.dsc
  to main/v/vde2/vde2_2.3.1-1.dsc
vde2_2.3.1-1_amd64.deb
  to main/v/vde2/vde2_2.3.1-1_amd64.deb
vde2_2.3.1.orig.tar.gz
  to main/v/vde2/vde2_2.3.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 572261@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Filippo Giunchedi <filippo@debian.org> (supplier of updated vde2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 05 Sep 2010 16:20:43 +0100
Source: vde2
Binary: vde2 vde2-cryptcab libvdeplug-dev libvdeplug3 libvde-dev libvde0
Architecture: source amd64
Version: 2.3.1-1
Distribution: experimental
Urgency: low
Maintainer: Debian VSquare Team <pkg-vsquare-devel@lists.alioth.debian.org>
Changed-By: Filippo Giunchedi <filippo@debian.org>
Description: 
 libvde-dev - Virtual Distributed Ethernet - support libraries development file
 libvde0    - Virtual Distributed Ethernet - support libraries
 libvdeplug-dev - Virtual Distributed Ethernet - Plug development files
 libvdeplug3 - Virtual Distributed Ethernet - Plug library
 vde2       - Virtual Distributed Ethernet
 vde2-cryptcab - Virtual Distributed Ethernet - CryptCab
Closes: 460734 568363 572261
Changes: 
 vde2 (2.3.1-1) experimental; urgency=low
 .
   * New upstream version
     - bump libvdeplug soname
     - ship updated version of slirp (Closes: #460734, #572261)
   * Remove debian/patches/dont_use_installpath, use ./configure --sysconfdir
     and --localstate dir instead
   * Drop soname from libvdeplug3-dev, easier for package build-depending on
     the library
   * Fix "Timing issue in /etc/network/if-pre-up.d/vde2" by calling vde_tunctl
     in ifupdown hooks (Closes: #568363)
   * Update standards-version to 3.9.1: stop shipping .la files
Checksums-Sha1: 
 6241c854a394c4c771f0d8654930cd33ed3345fc 1426 vde2_2.3.1-1.dsc
 63a8f33215a564cbc2ee52249aac00988d62874b 698059 vde2_2.3.1.orig.tar.gz
 43bec1e36f89f4280939e61aa12cc4f494e2eb1c 11134 vde2_2.3.1-1.diff.gz
 e24439366137571c8f9db6cde6dc474db278a9ea 220062 vde2_2.3.1-1_amd64.deb
 242497923ca7214752ac31fc6e9de031b317a740 17880 vde2-cryptcab_2.3.1-1_amd64.deb
 9f2b709d9c7e604d0a455f8051c5cdcaa8da8822 14878 libvdeplug-dev_2.3.1-1_amd64.deb
 8bd11ca138995e5d2a9d45475ae661eb3af1c295 13572 libvdeplug3_2.3.1-1_amd64.deb
 f8d1e6a4b89c5450afe151407414f9397d87de40 28216 libvde-dev_2.3.1-1_amd64.deb
 0459a7a140eeb3826b4007de9128bb32d45376d4 29312 libvde0_2.3.1-1_amd64.deb
Checksums-Sha256: 
 c68db3569c09135e9ffca6bd927d20a70d42b927edf60f1ccac8cd39b3b195a3 1426 vde2_2.3.1-1.dsc
 6778c4a302b8fa3d9e2664760c9cf0bed02384984cbc79f773c1b230916e79ed 698059 vde2_2.3.1.orig.tar.gz
 0aeeacd2071a917e688ef3814989acc66f0f65d3ed12d636ceee9ae0b0a95efb 11134 vde2_2.3.1-1.diff.gz
 83b21486395fe6319c360518fd82695c9bc6af82de7dd0fb0b401e9e8bb07189 220062 vde2_2.3.1-1_amd64.deb
 aa940b31fd32bfbd810a49028c92b43381dd3147d023bfe77102a5ea4cda653d 17880 vde2-cryptcab_2.3.1-1_amd64.deb
 09fea7897f5731a218af6215ee6cffd91ffacff6531e0dff9aff873edb14a76d 14878 libvdeplug-dev_2.3.1-1_amd64.deb
 457c31bb76043cada013eb4ed572a091c5b0fd9e81a3dbdc973e6c3ac0966bf9 13572 libvdeplug3_2.3.1-1_amd64.deb
 ba4c892c4e2407c5697c5bfcdafa1903f79f87d1e7eb4381bc647035bbb316a8 28216 libvde-dev_2.3.1-1_amd64.deb
 d7882baac635ff2260f3209d2c338c4bfa45ab26bad9ffb114ad6d13e595b653 29312 libvde0_2.3.1-1_amd64.deb
Files: 
 64341f8c06377bdec0c386796190889a 1426 net optional vde2_2.3.1-1.dsc
 c8c2acb92a72f779e0b484b1543a1cc3 698059 net optional vde2_2.3.1.orig.tar.gz
 d89e936e9df74d7b1389bbdc92dbd0a2 11134 net optional vde2_2.3.1-1.diff.gz
 d076a09426bed135846b6154dc9c49f9 220062 net optional vde2_2.3.1-1_amd64.deb
 165bbcc74ea0a2ae1f6f6fb05cbf94a6 17880 net optional vde2-cryptcab_2.3.1-1_amd64.deb
 2f61b47f664b1ccd426b0b0668e64a35 14878 libdevel optional libvdeplug-dev_2.3.1-1_amd64.deb
 11697ace68017bc7351d98d2e876f15a 13572 libs optional libvdeplug3_2.3.1-1_amd64.deb
 0b6023c46a6b7f1ce245cca35d761e3d 28216 libdevel optional libvde-dev_2.3.1-1_amd64.deb
 f9acf4e2e4dd5598c263b28b29a4ae97 29312 libs optional libvde0_2.3.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkyDuosACgkQABzeamt51AERrQCgkLp4qViBW/WVHFS+5Qz+LQX+
GtsAoKXLVq47z7k9471CfHJDgv8ruQA6
=ATec
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.